On Tue, Feb 20, 2007 at 05:38:19PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > It is secrecy, not security - attacker will check the source and find > > where constant per-boot value is added and recalculate attack vector - > > we all were college students, it would be even more fun to crack. > > > > In that regard Jenkins ahsh and XOR one have _exactly_ the same attack > > vector, only Jenkins is a bit more sophisticated. I even think that > > example in rt_hash_code() will endup with heavy problems when one of the > > addresses is constant - my tests show problem exactly in the case of > > jhash_2words() with random third parameter and constant one of the first > > like in rt_hash_code(). > > Please define heavy problem. > > On most hosts, with one NIC, one IP address, most entries in cache have the > same address (IP address of eth0 or localhost). It just works. > > Last time I checked, the 2^21 route cache I am using was correctly filled, > thanks to jhash. > > Again, the random value is 32bits. If jhash happens to be cracked by your > students, we just put md5 or whatever in... > > You can call it secrecy or whatever, fact is : it's just working, far better > than XOR previous hash function.
Hmm, I've just ran following test: 1. created 2^20 hash table. 2. ran in loop (100*(2^20) iterations) following hashes: a. xor hash (const_ip, const_ip, random_word) b. jhash_3words(const_ip, const_ip, random_word, 123123) - it is exactly as jhash_2words(const_ip, const_ip, wandom_word) 3. hash &= hash_size - 1; 4. table[hash].counter++; 5. for (i=0; i<hash_size; ++i) results[table[i].counter]++; And got pretty artefact for jenkins hash attached in the picture artefact.png. Distribution.png file contains distribution of the 2^10 hash table for 100*(2^10) for the above scenario. I've attached source code and running script. $ ./run.sh will produce gnuplot window with shown artefact. If one change comments at the end of the file, run.sh will produce distribution graphs. P.S. jenkins hash is about two times slower. -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html