Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Johannes Berg
On Tue, 2007-01-16 at 16:55 -0200, Marcelo Tosatti wrote: > _Please_ review, this driver is targeted for mainline inclusion. > > There have been almost no comments resulting from the first submission. We had looked over the previous version a few days ago and noticed that the biggest part of the

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Herbert Xu
Herbert Xu <[EMAIL PROTECTED]> wrote: > >> - Would the expression "err ? err : -1" have served me better? >> - Do error codes mean anything here, or should I simply say "return -1"? > > err ?: -1 > > should work. Actually, you should probably use a more meaningful error code than -1. -- Visit O

[take33 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-16 Thread Evgeniy Polyakov
Kevent based AIO (aio_sendfile()/aio_sendfile_path()). aio_sendfile()/aio_sendfile_path() contains of two major parts: AIO state machine and page processing code. The former is just a small subsystem, which allows to queue callback for theirs invocation in process' context on behalf of pool of

[take33 5/10] kevent: Timer notifications.

2007-01-16 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanosec

[take33 7/10] kevent: Signal notifications.

2007-01-16 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are use

[take33 8/10] kevent: Kevent posix timer notifications.

2007-01-16 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git

[take33 9/10] kevent: Private userspace notifications.

2007-01-16 Thread Evgeniy Polyakov
Private userspace notifications. Allows to register notifications of any private userspace events over kevent. Events can be marked as readt using kevent_ctl(KEVENT_READY) command. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/kernel/kevent/kevent_unotify.c b/kernel/kevent/k

[take33 4/10] kevent: Socket notifications.

2007-01-16 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found on

[take33 0/10] kevent: Generic event handling mechanism.

2007-01-16 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events. Ev

[take33 1/10] kevent: Description.

2007-01-16 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..87a1ba9 --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,268 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

[take33 3/10] kevent: poll/select() notifications.

2007-01-16 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

[take33 6/10] kevent: Pipe notifications.

2007-01-16 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index 68090e8..0c75bf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -313,6 +314,7 @@ redo: break; } if

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Herbert Xu
Brandon Craig Rhodes <[EMAIL PROTECTED]> wrote: > > Egads! You are correct. > > My intention was to preserve the value of "err" if an unsuccessful > value was returned by skb_padto(), and otherwise to return "-1" which > seemed the popular value used for errors elsewhere in the code. > > - Woul

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Evgeniy Polyakov
On Tue, Jan 16, 2007 at 05:08:15PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > On Tue, 2007-01-16 at 18:33 +0300, Evgeniy Polyakov wrote: > > On Tue, Jan 16, 2007 at 02:47:54PM +0100, Peter Zijlstra ([EMAIL > > PROTECTED]) wrote: > > > > > + if (unlikely(skb->emergency)) > > > > > +

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Andi Kleen
On Wednesday 17 January 2007 03:33, Eric W. Biederman wrote: > There has not been much maintenance on sysctl in years, and as a result is > there is a lot to do to allow future interesting work to happen, and being > ambitious I'm trying to do it all at once :) > > The patches in this series fall i

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Mitchell Blank Jr
Brandon Craig Rhodes wrote: > + if (skb_tailroom(skb) < 4) { > + int err; > + err = skb_padto(skb, skb->len + 4); > + if (unlikely(err || skb_tailroom(skb) < 4)) { > + printk(KERN_DEBUG "Failed to increase tailroom" > +

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Michael Wu
On Tuesday 16 January 2007 21:31, Brandon Craig Rhodes wrote: > The attached patch, if applied to kernel 2.6.18, solves both problems. > I am not very familiar with the conventions of kernel networking code, > so there may be better ways of fixing this; but the patch should > illustrate the general

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Brandon Craig Rhodes
Mitchell Blank Jr <[EMAIL PROTECTED]> writes: > Brandon Craig Rhodes wrote: > >> +if (unlikely(err || skb_tailroom(skb) < 4)) { >> +printk(KERN_DEBUG "Failed to increase tailroom" >> + " for TKIP encrypt"); >> +return er

Re: [PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c

2007-01-16 Thread Benjamin Herrenschmidt
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > This was partially done already and there was no ABI breakage what > a relief. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAI

Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c

2007-01-16 Thread Benjamin Herrenschmidt
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > And make the mode of the kernel directory 0555 no one is allowed > to write to sysctl directories. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Acked-by: Benjamin

Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag

2007-01-16 Thread Benjamin Herrenschmidt
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > With unique sysctl binary numbers setting insert_at_head is pointless. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTEC

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 17 Jan 2007 13:35:01 +1100 > On Tue, Jan 16, 2007 at 05:07:19PM -0800, David Miller wrote: > > > > Good catch Herbert, patch applied, thanks. > > Thanks Dave. I think we need this for 2.6.19 too. > > [IPSEC]: Policy list disorder > > The recent

TKIP encryption should allocate enough tailroom

2007-01-16 Thread Brandon Craig Rhodes
After frustrating days of hung TCP connections, I have determined that the encryption routines in net/iee80211/ieee80211_crypt_tkip.c should be more aggressive in providing themselves with enough packet tailroom to perform their encryption. They presently will only perform encryption if the packet

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread Herbert Xu
On Tue, Jan 16, 2007 at 05:07:19PM -0800, David Miller wrote: > > Good catch Herbert, patch applied, thanks. Thanks Dave. I think we need this for 2.6.19 too. [IPSEC]: Policy list disorder The recent hashing introduced an off-by-one bug in policy list insertion. Instead of adding after the las

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 17 Jan 2007 07:59:05 +1100 > [IPSEC]: Policy list disorder > > The recent hashing introduced an off-by-one bug in policy list insertion. > Instead of adding after the last entry with a lesser or equal priority, > we're adding after the successor of

Re: [Bugme-new] [Bug 7832] New: if i use iproute2 for network balancing

2007-01-16 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > >> /sbin/ip route change default equalize nexthop dev ppp0 nexthop dev ppp1 >> /sbin/ip route flush cache Is CONFIG_IP_ROUTE_MULTICACHE turned on? If so does this still happen if you disable it? Cheers, -- Visit Openswan at http://www.openswan.org/ Emai

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 23:07 +0100, Michael Buesch wrote: > On Tuesday 16 January 2007 22:50, Pavel Roskin wrote: > > On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: > > > > > A patch for that is already upstream. > > > > I don't see it. It's not in your tree yet. > > It is on its way u

Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki_left

2007-01-16 Thread Ingo Oeser
On Tuesday, 16. January 2007 06:37, Nate Diller wrote: > On 1/15/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote: > > > Convert code using iocb->ki_left to use the more generic iov_length() > > > call. > > > > No way. We need to red

Re: [PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c

2007-01-16 Thread Ingo Oeser
Hi Eric, On Tuesday, 16. January 2007 17:39, Eric W. Biederman wrote: > diff --git a/arch/mips/au1000/common/power.c b/arch/mips/au1000/common/power.c > index b531ab7..31256b8 100644 > --- a/arch/mips/au1000/common/power.c > +++ b/arch/mips/au1000/common/power.c > @@ -419,15 +419,41 @@ static int

Re: [Bugme-new] [Bug 7832] New: if i use iproute2 for network balancing

2007-01-16 Thread Ben Greear
Andrew Morton wrote: On Tue, 16 Jan 2007 03:13:35 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=7832 Summary: if i use iproute2 for network balancing Kernel Version: 2.6.19.1 Status: NEW Severity: normal Owner: [EMAIL

Re: [PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage.

2007-01-16 Thread Paul Mundt
On Tue, Jan 16, 2007 at 09:39:42AM -0700, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > While doing the C99 conversion I notices that the top level sh64 > directory was using the binary number for CTL_KERN. That is a > no-no so I removed the support for the

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Dan Williams
On Tue, 2007-01-16 at 20:32 +0100, Arkadiusz Miskiewicz wrote: > On Tuesday 16 January 2007 19:55, you wrote: > > Announcing an updated patch of the Marvell Libertas 8388 802.11 USB > > driver. > > > > Diff can be found at > > http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch > > Is core

Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

2007-01-16 Thread Ingo Oeser
Hi Eric, On Tuesday, 16. January 2007 17:39, Eric W. Biederman wrote: > diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c > index 2e744a2..5337789 100644 > --- a/drivers/parport/procfs.c > +++ b/drivers/parport/procfs.c > @@ -263,50 +263,118 @@ struct parport_sysctl_table { > +

Re: Can someone please try...

2007-01-16 Thread Michael Buesch
On Tuesday 16 January 2007 22:50, Pavel Roskin wrote: > On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: > > > A patch for that is already upstream. > > I don't see it. It's not in your tree yet. It is on its way upstream to linville. > > It's surprising that it doesn't happen for me,

Re: [Bugme-new] [Bug 7832] New: if i use iproute2 for network balancing

2007-01-16 Thread Andrew Morton
> On Tue, 16 Jan 2007 03:13:35 -0800 [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=7832 > >Summary: if i use iproute2 for network balancing > Kernel Version: 2.6.19.1 > Status: NEW > Severity: normal > Owner: [EMAIL PROTECT

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: > A patch for that is already upstream. I don't see it. It's not in your tree yet. > It's surprising that it doesn't happen for me, though. > Neiter on PPC, nor on i386. It did happen for me on i386, as well as on x86_64. The dump was f

[PATCH 2.6.20-rc3]: 8139cp: Don't blindly enable interrupts

2007-01-16 Thread Chris Lalancette
Francois Romieu wrote: >Chris Lalancette <[EMAIL PROTECTED]> : >[...] > > >> Thanks for the comments. While the patch you sent will help, there are >>still other places that will have problems. For example, in netpoll_send_skb, >>we call local_irq_save(flags), then call dev->hard_start_xmi

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Arkadiusz Miskiewicz
On Tuesday 16 January 2007 19:55, you wrote: > Announcing an updated patch of the Marvell Libertas 8388 802.11 USB > driver. > > Diff can be found at > http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch Is core chip somehow close to pci/pci-e: 00:07.0 Ethernet controller: Marvell Technol

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread Herbert Xu
Marco Berizzi <[EMAIL PROTECTED]> wrote: > Yesterday I have updated to linux 2.6.19.2 > (from 2.6.19.1) and passthrough openswan > connection aren't working anymore. > This is the 'ip -s x s' output: I presume you mean ip -s x p :) > src 10.180.0.0/16 dst 172.16.0.0/23 uid 0 > dir in action allow

Re: [PATCH 48/59] sysctl: Register the ocfs2 sysctl numbers

2007-01-16 Thread Mark Fasheh
On Tue, Jan 16, 2007 at 09:39:53AM -0700, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > ocfs2 was did not have the binary number it uses under CTL_FS > registered in sysctl.h. Register it to avoid future conflicts, > and change the name of the definition to

Re: [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start_xmit

2007-01-16 Thread Francois Romieu
Chris Lalancette <[EMAIL PROTECTED]> : [...] > Thanks for the comments. While the patch you sent will help, there are > still other places that will have problems. For example, in netpoll_send_skb, > we call local_irq_save(flags), then call dev->hard_start_xmit(), and then call > local_irq_r

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread David Howells
The FRV bits look okay. I can't test them until I get back from Australia in Feb. David - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Brandeburg, Jesse
added Linux-pci Jesse Brandeburg wrote: > On 1/16/07, Allen Parker <[EMAIL PROTECTED]> wrote: >> Allen Parker wrote: >>> I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well >>> under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier >>> today I reported this to [EMAIL PROTE

[PATCH -MM] e1000: update new hardware init layer code with bugfixes

2007-01-16 Thread Auke Kok
e1000: update new hardware init layer code with bugfixes From: Jeb Cramer <[EMAIL PROTECTED]> Replace hard coded RAR numbers with constant. Add several function description and fix some small copy+paste errors in others. Fix link speed detection on PCI adapters showing wrong PCI bus speed. Fix la

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >>> >>> Agreed. *Furthermore*, if the number isn't in it shouldn't >>> exist anywhere else, either. >> >> That would be a good habit. Feel free to send the patches to ensure that >> is so. >> >> I'm a practical fix it when

Re: Can someone please try...

2007-01-16 Thread Michael Buesch
On Tuesday 16 January 2007 19:29, Pavel Roskin wrote: > On Tue, 2007-01-16 at 18:06 +0100, Michael Buesch wrote: > > ...the bcm43xx driver in my tree with a 4318 chip? > > Things are progressing for me a bit because I observed an association to > an AP with no security. I still had to use wpa_sup

Re: Can someone please try...

2007-01-16 Thread Michael Buesch
On Tuesday 16 January 2007 20:00, Andreas Schwab wrote: > Michael Buesch <[EMAIL PROTECTED]> writes: > > > ...the bcm43xx driver in my tree with a 4318 chip? > > The code there works excellent with my 4306 now, but I can't > > get it to work with my 4318. > > Doesn't work for me either. I cannot

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Jesse Brandeburg
On 1/16/07, Allen Parker <[EMAIL PROTECTED]> wrote: Allen Parker wrote: > I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well > under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I > reported this to [EMAIL PROTECTED], but thought I should get the > word out in

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: Agreed. *Furthermore*, if the number isn't in it shouldn't exist anywhere else, either. That would be a good habit. Feel free to send the patches to ensure that is so. I'm a practical fix it when it is in my way kind of guy ;) That's fine. However, I am wonderin

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >>> With "architectural" I mean "guaranteed to be stable" (as opposed to >>> "incidental"). Sorry for the confusion. >> >> Ok. Then largely we are in agreement. To implement that the rule is simple. >> If it isn't CTL_

Re: Can someone please try...

2007-01-16 Thread Andreas Schwab
Michael Buesch <[EMAIL PROTECTED]> writes: > ...the bcm43xx driver in my tree with a 4318 chip? > The code there works excellent with my 4306 now, but I can't > get it to work with my 4318. Doesn't work for me either. I cannot get it to associate to the AP. Andreas. -- Andreas Schwab, SuSE La

[PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Marcelo Tosatti
Announcing an updated patch of the Marvell Libertas 8388 802.11 USB driver. Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch _Please_ review, this driver is targeted for mainline inclusion. There have been almost no comments resulting from the first submission.

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: With "architectural" I mean "guaranteed to be stable" (as opposed to "incidental"). Sorry for the confusion. Ok. Then largely we are in agreement. To implement that the rule is simple. If it isn't CTL_UNNUMBERED and the number is in Linus's tree, it is our responsi

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> >>> I think it would be fair to say that if they're not in > they're >>> not architectural, but that doesn't resolve the counterpositive (are there >>> sysctls in which aren't architectural? From the looks of > it, I >>>

Re: [PATCH -mm 9/10][RFC] aio: usb gadget remove aio file ops

2007-01-16 Thread David Brownell
On Tuesday 16 January 2007 1:13 am, Nate Diller wrote: > On 1/15/07, David Brownell <[EMAIL PROTECTED]> wrote: > > What's needed is an async, non-sleeeping, interface ... with I/O > > overlap. That's antithetical to using read()/write() calls, so > > your proposed approach couldn't possibly work.

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: I think it would be fair to say that if they're not in they're not architectural, but that doesn't resolve the counterpositive (are there sysctls in which aren't architectural? From the looks of it, I would say yes.) Non-architectural sysctl numbers should not be ex

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 18:06 +0100, Michael Buesch wrote: > ...the bcm43xx driver in my tree with a 4318 chip? Things are progressing for me a bit because I observed an association to an AP with no security. I still had to use wpa_supplicant. Unfortunately, there is a bigger issue with the new co

Re: [PATCH 20/59] sysctl: cdrom Don't set de->owner

2007-01-16 Thread James Bottomley
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted These three look OK: [PATCH 15/59] sysctl: scsi remove unnecessary insert_at_head flag [PATCH 19/59] sysctl: cdrom remove unnecessary insert_at_head flag [PATCH 20/59] sysctl: cdro

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
CC list trimmed. "H. Peter Anvin" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> >> - Removal of sys_sysctl support where people had used conflicting sysctl >> numbers. Trying to break glibc or other applications by changing the >> ABI is not cool. 9 instances of this in the kern

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: - Removal of sys_sysctl support where people had used conflicting sysctl numbers. Trying to break glibc or other applications by changing the ABI is not cool. 9 instances of this in the kernel seems a little extreme. It would be highly advantageous if we could

Re: [PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag

2007-01-16 Thread Ralf Baechle
On Tue, Jan 16, 2007 at 09:39:10AM -0700, Eric W. Biederman wrote: Looks ok, for these: Subject: [PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag Subject: [PATCH 6/59] sysctl: netrom remove unnecessary insert_at_head flag Subject: [PATCH 11/59] sysctl: ax25 remove unnecessary inse

Re: Two Dual Core processors and NICS (not handling interrupts on one CPU/assigning a Two Dual Core processors and NICS (not handling interrupts on one CPU / assigning a CPU to a NIC)

2007-01-16 Thread Rick Jones
Mark Ryden wrote: Hello, I have a machine with 2 dual core CPUs. This machine runs Fedora Core 6. I have two Intel e1000 GigaBit network cards on this machine; I use bonding so that the machine assigns the same IP address to both NICs ; It seems to me that bonding is configured OK, bacuse whe

[PATCH 55/59] sysctl: Remove insert_at_head from register_sysctl

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The semantic effect of insert_at_head is that it would allow new registered sysctl entries to override existing sysctl entries of the same name. Which is pain for caching and the proc interface never implemented. I have done an audit and dis

[PATCH 14/59] sysctl: C99 convert xfs ctl_tables

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_sysctl.c | 258 1 files changed, 180 insertions(+), 78 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_sysctl.c b/fs/xfs/l

[PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With this change the sysctl inodes can be cached and nothing needs to be done when removing a sysctl table. For a costk of 2K code we will save about 4K of static tables (when we remove de from ctl_table) and 70K in proc_dir_entries that we w

[PATCH 32/59] sysctl: C99 convert arch/mips/lasat/sysctl.c and remove ABI breakage.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted While C99 converting the ctl_table initializers I realized that the binary sysctl numbers were in conflict with the binary values under CTL_KERN. Including CTL_KERN KERN_VERSION as used by glibc. So I just removed the sysctl binary interfac

[PATCH 56/59] sysctl: factor out sysctl_head_next from do_sysctl

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The current logic to walk through the list of sysctl table headers is slightly painful and implement in a way it cannot be used by code outside sysctl.c I am in the process of implementing a version of the sysctl proc support that instead of

[PATCH 59/59] sysctl: Remove the proc_dir_entry member for the sysctl tables.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted It isn't needed anymore, all of the users are gone, and all of the ctl_table initializers have been converted to use explicit names of the fields they are initializing. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/s

[PATCH 28/59] sysctl: C99 Convert arch/ia64/sn/kernel/xpc_main.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/ia64/sn/kernel/xpc_main.c | 86 +-- 1 files changed, 38 insertions(+), 48 deletions(-) diff --git a/arch/ia64/sn/kernel/xpc_main.c b/arch/ia6

[PATCH 34/59] sysctl: s390 Remove unnecessary use of insert_at_head

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/s390/appldata/appldata_base.c |4 ++-- arch/s390/kernel/debug.c |2 +- arch/s390/mm/cmm.c |2 +- 3 files changed, 4 insertions(+), 4 deletions

[PATCH 46/59] sysctl: C99 convert coda ctl_tables and remove binary sysctls.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Will converting the coda sysctl initializers I discovered that it is yet another user of sysctl that was stomping CTL_KERN. So off with it's sys_sysctl support since it wasn't done in a supportable way. Signed-off-by: Eric W. Biederman <[EMAI

[PATCH 29/59] sysctl: C99 convert arch/ia64/kernel/perfmon and remove ABI breakage

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This convers the sysctl ctl_tables to use C99 initializers. While I was looking at it I discovered it was using a portion of the sysctl binary addresses space under CTL_KERN KERN_OSTYPE which was completely inappropriate. So I completely remo

[PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted While doing the C99 conversion I notices that the top level sh64 directory was using the binary number for CTL_KERN. That is a no-no so I removed the support for the sysctl binary interface only leaving sysctl /proc support. At least the sys

[PATCH 27/59] sysctl: sn Remove sysctl ABI BREAKAGE

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted By not using the enumeration in sysctl.h (or even understanding it) the SN platform placed their arch specific xpc directory on top of CTL_KERN and only because they didn't have 4 entries in their xpc directory got lucky and didn't break glibc

[PATCH 52/59] sysctl: Create sys/fs/binfmt_misc as an ordinary sysctl entry

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted binfmt_misc has a mount point in the middle of the sysctl and that mount point is created as a proc_generic directory. Doing it that way gets in the way of cleaning up the sysctl proc support as it continues the existence of a horrible hack.

[PATCH 30/59] sysctl: mips/au1000 Remove sys_sysctl support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The assignment of binary numbers for sys_sysctl use was in shambles and despite requiring methods. Nothing was implemented on the sys_sysctl side. So this patch gives a mercy killing to the sys_sysctl support for powermanagment on mips/au100

[PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/pm.c | 50 +++--- 1 files changed, 43 insertions(+), 7 deletions(-) diff --git a/arch/frv/kernel/pm.c b/arch/frv/kernel/pm

[PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/mips/au1000/common/power.c | 38 -- 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/arch/mips/au1000/common/power.c b/arch/mip

[PATCH 4/59] sysctl: sunrpc Don't unnecessarily set ctl_table->de

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted We don't need this to prevent module unload races so remove the unnecessary code. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/sunrpc/sysctl.c |8 +--- net/sunrpc/xprtsock.c |7 +-- 2 files changed, 2 insert

[PATCH 3/59] sysctl: sunrpc Remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Because the sunrpc sysctls don't conflict with any other sysctls the setting the insert at head flag to register_sysctl has no semantic meaning. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/sunrpc/sysctl.c |2 +- net/su

[PATCH 26/59] sysctl: C99 convert arch/frv/kernel/sysctl.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/sysctl.c | 29 - 1 files changed, 24 insertions(+), 5 deletions(-) diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/kernel/sysctl.c index

[PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The real time clock driver was using the binary number reserved for cdroms in the sysctl binary number interface, which is a no-no. So since the sysctl binary interface is wrong remove it. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>

[PATCH 20/59] sysctl: cdrom Don't set de->owner

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted There is no need for open files in /proc/sys/XXX to hold a reference count on the module that provides the file to prevent module unload races. While there is code active in the module p->used in the sysctl_table_header is incremented, preven

[PATCH 53/59] sysctl: Remove support for CTL_ANY

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted There are currently no users in the kernel for CTL_ANY and it only has effect on the binary interface which is practically unused. So this complicates sysctl lookups for no good reason so just remove it. Signed-off-by: Eric W. Biederman <[EM

[PATCH 39/59] sysctl: C99 convert ctl_tables in arch/x86_64/ia32/ia32_binfmt.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x86_64/ia32/ia32_binfmt.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/arch/x86_64/ia32/ia32_binfmt.c b/arch/x86_64/ia32/

[PATCH 38/59] sysctl: x86_64 Remove unnecessary use of insert_at_head

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The only sysctl x86_64 provides are not provided elsewhere, so insert_at_head is unnecessary. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x86_64/ia32/ia32_binfmt.c |2 +- arch/x86_64/mm/init.c |2 +- 2 file

[PATCH 2/59] sysctl: Move CTL_SUNRPC to sysctl.h where it belongs

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/sunrpc/debug.h |1 - include/linux/sysctl.h |3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/sunrpc/debug.h b/include/lin

[PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- init/main.c |3 +++ kernel/sysctl.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/init/main.c b/init/main.c index 8b4a7d7..8af5c6e 100644 --- a/init

[PATCH 23/59] sysctl: Move CTL_FRV into sysctl.h where it belongs

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/sysctl.c |1 - include/linux/sysctl.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/kernel/sysctl.c

[PATCH 21/59] sysctl: Move CTL_PM into sysctl.h where it belongs.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/pm.c |1 - include/linux/sysctl.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/frv/kernel/pm.c b/arch/frv/kernel/pm.c index ee677c

[PATCH 40/59] sysctl: C99 convert ctl_tables in arch/x86_64/kernel/vsyscall.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Basically everything was done but I removed all element initializers from the trailing entries to make it clear the entire last entry should be zero filled. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x86_64/kernel/vsyscall

[PATCH 42/59] sysctl: Remove sys_sysctl support from the hpet timer driver.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted In the binary sysctl interface the hpet driver was claiming to be the cdrom driver. This is a no-no so remove support for the binary interface. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/char/hpet.c |4 ++-- 1 file

[PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With unique sysctl binary numbers setting insert_at_head is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/char/ipmi/ipmi_poweroff.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drive

[PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This was partially done already and there was no ABI breakage what a relief. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/powerpc/kernel/idle.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 9/59] sysctl: decnet remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag does not succeed in overriding any sysctls, and is just confusing because it doesn't. Clear the flag. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/decnet/

[PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted And make the mode of the kernel directory 0555 no one is allowed to write to sysctl directories. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/ppc/kernel/ppc_htab.c | 11 --- 1 files changed, 8 insertions(+), 3 dele

[PATCH 19/59] sysctl: cdrom remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With unique binary sysctl numbers setting insert_at_head to override other sysctl entries is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/cdrom/cdrom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-

[PATCH 1/59] sysctl x25: Remove unnecessary insert_at_head from register_sysctl_table.

2007-01-16 Thread Eric W. Biederman
Since x25 uses unique binary numbers inserting yourself at the head of the search list for sysctls so you can override already registered sysctls is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/x25/sysctl_net_x25.c |2 +- 1 files changed, 1 insertions(+), 1 deletion

[PATCH 8/59] sysctl: ipx remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag servers no semantic purpose and is just confusing. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/ipx/sysctl_net_ipx.c |2 +- 1 files changed, 1 insertio

[PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag serves no semantic purpose. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/rose/sysctl_net_rose.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

  1   2   >