Chris Lalancette <[EMAIL PROTECTED]> : [...] > Thanks for the comments. While the patch you sent will help, there are > still other places that will have problems. For example, in netpoll_send_skb, > we call local_irq_save(flags), then call dev->hard_start_xmit(), and then call > local_irq_restore(flags). This is a similar situation to what I described > above; we will re-enable interrupts in cp_start_xmit(), when netpoll_send_skb > doesn't expect that, and will probably run into issues. > Is there a problem with changing cp_start_xmit to use the > spin_lock_irqsave(), besides the extra instructions it needs?
No. Given the history of locking in netpoll and the content of Documentation/networking/netdevices.txt, asking Herbert which rule(s) the code is supposed to follow seemed safer to me. You can forget my patch. Please resend your patch inlined to Jeff as described in http://linux.yyz.us/patch-format.html. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
