On Wed, 2006-08-30 at 08:43 -0700, Jouni Malinen wrote:
> Could you please separate cleanup parts (list_for_each changes) from
> functional changes (adding locking) to make it easier to review the
> patch?
Yeah, I guess I should do that.
> I would prefer not to hold spinlocks when calling regist
On Thu, 31 Aug 2006 09:22:05 +1000
"Andrew Hall" <[EMAIL PROTECTED]> wrote:
Has there been any updates on a fix for the sky2 tx timeout issues?
I have been tracking this problem for a while and consistently see this
issue when the interface is under heavy load. I'm using 2.6.17.11 but
have
According to the function call udp_sendmsg() in the source file
net/ipv4/udp.c (Linux Kernel 2.6.17.11), when an error value is returned
from the function ip_append_data() due to local device congestion, say
interface queue overflow, pending packets in the queue sk->sk_write_queue
are simply f
Jeff,
Here's a patch to improve the selection on the myri10ge firmware.
Please apply to #upstream for 2.6.19.
The patch actually raises two concerns:
* We might want to add a generic PCI function to get the PCIe link width since
some other drivers (at least ipath) do the same. But we probably d
Herbert Xu writes:
> BTW, did you see the "cmpldi r1,..." stuff in the code? That's a typo,
> right?
Yes it is a typo, but fixing it is lower priority since both r1 and
cr1 equal 1.
Paul.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PRO
Hi Paul:
On Thu, Aug 31, 2006 at 01:22:07PM +1000, Paul Mackerras wrote:
>
> You missed a couple of 'beqlr' instructions (branch if equal to LR).
> I'd be interested to know if it still fails with the patch below.
Yes that'd do it.
BTW, did you see the "cmpldi r1,..." stuff in the code? That's
Herbert Xu writes:
> Interesting. We were previously off by 28 bytes, now we're off by 8 :)
You missed a couple of 'beqlr' instructions (branch if equal to LR).
I'd be interested to know if it still fails with the patch below.
Thanks,
Paul.
diff --git a/arch/powerpc/lib/memcpy_64.S b/arch/powe
On Wed, Aug 30, 2006 at 11:36:26AM -0500, Joy Latten wrote:
>
> I tried the patch on the following:
> linux-2.6.17 + patch-2.6.18-rc1
>
> The good news is that the pings worked great!
> So perhaps ESP is working ok with ICMP.
>
> But when I tried to do sftp, I still got the oops.
> I don't think
Joy Latten writes:
> The good news is that the pings worked great!
> So perhaps ESP is working ok with ICMP.
>
> But when I tried to do sftp, I still got the oops.
> I don't think TCP and ESP are working.
You're hitting the BUG_ON(len) at line 611 of net/xfrm/xfrm_algo.c.
Is that the same thing
John,
Please apply Jean's patch to wireless-2.6. It should apply cleanly to the
version you pushed earlier
today (8/30). I have compiled and tested. For complete operation with WE-21, it
also needs the patch
entitled [PATCH 2.6.18] WE-21 support (core API) at
(http://www.spinics.net/lists/netdev
On Wed, 30 Aug 2006 16:31:12 -0700
Roland Dreier <[EMAIL PROTECTED]> wrote:
> Stephen> The undo should really be handled by the caller, not in
> Stephen> netif_rx_reschedule. The existing interface assumes you
> Stephen> have already deducted N from your quota and so it needs
> St
Roland> makes sense -- especially since the caller probably also
Roland> deducted N from *budget, and netif_rx_reschedule() doesn't
Roland> touch that.
Actually, why does undoing the change to quota make sense? Presumably
I passed N packets to netif_receive_skb() -- why shouldn't I de
Stephen> The undo should really be handled by the caller, not in
Stephen> netif_rx_reschedule. The existing interface assumes you
Stephen> have already deducted N from your quota and so it needs
Stephen> to be put back.
makes sense -- especially since the caller probably also dedu
Has there been any updates on a fix for the sky2 tx timeout issues?
I have been tracking this problem for a while and consistently see this
issue when the interface is under heavy load. I'm using 2.6.17.11 but have
tried .15, .16, .17 and .18rcX all with the same issue - a large amount of
(HTTP g
Hello!
> Really?
>
> It is used with needlock=0 by DCCP ipv6, for example. This case seems
> correct too. What about sk_receive_skb()? dn_queue_skb()? In fact,
> there seems to be numerous uses still with needlock=0, all legitimate.
Well, not quite legitime.
sk_receive_skb() has the same bug
From: Alexey Kuznetsov <[EMAIL PROTECTED]>
Date: Thu, 31 Aug 2006 03:14:06 +0400
> > Let us to fix bugs first, and then consider rewriting the locking.
>
> To be honest, I think switching to RCU is the simplest bug fix.
> At least, it does not require to search where bh_lock_sock() is taken
> dn_
On Wed, 30 Aug 2006 15:07:31 -0700
Roland Dreier <[EMAIL PROTECTED]> wrote:
> I'm looking at updating IP-over-InfiniBand to use NAPI, and due to the
> way IB works, the driver is going to be susceptible to the rotting
> packet problem. It seems I'm going to have to call netif_rx_reschedule().
Lo
David Miller wrote:
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 30 Aug 2006 10:27:27 -0700
Linux TCP implements "Appropriate Byte Count" (ABC) and this penalizes
applications that do small sends. The problem is that the other side
may be delaying acknowledgments. If receiver doesn'
Francois Romieu <[EMAIL PROTECTED]> :
[...]
> Added:
> 0043-ip1000-use-the-new-IRQF_-constants-and-the-dma_-alloc-free-_coherent-AP
> I.txt
> 0044-ip1000-mixed-case-and-upper-case-removal.txt
> 0045-ip1000-add-ipg_-r-w-8-16-32-macros.txt
Added:
0046-ip1000-kiss-TxBuffDMAhandle-goodbye.txt
0047-ip1
It appears that the Dlink DGE-550SX card has this pci_id:
vendor = 0x1186, device = 0x4001
(decoded from SysKonnect version of sk98lin driver).
According to a couple of places Dlink also uses the same id for the DFE-650TX
card. Before I add this to the sky2 driver, I want to make sure not
From: Alexey Kuznetsov <[EMAIL PROTECTED]>
Date: Thu, 31 Aug 2006 02:20:42 +0400
> Current code in tcp_v4_rcv() calls sk_filter() _before_ it takes socket lock.
> This happened when LSM patches were applied. Apparently, LSM does not
> want to see socket locked in security_sock_rcv_skb().
Ok.
> O
Hello!
> > Function sk_filter() is called from tcp_v{4,6}_rcv() functions with argue
> > needlock = 0, while socket is not locked at that moment. In order to avoid
> > this and similar issues in the future, use rcu for sk->sk_filter field read
> > protection.
> >
> > Patch is for net-2.6.19
>
I'm looking at updating IP-over-InfiniBand to use NAPI, and due to the
way IB works, the driver is going to be susceptible to the rotting
packet problem. It seems I'm going to have to call netif_rx_reschedule().
However I'm confused about a couple of things, and there are only two
uses of netif_r
On Wed, Aug 30, 2006 at 02:51:05PM +0200, Michael Buesch wrote:
> On Wednesday 30 August 2006 03:12, Jean Tourrilhes wrote:
> > Hi,
> >
> > WE-21 for Broadcom driver and SoftMAC...
> > This version is for wireless-2.6 git.
> >
> > Jean
> >
> > Signed-off-by: Jean Tour
On Wed, 30 Aug 2006 14:39:55 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Wed, 30 Aug 2006 10:27:27 -0700
>
> > Linux TCP implements "Appropriate Byte Count" (ABC) and this penalizes
> > applications that do small sends. The problem is
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Wed, 30 Aug 2006 22:35:07 +0200
> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc4-mm2:
> >...
> > git-net.patch
> >...
> > git trees
> >...
>
> This patch makes the needlessly global struct simp_hash_
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 30 Aug 2006 10:27:27 -0700
> Linux TCP implements "Appropriate Byte Count" (ABC) and this penalizes
> applications that do small sends. The problem is that the other side
> may be delaying acknowledgments. If receiver doesn't acknowledge the
From: Dmitry Mishin <[EMAIL PROTECTED]>
Date: Wed, 30 Aug 2006 17:07:14 +0400
> Function sk_filter() is called from tcp_v{4,6}_rcv() functions with argue
> needlock = 0, while socket is not locked at that moment. In order to avoid
> this and similar issues in the future, use rcu for sk->sk_filte
On Wed, 30 Aug 2006 22:58:17 +0200
"Frank Schneider" <[EMAIL PROTECTED]> wrote:
>
> hi all,
>
> I am writing/customizing a network(wlan pc card) device driver for Linux
> kernel 2.6.12
> Think about I have two modules e.g. ath_pci and wlan module.
> I can call a function from a .c file which
Here is a comparison of the existing implementation against 802.1d standard
pseudo-code.
/* Spec */
Boolean supersedes_port_info(port_no, config) /* (8.6.2.2) */
Int port_no;
Config_bpdu *config;
{
return config->root_id < port_info[port_no].designated_root /*
(8.6.2.2 a) */
hi all,
I am writing/customizing a network(wlan pc card) device driver for Linux
kernel 2.6.12
Think about I have two modules e.g. ath_pci and wlan module.
I can call a function from a .c file which is implemented in a .c file in
wlan module by using EXPORT_SYMBOL macro..
and i need to d
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
> git-net.patch
>...
> git trees
>...
This patch makes the needlessly global struct simp_hash_info static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.18-rc4-mm3/net/sched/
James Morris wrote:
> On Fri, 25 Aug 2006, Venkat Yekkirala wrote:
>>>I like these changes, but wondering why you haven't supplied
>>>code for the
>>>outbound case ?
>>
>>The code for the outbound is still in the works. I hope to have it
>>out in a week or so.
>
> Ok, I guess we should wait unti
While merging this, I uninlined rdma_node_get_transport, since I don't
think there's any reason to make it inline:
add/remove: 1/0 grow/shrink: 7/16 up/down: 65/-146 (-81)
function old new delta
rdma_node_get_transport- 33
Hi!,
I'm not able to subscrive at this list. My server mail don't send
the mail and consider it a spam mail...
For this, please send eventual
response to this mail address ([EMAIL PROTECTED])
The problem
is this:
I'm searching, in kernel code, the code that implement thi
command:
tc filter
On Wed, 30 Aug 2006 11:04:36 -0700
Brian Braunstein <[EMAIL PROTECTED]> wrote:
> PATCH
> problem at: br_stp.c:271
> problem: ignoring BPDUs if cost goes up
>
> i was refered to email these addresses by the bridging code author.
>
> please see the full problem description and patch at:
> http://m
On Wed, 30 Aug 2006 11:04:36 -0700
Brian Braunstein <[EMAIL PROTECTED]> wrote:
> PATCH
> problem at: br_stp.c:271
> problem: ignoring BPDUs if cost goes up
>
> i was refered to email these addresses by the bridging code author.
>
> please see the full problem description and patch at:
> http://m
On Wed, Aug 30, 2006 at 03:46:27AM +0100, Daniel Drake wrote:
> Looks like zd1211rw was forgotten from the WE-21 migration. This patch
> should do it...
Good catch !
Actually, I did look at it, and verified that it was using
softmac for ESSID, so I thought I was ok... With the numb
PATCH
problem at: br_stp.c:271
problem: ignoring BPDUs if cost goes up
i was refered to email these addresses by the bridging code author.
please see the full problem description and patch at:
http://mesh.calit2.net/calmesh/one/linux_kernel_modifications/bridge_ignoring_bpdus/
if you would like
3945 firmware and hardware still do time critical functions like
Beaconing and power management. This restrict us once associated to
switch channel from the driver. we need to unassociated first before
switching to a new channel. Because of this restriction while
associated we can only call s
Jouni Malinen wrote:
On Mon, Aug 28, 2006 at 01:45:34PM -0700, mabbas wrote:
This patch modify d80211 to add SIOCSIWRATE and SIOCGIWRATE
commands. this patch almost does the same thing as in
PRISM2_HOSTAPD_SET_RATE_SETS.
I don't think I would like to get this applied since this seem
On Tue, 2006-08-29 at 21:44 -0700, David Miller wrote:
> From: Sridhar Samudrala <[EMAIL PROTECTED]>
> Date: Tue, 29 Aug 2006 10:55:29 -0700
>
> > verify_iovec() has the following piece of code that allows overflow
> > of iov_len values in an iovec.
> >
> > for (ct = 0; ct < m->msg_iovlen
On Wed, 2006-08-30 at 10:35 -0700, Roland Dreier wrote:
> OK, getting closer to finishing the merge...
>
> anyway, why is iw_cm_private.h in include/rdma where it is visible
> everywhere? As far as I can tell drivers/infiniband/core/iwcm.c is
> the only place it's included. So why not just put t
On 8/30/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
On Wed, 30 Aug 2006 19:21:20 +0200
"Thibaut VARENE" <[EMAIL PROTECTED]> wrote:
> Replying to myself as I've been pointed at Stephen's reply (please CC
> me, i'm not subscribed):
>
> I'm bringing the interface up with 'dhclient eth0', and y
OK, getting closer to finishing the merge...
anyway, why is iw_cm_private.h in include/rdma where it is visible
everywhere? As far as I can tell drivers/infiniband/core/iwcm.c is
the only place it's included. So why not just put this stuff in
drivers/infiniband/core/iwcm.h and do
#inclu
On Wed, 30 Aug 2006 14:07:34 +0400
Alexander Vodomerov <[EMAIL PROTECTED]> wrote:
> Hello!
>
> I'm writing an application that is working over TCP. Total traffic is
> very low (~ 10 kb/sec), but performance is very bad. I've tried to
> investigate problem with tcpdump and strace, and it shows tha
On Wed, 30 Aug 2006 19:21:20 +0200
"Thibaut VARENE" <[EMAIL PROTECTED]> wrote:
> Replying to myself as I've been pointed at Stephen's reply (please CC
> me, i'm not subscribed):
>
> I'm bringing the interface up with 'dhclient eth0', and yes it's using
> autoneg.
>
Any chance of getting a back
On Wednesday 30 August 2006 06:41, Dan Williams wrote:
> Um, that's how it's supposed to work, and that's how it's always worked.
> If you're associated with an access point, its BSSID is returned from
> SIOCGIWAP. If you are not associated, 00:00:00:00:00:00 is returned.
> Please don't break that
On Mon, 28 Aug 2006 16:36:39 +0800, Hong Liu wrote:
> "iwconfig key [x]" behavior is not correctly handled in the stack, also
> modify the giwencode method to show the key info.
Thanks for spotting and fixing these bugs!
> @@ -2869,7 +2877,8 @@ static int ieee80211_ioctl_giwencode(str
>
Replying to myself as I've been pointed at Stephen's reply (please CC
me, i'm not subscribed):
I'm bringing the interface up with 'dhclient eth0', and yes it's using autoneg.
HTH
T_Bone
On 8/30/06, Thibaut VARENE <[EMAIL PROTECTED]> wrote:
Hi,
The following commit:
commit 239e44e1f05e2163ee
On Mon, Aug 28, 2006 at 01:45:34PM -0700, mabbas wrote:
> This patch modify d80211 to add SIOCSIWRATE and SIOCGIWRATE
> commands. this patch almost does the same thing as in
> PRISM2_HOSTAPD_SET_RATE_SETS.
I don't think I would like to get this applied since this seems to be
changing the design
On Fri, 25 Aug 2006 16:32:13 +0800, Hong Liu wrote:
> Add hardware scan callback to support cards like ipw3945 which
> implements the scan command in firmware.
How ipw3945 performs scan? From the patch, it looks like it switches
channels (and sends probe requests) in the firmware and delivers all
On Fri, 25 Aug 2006 16:32:08 +0800, Hong Liu wrote:
> After key negotiation completed using wpa_supplicant, wpa_supplicant
> can't reassoc with the AP if we reboot the AP. It always fails at the
> 4-way handshake.
> The problem is the key info is not cleared correctly. Thus when
> wpa_supplicant se
>--
>diff --git a/arch/powerpc/lib/memcpy_64.S b/arch/powerpc/lib/memcpy_64.S
>index fd66acf..9e8d9e7 100644
>--- a/arch/powerpc/lib/memcpy_64.S
>+++ b/arch/powerpc/lib/memcpy_64.S
>@@ -11,6 +11,7 @@ #include
>
> .align 7
> _GLOBAL(memcpy)
>+ std r3,-8(r1)
> mtcrf 0x01,r5
On Wed, 30 Aug 2006 17:30:46 +0200
"Thibaut VARENE" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> The following commit:
>
> commit 239e44e1f05e2163ee066c07a753f9fb445979b2
> Author: Edgar E. Iglesias <[EMAIL PROTECTED]>
> Date: Mon Aug 14 23:00:24 2006 -0700
>
> [PATCH] skge: remember to run netif
On Wed, Aug 30, 2006 at 09:26:21AM +0200, Johannes Berg wrote:
> On Tue, 2006-08-29 at 11:39 -0700, Jouni Malinen wrote:
>
> > What would be the preferred way of doing the conversion here? I think I
> > would prefer to get the radar detection code in as-is and then move all
> > the messages to use
On Wed, Aug 30, 2006 at 10:43:39AM +0200, Johannes Berg wrote:
> This patch converts uses of list_for_each and list_for_each_safe to
> list_for_each_entry and list_for_each_entry_safe respectively where
> applicable. It also adds locking in some places though I'm not entirely
> sure that I can do i
Hi,
The following commit:
commit 239e44e1f05e2163ee066c07a753f9fb445979b2
Author: Edgar E. Iglesias <[EMAIL PROTECTED]>
Date: Mon Aug 14 23:00:24 2006 -0700
[PATCH] skge: remember to run netif_poll_disable()
Signed-off-by: Edgar E. Iglesias <[EMAIL PROTECTED]>
Cc: Stephen Hemminger
The following changes since commit e4ac2663ea27d5dda88d97d117080995fcfcd6d5:
John W. Linville:
Merge branch 'from-linus' into upstream
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream
Larry Finger:
bcm43xx: op
On Tue, 2006-08-29 at 16:01 -0700, Michael Wu wrote:
> On Tuesday 29 August 2006 15:50, Michael Wu wrote:
> > On Tuesday 29 August 2006 15:28, Mohamed Abbas wrote:
> > > SIOCGIWAP will always report the bssid no
> > > matter what the status of our link.
> >
> > That is not the case at the moment.
On Wed, 2006-08-30 at 00:15 +0200, Ulrich Kunitz wrote:
> On 06-08-29 10:45 Jouni Malinen wrote:
>
> > The only reason for adding nick command would be to maintain backwards
> > compatibility with some scripts. I do not use any distro configuration
> > mechanisms for setting up wireless, so I do n
David Miller wrote:
> From: [EMAIL PROTECTED]
> Date: Tue, 29 Aug 2006 10:42:51 -0400
>
>
>>This patchset contains a series of small patches to fix a bug and some general
>>ugliness from the original author (that moron ...). All of the following
>>patches are against David's net-2.6.19 tree.
>>
Hello, all!
Function sk_filter() is called from tcp_v{4,6}_rcv() functions with argue
needlock = 0, while socket is not locked at that moment. In order to avoid
this and similar issues in the future, use rcu for sk->sk_filter field read
protection.
Patch is for net-2.6.19
Signed-off-by: Dmitr
On Wednesday 30 August 2006 00:51, Daniel Drake wrote:
> From: Ulrich Kunitz <[EMAIL PROTECTED]>
>
> Inspired by an e-mail by Stephen Hemminger I decided to remove all
> unneeded packed attributes from the code where the member variables are
> already aligned. This avoids horrible code being gener
On Wednesday 30 August 2006 03:12, Jean Tourrilhes wrote:
> Hi,
>
> WE-21 for Broadcom driver and SoftMAC...
> This version is for wireless-2.6 git.
>
> Jean
>
> Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]>
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
N
[EMAIL PROTECTED] wrote:
As the length of field ifr_name of struct ifreq is IFNAMSIZ(16) in header file /usr/include/net/if.h.
It will result in buffer overflow when devname is too long. Modified strcpy to strncpy for only
copying IFNAMSIZ bytes into struct ifreq. Also, by adding a section into
Andrew Morton wrote:
> Obvious question: does it happen with 2.6.17.x or 2.6.18-rc5?
>
>
> Begin forwarded message:
>
> Date: Tue, 29 Aug 2006 19:49:11 -0700
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
> Subject: [Bugme-new] [Bug 7074] New: Kernel Panic on kernel 2.6.16.1
>
>
> http://bu
Hi:
Thanks to some excellent info from Joy, I've trakced the problem down to
a broken implementation of memmove on ppc64, which in turn is due to a
broken memcpy.
Both memmove and memcpy need to return the destination pointer as per
the C standard. The ppc64 version of memcpy returns a pointer t
As the length of field ifr_name of struct ifreq is IFNAMSIZ(16) in header file
/usr/include/net/if.h.
It will result in buffer overflow when devname is too long. Modified strcpy to
strncpy for only
copying IFNAMSIZ bytes into struct ifreq. Also, by adding a section into
parse_cmdline to detect
Hello!
I'm writing an application that is working over TCP. Total traffic is
very low (~ 10 kb/sec), but performance is very bad. I've tried to
investigate problem with tcpdump and strace, and it shows that
application does multiple writes, but TCP buffers them and send after
some delay (about 40
Scheduling a tasklet when all it'll do is free the skb seems pretty
strange, we can just free the skb right away (it'll not be freed but
cleaned up later anyway then).
Also, this patch adds a few comments about what that code is doing with
the skb->cb field, namely storing a pointer and not the ac
This patch converts uses of list_for_each and list_for_each_safe to
list_for_each_entry and list_for_each_entry_safe respectively where
applicable. It also adds locking in some places though I'm not entirely
sure that I can do it that way (i.e. call ieee80211_key_enable_hwaccel
etc. with spinlocks
This patch makes d80211 use BUILD_BUG_ON instead of checking at module
initialisation time. This check really is only interesting while you
hack since if the module was built, then it's either an 'always true' or
'always false' comparison, hence useless to do it at runtime.
Signed-off-by: Johannes
This patch replaces the if (...) else if (...) else if (...) ...
statements I complained about earlier with switches.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
--- wireless-dev.orig/net/d80211/ieee80211_ioctl.c 2006-08-25
22:49:45.518728753 +0200
+++ wireless-dev/net/d80211/ieee80211
On Tue, 2006-08-29 at 11:39 -0700, Jouni Malinen wrote:
> What would be the preferred way of doing the conversion here? I think I
> would prefer to get the radar detection code in as-is and then move all
> the messages to use a new mechanism as one change once that mechanism
> becomes available.
dm9000_release_board calls release_resource with the platform resource
instead of the requested resource:
db->addr_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
db->addr_req = request_mem_region(db->addr_res->start, i, pdev->name);
dm9000_release_board:
if (db->addr_res != NULL) {
76 matches
Mail list logo
