[PATCH 3/4] IP100A: Correct initial and close hardware step.

2006-08-21 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - Correct initial and close hardware step. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- sundance.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) ddfaae9a0f4bd37c155f21fb4779093eef059bf6 diff --git a/sundance.c b

Re: [PATCH 03/18] d80211: pointers as extended booleans

2006-08-21 Thread Bill Fink
On Mon, 21 Aug 2006, Johannes Berg wrote: > Please review carefully, the task was so boring that I might have made > stupid mistakes. > --- > This huge patch changes d80211 to treat pointers as "extended booleans", > using "if (!ptr)" and "if (ptr)" instead of comparisons with NULL. > > Signed-of

[PATCH 1/4] IP100A: Fix TX Pause bug (reset_tx, intr_handler)

2006-08-21 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - Fix TX Pause bug (reset_tx, intr_handler) Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- sundance.c | 53 ++--- 1 files changed, 30 insertions(+), 23 deletions(-) ba5de849a1160e56f834

[PATCH 4/4] IP100A: Solve host error problem in low performance embedded system when continune down and up.

2006-08-21 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - Solve host error problem in low performance embedded system when continune down and up. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- sundance.c | 30 +- 1 files changed, 25 insertions(+), 5 deleti

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-21 Thread Randy.Dunlap
On Tue, 22 Aug 2006 13:37:14 -0400 Jesse Huang wrote: > Dear All: > I had regenerate this patch from: > git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git > > And, submit those modifications as one patch. > > Add: "Remove and add some whitespace" > > From: Jesse Huang <[EM

[PATCH] tcp: RFC3465 Appropriate Byte Count fix

2006-08-21 Thread Daikichi Osuga
From: Daikichi Osuga <[EMAIL PROTECTED]> RFC3465 Appropriate Byte Count fix slow start after retransmit timeout does not work is fixed. case of L=2*SMSS acked bytes comparison is fixed. Signed-off-by: Daikichi Osuga <[EMAIL PROTECTED]> --- linux-2.6.15.i686.org/net/ipv4/tcp_input.c 2006-08-21 1

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 09:36:50PM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > On Mon, 21 Aug 2006 16:09:34 +0400 > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL > > PROTECTED]) wrote: > > > > +static int __init kevent

[PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-21 Thread Jesse Huang
Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. Add: "Remove and add some whitespace" From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - update maintainer information - rem

Re: [PATCH] IP1000A: IC Plus update

2006-08-21 Thread Randy.Dunlap
On Tue, 22 Aug 2006 11:11:16 +0800 Jesse Huang wrote: > Hi Randy: > > Thanks for your review. I will follow your suggestions. I used > git-format-diff > to generate this patch, should I use diffstat to instead of it? Sorry, I really can't advise you on how to use git. Did you have a complete ker

Re: [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms

2006-08-21 Thread Zhu Yi
On Mon, 2006-08-21 at 10:52 +0100, Christoph Hellwig wrote: > There's a lot more little endian platforms than just the intel ones, > aswell. > > It seems you're totally unsuitable as a driver or subsystem maintainer > if you favour you own employer so much. I'm not saying I'm not going to support

Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro

2006-08-21 Thread Zhu Yi
On Mon, 2006-08-21 at 06:39 -0400, Dan Williams wrote: > Per my other mail, what exactly has changed and must be checked? The > SIOCGIWFREQ stuff? The prototype of ieee80211_tx_frame() changed. It used to have 3 parameters. Now it has 5. Thanks, -yi - To unsubscribe from this list: send the line

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Andrew Morton
On Mon, 21 Aug 2006 16:09:34 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL > PROTECTED]) wrote: > > > +static int __init kevent_init_timer(void) > > > +{ > > > + struct kevent_callbacks tc = { > > > + .callback = &k

Re: [PATCH] IP1000A: IC Plus update

2006-08-21 Thread Jesse Huang
Hi Randy: Thanks for your review. I will follow your suggestions. I used git-format-diff to generate this patch, should I use diffstat to instead of it? The old DefaultPhyParam table content a lot of furture hardware parameters. We are sure now that is not need for new version of IP1000A, so I re

[ETHTOOL] GSO Support for ethtool

2006-08-21 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Upcoming 2.6.18 provides Generic Segmentation Offload (GSO). This provides its control with -K option. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/ethtool-copy.h b/ethtool-copy.h index d696de3..30f5e05 100644 --- a/ethtool-copy.h +++ b/ethtool-copy.h @@ -285,6 +285,8

Re: [PATCH 2/6] IP100A Fix Tx pause bug

2006-08-21 Thread Jesse Huang
- Original Message - From: "Jeff Garzik" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: ; ; <[EMAIL PROTECTED]> Sent: Friday, August 18, 2006 7:27 PM Subject: Re: [PATCH 2/6] IP100A Fix Tx pause bug (1) >> + iowrite8(127, ioaddr + TxDMAPollPeriod); >> + > > what does the va

[PATCH 03/3] d80211: adhoc

2006-08-21 Thread Mohamed Abbas
This a small patch allow IBSS network to recieve management frame. Thanks Mohamed diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c index 8caf352..1153932 100644 --- a/net/d80211/ieee80211_sta.c +++ b/net/d80211/ieee80211_sta.c @@ -1716,7 +1710,8 @@ void ieee80211_sta_rx_mgmt(st

[PATCH 02/3] d80211: iwlist scan

2006-08-21 Thread Mohamed Abbas
This patch enhance iwlist scan to dispaly supported rate with readable format. It also add a macro to convert channel to freq value. this macro is needed in ieee80211_rx_bss_info. In 3945 we issues a host scan command to perform scanning which will cause in setting the freq to the wrong value.

Re: [PATCH 2/4]: powerpc/cell spidernet low watermark patch.

2006-08-21 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Mon, 21 Aug 2006 19:13:11 -0500 > @@ -1495,16 +1500,16 @@ spider_net_interrupt(int irq, void *ptr, > if (!status_reg) > return IRQ_NONE; > > - if (status_reg & SPIDER_NET_RXINT ) { > + if (status_reg & SPIDER_NET_RXINT) {

Re: [RFC] HOWTO use NAPI to reduce TX interrupts

2006-08-21 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 17:29:05 -0700 > This is a digression from spidernet, but what if a device is able to > generate separate MSIs for TX and RX? Some people from IBM have > suggested that it is beneficial for throughput to handle TX work and > RX work f

[PATCH 01/3] d80211: add support for SIOCSIWRATE, SIOCSIWTXPOW and SIOCSIWPOWER

2006-08-21 Thread Mohamed Abbas
the attached patch will add support to handle these iw_handle SIOC[S/G]IWRATE, SIOC[S/G]IWTXPOW and SIOC[S/G]IWPOWER. It also added some changes in ieee80211_ioctl_giwrange function to report supported channels and rates. a call to ieee80211_hw_config is needed to infor the low level driver

Re: [RFC] HOWTO use NAPI to reduce TX interrupts

2006-08-21 Thread Roland Dreier
David> Don't touch interrupts until both RX and TX queue work is David> fullydepleted. You seem to have this notion that RX and TX David> interrupts are seperate. They aren't, even if your device David> can generate those events individually. Whatever interrupt David> you get

Re: [PATCH 2/4]: powerpc/cell spidernet low watermark patch.

2006-08-21 Thread Linas Vepstas
On Sat, Aug 19, 2006 at 02:33:42PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2006-08-18 at 18:45 -0500, Linas Vepstas wrote: > > On Fri, Aug 18, 2006 at 06:29:42PM -0500, linas wrote: > > > > > > I don't understand what you are saying. If I call the transmit > > > queue cleanup code from the

Re: [RFC] HOWTO use NAPI to reduce TX interrupts

2006-08-21 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Mon, 21 Aug 2006 18:52:44 -0500 > Under what circumstance does one turn TX interrupts back on? > I couldn't quite figure that out. Don't touch interrupts until both RX and TX queue work is fullydepleted. You seem to have this notion that RX and TX in

Re: [RFC] HOWTO use NAPI to reduce TX interrupts

2006-08-21 Thread Linas Vepstas
On Sat, Aug 19, 2006 at 01:25:18PM +0200, Arnd Bergmann wrote: > > What is the best way to treat the IRQ mask for TX interrupts? > I guess it should be roughly: > > - off when we expect ->poll() to be called, i.e. after calling > netif_rx_schedule() or returning after a partial rx from poll().

Re: 800+ byte inlines in include/net/pkt_act.h

2006-08-21 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 08:26:00 -0400 > As per last discussion, either Patrick McHardy or myself are going > to work on it - at some point. Please be patient. The other > alternative is: you fix it and send patches. I'm working on it right now. This code is really

Re: sky2 driver - large files upload problem

2006-08-21 Thread Stephen Hemminger
On Tue, 22 Aug 2006 00:04:07 +0200 Jon Wikne <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > > On Mon, 21 Aug 2006 16:21:07 +0200 > > Jon Wikne <[EMAIL PROTECTED]> wrote: > > > >>Daniel Drake wrote: > >> > >>>Jon Wikne wrote: > >>> > What happens is typically this: After transeferr

Re: Proper pci_enable_device() error handling in resume routine

2006-08-21 Thread Valerie Henson
On Mon, Aug 21, 2006 at 11:12:03AM -0700, Auke Kok wrote: > Valerie Henson wrote: > >I'm trying to properly handle pci_enable_device() errors in the resume > >routines of a couple of tulip drivers. I noticed that several drivers > >pay attention to errors from pci_enable_device() in the init routi

Re: sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable)

2006-08-21 Thread Daniel Drake
Thomas Glanzmann wrote: I can ssh off the machine for days. But sshing in IPv6 and starting vim makes the network card hang. This is possibly related to an equally strange issue reported on the Gentoo bugzilla. As soon as iptables is started, sky2 hangs. http://bugs.gentoo.org/136508 I'll b

Re: sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable)

2006-08-21 Thread Thomas Glanzmann
Hello, [resent because forget to CC netdev ] > Something is happening long before you start doing ipv6. The parity > error's mean that the PCI transfers are going south. The driver might > be better to just shut it self off after that. I can ssh off the machine for days. But s

Re: sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable)

2006-08-21 Thread Thomas Glanzmann
Hello, > Is this fix in your version? > http://www.mail-archive.com/netdev@vger.kernel.org/msg18603.html I put this one in and recompiled and I am *still* able to reproduce the problem. Thomas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

Re: NAPI documentation

2006-08-21 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 15:09:35 -0700 > Click edit on wiki and it is the first sentence. Thanks a lot. > Also, does Jamal have a link to his UKUUG paper? I don't think there is a copy online right now. - To unsubscribe from this list: send the line "u

Re: NAPI documentation

2006-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2006 15:05:09 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 21 Aug 2006 13:40:53 -0700 > > > Please edit and improve > > http://linux-net.osdl.org/index.php/NAPI > > > > When the page is in good shape, I will de-

Re: Linker error on via-velocity driver

2006-08-21 Thread Francois Romieu
Henne <[EMAIL PROTECTED]> : [...] > I found a bug in the via-velocity driver, but I cant find a maintainer > for that, so I write to the lists. > This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled. > This is tested on i386 and x86_64. > I'm not familiar with network stuff but I don

Re: sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable)

2006-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2006 23:22:43 +0200 Thomas Glanzmann <[EMAIL PROTECTED]> wrote: > Hello, > I have the newest sky2 driver (with the newest fix in version 1.5) > running on my intel mac mini running under legacy bios modus. However if > I ssh in via IPv6 and start vim in the shell to edit a file the

Re: sky2 driver - large files upload problem

2006-08-21 Thread Jon Wikne
Stephen Hemminger wrote: On Mon, 21 Aug 2006 16:21:07 +0200 Jon Wikne <[EMAIL PROTECTED]> wrote: Daniel Drake wrote: Jon Wikne wrote: What happens is typically this: After transeferring some data, ranging from less than 100kB to 10MB, the upload freezes, i.e. gets no further. Use of ping s

Re: NAPI documentation

2006-08-21 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 13:40:53 -0700 > Please edit and improve > http://linux-net.osdl.org/index.php/NAPI > > When the page is in good shape, I will de-wiki it to place in kernel doc tree. How do I edit the introduction paragraphs at the top? I

Re: [Patch] Signedness issue in drivers/net/3c515.c

2006-08-21 Thread Alan Cox
Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton: > /* Wait for the stall to complete. */ > for (i = 20; i >= 0; i--) > if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0) > break; > > Your fix will convert this indefinit wait into a b

[PATCH]: e1000: error out if we cannot enable PCI device on resume

2006-08-21 Thread Auke Kok
FYI, in light of the recent error handling patches. I'll stack the outstanding list submitted by Vasily Averin to our git repository for submission to #upstream. Cheers, Auke --- e1000_main.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) --- e1000: error out if we canno

[PATCH 2/2] myri10ge: use multicast support in the firmware

2006-08-21 Thread Brice Goglin
[PATCH] myri10ge: use multicast support in the firmware Some recent myri10ge firmwares support multicast filtering as well as an extended mcp_irq_data structure (64 instead of 40 bytes). The new command MXGEFW_CMD_SET_STATS_DMA_V2 is used to check whether the firmware support those. mgp->fw_multic

[PATCH 1/2] myri10ge: use netif_msg_link

2006-08-21 Thread Brice Goglin
[PATCH] myri10ge: use netif_msg_link Add msg_enable and use netif_msg_link to enable/disable reporting of link status changes since some Ethernet switches seem to generate a lot of status changes under some circumstances and some people want to avoid useless flooding in the logs. Also add a count

[PATCH 0/2] myri10ge: updates for 2.6.19

2006-08-21 Thread Brice Goglin
Jeff, Here's 2 patches for myri10ge for 2.6.19. 1) use netif_msg_link As you requested after I sent my first patch to make link status change reporting configurable, I reworked the code to use netif_msg_link. I sent this new version last week without getting any complains, so I hope it is ok to g

Re: [Patch] Signedness issue in drivers/net/3c515.c

2006-08-21 Thread Andrew Morton
On Sat, 19 Aug 2006 19:37:57 +0200 Eric Sesterhenn <[EMAIL PROTECTED]> wrote: > while playing with gcc 4.1 -Wextra warnings, I came across this one: > > drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is > always true > > Since i is unsigned the >= 0 check in the for l

NAPI documentation

2006-08-21 Thread Stephen Hemminger
I took this opportunity to get a start on improving NAPI documentation. I mashed together the short text about NAPI (with permission) from lwn.net and the existing NAPI-HOWTO, to make a page on the Linux net wiki. I took the liberty of removing some of the bits that were out of date, or referred

Linker error on via-velocity driver

2006-08-21 Thread Henne
Hi there! I found a bug in the via-velocity driver, but I cant find a maintainer for that, so I write to the lists. This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled. This is tested on i386 and x86_64. I'm not familiar with network stuff but I don't believe a device should depen

Re: [PATCH 13/18] d80211: clean up some coding style issues

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:20 +0200, Johannes Berg wrote: > Try to reduce the coding style nits people will point out once > we post integration patches. Please, wait with such patches for some more time. Yes, the coding style in some places in d80211 annoys me as well. But there is a bunch of not

Re: [PATCH 11/18] d80211: clean up qdisc requeue

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:18 +0200, Johannes Berg wrote: > There was a comment saying: > /* TODO: clean up the cases where master_hard_start_xmit > * returns non 0 - it shouldn't ever do that. Once done we > * can remove this function */ > > I noticed that master_hard_start_xmit never returns no

Re: [PATCH 06/18] d80211: rework rate control registration

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:13 +0200, Johannes Berg wrote: > Contrary to what Jiri said, proper rate control module refcounting > is much easier than allowing rate control changes on-the-fly... > This patch implements only the former along with cleanups. > Note that the diff between rate_control.c an

[patch 08/20] ipx: header length validation needed

2006-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger <[EMAIL PROTECTED]> This patch will linearize and check there is enough data. It handles the pprop case as well as avoiding a whole audit of the routing code. Signed-off-by: Stephe

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 17:01:21 +0400 > Actually I completely do not care about define or enums, it is really > silly dispute, I just do not want to rewrite bunch of code _again_ and > then _again_ when someone decide that defines are better. I totally a

Re: [PATCH 02/18] d80211: master link

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:09 +0200, Johannes Berg wrote: > This patch adds a link from the wiphy to the master device in sysfs. Please add proper error handling and remove the link when the master device is unregistered. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: sen

Re: Proper pci_enable_device() error handling in resume routine

2006-08-21 Thread Auke Kok
Valerie Henson wrote: I'm trying to properly handle pci_enable_device() errors in the resume routines of a couple of tulip drivers. I noticed that several drivers pay attention to errors from pci_enable_device() in the init routine but ignore it on resume; other drivers vary wildly. What's prop

Re: sky2 driver - large files upload problem

2006-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2006 16:21:07 +0200 Jon Wikne <[EMAIL PROTECTED]> wrote: > Daniel Drake wrote: > > > > Jon Wikne wrote: > > > >> What happens is typically this: After transeferring some > >> data, ranging from less than 100kB to 10MB, the upload freezes, > >> i.e. gets no further. Use of ping sho

Re: [PATCH] IP1000A: IC Plus update

2006-08-21 Thread Randy.Dunlap
On Mon, 21 Aug 2006 16:32:07 -0400 Jesse Huang wrote: > Dear All: > I had regenerate this patch from: > git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git > > And, submit those modifications as one patch. > > From: Jesse Huang <[EMAIL PROTECTED]> > > Change Logs: >- up

Re: [RFC] nl80211 + packet injection with it and d80211

2006-08-21 Thread Johannes Berg
Here's a respun patch hopefully addressing most of Jiri's comments, and allowing to add/remove virtual interfaces via netlink as well. I introduced a new notion of 'wiphy' which is just a number handed out by nl80211 for each registered backend, and I also changed it so that each backend must regi

Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

2006-08-21 Thread Michael Buesch
On Monday 21 August 2006 16:43, Larry Finger wrote: > Hi John, > > Please apply this to wireless-2.6. > > Larry > > -- > > This fixes various bugs in the init and shutdown code > that would lead to lockups and crashes, and is the softmac > equivalent of the patches submitted by Michael Buesch f

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: > On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote: >> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c >> +++ kernel/drivers/net/ehea/ehea_main.c > >> +static inline int ehea_refill_rq3_def(struct ehea_port_res *pr, int nr_of_wqes) > > This one looks

[PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

2006-08-21 Thread Larry Finger
Hi John, Please apply this to wireless-2.6. Larry -- This fixes various bugs in the init and shutdown code that would lead to lockups and crashes, and is the softmac equivalent of the patches submitted by Michael Buesch for bcm43xx-d80211. These changes may fix some of the NETDEV WATCHDOG tran

[PATCH 7/7] [CRYPTO] digest: Remove old HMAC implementation

2006-08-21 Thread Herbert Xu
[CRYPTO] digest: Remove old HMAC implementation This patch removes the old HMAC implementation now that nobody uses it anymore. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- crypto/Kconfig |2 crypto/digest.c|3 - c

[PATCH 4/7] [IPSEC]: Use HMAC template and hash interface

2006-08-21 Thread Herbert Xu
[IPSEC]: Use HMAC template and hash interface This patch converts IPsec to use the new HMAC template. The names of existing simple digest algorithms may still be used to refer to their HMAC composites. The same structure can be used by other MACs such as AES-XCBC-MAC. This patch also switches f

[PATCH 6/7] [CRYPTO] doc: Update documentation for hash and me

2006-08-21 Thread Herbert Xu
[CRYPTO] doc: Update documentation for hash and me This patch updates the documentation to reflect the switch from digest to hash. It also replaces notes about emailing James Morris to refer to me instead. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- Documentation/crypto/api-intro.txt |

[PATCH 3/7] [CRYPTO] tcrypt: Use HMAC template and hash interface

2006-08-21 Thread Herbert Xu
[CRYPTO] tcrypt: Use HMAC template and hash interface This patch converts tcrypt to use the new HMAC template rather than the hard-coded version of HMAC. It also converts all digest users to use the new cipher interface. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Signed-off-by: David S. Mille

[PATCH 2/7] [CRYPTO] hmac: Add crypto template implementation

2006-08-21 Thread Herbert Xu
[CRYPTO] hmac: Add crypto template implementation This patch rewrites HMAC as a crypto template. This means that HMAC is no longer a hard-coded part of the API. It's now a template that generates standard digest algorithms like any other. The old HMAC is preserved until all current users are co

[PATCH 5/7] [SCTP]: Use HMAC template and hash interface

2006-08-21 Thread Herbert Xu
[SCTP]: Use HMAC template and hash interface This patch converts SCTP to use the new HMAC template and hash interface. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- include/net/sctp/constants.h |4 ++-- include/net/sctp/sctp.h |

[0/7] [CRYPTO]: Add hash type and hmac template

2006-08-21 Thread Herbert Xu
Hi: Dave, these patches are for cryptodev-2.6. This series of patches adds the new hash crypto type. It completely replaces the existing digest type from the user's side. For now the digest algorithm interface will remain and coexist with the new hash algorithm interface. The main reasons for

[PATCH 1/7] [CRYPTO] digest: Added user API for new hash type

2006-08-21 Thread Herbert Xu
[CRYPTO] digest: Added user API for new hash type The existing digest user interface is inadequate for support asynchronous operations. For one it doesn't return a value to indicate success or failure, nor does it take a per-operation descriptor which is essential for the issuing of requests whil

Re: sky2 driver - large files upload problem

2006-08-21 Thread Jon Wikne
Daniel Drake wrote: Jon Wikne wrote: What happens is typically this: After transeferring some data, ranging from less than 100kB to 10MB, the upload freezes, i.e. gets no further. Use of ping shows the connection is effectively dead. If I do a sequence /sbin/ifdown eth0 /sbin/ifup eth0 the upl

Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines

2006-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2006 13:57:23 +0530 "Amit S. Kale" <[EMAIL PROTECTED]> wrote: > We can certainly create a table for all error messages. It'll hurt > readability > of code in many of the other places where printks are used to indicate some > hardware error. > -Amit My suggestion was intended as

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Bernd Petrovitsch
On Mon, 2006-08-21 at 17:01 +0400, Evgeniy Polyakov wrote: [ #define vs enum { } ] > And, ugh: > > (gdb) list > 1 enum { > 2 A = 1, > 3 B = 2, > 4 }; > 5 > 6 int main() > 7 { > 8 printf("%x\n", A | B); > 9 } > (gdb) bre 8 > Br

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-21 Thread Jens Axboe
On Fri, Aug 18 2006, Daniel Phillips wrote: > nearly the same kind of function, and suffering very nearly the same kind > of problems we had in the block layer before mingo's mempool machinery > arrived? Correction, the block layer wasn't buggy (eg deadlock prone) before mempool, mempool was merel

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-21 Thread Philip R. Auld
Hi Andrew, Rumor has it that on Fri, Aug 18, 2006 at 07:44:35PM -0700 Andrew Morton said: > On Fri, 18 Aug 2006 16:44:01 -0700 > Daniel Phillips <[EMAIL PROTECTED]> wrote: > > - We expect that the lots-of-dirty-anon-memory-over-swap-over-network > scenario might still cause deadlocks. > >

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-08-21 Thread Jörn Engel
On Mon, 21 August 2006 14:23:53 +0200, Jan-Bernd Themann wrote: > > Is it valid (common in the kernel environment) to treat NULL as 0 after a > memset > and thus to forget about initialization? Yes. According to C99, "An implementation might conveivably have codes for floating zero and/or null

Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 11:33:22AM +0800, Zhu Yi wrote: > Add IEEE80211_API_VERSION macro so that drivers are able to check it > during compile time. This feature is useful to make backward IEEE80211 > compatibilities for wireless drivers. NACK. - To unsubscribe from this list: send the line "uns

Re: sky2 driver - large files upload problem

2006-08-21 Thread Daniel Drake
Hi Jon, Jon Wikne wrote: What happens is typically this: After transeferring some data, ranging from less than 100kB to 10MB, the upload freezes, i.e. gets no further. Use of ping shows the connection is effectively dead. If I do a sequence /sbin/ifdown eth0 /sbin/ifup eth0 the upload might resu

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-08-21 Thread Jan-Bernd Themann
Hi On Friday 18 August 2006 16:44, Alexey Dobriyan wrote: > > +static int ehea_init_port_res(struct ehea_port *port, struct ehea_port_res > > *pr, > > + struct port_res_cfg *pr_cfg, int queue_token) > > +{ > > + int ret = -EINVAL; > > + int max_rq_entries = 0; > > +

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Bernd Petrovitsch
On Mon, 2006-08-21 at 15:13 +0400, Evgeniy Polyakov wrote: [...] > And what is the difference between As others already pointed out in this thread: These are not seen by the C compiler. > #define A 1 > #define B 2 > #define C 4 > and These are known by the C compiler and thus usable/viewable in

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 02:53:25PM +0200, Bernd Petrovitsch ([EMAIL PROTECTED]) wrote: > On Mon, 2006-08-21 at 15:13 +0400, Evgeniy Polyakov wrote: > [...] > > And what is the difference between > > As others already pointed out in this thread: > > These are not seen by the C compiler. > > #defi

Re: [PATCH 2/6] ehea: pHYP interface

2006-08-21 Thread Jan-Bernd Themann
Hi Nathan, sorry for the delayed answer. On Friday 11 August 2006 23:19, Nathan Lynch wrote: > > +static inline long ehea_hcall_9arg_9ret(unsigned long opcode, > > + unsigned long arg1, > > + unsigned long arg2, > > +

sky2 driver - large files upload problem

2006-08-21 Thread Jon Wikne
Hi Stephen & rest of list, I'm having a peculiar problem with the sky2 driver. The problem is seen on the versions in kernels 2.6.16.16, 2.6.17.8 and 2.6.18-rc4. The problem appears when uploading large files (for instance via scp) _from_ the system in question. Downloads work OK, as does normal

[take12 4/3] kevent: Comment cleanup.

2006-08-21 Thread Evgeniy Polyakov
Remove file name from comments. dda1ae6fe306b485a91ebb58734bba06aebf diff --git a/kernel/kevent/kevent.c b/kernel/kevent/kevent.c index 2872aa2..02ecf30 100644 --- a/kernel/kevent/kevent.c +++ b/kernel/kevent/kevent.c @@ -1,6 +1,4 @@ /* - * kevent.c - * * 2006 Copyright (c) Evgeniy Pol

Re: [PATCH 5/7] ieee80211: export symbol ieee80211_api_version

2006-08-21 Thread John W. Linville
On Mon, Aug 21, 2006 at 11:33:40AM +0800, Zhu Yi wrote: > Export this symbol so that wireless drivers can check the running IEEE80211 > API version dynamically. The sole purpose of this would seem to be supporting out-of-stream driver development. Is there some other use that I am overlooking? I

Re: 800+ byte inlines in include/net/pkt_act.h

2006-08-21 Thread jamal
On Sun, 2006-20-08 at 19:33 +0200, Denis Vlasenko wrote: > Hi, > > include/net/pkt_act.h plays a game of inlines > which are kind of "templatized", like this: > > act_ipt.c: > > /* ovewrride the defaults */ > #define tcf_st tcf_ipt > #define tcf_t_lock ipt_lock > #define tcf_ht

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 02:13:49PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: > > > Call me a cynic, but I'm always a bit sceptical about needing lockdep > > > annotations like this... Can you explain why you need it in this case, > > > including the proof that it's safe? > > > > Ok, agai

Re: [2.6.19 PATCH 7/7] ehea: Makefile & Kconfig

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: > On Fri, Aug 18, 2006 at 01:37:44PM +0200, Jan-Bernd Themann wrote: >> --- linux-2.6.18-rc4/drivers/net/Kconfig >> +++ patched_kernel/drivers/net/Kconfig >> @@ -2277,6 +2277,12 @@ config CHELSIO_T1 >>To compile this driver as a module, choose M here: the module

Re: [RFC] nl80211 + packet injection with it and d80211

2006-08-21 Thread John W. Linville
On Mon, Aug 21, 2006 at 08:44:52AM +0200, Johannes Berg wrote: > Another thing that crossed my mind: Should we have a netlink call for > adding virtual interfaces as well? Because then, the ipw2x00 drivers can > have their monitor interface(s) added the same way. Yes. -- John W. Linville [EMAIL

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Arjan van de Ven
On Mon, 2006-08-21 at 15:59 +0400, Evgeniy Polyakov wrote: > On Mon, Aug 21, 2006 at 01:27:22PM +0200, Arjan van de Ven ([EMAIL > PROTECTED]) wrote: > > On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > > > ]> > +lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key); > > > >

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-21 Thread Eugene Teo
Willy Tarreau wrote: > On Sun, Aug 20, 2006 at 02:05:20AM +0200, Michael Buesch wrote: >> On Sunday 20 August 2006 01:48, Willy Tarreau wrote: >>> On Sun, Aug 20, 2006 at 03:05:32AM +0400, Solar Designer wrote: [snipped] > diff --git a/net/socket.c b/net/socket.c > index ac45b13..910ef88 100644 > -

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > > +static int __init kevent_init_timer(void) > > +{ > > + struct kevent_callbacks tc = { > > + .callback = &kevent_timer_callback, > > + .enqueue = &kevent_timer_enqueue, > > +

Re: [2.6.19 PATCH 5/7] ehea: main header files

2006-08-21 Thread Thomas Klein
Michael Neuling wrote: >> +static inline void ehea_update_sqa(struct ehea_qp *qp, u16 nr_wqes) >> +{ >> +struct h_epa epa = qp->epas.kernel; >> +epa_store_acc(epa, QPTEMM_OFFSET(qpx_sqa), >> + EHEA_BMASK_SET(QPX_SQA_VALUE, nr_wqes)); >> +} >> + >> +static inline void ehea_

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 01:27:22PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: > On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > > ]> > + lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key); > > > > > > When looking at the kevent_storage_init callers most need t

Re: Bug in order of multiple IPv6 addresses per interface? Newest added one is preferred in difference to IPv4

2006-08-21 Thread JINMEI Tatuya / 神明達哉
> On Mon, 21 Aug 2006 12:47:36 +0200, > Peter Bieringer <[EMAIL PROTECTED]> said: >> I do not favor changing this so far. > Hmm, would it be possible to implement a primary flag in the future? > BTW: Does anyone know about the behavior of *BSD for this issue? As far as I know, BSD vari

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Arjan van de Ven
On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > ]> > +lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key); > > > > When looking at the kevent_storage_init callers most need to do > > those lockdep_set_class class. Shouldn't kevent_storage_init just > > get a "struct

Re: [take9 2/2] kevent: poll/select() notifications. Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:01:04PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Fri, Aug 18, 2006 at 02:59:34PM +0400, Evgeniy Polyakov wrote: > > > If there's a really good reason we can keep things separate, but > > > > > > "epoll and kevent_poll differs on some aspects" > > > >

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: > > > > > > Timer notifications. > > > > Timer notifications can be used for fine grained per-process time > > management, since interval t

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 11:56:37AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Fri, Aug 18, 2006 at 03:23:36PM +0400, Evgeniy Polyakov wrote: > > > defines make some sense for userspace-visible ABIs because then people > > > can test for features with ifdef. It doesn't make any sense

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: > > > Timer notifications. > > Timer notifications can be used for fine grained per-process time > management, since interval timers are very inconvenient to use, > and they are limited. Shouldn't this at leat use a hrtimer? >

Re: [take9 2/2] kevent: poll/select() notifications. Timer notifications.

2006-08-21 Thread Christoph Hellwig
On Fri, Aug 18, 2006 at 02:59:34PM +0400, Evgeniy Polyakov wrote: > > If there's a really good reason we can keep things separate, but > > > > "epoll and kevent_poll differs on some aspects" > > > > is not one :) > > kevent_poll uses hash table (actually it is kevent that uses table), > lockin

Re: [PATCH] locking bug in fib_semantics.c

2006-08-21 Thread Jarek Poplawski
On 21-08-2006 10:17, David Miller wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Mon, 21 Aug 2006 10:16:43 +0200 ... >> But I hope the real reason for this patch isn't exactly like that. >> Could fib_release_info() be interrupted by BH really? > > Absolutely, yes it can. What makes yo

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Christoph Hellwig
On Fri, Aug 18, 2006 at 03:23:36PM +0400, Evgeniy Polyakov wrote: > > defines make some sense for userspace-visible ABIs because then people > > can test for features with ifdef. It doesn't make any sense for constants > > that are used purely in-kernel. For those enums make more sense because >

Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: > On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote: >> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c >> +++ kernel/drivers/net/ehea/ehea_ethtool.c >> +{ >> +strncpy(info->driver, DRV_NAME, sizeof(info->driver) - 1); >> +strncpy(info->ver

Re: Bug in order of multiple IPv6 addresses per interface? Newest added one is preferred in difference to IPv4

2006-08-21 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Mon, 21 Aug 2006 07:36:19 +0200), Peter Bieringer <[EMAIL PROTECTED]> says: > In IPv6, the behavior is completly different: > > # ip -6 addr show dev eth0 |grep -w inet6 |grep -w global > inet6 2001:db8:0:1::11/64 scope global > > # ip -6 addr add

  1   2   >