Valerie Henson wrote:
I'm trying to properly handle pci_enable_device() errors in the resume
routines of a couple of tulip drivers. I noticed that several drivers
pay attention to errors from pci_enable_device() in the init routine
but ignore it on resume; other drivers vary wildly. What's proper
behavior when resuming? Extant examples:
0. Don't call pci_enable_device() at all (8139too)
1. Ignore the return value (eepro100, many others)
2. Check for failure and bail out, but return success (sungem)
Digging through e1000 I spot that we even pci_enable_device after a PCI error,
so it is good practice I think to make sure the device is up. I suppose that
most people can live without explicit re-enabling the device (most NICs are on
anyway), but if we do enable it explicitly we should certainly check the result
code. Interestingly enough we failed to do this in e1000, so I'll submit a
patch for that later.
Cheers,
Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
