Re: [0/4] [IPSEC]: Add xfrm_mode support

2006-05-27 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 27 May 2006 21:32:36 +1000 > These patches abstract out the protocol-specific encapsulation parts of > IPsec into what I've termed xfrm_mode objects. This allows us to share > a little bit more code. But more importantly, it allows us to add new >

Re: [1/4] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-27 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 27 May 2006 22:08:01 +1000 > YOSHIFUJI Hideaki / <[EMAIL PROTECTED]> wrote: > > In article <[EMAIL PROTECTED]> (at Sat, 27 May 2006 21:33:45 +1000), > > Herbert Xu <[EMAIL PROTECTED]> says: > > > >> As far as I can gather it's an attempt to gu

Re: e1000 poor network performance - 2.6.17-rc5-g705af309

2006-05-27 Thread Jesse Brandeburg
On 5/26/06, Aravind Gottipati <[EMAIL PROTECTED]> wrote: Hi, I recently started running linux on a new x60 thinkpad and started noticing really poor network performance with this kernel. I saw some archived threads from a while back saying this could be related to conntracking. Disabled that (

[PATCH] Right prototype of __raw_v4_lookup()

2006-05-27 Thread Alexey Dobriyan
All users pass 32-bit values as addresses and internally they're compared with 32-bit entities. So, change "laddr" and "raddr" types to __be32. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- include/net/raw.h |2 +- net/ipv4/raw.c|2 +- 2 files changed, 2 insertions(+), 2 del

Re: CRC16 in rt2x00

2006-05-27 Thread Ivo van Doorn
On Saturday 27 May 2006 18:30, Sergey Vlasov wrote: > On Sat, May 27, 2006 at 04:24:07PM +0200, Ivo van Doorn wrote: > > On Saturday 27 May 2006 15:55, Sergey Vlasov wrote: > [skip] > > > However, fs/udf/crc.c has exactly the same CRC table as rt2x00: > [skip] > > > This is a bit-reversed form of C

Re: [PATCH] via-velocity: allow MTU size less than 1500 bytes

2006-05-27 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] > ACK, but patch won't apply: I have regenerated it against mainline. It can be pulled from the repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git velocity -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: Refactor Netlink connector?

2006-05-27 Thread James Morris
On Sat, 27 May 2006, James Morris wrote: > One of the problems is that different Netlink protocols bury their > commands at different levels, so the SELinux code has to know how how deep > to dig (and then do the digging) to determine exactly which command is > being called. Actually, a possib

[PATCH v3] bridge: fix locking and memory leak in br_add_bridge

2006-05-27 Thread Stephen Hemminger
There are several bugs in error handling in br_add_bridge: - when dev_alloc_name fails, allocated net_device is not freed - unregister_netdev is called when rtnl lock is held - free_netdev is called before netdev_run_todo has a chance to be run after unregistering net_device Signed-off-by: Jiri

Re: Refactor Netlink connector?

2006-05-27 Thread James Morris
On Sat, 27 May 2006, Evgeniy Polyakov wrote: > > connector (the w1 driver) to use generic Netlink? > > Process accounting, CIFS and OFS netfilter module use it too. w1 is the only in-tree thing I can see using any of the exported connector symbols. I can see that cifs has included a connector

Re: [PATCH] eth1394: endian fixes

2006-05-27 Thread Stephen Hemminger
On Sat, 27 May 2006 12:05:40 +0200 Stefan Richter <[EMAIL PROTECTED]> wrote: > Alexey Dobriyan wrote on 2006-05-16: > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > ... > > @@ -935,7 +935,7 @@ static inline u16 ether1394_parse_encap( > > *(u32*)arp_ptr = arp1394->sip; /* move

Re: CRC16 in rt2x00

2006-05-27 Thread Sergey Vlasov
On Sat, May 27, 2006 at 04:24:07PM +0200, Ivo van Doorn wrote: > On Saturday 27 May 2006 15:55, Sergey Vlasov wrote: [skip] > > However, fs/udf/crc.c has exactly the same CRC table as rt2x00: [skip] > > This is a bit-reversed form of CRC-CCITT supported by lib/crc-ccitt.c. > > Unfortunately, this d

Re: [PATCH] eth1394: endian fixes

2006-05-27 Thread Alexey Dobriyan
On Sat, May 27, 2006 at 12:05:40PM +0200, Stefan Richter wrote: > Alexey Dobriyan wrote on 2006-05-16: > >Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > ... > >@@ -935,7 +935,7 @@ static inline u16 ether1394_parse_encap( > > *(u32*)arp_ptr = arp1394->sip; /* move sender IP addr *

Re: CRC16 in rt2x00

2006-05-27 Thread Ivo van Doorn
On Saturday 27 May 2006 15:55, Sergey Vlasov wrote: > On Sat, 27 May 2006 13:27:15 +0200 Ivo van Doorn wrote: > > > I have a small question about the CRC16 usage in rt2x00 > > and what the netdev preferred method is for this. > > > > At the moment the rt2x00 drivers in wireless-dev use > > its ow

Re: [2/4] [IPSEC] xfrm: Abstract out encapsulation modes

2006-05-27 Thread Diego Beltrami
Quoting Herbert Xu <[EMAIL PROTECTED]>: > [IPSEC] xfrm: Abstract out encapsulation modes > > This patch adds the structure xfrm_mode. It is meant to represent > the operations carried out by transport/tunnel modes. > > By doing this we allow additional encapsulation modes to be added > without cl

Re: CRC16 in rt2x00

2006-05-27 Thread Sergey Vlasov
On Sat, 27 May 2006 13:27:15 +0200 Ivo van Doorn wrote: > I have a small question about the CRC16 usage in rt2x00 > and what the netdev preferred method is for this. > > At the moment the rt2x00 drivers in wireless-dev use > its own CRC16 table and calculation inside the driver. > There already i

Re: Refactor Netlink connector?

2006-05-27 Thread Evgeniy Polyakov
On Fri, May 26, 2006 at 04:04:53PM -0400, James Morris ([EMAIL PROTECTED]) wrote: > I've been looking through the kernel for new subsytems which might need > LSM hooks, and we've got a proliferation of Netlink abstractions: generic > Netlink, nfnetlink, connector and kobject_uevent. > > I think

Re: [PATCH] r8169: add new PCI ID

2006-05-27 Thread Yoichi Yuasa
On Sat, 27 May 2006 13:39:19 +0200 Francois Romieu <[EMAIL PROTECTED]> wrote: > Jeff Garzik <[EMAIL PROTECTED]> : > [...] > > applied > > $ grep 8129 drivers/net/*.[ch] > [...] > drivers/net/8139too.c: {0x10ec, 0x8129, PCI_ANY_ID, PCI_ANY_ID, 0, 0, > RTL8139 } > > Not a big issue but I would b

Re: [1/4] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-27 Thread Herbert Xu
YOSHIFUJI Hideaki / <[EMAIL PROTECTED]> wrote: > In article <[EMAIL PROTECTED]> (at Sat, 27 May 2006 21:33:45 +1000), Herbert > Xu <[EMAIL PROTECTED]> says: > >> As far as I can gather it's an attempt to guard against the removal of >> the corresponding modules. Since neither module can be

Re: [1/4] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-27 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 27 May 2006 21:33:45 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > As far as I can gather it's an attempt to guard against the removal of > the corresponding modules. Since neither module can be unloaded at all > we can leave it to whoever fixes up IPv6 u

Re: [PATCH] r8169: add new PCI ID

2006-05-27 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] > applied $ grep 8129 drivers/net/*.[ch] [...] drivers/net/8139too.c: {0x10ec, 0x8129, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 } Not a big issue but I would be really surprized that it does trigger a few PR. -- Ueimor - To unsubscribe from this list: send

[4/4] [IPSEC] xfrm: Use IPPROTO_MAX instead of 256

2006-05-27 Thread Herbert Xu
[IPSEC] xfrm: Use IPPROTO_MAX instead of 256 The size of the type_map array (256) comes from the number of IP protocols, i.e., IPPROTO_MAX. This patch is based on a suggestion from Ingo Oeser. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ E

[1/4] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-27 Thread Herbert Xu
[IPSEC] xfrm: Undo afinfo lock proliferation The number of locks used to manage afinfo structures can easily be reduced down to one each for policy and state respectively. This is based on the observation that the write locks are only held by module insertion/removal which are very rare events so

[3/4] [IPSEC] proto: Move transport mode input path into xfrm_mode_transport

2006-05-27 Thread Herbert Xu
[IPSEC] proto: Move transport mode input path into xfrm_mode_transport Now that we have xfrm_mode objects we can move the transport mode specific input decapsulation code into xfrm_mode_transport. This removes duplicate code as well as unnecessary header movement in case of tunnel mode SAs since

[2/4] [IPSEC] xfrm: Abstract out encapsulation modes

2006-05-27 Thread Herbert Xu
[IPSEC] xfrm: Abstract out encapsulation modes This patch adds the structure xfrm_mode. It is meant to represent the operations carried out by transport/tunnel modes. By doing this we allow additional encapsulation modes to be added without clogging up the xfrm_input/xfrm_output paths. Candidat

[0/4] [IPSEC]: Add xfrm_mode support

2006-05-27 Thread Herbert Xu
Hi Dave: These patches abstract out the protocol-specific encapsulation parts of IPsec into what I've termed xfrm_mode objects. This allows us to share a little bit more code. But more importantly, it allows us to add new encapsulation modes such as BEET or v4/v6 and v6/v4 without polluting the

CRC16 in rt2x00

2006-05-27 Thread Ivo van Doorn
Hi, I have a small question about the CRC16 usage in rt2x00 and what the netdev preferred method is for this. At the moment the rt2x00 drivers in wireless-dev use its own CRC16 table and calculation inside the driver. There already is a CRC16 library in the kernel which uses the 0x8005 table, whi

Re: [PATCH 0/9] Resending NetXen 1G/10G NIC driver patch

2006-05-27 Thread Amit S. Kale
On Saturday 27 May 2006 01:32, Roland Dreier wrote: > Amit> We'll implement the minor changes rightaway and post an > Amit> update. We are also thinking about what's the best way to > Amit> incorporate the data structure changes you have > Amit> suggested. Will post a reply on that

Re: [PATCH] eth1394: endian fixes

2006-05-27 Thread Stefan Richter
Alexey Dobriyan wrote on 2006-05-16: Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> ... @@ -935,7 +935,7 @@ static inline u16 ether1394_parse_encap( *(u32*)arp_ptr = arp1394->sip; /* move sender IP addr */ arp_ptr += arp->ar_pln; /* skip ov

[PATCH, 2.6.17-rc5-git3] ieee80211softmac_io.c: fix warning "defined but not used"

2006-05-27 Thread Toralf Förster
Got this compiler warning and Johannes Berg <[EMAIL PROTECTED]> wrote: Yeah, known 'bug', we have that code there but never use it. Feel free to submit a patch (to John Linville, CC netdev and softmac-dev) to remove it. Signed-off-by: Toralf Foerster <[EMAIL PROTECTED]> --- src/net/ieee80211/so

Re: [PATCH v2] bridge: fix locking and memory leak in br_add_bridge

2006-05-27 Thread Jiri Benc
Fri, 26 May 2006 19:26:11 -0700 (PDT), David Miller pise: > From: Jiri Benc <[EMAIL PROTECTED]> > Date: Fri, 26 May 2006 11:08:06 +0200 > > I don't think this is correct. netdev_run_todo calls dev->destructor > > which is set to free_netdev by br_dev_setup. So you're calling > > free_netdev on alre