Re: [PATCH] reno sacked_out count fix

2006-05-16 Thread David S. Miller
From: "Angelo P. Castellani" <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 11:24:00 +0200 > Using NewReno, if a sk_buff is timed out and is accounted as lost_out, > it should also be removed from the sacked_out. > > This is necessary because recovery using NewReno fast retransmit could > take up to

Re: [RFC] new qla3xxx NIC Driver v2.02.00k19

2006-05-16 Thread Francois Romieu
Ron Mercer <[EMAIL PROTECTED]> : [...] > Looking forward to any and all feedback. First pass: - please reorder the code so that the forward declarations are not needed - the typedefs (say PQL3XXX_PORT_REGISTERS) hide pointer information. They are useless (and capitalized :o/ ). Just say no to ty

Re: [1/1] connector: export cn_already_initialized.

2006-05-16 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Sat, 6 May 2006 12:40:45 +0400 > Some external patches, which can be built both as static build and as > module just check that value, and thus will fail with unresolved symbol > when cn and module are built as modules. > > The right set of operati

Re: Controlling TCP window size

2006-05-16 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 14:28:23 -0400 > The problem really is that the window_clamp variable is overloaded. > It's used as a kind of cache for rcvbuf -> window conversion, but also > as a user-settable bound in window size. On examination, it looks like >

Re: [2.6 patch] net/802/tr.c: remove an unused export

2006-05-16 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 20:48:43 +0200 > This patch removes the unused EXPORT_SYMBOL(tr_source_route). > > (No, the usage in net/llc/llc_output.c can't be modular.) > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from thi

Re: [PATCH] ipv6: endian fix

2006-05-16 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 22:36:46 +0400 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks Alexey. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH] ipx: correct return type of ipx_map_frame_type

2006-05-16 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 22:49:40 +0400 > Casting BE16 to int and back may or may not work. Correct, to be sure. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] ipx: correct return type of ipxrtr_delete

2006-05-16 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 17 May 2006 00:12:38 +0400 > A single caller passes __u32. Inside function "net" is compared with > __u32 (__be32 really, just wasn't annotated). > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, but I had to fix your changelog,

Re: skge driver oops

2006-05-16 Thread David Arnold
-->"Stephen" == Stephen Hemminger <[EMAIL PROTECTED]> writes: Stephen> I tried reproducing this and can't seem to cause it. thanks anyway :-) Stephen> Are you running anything special that could influence this? Stephen> bridging, VLAN's, bonding, netfilter, queueing disciplines, Stephen>

Re: skge driver oops

2006-05-16 Thread Stephen Hemminger
On Fri, 12 May 2006 11:36:24 +1000 "David Arnold" <[EMAIL PROTECTED]> wrote: > i've been getting semi-regular lockups on my machine over 2.6.16 > series. I recently attached a serial console in an attempt to capture > an OOPS. > > i got one yesterday. it's copied manually from the console, but

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-16 Thread Pavel Roskin
Hello! On Tue, 2006-05-16 at 17:24 +0200, Marcin Juszkiewicz wrote: > [EMAIL PROTECTED]:~# pccardctl ident > Socket 0: > product info: "D-Link", "DCF-660W", "", "" > manfid: 0xd601, 0x0005 > function: 6 (network) This manfid is in the driver already, and it also covers ZCOMAX XI-325HP 200mw

Re: Setting TCP_NODELAY doesn't disable Nagle's alg. on loopback

2006-05-16 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 09:16:06 -0700 > If it is 2.6.5 that is over 2+ years old. Please try with something > past the Pleistocene era... R O F L! If that doesn't belong in a quotes file, I don't know what does :-) - To unsubscribe from this list: send

Re: [PATCH] Enabling standard compliant behaviour in the Linux TCP implementation

2006-05-16 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 09:24:07 -0700 > Read Linus's comments on standards. We make software for users, not for > academic use. > http://kerneltrap.org/node/5725 > > If we added this then paranoid users would set it. I totally agree, and naming t

[PATCH] ipx: correct return type of ipxrtr_delete

2006-05-16 Thread Alexey Dobriyan
A single caller passes __u32. Inside function "net" is compared with __u32 (__be32 really, just wasn't annotated). Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- --- a/net/ipx/ipx_route.c +++ b/net/ipx/ipx_route.c @@ -119,7 +119,7 @@ out: return rc; } -static int ipxrtr_delete(

RE: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-05-16 Thread Guenther Thomsen
Thanks for your continued work on it. I will test the patch, as soon as I get access to the hardware again (probably next week). best regards Guenther -Original Message- From: Stephen Hemminger [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 16, 2006 12:12 PM To: Guenther Thomsen C

Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-05-16 Thread Stephen Hemminger
Could you try the 2.6.17-rc4 version with this patch. It turns out the board seems to give out of order status responses. Ignore the vendor sk98lin driver, when I try the stock version it spends it's life resetting itself because it sets up PCI bus wrong. If I fix that, it spends it's time getting

[PATCH] ipx: correct return type of ipx_map_frame_type

2006-05-16 Thread Alexey Dobriyan
Casting BE16 to int and back may or may not work. Correct, to be sure. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- --- a/net/ipx/af_ipx.c +++ b/net/ipx/af_ipx.c @@ -944,9 +944,9 @@ out: return rc; } -static int ipx_map_frame_type(unsigned char type) +static __be16 ipx_map_fr

[2.6 patch] net/802/tr.c: remove an unused export

2006-05-16 Thread Adrian Bunk
This patch removes the unused EXPORT_SYMBOL(tr_source_route). (No, the usage in net/llc/llc_output.c can't be modular.) Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 20 Apr 2006 --- linux-2.6.17-rc1-mm3-full/net/802/tr.c.old 2006-04-20 22:45:07.0

Re: Controlling TCP window size

2006-05-16 Thread John Heffner
Andy Furniss wrote: John Heffner wrote: Andy Furniss wrote: I've been doing some testing of my new wan connection and noticed that when I specify a window with ip route it still changes after a while. Looks like this is occurring in net/ipv4/tcp_input.c:tcp_rcv_space_adjust(). The pro

[PATCH] ipv6: endian fix

2006-05-16 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- --- a/net/ipv6/netfilter/ip6t_eui64.c +++ b/net/ipv6/netfilter/ip6t_eui64.c @@ -38,11 +38,11 @@ match(const struct sk_buff *skb, return 0; } memset(eui64, 0, sizeof(eui64)); - if (eth_hdr(skb)->h_proto

Re: Controlling TCP window size

2006-05-16 Thread Andy Furniss
John Heffner wrote: Andy Furniss wrote: I've been doing some testing of my new wan connection and noticed that when I specify a window with ip route it still changes after a while. Looks like this is occurring in net/ipv4/tcp_input.c:tcp_rcv_space_adjust(). The problem really is that th

Re: Controlling TCP window size

2006-05-16 Thread John Heffner
Andy Furniss wrote: I've been doing some testing of my new wan connection and noticed that when I specify a window with ip route it still changes after a while. Looks like this is occurring in net/ipv4/tcp_input.c:tcp_rcv_space_adjust(). The problem really is that the window_clamp variable i

[RFC] new qla3xxx NIC Driver v2.02.00k19

2006-05-16 Thread Ron Mercer
All, Second submission for the upstream inclusion of the qla3xxx Ethernet driver. This is a complementary network driver for our ISP4XXX parts. There is a concurrent effort underway to get the iSCSI driver (qla4xxx) integrated upstream as well. The following files are included and have been poste

[1/1] Netchannel subsyste.

2006-05-16 Thread Evgeniy Polyakov
Receiving support. As proof-of-concept code I created simple copy_to_user() based getting data callback. Next step is to implement netchannels data allocation callbacks to get data from mapped userspace area and make get data callback be similar to ->recvmsg() so all protocol processing happens in

Re: ifIndex allocation

2006-05-16 Thread Stephen Hemminger
On Tue, 16 May 2006 08:11:01 +0200 "Sven Schnelle" <[EMAIL PROTECTED]> wrote: > Hi List, Redirecting to netdev > > investigating a problem with an snmp software for linux, i was wondering > why the kernel allocates a new ifindex Number, even if the old one is still > available. For example, if

Re: [-mm patch] drivers/net/s2io.c: make bus_speed[] static

2006-05-16 Thread Adrian Bunk
On Tue, May 16, 2006 at 05:36:11PM +0200, Andreas Mohr wrote: > Hi, > > On Tue, May 16, 2006 at 05:30:50PM +0200, Adrian Bunk wrote: > > This patch makes the needlessly global bus_speed[] static. > > Is there a reason why you don't also constify it while you are at it? > Or is it because you want

Re: [PATCH] Enabling standard compliant behaviour in the Linux TCP implementation

2006-05-16 Thread Stephen Hemminger
On Tue, 16 May 2006 16:24:22 +0200 "Angelo P. Castellani" <[EMAIL PROTECTED]> wrote: > Hi all, > I'm a student doing a thesis about TCP performance over high BDP links > and so about congestion control in TCP. > > To do this work I've built a testbed using the latest Linux release (2.6.16). > >

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-16 Thread Mike Stroyan
On Mon, May 15, 2006 at 06:50:36PM -0700, Mark A Smith wrote: > > I cannot think of another possible definition for thread-safe in the > context of these functions. Certainly they should not cause a "crash" when > called from multiple threads, but that's a requirement independent of > thread-safet

Re: Setting TCP_NODELAY doesn't disable Nagle's alg. on loopback

2006-05-16 Thread Stephen Hemminger
On Tue, 16 May 2006 10:50:30 +0200 "Radko Mihal" <[EMAIL PROTECTED]> wrote: > Hi, > > We are facing strange problem with disabling the Nagle's algorithm via > setting the TCP_NODELAY flag on server socket (setsockopt), where server is > communication with client via loopback. > After the first

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-16 Thread Marcin Juszkiewicz
Dnia wtorek, 16 maja 2006 16:38, Jeff Garzik napisał: > Marcin Juszkiewicz wrote: > > One more Prism2 card which works with HostAP. > Please roll these into a single patch. There's no need to split it up > such that there is one ID per patch. Here's another card that would benefit from a hostap

[-mm patch] drivers/net/s2io.c: make bus_speed[] static

2006-05-16 Thread Adrian Bunk
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote: >... > Changes since 2.6.17-rc3-mm1: >... > git-netdev-all.patch >... > git trees >... This patch makes the needlessly global bus_speed[] static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.17-rc4-mm1-full/drivers

Re: [RFC] changing value of NETDEV_ALIGN to cacheline size

2006-05-16 Thread Christian Borntraeger
On Tuesday 16 May 2006 00:49, David S. Miller wrote: > From: Rick Jones <[EMAIL PROTECTED]> > Date: Mon, 15 May 2006 14:39:23 -0700 > > > How about: > > How about, just leave it alone? :-) Agreed. Currently it only makes a difference with slab debugging, which hurts performance no matter what we

Re: [PATCH 3/6] new pcmcia IDs for hostap - NETGEAR MA701

2006-05-16 Thread Jeff Garzik
Marcin Juszkiewicz wrote: Dnia wtorek, 16 maja 2006 16:38, Jeff Garzik napisał: Marcin Juszkiewicz wrote: One more Prism2 card which works with HostAP. Please roll these into a single patch. There's no need to split it up such that there is one ID per patch. Index: netdev-2.6/drivers/net/wi

Re: [PATCH 3/6] new pcmcia IDs for hostap - NETGEAR MA701

2006-05-16 Thread Marcin Juszkiewicz
Dnia wtorek, 16 maja 2006 16:38, Jeff Garzik napisał: > Marcin Juszkiewicz wrote: > > One more Prism2 card which works with HostAP. > > Please roll these into a single patch. There's no need to split it up > such that there is one ID per patch. Index: netdev-2.6/drivers/net/wireless/hostap/hostap

Re: [PATCH 3/6] new pcmcia IDs for hostap - NETGEAR MA701

2006-05-16 Thread Jeff Garzik
Marcin Juszkiewicz wrote: One more Prism2 card which works with HostAP. Please roll these into a single patch. There's no need to split it up such that there is one ID per patch. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH 2/6] new pcmcia IDs for hostap - D-Link DCF-660W

2006-05-16 Thread Marcin Juszkiewicz
I use D-Link DCF-660W card with WPA protected network. By default orinoco_cs was loaded for my card so I was not able to connect. This patch make my card working with hostap_cs (like it was when I used pcmcia-cs). Card was used with hostap_cs during last year in two Zaurus models (2.4.18 on one and

[PATCH 6/6] new pcmcia IDs for hostap - U.S. Robotics

2006-05-16 Thread Marcin Juszkiewicz
From: Jochen Friedrich <[EMAIL PROTECTED]> Yet another card known to work OK with hostap_cs: # pccardctl ident Socket 0: no product info available Socket 1: product info: "U.S. Robotics", "IEEE 802.11b PC-CARD", "Version 01.02", "" manfid: 0x0156, 0x0002 function: 6 (network) Signed-off-

[PATCH 5/6] new pcmcia IDs for hostap - Pretec

2006-05-16 Thread Marcin Juszkiewicz
I use two Zaurus palmtops - one run 2.4.18 kernel (it's sl-5500) and second run 2.6.16. Both are running under control of OpenZaurus distribution (I'm Release Manager of it). When I use pcmcia-cs then my Pretec WiFi card is handled by hostap driver and everything is working fine. Recently I swi

[PATCH] Enabling standard compliant behaviour in the Linux TCP implementation

2006-05-16 Thread Angelo P. Castellani
Hi all, I'm a student doing a thesis about TCP performance over high BDP links and so about congestion control in TCP. To do this work I've built a testbed using the latest Linux release (2.6.16). Anyway I've came across the fact that Linux TCP implementation isn't fully standard compliant. Eve

[PATCH 1/6] new pcmcia IDs for hostap - ASUS WL-110

2006-05-16 Thread Marcin Juszkiewicz
Here's another card that would benefit from a hostap driver: Platform: HP Ipaq hx4700 running 2.6.16-hh [EMAIL PROTECTED]:~# pccardctl ident Socket 0: product info: "ASUS", "802_11B_CF_CARD_25", "Version 01.00", "" manfid: 0x02aa, 0x0002 function: 6 (network) [EMAIL PROTECTED]:~# ifconfig

[PATCH 3/6] new pcmcia IDs for hostap - NETGEAR MA701

2006-05-16 Thread Marcin Juszkiewicz
One more Prism2 card which works with HostAP. Platform: Sharp Zaurus SL-5500 running 2.4.18 + hostap_cs 0.4.7 [EMAIL PROTECTED]:~# cardctl ident Socket 0: product info: "NETGEAR", "MA701 Wireless CF Card", "" manfid: 0xd601, 0x0002 function: 6 (network) [EMAIL PROTECTED]:~# iwconfig wlan0

[PATCH 4/6] new pcmcia IDs for hostap - PLANEX GW-CF11X

2006-05-16 Thread Marcin Juszkiewicz
Platform: Sharp Zaurus SL-C3100 running 2.6.16 + pcmciautils 013 [EMAIL PROTECTED]:~# pccardctl ident Socket 0: product info: "HITACHI", "microdrive", "", "" manfid: 0x0319, 0x function: 4 (fixed disk) Socket 1: product info:"PLANEX COMMUNICATION INC","PLANEX GW-CF11X Wireless CF Card

Re: Patches from Marcin Juszkiewicz

2006-05-16 Thread John W. Linville
On Mon, May 15, 2006 at 11:00:43PM +0200, Marcin Juszkiewicz wrote: > Dnia poniedziałek, 15 maja 2006 22:06, John W. Linville napisał: > > On Fri, May 12, 2006 at 04:43:30PM -0400, Pavel Roskin wrote: > > > As a co-maintainer of Orinoco driver, I'd like to ask the netdev team > > > not to apply any

Re:

2006-05-16 Thread Arnaldo Carvalho de Melo
On 5/16/06, Chris Boot <[EMAIL PROTECTED]> wrote: Hi, I've just seen the following assertions pop out of one of my servers running 2.6.16.9 with grsecurity. I've searched the archives of LKML and netdev and I've only found posts relating to 2.6.9, after which some related bugs were fixed... It l

Controlling TCP window size

2006-05-16 Thread Andy Furniss
I've been doing some testing of my new wan connection and noticed that when I specify a window with ip route it still changes after a while. Using 2.6.16.11 and latest iproute2. ip ro del default ip ro add default via 192.168.0.1 window 28000 ip ro ls 192.168.0.0/24 dev eth0 proto kernel sc

Re: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/* (again)

2006-05-16 Thread Ingo Oeser
Hi Chris, here are some steps to narrow it down. 1. try the latest kernel first (2.6.16.16). This BUG should be fixed there. 2. try without grsecurity patch 3. if it still persists: Please provide more information about your setup before submitting a bug. lspci -vvv and

Re: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/* (again)

2006-05-16 Thread Chris Boot
On 16 May 2006, at 11:51, Evgeniy Polyakov wrote: On Tue, May 16, 2006 at 11:38:38AM +0100, Chris Boot ([EMAIL PROTECTED]) wrote: May 16 09:15:12 baldrick kernel: [6442250.504000] KERNEL: assertion (! sk->sk_forward_alloc) failed at net/core/stream.c (283) May 16 09:15:12 baldrick kernel: [6

Re: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/* (again)

2006-05-16 Thread Evgeniy Polyakov
On Tue, May 16, 2006 at 11:38:38AM +0100, Chris Boot ([EMAIL PROTECTED]) wrote: > May 16 09:15:12 baldrick kernel: [6442250.504000] KERNEL: assertion (! > sk->sk_forward_alloc) failed at net/core/stream.c (283) > May 16 09:15:12 baldrick kernel: [6442250.513000] KERNEL: assertion (! > sk->sk_forw

KERNEL: assertion (!sk->sk_forward_alloc) failed at net/* (again)

2006-05-16 Thread Chris Boot
Hi, Sorry, no subject last time! I've just seen the following assertions pop out of one of my servers running 2.6.16.9 with grsecurity. I've searched the archives of LKML and netdev and I've only found posts relating to 2.6.9, after which some related bugs were fixed... It looks like these

[no subject]

2006-05-16 Thread Chris Boot
Hi, I've just seen the following assertions pop out of one of my servers running 2.6.16.9 with grsecurity. I've searched the archives of LKML and netdev and I've only found posts relating to 2.6.9, after which some related bugs were fixed... It looks like these bugs are related to e1000,

[PATCH] reno sacked_out count fix

2006-05-16 Thread Angelo P. Castellani
Using NewReno, if a sk_buff is timed out and is accounted as lost_out, it should also be removed from the sacked_out. This is necessary because recovery using NewReno fast retransmit could take up to a lot RTTs and the sk_buff RTO can expire without actually being really lost. left_out = sacked_

Setting TCP_NODELAY doesn't disable Nagle's alg. on loopback

2006-05-16 Thread Radko Mihal
Hi, We are facing strange problem with disabling the Nagle's algorithm via setting the TCP_NODELAY flag on server socket (setsockopt), where server is communication with client via loopback. After the first segment (of the response) is sent by server side, server is waiting for ACK instead of c

Re: [1/1] netchannel subsystem.

2006-05-16 Thread Evgeniy Polyakov
On Tue, May 16, 2006 at 12:06:31AM -0700, David S. Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Tue, 16 May 2006 10:59:23 +0400 > > > And what if we use ESP which would place it's hashed sequence number as > > port? > > If it makes you happy put somethin

Re: [1/1] netchannel subsystem.

2006-05-16 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 10:59:23 +0400 > And what if we use ESP which would place it's hashed sequence number as > port? If it makes you happy put something like: case TCP: case UDP: case SCTP: case DCCP: ...

Re: [1/1] netchannel subsystem.

2006-05-16 Thread Evgeniy Polyakov
On Tue, May 16, 2006 at 10:59:23AM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Mon, May 15, 2006 at 11:57:12PM -0700, David S. Miller ([EMAIL PROTECTED]) > wrote: > > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > > Date: Tue, 16 May 2006 10:19:09 +0400 > > > > > +static int netchannel