Re: ipfrag calculating its hash outside lock

2006-04-09 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 08 Apr 2006 13:46:25 +1000 > David S. Miller <[EMAIL PROTECTED]> wrote: > > From: Zach Brown <[EMAIL PROTECTED]> > > Date: Fri, 07 Apr 2006 16:59:01 -0700 > > > >> b) Just calculate the hashes under the lock, we're already doing lots of > >> work th

Re: [Bugme-new] [Bug 6349] New: iptables DNAT returns unknown error 4294967295

2006-04-09 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sat, 08 Apr 2006 13:58:10 +0200 > Patrick McHardy wrote: > > Please try if this patch helps. > > > > + .hooks = 1 << NF_IP_PRE_ROUTING || 1 << NF_IP_LOCAL_OUT, > > I shouldn't send patches before getting out of bed .. :) > > Please try

Re: [Bugme-new] [Bug 6354] New: NULL Pointer lapbether

2006-04-09 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sat, 8 Apr 2006 11:32:50 -0700 > Begin forwarded message: ... > Lapbether generate an oops, when I try to receive or sends packets over X25. > > I think that the problem was introduced by this patch: > http://www.kernel.org/git/?p=linux/kernel/git/to

Re: net interface renaming issue (+fix?)

2006-04-09 Thread David S. Miller
From: Thomas de Grenier de Latour <[EMAIL PROTECTED]> Date: Mon, 10 Apr 2006 01:33:33 +0200 > On Sun, 09 Apr 2006 14:15:32 -0700 (PDT), > "David S. Miller" <[EMAIL PROTECTED]> wrote: > > > > > I wonder if this will cause other problems by invoked scripts > > seeing the state not advanced yet? >

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-09 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 9 Apr 2006 17:58:22 +0200 > This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks Adrian. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] bcm43xx: set trans_start on TX to prevent bogus timeouts

2006-04-09 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 10 Apr 2006 14:47:23 +1000 > BTW, for some reason none of your posts seem to be turning up on > netdev. The last message from you that I received through netdev > was dated the 15th of Mrach. The reason is that the string "interg*enia" is in our fi

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread George P Nychis
> On Sun, 9 Apr 2006 23:20:01 -0400 (EDT) George P Nychis wrote: > >> >>> On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: >>> > On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: > >> >>> On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis

Re: [PATCH] bcm43xx: set trans_start on TX to prevent bogus timeouts

2006-04-09 Thread Herbert Xu
On Mon, Apr 10, 2006 at 02:39:54AM +0200, Michael Buesch wrote: > diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c > b/drivers/net/wireless/bcm43xx/bcm43xx_main.c > index 6c969f4..006a7d4 100644 > --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c > +++ b/drivers/net/wireless/bcm43xx/bcm43x

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-09 Thread Benoit Boissinot
On Mon, Apr 10, 2006 at 06:28:00AM +0200, Michael Buesch wrote: > On Monday 10 April 2006 06:22, you wrote: > > Either the ppc code is wrong (it doesn't enforce dma_mask) either the > > driver still works without the check. > > > > Maybe ppc should do the same thing as i386: > > > > 47 if

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Willy Tarreau
On Sun, Apr 09, 2006 at 08:29:12PM -0700, Randy.Dunlap wrote: > On Sun, 9 Apr 2006 23:20:01 -0400 (EDT) George P Nychis wrote: > > > > > > On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: > > > > > >> > > >>> On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: > > >>>

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-09 Thread Benoit Boissinot
On Mon, Apr 10, 2006 at 06:07:32AM +0200, Michael Buesch wrote: > On Monday 10 April 2006 06:01, you wrote: > > Since the driver already sets the correct dma_mask, there is no reason > > to bail there. In fact if you have an iommu, I think you can have a > > address above 1G which will be ok for th

[RFC/PATCH] remove unneeded check in bcm43xx

2006-04-09 Thread Benoit Boissinot
Since the driver already sets the correct dma_mask, there is no reason to bail there. In fact if you have an iommu, I think you can have a address above 1G which will be ok for the device (if it isn't true then the powerpc dma_alloc_coherent with iommu needs to be fixed because it doesn't respect t

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 23:20:01 -0400 (EDT) George P Nychis wrote: > > > On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: > > > >> > >>> On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: > >>> > > > On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote:

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread George P Nychis
> On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: > >> >>> On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: >>> > On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: > >> Thanks for the help. >> >> Here is the makefile: >>

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: > > > On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: > > > >> > >>> On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: > >>> > Thanks for the help. > > Here is the makefile: http://rafb.n

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread George P Nychis
> On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: > >> >>> On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: >>> Thanks for the help. Here is the makefile: http://rafb.net/paste/results/auchPH75.html And here is the full errors I receive:

Re: Prism2 driver for Devicescape 802.11 stack (AP and fullmac STA)

2006-04-09 Thread Jouni Malinen
On Mon, Apr 10, 2006 at 04:23:47AM +0200, Michael Buesch wrote: > When I am back home, I will continue at the bcm43xx AP stuff. > Shouldn't be too hard to get it working, actually. > So, there we will have another driver for testing AP mode. Yes, indeed. As far as I can tell, the main issue is in

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: > > > On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: > > > >> Thanks for the help. > >> > >> Here is the makefile: http://rafb.net/paste/results/auchPH75.html > >> > >> And here is the full errors I receive: > >> h

Prism2 driver for Devicescape 802.11 stack (AP and fullmac STA)

2006-04-09 Thread Jouni Malinen
I've started creating a new Prism2/2.5/3 driver for the Devicescape 802.11 stack based on the Host AP driver. This allows access point mode to be tested with the current net/d80211 code in wireless-dev.git (requires hostapd snapshot from the development branch) and eventually, will be an example on

Re: TCP not retransmitting supposedly lost segment

2006-04-09 Thread Florian Zumbiehl
Hi, meanwhile I gathered some information from /proc/net/tcp6 on this problem - in case anyone is interested :-) | 1144560959: 8: :1223 :1A0B 01 : 02:00097F82 10000 3188619 8 c1409260 89 10 20 2

Re: net interface renaming issue (+fix?)

2006-04-09 Thread Thomas de Grenier de Latour
On Sun, 09 Apr 2006 14:15:32 -0700 (PDT), "David S. Miller" <[EMAIL PROTECTED]> wrote: > > I wonder if this will cause other problems by invoked scripts > seeing the state not advanced yet? > I don't know. An other way would be to allow reading 'address' also when device is in NETREG_REGISTER

Re: net interface renaming issue (+fix?)

2006-04-09 Thread David S. Miller
From: Thomas de Grenier de Latour <[EMAIL PROTECTED]> Date: Sun, 9 Apr 2006 21:34:48 +0200 > On Sun, 9 Apr 2006 21:56:59 +0400, > Sergey Vlasov <[EMAIL PROTECTED]> wrote: > > > However, show_address() does not output anything unless > > dev->reg_state == NETREG_REGISTERED - and this state is set

Re: [2.6 patch] make CONFIG_UNIX a bool

2006-04-09 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 9 Apr 2006 21:53:39 +0200 > CONFIG_UNIX=m doesn't make that much sense and requires us to export > things we don't want to export to modules. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> I disagree. Every protocol module shoule be able to

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread George P Nychis
> On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: > >> Thanks for the help. >> >> Here is the makefile: http://rafb.net/paste/results/auchPH75.html >> >> And here is the full errors I receive: >> http://rafb.net/paste/results/Qplpqw74.html >> >> Greatly appreciate it >> >> - G

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: > Thanks for the help. > > Here is the makefile: > http://rafb.net/paste/results/auchPH75.html > > And here is the full errors I receive: > http://rafb.net/paste/results/Qplpqw74.html > > Greatly appreciate it > > - George [repeat

[2.6 patch] make CONFIG_UNIX a bool

2006-04-09 Thread Adrian Bunk
CONFIG_UNIX=m doesn't make that much sense and requires us to export things we don't want to export to modules. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- fs/file_table.c|1 - include/net/af_unix.h |2 -- net/unix/Kconfig |6 +- net/unix/af_un

Re: net interface renaming issue (+fix?)

2006-04-09 Thread Thomas de Grenier de Latour
On Sun, 9 Apr 2006 21:56:59 +0400, Sergey Vlasov <[EMAIL PROTECTED]> wrote: > However, show_address() does not output anything unless > dev->reg_state == NETREG_REGISTERED - and this state is set by > netdev_run_todo() only after netdev_register_sysfs() returns, so in > the meantime (while netdev_

Re: [RFC: 2.6 patch] the overdue removal of ip{,6}_queue

2006-04-09 Thread Patrick McHardy
Adrian Bunk wrote: > This patch contains the overdue removal of ip{,6}_queue. I think this is too early, none of the distributions seem to have picked up the compat library already. I believe (not sure, Harald?) that it requires at least recompilation of programs using libipq, so the 6 month perio

Re: Broadcast ARP packets on link local addresses (Version2).

2006-04-09 Thread David Daney
Herbert Xu wrote: jamal <[EMAIL PROTECTED]> wrote: I think that the broadcast ARP is still valid for any address configured as a link local addresses to be done in the kernel - for those reasons described in the RFC (which i didnt find very convincing, but other people felt strongly about and n

[RFC: 2.6 patch] the overdue removal of ip{,6}_queue

2006-04-09 Thread Adrian Bunk
This patch contains the overdue removal of ip{,6}_queue. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt | 12 Documentation/networking/ip-sysctl.txt |1 include/linux/netfilter_ipv4/ip_queue.h| 72 -- include/linux/netlink.h

Re: net interface renaming issue (+fix?)

2006-04-09 Thread Sergey Vlasov
On Sun, 9 Apr 2006 19:21:40 +0200 Thomas de Grenier de Latour wrote: > Hi, > > I'm running Gentoo Linux, a 2.6.16-ck kernel, and udev-0.89-r2, and > have had hard time with network interfaces renaming through udev > rules. The first thing i've tried were rules like this one: > > SUBSYSTEM=="ne

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread George P Nychis
Thanks for the help. Here is the makefile: http://rafb.net/paste/results/auchPH75.html And here is the full errors I receive: http://rafb.net/paste/results/Qplpqw74.html Greatly appreciate it - George > On Sat, 8 Apr 2006 19:18:47 -0400 (EDT) George P Nychis wrote: > >> Yeah, this module is

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-09 Thread Matt Mackall
On Sun, Apr 09, 2006 at 05:58:22PM +0200, Adrian Bunk wrote: > This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral). > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Matt Mackall <[EMAIL PROTECTED]> Adrian appears to be correct that this doesn't break modular ipv6. --

Re: Window shrinking (was Linux v2.6.16-rc6)

2006-04-09 Thread Mark Butler
Andy Furniss wrote: David S. Miller wrote: From: "Michal Piotrowski" <[EMAIL PROTECTED]> Date: Sun, 12 Mar 2006 02:51:40 +0100 I have noticed this warnings TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window 148470938:148470943. Repaired. TCP: Treason uncloaked! Peer 82.113.5

[2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-09 Thread Adrian Bunk
This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 5 Apr 2006 --- linux-2.6.17-rc1-mm1-full/drivers/char/random.c.old 2006-04-05 17:00:04.0 +0200 +++ linux-2.6.17-rc1-mm1-full/dri

[2.6 patch] drivers/net/via-rhine.c: make a function static

2006-04-09 Thread Adrian Bunk
This patch makes the needlessly global rhine_set_carrier() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 4 Apr 2006 --- linux-2.6.17-rc1-mm1-full/drivers/net/via-rhine.c.old 2006-04-04 17:41:16.0 +0200 +++ linux-2.6.17-rc1-mm1-full/d

Re: [PATCH] Unaligned accesses in the ethernet bridge

2006-04-09 Thread Adrian Bunk
On Fri, Apr 07, 2006 at 04:57:11PM -0700, Stephen Hemminger wrote: > On Thu, 6 Apr 2006 22:37:08 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > On Thu, Mar 23, 2006 at 01:06:02PM +1100, Peter Chubb wrote: > > > > > > I see lots of > > > kernel unaligned access to 0xa001009dbb6f, ip=0x

Re: Linux v2.6.16-rc6

2006-04-09 Thread Andy Furniss
David S. Miller wrote: From: "Michal Piotrowski" <[EMAIL PROTECTED]> Date: Sun, 12 Mar 2006 02:51:40 +0100 I have noticed this warnings TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window 148470938:148470943. Repaired. TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrink

Re: [PATCH] softmac: don't send out packets while scanning

2006-04-09 Thread Johannes Berg
On Sun, 2006-04-09 at 15:17 +1000, Herbert Xu wrote: > Right. You can't stop the queue for a period longer than the watchdog > timeout (default is 5s) on the device. In fact there is a bug here in > that neither bcm43xx nor the softmac layer is setting trans_start. Hah. Alright, I'll look into