Re: [PATCH 4/4] forcedeth: fix multi irq issues

2006-04-01 Thread Ayaz Abdulla
Manfred Spraul wrote: Ayaz Abdulla wrote: if (nv_alloc_rx(dev)) { -spin_lock(&np->lock); +spin_lock_irqsave(&np->lock, flags); Tiny point: there is not need for irqsave(): we are in timer context, that guarantees: - bottom half disabled - interrupts enabled Just use s

Re: [PATCH 2/4] forcedeth: add support for configuration

2006-04-01 Thread Ayaz Abdulla
Manfred Spraul wrote: Ayaz Abdulla wrote: This patch adds support for configuration of various parameters. This includes module parameters and ethtool commands. + +if (netif_running(dev)) { +nv_start_rx(dev); +nv_start_tx(dev); +nv_enable_irq(dev); +} +

Re: [PATCH 3/4] forcedeth: fix initialization

2006-04-01 Thread Ayaz Abdulla
Manfred Spraul wrote: Ayaz Abdulla wrote: + +NvRegPowerState2 = 0x600, +#define NVREG_POWERSTATE2_POWERUP_MASK0x0F11 +#define NVREG_POWERSTATE2_POWERUP_REV_A30x0001 }; If the nic has a register 0x600, then we should - ioremap enough memory. Right now, the code only remaps

Fw: bridge+netfilter broken for IP fragments in 2.6.16?

2006-04-01 Thread Andrew Morton
Begin forwarded message: Date: Sat, 1 Apr 2006 16:30:11 +0200 From: Thomas Zeitlhofer <[EMAIL PROTECTED]> To: linux-kernel@vger.kernel.org Subject: bridge+netfilter broken for IP fragments in 2.6.16? Hello, I have set up a bridge with two ports: # brctl show br0 bridge name bridge id

Re: [PATCH] Re: Goramo PCI200SYN WAN driver subsystem ID patch

2006-04-01 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread David Daney
jamal wrote: On Sat, 2006-01-04 at 15:25 +1100, Herbert Xu wrote: On Fri, Mar 31, 2006 at 09:49:31PM -0500, jamal wrote: [..] my understanding: the sender is trying to claim that IP and is setting the destination to the IP it is trying to claim and see if someone responds. Are you sure? I

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread David Daney
Herbert Xu wrote: On Fri, Mar 31, 2006 at 09:49:31PM -0500, jamal wrote: The RFC seems to talk about sender IP address instead though... my understanding: the sender is trying to claim that IP and is setting the destination to the IP it is trying to claim and see if someone responds. Are y

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread jamal
On Sat, 2006-01-04 at 17:11 +0200, Stefan Rompf wrote: > Am Samstag 01 April 2006 14:50 schrieb jamal: > > > No stefan - check arpd. Infact if you really want to scale ARP to many > > many entries, you do it in user space. This has been proven more than > > once in the past: Thats the main reason

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Stefan Rompf
Am Samstag 01 April 2006 14:50 schrieb jamal: > No stefan - check arpd. Infact if you really want to scale ARP to many > many entries, you do it in user space. This has been proven more than > once in the past: Thats the main reason the current daemons exist. It is AFAIK the primary purpose of ar

Re: [PATCH UPDATE netdev-2.6.git] bonding: suppress duplicate packets

2006-04-01 Thread Krzysztof Oledzki
On Fri, 31 Mar 2006, Jay Vosburgh wrote: Krzysztof Oledzki <[EMAIL PROTECTED]> wrote: [...] I took this patch from linux-2.6 using git tree and applied to 2.6.16.1 together with recent "link status" fix. Unfortunately broadcast packet duplication still occurs. I am unable to induce

[PATCH 1.3/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
+static int +netxen_loopback_test(struct net_device *netdev, int fint, void *ptr) +{ + int ii, ret; + unsigned char *data; + netxen_send_test_t args; + + if ((ret = copy_from_user(&args, ptr, sizeof(a

[PATCH 1.1/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_main.c linux-2.6.16/drivers/net/netxen/netxen_nic_main.c --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_main.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_main.c 2006-03-24 14:19:19.

[PATCH 4/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c linux-2.6.16/drivers/net/netxen/netxen_nic_init.c --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_init.c 2006-03-24 14:13:57.

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread jamal
On Sat, 2006-01-04 at 08:24 -0500, Paul Fox wrote: > hi -- > > i'm not subscribed to netdev, so this probably won't make it to > the list. that's probably okay. > It made it. > > Hopefully, the original poster > > can explain what kind of problems they saw that prompted the patch. > > i can't

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Paul Fox
hi -- i'm not subscribed to netdev, so this probably won't make it to the list. that's probably okay. > >All ARP packets (*replies* as well as requests) that contain a Link- > >Local 'sender IP address' MUST be sent using link-layer broadcast > >instead of link-layer unicast. Thi

[PATCH 9/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h --- linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h 2006-03-24 14:13:57.

[PATCH 8/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_config.h linux-2.6.16/drivers/net/netxen/netxen_nic_config.h --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_config.h1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_config.h 2006-03-24 14:13:57.

[PATCH 7/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_inc.h linux-2.6.16/drivers/net/netxen/netxen_inc.h --- linux-2.6.16_orig/drivers/net/netxen/netxen_inc.h 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_inc.h2006-03-24 14:13:57.0 -0800 @@ -0,

[PATCH 6/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/niu.c linux-2.6.16/drivers/net/netxen/niu.c --- linux-2.6.16_orig/drivers/net/netxen/niu.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/niu.c 2006-03-24 14:13:57.0 -0800 @@ -0,0 +1,858 @@ +/* + * Copyright

[PATCH 5/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_isr.c linux-2.6.16/drivers/net/netxen/netxen_nic_isr.c --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_isr.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_isr.c2006-03-24 14:13:57.00

Re: [PATCH 0/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c linux-2.6.16/drivers/net/netxen/netxen_nic_init.c --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_init.c 2006-03-24 14:13:57.

[PATCH 3/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_hw.c linux-2.6.16/drivers/net/netxen/netxen_nic_hw.c --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_hw.c1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_hw.c 2006-03-24 14:13:57.

[PATCH 2/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_ethtool.c linux-2.6.16/drivers/net/netxen/netxen_nic_ethtool.c --- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_ethtool.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/netxen_nic_ethtool.c2006-03-24

[PATCH 0/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
Hi, I'll be sending a NetXen (formerly Universal Network Machines) 1G/10G in subsequent emails. This is a revised version of the UNM driver posted earlier. We would like this driver to be inluded in mainline kernel. Kindly review it and feel free to get back to me for any feedback/queries/comm

Re: RX processing order for packet sockets and bridge

2006-04-01 Thread jamal
On Fri, 2006-31-03 at 21:21 -0700, Stephen Hemminger wrote: > jamal wrote: > [..] > >I think thats a fine trade-off. The advantage of putting it in user > >space is its a lot easier to add newer features. The current STP - by > >virtue of being in the kernel - is missing a lot of newer development

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread jamal
On Sat, 2006-01-04 at 14:29 +0200, Stefan Rompf wrote: > Am Samstag 01 April 2006 12:27 schrieb David S. Miller: > > > > Routing is a pretty basic network feature, yet userspace manages it > > and the kernel just does the switching. > > That's comparing apples with pies. For the average machine,

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread jamal
On Sat, 2006-01-04 at 15:25 +1100, Herbert Xu wrote: > On Fri, Mar 31, 2006 at 09:49:31PM -0500, jamal wrote: [..] > > > > my understanding: the sender is trying to claim that IP and is setting > > the destination to the IP it is trying to claim and see if someone > > responds. > > Are you sure?

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Stefan Rompf
Am Samstag 01 April 2006 12:27 schrieb David S. Miller: > > Neighbor address resolution is such a basic networking feature that > > it should not depend on a running userspace daemon to function > > properly. > > Routing is a pretty basic network feature, yet userspace manages it > and the kernel

Re: ipsec tunnel asymmetrical mtu

2006-04-01 Thread Herbert Xu
Marco Berizzi <[EMAIL PROTECTED]> wrote: > > Thanks a lot for the reply Herbert. > Is there a way to tell netkey to frag packets like klips > ignoring the DF bit? There is a netfilter module around which can zap the DF bit for you. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: He

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Herbert Xu
On Sat, Apr 01, 2006 at 09:33:40PM +1100, herbert wrote: > > In fact most of the bits for that is already there since user-space can > already manipulate the ARP cache. The only missing bit is the notification > when there is a cache miss. Oh and I totally agree that ARP resolution is such a fun

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Herbert Xu
On Sat, Apr 01, 2006 at 02:27:15AM -0800, David S. Miller wrote: > > Routing is a pretty basic network feature, yet userspace manages it > and the kernel just does the switching. > > It's a control plane issue. Exactly. I'm not talking about moving everything into user-space either. Just the b

Re: ipsec tunnel asymmetrical mtu

2006-04-01 Thread Marco Berizzi
Herbert Xu wrote: Marco Berizzi <[EMAIL PROTECTED]> wrote: > > If I run 'ping 172.16.1.52 -M do -s 1472' from a 172.25.5.0 > host I got this result: > > PING 172.16.1.52 (172.16.1.52) 1472(1500) bytes of data. > 1480 bytes from 172.16.1.52: icmp_seq=1 ttl=62 time=74.1 ms > 1480 bytes from 172.16

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread David S. Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Sat, 1 Apr 2006 12:17:01 +0200 > Neighbor address resolution is such a basic networking feature that > it should not depend on a running userspace daemon to function > properly. Routing is a pretty basic network feature, yet userspace manages it and th

Re: [PATCH] net: Broadcast ARP packets on link local addresses

2006-04-01 Thread Stefan Rompf
Am Samstag 01 April 2006 06:25 schrieb Herbert Xu: > BTW, I like your idea of moving STP to user-space. In fact I think we > can extend it to move ARP to user-space as well. Neighbor address resolution is such a basic networking feature that it should not depend on a running userspace daemon to

netfilter: IP_NF_CONNTRACK_NETLINK=y, IP_NF_NAT=m compile error

2006-04-01 Thread Adrian Bunk
On Fri, Mar 31, 2006 at 06:09:16PM +0100, Athanasius wrote: > On Tue, Mar 28, 2006 at 05:39:32PM +0100, Athanasius wrote: > > CC init/version.o > > LD init/built-in.o > > LD .tmp_vmlinux1 > > net/built-in.o(.text+0x7c990): In function `ctnetlink_parse_nat_proto': > > : undefine

Re: [2/*] [IPSEC]: Kill unused decap state structure

2006-04-01 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 1 Apr 2006 15:49:27 +1100 > This patch removes the *_decap_state structures which were previously > used to share state between input/post_input. This is no longer needed. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Another good cleanup. Ap

Re: [1/*] [IPSEC]: Kill unused decap state argument

2006-04-01 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 1 Apr 2006 15:03:55 +1100 > This patch removes the decap_state argument from the xfrm input hook. > Previously this function allowed the input hook to share state with the > post_input hook. The latter has since been removed. > > The only purpose f

Re: Use pci_set_consistent_dma_mask in ixgb driver

2006-04-01 Thread Jesse Brandeburg
On 3/28/06, Andreas Schwab <[EMAIL PROTECTED]> wrote: > The ixgb driver is using pci_alloc_consistent, thus is should also use > pci_set_consistent_dma_mask. This allows the driver to work on SGI > systems. I had noticed that e1000/ixgb both need this fix. Its on my todo list, but thanks for doi