On Sat, 2006-03-11 at 08:11 -0500, jamal wrote:
> > On my machine tc does not parse filter "sample" for the u32
> > filter. Eg:
> >
> > tc filter add dev eth2 parent 1:0 protocol ip prio 1 u32 ht 801: \
> > classid 1:3 \
> > sample ip protocol 1 0xff match ip protocol 1 0xff
> > Illeg
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]>
Date: Sun, 12 Mar 2006 22:25:37 -0300
> > Sure, new patch attached.
>
> Thanks a lot.
All 7 patches applied, thanks a lot for doing these Coverity
fixes Patrick!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body o
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Sun, 12 Mar 2006 17:15:31 -0800
> We can remove the export again by uninlining scm_recv().
>
> Both scm_recv() and scm_send() are very large anyway.
>
> If they're uninlined then they'll need to be exported to modules.
This seems like a good idea.
-
From: James Morris <[EMAIL PROTECTED]>
Date: Sun, 12 Mar 2006 20:07:33 -0500 (EST)
> On Sun, 12 Mar 2006, [EMAIL PROTECTED] wrote:
>
> > Cc: Stephen Smalley <[EMAIL PROTECTED]>
> > Cc: James Morris <[EMAIL PROTECTED]>
> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
>
> These SELinux symbols
On Fri, Mar 10, 2006 at 08:10:26PM +0100, Adrian Bunk wrote:
> The Coverity checker spotted this inconsequent NULL checking
> (unconditionally dereferencing directly after checking for NULL
> isn't a good idea).
Thanks! Added to my queue for wireless-2.6.
--
Jouni Malinen
On 3/12/06, Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Arnaldo Carvalho de Melo wrote:
> >>- if(ip_ufo_append_data(sk, getfrag, from, length, hh_len,
> >>- fragheaderlen, transhdrlen, mtu, flags))
> >>+ if ((err = ip_ufo_append_data(sk, get
Arnaldo Carvalho de Melo wrote:
>>- if(ip_ufo_append_data(sk, getfrag, from, length, hh_len,
>>- fragheaderlen, transhdrlen, mtu, flags))
>>+ if ((err = ip_ufo_append_data(sk, getfrag, from, length,
>>hh_len,
>>+
On Fri, Mar 10, 2006 at 12:06:46AM +0100, Adrian Bunk wrote:
> The Coverity checker noted that the call to prism2_hw_reset() was dead
> code.
>
> Does this patch change the code to what was intended?
Thanks! Based on my CVS history, it looks like this was broken in 2002
when the access command
James Morris <[EMAIL PROTECTED]> wrote:
>
> On Sun, 12 Mar 2006, [EMAIL PROTECTED] wrote:
>
> > Cc: Stephen Smalley <[EMAIL PROTECTED]>
> > Cc: James Morris <[EMAIL PROTECTED]>
> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
>
> These SELinux symbols should not be directly exported (if y
On 3/12/06, Patrick McHardy <[EMAIL PROTECTED]> wrote:
> [IPV4/6]: Fix UFO error propagation
>
> When ufo_append_data fails err is uninitialized, but returned back.
> Strangely gcc doesn't notice it.
>
> Coverity #901 and #902
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
>
> ---
> commit
On 3/12/06, James Morris <[EMAIL PROTECTED]> wrote:
> On Sun, 12 Mar 2006, [EMAIL PROTECTED] wrote:
>
> > Cc: Stephen Smalley <[EMAIL PROTECTED]>
> > Cc: James Morris <[EMAIL PROTECTED]>
> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
>
> These SELinux symbols should not be directly exported (
On Sun, 12 Mar 2006, [EMAIL PROTECTED] wrote:
> Cc: Stephen Smalley <[EMAIL PROTECTED]>
> Cc: James Morris <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
These SELinux symbols should not be directly exported (if you need it
temporarily to fix the build, fine, but please d
hardware: e1000 NIC in ThinkPad T42
kernel: 2.6.16-rc5-mm3
I always get $subject message. I changed the delay in
net/core/netpoll.c from 4 seconds to 9 seconds, but it
doesn't matter, the e1000 always finds Link is Up immediately
after $subject message.
I suppose this is a consequence of e1000
I also suspect that they only have to make it
difficult for an end user and not a technologist.
The issues here can be complex and there there is often
a lot of mis-information. The above statement is basically
true, but the issue of how compliance is determined is
not always simple.
I am a
Hi Dave,
following are a couple of coverity fixes for the more serious problems.
Double checked and should be OK for 2.6.16.
net/ipv4/ip_output.c|5 +++--
net/ipv4/netfilter/arp_tables.c |2 +-
net/ipv4/tcp_highspeed.c|2 +-
net/ipv6/ah6.c |2
[IPV4/6]: Fix UFO error propagation
When ufo_append_data fails err is uninitialized, but returned back.
Strangely gcc doesn't notice it.
Coverity #901 and #902
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 3a83b01bbd9e0a2becfc427f7866dd2f20f75494
tree 421450cdd094d6490cfe4b56161
[NETFILTER]: nfnetlink_queue: fix possible NULL-ptr dereference
Fix NULL-ptr dereference when a config message for a non-existant
queue containing only an NFQA_CFG_PARAMS attribute is received.
Coverity #433
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit fa218d330c7f755e03fad775c
[TCP]: tcp_highspeed: fix AIMD table out-of-bounds access
Covertiy #547
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 4f58fff161d4c5f79955fe6ad2f98752282c9d6b
tree ae0cb1579a20ef7a0d380e8bd0dc4c436c0b30ec
parent 6e745f19b2d9704b08cc5a3d9476b252bf86b46f
author Patrick McHardy <[EM
[NET_SCHED]: act_api: fix skb leak in error path
The skb is allocated by the function, so it needs to be freed instead
of trimmed on overrun.
Coverity #614
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 9275d31561bc3268ae997dbff36eed84afe80516
tree 419d6a22bd673583c0b9a105eef9ec7
[NETFILTER]: arp_tables: fix NULL pointer dereference
The check is wrong and lets NULL-ptrs slip through since !IS_ERR(NULL)
is true.
Coverity #190
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit cbb18ea472603ef2e7fcc0dd21490c22a9c01335
tree 3efd50ffde8d6390a9302c4a79fcdf241a88e05
[XFRM]: Fix leak in ah6_input
tmp_hdr is not freed when ipv6_clear_mutable_options fails.
Coverity #650
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 901a2a6eb676baea9392e47f16f7e0a0219b7ba5
tree 0424294ae2d79986e07e7751025e763c6b9ea5d7
parent 9275d31561bc3268ae997dbff36eed84afe
[NETLINK]: Fix use-after-free in netlink_recvmsg
The skb given to netlink_cmsg_recv_pktinfo is already freed, move it up
a few lines.
Coverity #948
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 6e745f19b2d9704b08cc5a3d9476b252bf86b46f
tree 20b4276a4a7ffdaf8b4ec4d52e1fa35aa34d850
It was suggested I post this here. I sent the original netdev posting
to an incorrect email address. I have also tried turning off rp_filter
on both interfaces. arp_filter is already turned off. Putting any of
the router interfaces into promiscuous mode makes no difference.
- Greg Scott
__
Hi!
setkey command behaves strangely when SPD is large. Either because I'm
doing something wrong or because there is a bug. I believe it's a bug,
but who knows... Anyway, after 529 items it simply stops displaying
items from SPD with a message
recv: Resource temporarily unavailable
This occurs o
On Sun, Mar 12, 2006 at 07:23:00PM +, Mark Brown wrote:
> This patch provides a module option which configures the natsemi driver
> to use the external MII port on the chip but ignore any PHYs that may be
> attached to it. The link state will be left as it was when the driver
> started and can
This patch provides a module option which configures the natsemi driver
to use the external MII port on the chip but ignore any PHYs that may be
attached to it. The link state will be left as it was when the driver
started and can be configured via ethtool. Any PHYs that are present
can be access
This patch series against the upstream branch of netdev-2.6 adds support
for these boards to the natsemi driver. It implements some new
functionality required by the boards and enables the appropriate
settings when such a board is detected.
--
"You grabbed my hand and we fell into it, like a dayd
Add a vendor ID definition for Aculab.
Signed-Off-By: Mark Brown <[EMAIL PROTECTED]>
Index: e1000-queue/include/linux/pci_ids.h
===
--- e1000-queue.orig/include/linux/pci_ids.h2006-02-25 12:50:12.0
+
+++ e1000-queue/
The natsemi chip can have a larger EEPROM attached than it itself uses
for configuration. This patch adds support for user space access
to such an EEPROM.
Signed-off-by: Mark Brown <[EMAIL PROTECTED]>
Index: natsemi-queue/drivers/net/natsemi.c
Aculab E1/T1 PMXc cPCI carrier card cards present a natsemi on the cPCI
bus wired up in a non-standard fashion. This patch provides support in
the natsemi driver for these cards by implementing a quirk mechanism and
using that to configure appropriate settings for the card: forcing 100M
full duple
Am Sonntag 12 März 2006 17:50 schrieb Michael Richardson:
> I recently got a bug in my ear to try and get multiple-dhclients to
> work on separate interfaces under Linux (a one-daemon-per-interface
> model). Could use some advice from the linux masters (Jason, Andrew?)
> if you can spare some tim
(I won't forward more stuff unless asked to)
--- Begin Message ---
Michael Richardson wrote:
>
>
>>>"Simon" == Simon Kelley <[EMAIL PROTECTED]> writes:
>
> Simon> The alternative if LPF which is adopted by most clients,
> Simon> (udhcpc, dhcpcd, diamond) is AF_PACKET sockets. A pac
Currently, pktgen will create one thread for each online CPU in the
system. That behaivor may be annoying if you're using pktgen in a
large SMP system.
This patch adds a new module parameter called 'pg_max_threads', which
can be set to the maximum number of threads pktgen should create.
For exam
--- Begin Message ---
I recently got a bug in my ear to try and get multiple-dhclients to
work on separate interfaces under Linux (a one-daemon-per-interface
model). Could use some advice from the linux masters (Jason, Andrew?)
if you can spare some time for me.
Another motivation is trying to ki
On Sun, Mar 12, 2006 at 03:10:36AM -0800, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc6/2.6.16-rc6-mm1/
>
>
drivers/net/tg3.c:8065: warning: type qualifiers ignored on function return type
Signed-off-by: Benoit Boissinot <[EMAIL PROTECTED]>
Ingo Oeser wrote:
> From: Ingo Oeser <[EMAIL PROTECTED]>
>
> Stupidly use kzalloc() instead of kmalloc()/memset()
> everywhere where this is possible in net/ipv6/*.c .
>
> The netfilter part is NOT included, because Harald should see these, too.
Feel free to send netfilter patches to me.
-
To
Hi,
On 12/03/06, David S. Miller <[EMAIL PROTECTED]> wrote:
> From: "Michal Piotrowski" <[EMAIL PROTECTED]>
> Date: Sun, 12 Mar 2006 02:51:40 +0100
>
> > I have noticed this warnings
> > TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window
> > 148470938:148470943. Repaired.
> > TCP:
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
>
> On Fri, Mar 10, 2006 at 06:29:46PM -0800, Leech, Christopher ([EMAIL
> PROTECTED]) wrote:
> > From: Chris Leech [mailto:[EMAIL PROTECTED]
> > Sent: Friday, March 10, 2006 6:29 PM
> > To:
> > Subject: [PATCH 2/8] [I/OAT] Driver for the Intel(R)
On Fri, Mar 10, 2006 at 06:29:46PM -0800, Leech, Christopher ([EMAIL
PROTECTED]) wrote:
> From: Chris Leech [mailto:[EMAIL PROTECTED]
> Sent: Friday, March 10, 2006 6:29 PM
> To:
> Subject: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine
>
>
> Adds a new ioatdma driver
enumerate_
From: [EMAIL PROTECTED]
Date: Sun, 12 Mar 2006 01:19:18 -0800
> WARNING: "security_sid_to_context" [net/unix/unix.ko] undefined!
Applied, thanks Andrew.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:/
From: Andrew Morton <[EMAIL PROTECTED]>
WARNING: "security_sid_to_context" [net/unix/unix.ko] undefined!
(Those functions in scm.h should be uninlined)
Cc: Stephen Smalley <[EMAIL PROTECTED]>
Cc: James Morris <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
security/se
From: [EMAIL PROTECTED]
Date: Sun, 12 Mar 2006 00:41:41 -0800
> From: Andrew Morton <[EMAIL PROTECTED]>
>
> net/bridge/netfilter/ebtables.c:1481: warning: initialization makes pointer
> from integer without a cast
>
> Note that the compat functions aren't implemented?
>
> Signed-off-by: Andrew
From: [EMAIL PROTECTED]
Date: Sat, 11 Mar 2006 19:20:22 -0800
> From: Andrew Morton <[EMAIL PROTECTED]>
>
> net/bridge/netfilter/ebtables.c:1481: warning: initialization makes pointer
> from integer without a cast
>
> Note that the compat functions aren't implemented?
Right, but now at least t
From: [EMAIL PROTECTED]
Date: Sat, 11 Mar 2006 19:20:22 -0800
> From: Andrew Morton <[EMAIL PROTECTED]>
>
> net/bridge/br_netfilter.c: In function `br_nf_pre_routing':
> net/bridge/br_netfilter.c:427: warning: unused variable `vhdr'
> net/bridge/br_netfilter.c:445: warning: unused variable `vhdr'
From: Andrew Morton <[EMAIL PROTECTED]>
net/bridge/netfilter/ebtables.c:1481: warning: initialization makes pointer
from integer without a cast
Note that the compat functions aren't implemented?
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
net/bridge/netfilter/ebtables.c | 10
[EMAIL PROTECTED] wrote:
>
> +.set_optmax = EBT_SO_SET_MAX + 1
> +.set= do_ebt_set_ctl,
It's unclear why that compiled. Let me try again.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
From: Andrew Morton <[EMAIL PROTECTED]>
net/core/sock.c: In function `sock_setsockopt':
net/core/sock.c:460: error: duplicate case value
net/core/sock.c:278: error: previously used here
Guess:
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
include/asm-arm/socket.h |2 +-
1 files c
On Sat, Mar 11, 2006 at 06:39:04PM -0800, David S. Miller wrote:
> From: "Michal Piotrowski" <[EMAIL PROTECTED]>
> Date: Sun, 12 Mar 2006 02:51:40 +0100
>
> > I have noticed this warnings
> > TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window
> > 148470938:148470943. Repaired.
> >
48 matches
Mail list logo
