Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread Eric Dumazet
Andi Kleen a écrit : My vmlinux has 80278382 : 80278382: 8b 0d 78 ea 41 00 mov4319864(%rip),%ecx# 80696e00 80278388: 48 89 f8mov%rdi,%rax 8027838b: 48 c1 e0 0c shl$0xc,%rax

Re: [PATCH 00/16] ipw2200 driver updates

2006-03-07 Thread Larry Finger
Zhu Yi wrote: Hi, Here are some patches for ipw2200 driver. Please apply. Patches include: [PATCH 01/16] ipw2200: print geography code upon module load [PATCH 02/16] ipw2200: stop netdev queue if h/w doesn't have space for new packets [PATCH 03/16] ipw2200: fix a potential NULL pointer derefe

[PATCH 16/16] ipw2200: Update ipw2200 version stamp to 1.1.1

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Fri, 24 Feb 2006 04:20:48 + (+0800) [PATCH 16/16] ipw2200: Update ipw2200 version stamp to 1.1.1 --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -33,7 +33,7 @@ #include "ipw2200.h" #include -#define IPW2200_VERSION

[PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format

2006-03-07 Thread Zhu Yi
From: James Ketrenos <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 03:22:28 + (+0800) [PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format This patch modifies the driver to support the ipw2200-fw-3.0 image format. The 3.0 fw image does not add any new capabilities, but as a resu

[PATCH 14/16] ipw2200: wireless extension sensitivity threshold support

2006-03-07 Thread Zhu Yi
From: Olivier Hochreutiner <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 03:13:55 + (+0800) [PATCH 14/16] ipw2200: wireless extension sensitivity threshold support The patch allows the user to set the handover threshold, i.e. the number of consecutively missed beacons that will trigger a roaming

[PATCH 13/16] ipw2200: Enables the "slow diversity" algorithm

2006-03-07 Thread Zhu Yi
From: Cahill, Ben M <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 03:02:27 + (+0800) [PATCH 13/16] ipw2200: Enables the "slow diversity" algorithm This forces one antenna or the other, if the background noise is significantly quieter in one than the other. It favors the quieter antenna, and won'

[PATCH 12/16] ipw2200: Set a meaningful silence threshold value

2006-03-07 Thread Zhu Yi
From: Cahill, Ben M <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 02:58:02 + (+0800) [PATCH 12/16] ipw2200: Set a meaningful silence threshold value Set a meaningful silence threshold value (replacing our previous "0" default), which gets rid of the gratuitous "Link deterioration" notifications

[PATCH 10/16] ipw2200: Change debug level for firmware error logging

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Thu, 2 Mar 2006 06:40:59 + (+0800) [PATCH 10/16] ipw2200: Change debug level for firmware error logging Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -1802,9 +1802,9 @@ static

[PATCH 11/16] ipw2200: export `debug' module param only if CONFIG_IPW2200_DEBUG

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Mon, 6 Mar 2006 05:48:37 + (+0800) [PATCH 11/16] ipw2200: export `debug' module param only if CONFIG_IPW2200_DEBUG Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -11281,8 +1128

[PATCH 09/16] ipw2200: Filter unsupported channels out in ad-hoc mode

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Thu, 2 Mar 2006 05:55:51 + (+0800) [PATCH 09/16] ipw2200: Filter unsupported channels out in ad-hoc mode Currently iwlist ethX freq[uency]/channel lists all the channels the card supported for the current region, which includes some channels can only be

[PATCH 08/16] ipw2200: Fix ipw_sw_reset() implementation inconsistent with comment

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Fri, 17 Feb 2006 08:25:12 + (+0800) [PATCH 08/16] ipw2200: Fix ipw_sw_reset() implementation inconsistent with comment Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -8070,7 +

[PATCH 07/16] ipw2200: Fix rf_kill is activated after mode change with 'disable=1'

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Thu, 16 Feb 2006 16:21:09 + (+0800) [PATCH 07/16] ipw2200: Fix rf_kill is activated after mode change with 'disable=1' When loading the ipw2200 module with disabled=1, rf_kill is activated after every mode change. This is caused by ipw_sw_reset() is ca

[PATCH 06/16] ipw2200: remove the WPA card associates to non-WPA AP checking

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Fri, 17 Feb 2006 07:46:16 + (+0800) [PATCH 06/16] ipw2200: remove the WPA card associates to non-WPA AP checking wpa_supplicant needs to set wpa_enabled unconditionally, with this check it hasn't been possible to connect to non-WPA networks using wpa_su

[PATCH 05/16] ipw2200: Add signal level to iwlist scan output

2006-03-07 Thread Zhu Yi
From: Bill Moss <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 08:50:18 + (+0800) [PATCH 05/16] ipw2200: Add signal level to iwlist scan output This patch does two things. It uses the parameter IW_QUAL_DBM which is new in WE-19 to cause signal level and noise to be reported in dBm by the wireles

[PATCH 04/16] ipw2200: use generic ieee80211_get_hdrlen() to get packet length

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 06:18:19 + (+0800) [PATCH 04/16] ipw2200: use generic ieee80211_get_hdrlen() to get packet length replace ipw2200 specific frame_hdr_len() with generic ieee80211 routine ieee80211_get_hdrlen() Signed-off-by: Zhu Yi <[EMAIL PROTECTED]>

[PATCH 03/16] ipw2200: fix a potential NULL pointer dereference

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 16:02:22 + (+0800) [PATCH 03/16] ipw2200: fix a potential NULL pointer dereference Only on CONFIG_IPW2200_DEBUG is not defined Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wirele

[PATCH 02/16] ipw2200: stop netdev queue if h/w doesn't have space for new packets

2006-03-07 Thread Zhu Yi
From: James Ketrenos <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 09:10:51 + (+0800) [PATCH 02/16] ipw2200: stop netdev queue if h/w doesn't have space for new packets The patch roll back the change we made to support for the ability to start/stop independent Tx queues within a single net dev

[PATCH 01/16] ipw2200: print geography code upon module load

2006-03-07 Thread Zhu Yi
From: Henrik Brix Andersen <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 09:09:52 + (+0800) [PATCH 01/16] ipw2200: print geography code upon module load Given the amount of support requests for the meaning of the geography code I've written a patch for printing this information on module load n

[PATCH 00/16] ipw2200 driver updates

2006-03-07 Thread Zhu Yi
Hi, Here are some patches for ipw2200 driver. Please apply. Patches include: [PATCH 01/16] ipw2200: print geography code upon module load [PATCH 02/16] ipw2200: stop netdev queue if h/w doesn't have space for new packets [PATCH 03/16] ipw2200: fix a potential NULL pointer dereference [PATCH 04

[PATCH 5/6] ipw2100: move mutex.h include from ipw2100.c to ipw2100.h

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Tue, 28 Feb 2006 08:38:07 + (+0800) [PATCH 5/6] ipw2100: move mutex.h include from ipw2100.c to ipw2100.h Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ipw2100.c +++ b/drivers/net/wireless/ipw2100.c @@ -194,7 +194,6 @@ static

[PATCH 3/6] ipw2100: Fix radiotap code gcc warning

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Tue, 21 Feb 2006 18:41:14 + (+0800) [PATCH 3/6] ipw2100: Fix radiotap code gcc warning Fix gcc warning: ipw2100.c:2460: ISO C90 forbids mixed declarations and code Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/drivers/net/wireless/ipw2100.c +++

[PATCH 4/6] ipw2100: semaphore to mutexes conversion

2006-03-07 Thread Zhu Yi
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Tue, 28 Feb 2006 07:20:54 + (+0800) [PATCH 4/6] ipw2100: semaphore to mutexes conversion semaphore to mutexes conversion. the conversion was generated via scripts, and the result was validated automatically via a script as well. build-tested. Si

[PATCH 2/6] ipw2100: add radiotap headers to packtes captured in monitor mode

2006-03-07 Thread Zhu Yi
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Tue, 21 Feb 2006 18:36:17 + (+0800) [PATCH 2/6] ipw2100: add radiotap headers to packtes captured in monitor mode Signed-off-by: Stefan Rompf <[EMAIL PROTECTED]> Signed-off-by: Andrea Merello Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/d

[PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Tue, 21 Feb 2006 18:46:15 + (+0800) [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2 --- --- a/drivers/net/wireless/ipw2100.c +++ b/drivers/net/wireless/ipw2100.c @@ -167,7 +167,7 @@ that only one external action is invoked #include "ipw210

[PATCH 1/6] ipw2x00: expend Copyright to 2006

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 07:17:56 + (+0800) [PATCH 1/6] ipw2x00: expend Copyright to 2006 Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/Documentation/networking/README.ipw2100 +++ b/Documentation/networking/README.ipw2100 @@ -3,18 +3,18 @@ Intel(R) PRO/W

[PATCH 0/6] ipw2100 driver updates

2006-03-07 Thread Zhu Yi
Hi, Here are some patches for ipw2100 driver. Please apply. Patches include: [PATCH 1/6] ipw2x00: expend Copyright to 2006 [PATCH 2/6] ipw2100: add radiotap headers to packtes captured in monitor mode [PATCH 3/6] ipw2100: Fix radiotap code gcc warning [PATCH 4/6] ipw2100: semaphore to mutexes c

Re: de2104x: interrupts before interrupt handler is registered

2006-03-07 Thread Martin Michlmayr
* Francois Romieu <[EMAIL PROTECTED]> [2006-03-08 01:15]: > netdev watchdog events appear in the dmesg of the patched driver. > The driver survived it. So I'd say that the patch does its job. > > OTOH, if you ever saw the unpatched driver survive this event, yell > now. No, I've never seen the un

Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > On Tue, Mar 07, 2006 at 06:14:22PM -0800, Andrew Morton wrote: > > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > > > - if (atomic_read(sk->sk_prot->memory_allocated) < > > > sk->sk_prot->sysctl_mem[0]) { > > > +if (percpu_c

RE: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-07 Thread Simon Barber
Overloading configuration parameters with extra meanings like this makes it harder to configure the system - I think it's useful to keep an on/off function separate from the power setting. Simon -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jouni Malin

Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-07 Thread Ravikiran G Thirumalai
On Tue, Mar 07, 2006 at 06:14:22PM -0800, Andrew Morton wrote: > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > - if (atomic_read(sk->sk_prot->memory_allocated) < > > sk->sk_prot->sysctl_mem[0]) { > > + if (percpu_counter_read(sk->sk_prot->memory_allocated) < > > +

[PATCH] ieee80211: Fix QoS is not active problem

2006-03-07 Thread Zhu Yi
From: Hong Liu <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 02:28:01 + (+0800) [PATCH] ieee80211: Fix QoS is not active problem Fix QoS is not active even the network and the card is QOS enabled. The problem is we pass the wrong ieee80211_network address to ipw_handle_beacon/ipw_handle_probe_re

[PATCH] ieee80211: Fix CCMP decryption problem when QoS is enabled

2006-03-07 Thread Zhu Yi
From: Zhu Yi <[EMAIL PROTECTED]> Date: Tue, 28 Feb 2006 07:06:43 + (+0800) [PATCH] ieee80211: Fix CCMP decryption problem when QoS is enabled Use the correct STYPE for Qos data. Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- --- a/net/ieee80211/ieee80211_crypt_ccmp.c +++ b/net/ieee80211/iee

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread Benjamin LaHaise
On Tue, Mar 07, 2006 at 07:50:52PM +0100, Andi Kleen wrote: > > My vmlinux has > > 80278382 : > 80278382: 8b 0d 78 ea 41 00 mov4319864(%rip),%ecx ># 80696e00 > 80278388: 48 89 f8mov%rdi,%rax > 8027838b:

CWND underused when TSO on

2006-03-07 Thread Lachlan Andrew
Greetings all, There seems to be an anomoly in tcp_tso_should_defer which causes minor problems with TCP Westwood, and major problems with FAST TCP. The check chunk /= sysctl_tcp_tso_win_divisor; if (limit >= chunk) return 0; limits the nu

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread David S. Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 7 Mar 2006 19:50:52 +0100 > On Wednesday 08 March 2006 02:29, Benjamin LaHaise wrote: > > On Tue, Mar 07, 2006 at 05:27:37PM +0100, Andi Kleen wrote: > > > On Wednesday 08 March 2006 00:26, Benjamin LaHaise wrote: > > > > Hi Andi, > > > > > > > > On

Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > - if (atomic_read(sk->sk_prot->memory_allocated) < > sk->sk_prot->sysctl_mem[0]) { > +if (percpu_counter_read(sk->sk_prot->memory_allocated) < > +sk->sk_prot->sysctl_mem[0]) { Bear in mind that percpu_counter_read

Re: [patch 3/4] net: percpufy frequently used vars -- proto.sockets_allocated

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > --- linux-2.6.16-rc5mm3.orig/include/net/sock.h 2006-03-07 > 15:09:22.0 -0800 > +++ linux-2.6.16-rc5mm3/include/net/sock.h 2006-03-07 15:09:52.0 > -0800 > @@ -543,7 +543,7 @@ struct proto { > /* Memory pressure

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread Andi Kleen
On Wednesday 08 March 2006 02:29, Benjamin LaHaise wrote: > On Tue, Mar 07, 2006 at 05:27:37PM +0100, Andi Kleen wrote: > > On Wednesday 08 March 2006 00:26, Benjamin LaHaise wrote: > > > Hi Andi, > > > > > > On x86-64 one inefficiency that shows up on profiles is the handling of > > > struct pag

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long > amount) > +{ > +local_bh_disable(); > +percpu_counter_mod(fbc, amount); > +local_bh_enable(); > +} > + percpu_counter_mod() does preempt_disable(),

[patch 4/4] net: percpufy frequently used vars -- proto.inuse

2006-03-07 Thread Ravikiran G Thirumalai
This patch uses alloc_percpu to allocate per-CPU memory for the proto->inuse field. The inuse field is currently per-CPU as in NR_CPUS * cacheline size -- a big bloat on arches with large cachelines. Also marks some frequently used protos read mostly. Signed-off-by: Pravin B. Shelar <[EMAIL PRO

[patch 3/4] net: percpufy frequently used vars -- proto.sockets_allocated

2006-03-07 Thread Ravikiran G Thirumalai
Change the atomic_t sockets_allocated member of struct proto to a per-cpu counter. Signed-off-by: Pravin B. Shelar <[EMAIL PROTECTED]> Signed-off-by: Ravikiran Thirumalai <[EMAIL PROTECTED]> Signed-off-by: Shai Fultheim <[EMAIL PROTECTED]> Index: linux-2.6.16-rc5mm3/include/net/sock.h ==

[patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-07 Thread Ravikiran G Thirumalai
Add percpu_counter_mod_bh for using these counters safely from both softirq and process context. Signed-off by: Pravin B. Shelar <[EMAIL PROTECTED]> Signed-off by: Ravikiran G Thirumalai <[EMAIL PROTECTED]> Signed-off by: Shai Fultheim <[EMAIL PROTECTED]> Index: linux-2.6.16-rc5mm3/include/linux/

[patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-07 Thread Ravikiran G Thirumalai
Change struct proto->memory_allocated to a batching per-CPU counter (percpu_counter) from an atomic_t. A batching counter is better than a plain per-CPU counter as this field is read often. Signed-off-by: Pravin B. Shelar <[EMAIL PROTECTED]> Signed-off-by: Ravikiran Thirumalai <[EMAIL PROTECTED

[patch 0/4] net: percpufy frequently used vars on struct proto

2006-03-07 Thread Ravikiran G Thirumalai
Following patchset converts struct proto.memory_allocated to use batching per-cpu counters, struct proto.sockets_allocated to use per-cpu counters and changes the proto.inuse per-cpu variable to use alloc_percpu instead of the NR_CPUS x cacheline size padding. We observed 5% improvement in apache

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread Benjamin LaHaise
On Tue, Mar 07, 2006 at 05:27:37PM +0100, Andi Kleen wrote: > On Wednesday 08 March 2006 00:26, Benjamin LaHaise wrote: > > Hi Andi, > > > > On x86-64 one inefficiency that shows up on profiles is the handling of > > struct page conversion to/from idx and addresses. This is mostly due to > > th

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread Roland Dreier
David> I wish you had started the thread by mentioning this David> specific patch, we wasted an enormous amount of precious David> developer time speculating and asking for arbitrary tests David> to be run in order to narrow down the problem, yet you knew David> the specific cha

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 07 Mar 2006 17:17:30 -0800 > The reason TSO comes up is that reverting the patch described below > helps (or helped at some point at least) IPoIB throughput quite a bit. I wish you had started the thread by mentioning this specific patch, we wast

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread Roland Dreier
David> How limited are the IPoIB devices, TX descriptor wise? David> One side effect of the TSO changes is that one extra David> descriptor will be used for outgoing packets. This is David> because we have to put the headers as well as the user David> data, into page based buf

Re: [Bugme-new] [Bug 6186] New: net/ipv4/route.c: use after free in rt_fill_info

2006-03-07 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 7 Mar 2006 16:41:02 -0800 > [EMAIL PROTECTED] wrote: > > > > http://bugzilla.kernel.org/show_bug.cgi?id=6186 > > > >Summary: net/ipv4/route.c: use after free in rt_fill_info > > Kernel Version: 2.6.16-git > > Status: N

Re: [Bugme-new] [Bug 6187] New: netlink: possible use after free in netlink_recvmsg

2006-03-07 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6187 > >Summary: netlink: possible use after free in netlink_recvmsg > Kernel Version: 2.6.16-git > Status: NEW > Severity: normal > Owner: [EMAIL PROTECTED] > Submit

Re: [Bugme-new] [Bug 6186] New: net/ipv4/route.c: use after free in rt_fill_info

2006-03-07 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6186 > >Summary: net/ipv4/route.c: use after free in rt_fill_info > Kernel Version: 2.6.16-git > Status: NEW > Severity: normal > Owner: [EMAIL PROTECTED] > Submitter

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread David S. Miller
From: Matt Leininger <[EMAIL PROTECTED]> Date: Tue, 07 Mar 2006 16:11:37 -0800 > I used the standard setting for tcp_rmem and tcp_wmem. Here are a > few other runs that change those variables. I was able to improve > performance by ~30MB/s to 403 MB/s, but this is still a ways from the > 474

Re: de2104x: interrupts before interrupt handler is registered

2006-03-07 Thread Francois Romieu
Martin Michlmayr <[EMAIL PROTECTED]> : [...] > It seems to help. It's hard to say for sure because I don't have a > foolproof way to reproduce this panic. It _usually_ occurs after > copying a few hundred MB but there's no clear trigger. I've now copied > a few GB around using a kernel with your

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread Matt Leininger
On Tue, 2006-03-07 at 13:49 -0800, Stephen Hemminger wrote: > On Tue, 07 Mar 2006 13:44:51 -0800 > Matt Leininger <[EMAIL PROTECTED]> wrote: > > > On Mon, 2006-03-06 at 19:13 -0800, Shirley Ma wrote: > > > > > > > More likely you are getting hit by the fact that TSO prevents the > > > congestion

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread Andi Kleen
On Wednesday 08 March 2006 00:26, Benjamin LaHaise wrote: > Hi Andi, > > On x86-64 one inefficiency that shows up on profiles is the handling of > struct page conversion to/from idx and addresses. This is mostly due to > the fact that struct page is currently 56 bytes on x86-64, so gcc has to

[PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-07 Thread Benjamin LaHaise
Hi Andi, On x86-64 one inefficiency that shows up on profiles is the handling of struct page conversion to/from idx and addresses. This is mostly due to the fact that struct page is currently 56 bytes on x86-64, so gcc has to emit a slow division or multiplication to convert. By switching to

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread Andi Kleen
On Wednesday 08 March 2006 00:13, David S. Miller wrote: > From: Andi Kleen <[EMAIL PROTECTED]> > Date: Tue, 7 Mar 2006 16:39:58 +0100 > > > Also the locking requirements would need to be defined. The originals > > didn't have any locking at all. > > You don't need any locking, just a producer an

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread David S. Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 7 Mar 2006 16:39:58 +0100 > Also the locking requirements would need to be defined. The originals > didn't have any locking at all. You don't need any locking, just a producer and consumer index in seperate cache lines, and a wakeup protocol that ma

[PATCH] use wait queue spinlock for the socket spinlock

2006-03-07 Thread Benjamin LaHaise
Hi Dave et al, The patch below merges the use of the wait queue lock and socket spinlock into one. This gains us ~100-150Mbit/s on netperf, mostly due to the fact that because we know how the spinlock is used, we can avoid the whole irq save, disable and reenable sequence since the spinlock on

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread Andi Kleen
On Tuesday 07 March 2006 23:51, David S. Miller wrote: > From: Andi Kleen <[EMAIL PROTECTED]> > Date: Tue, 7 Mar 2006 23:47:11 +0100 > > > In particular I liked the concept of using arrays of pointers as > > queues instead of double linked lists to be more cache friendly. > > Why doesn't someone

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-07 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 00:51:33 +0300 > RCU introduces noticeble latencies for writing part compared to > rwlock, so workloads when a lot of new short connections are created > and destroyed, like busy web server within LAN with small latencies, > will suf

Re: [PATCH] [NETFILTER] ip_queue: Fix wrong skb->len == nlmsg_len assumption

2006-03-07 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 07 Mar 2006 13:58:53 +0100 > Thomas Graf wrote: > > The size of the skb carrying the netlink message is not > > equivalent to the length of the actual netlink message > > due to padding. ip_queue matches the length of the payload > > against the

Re: [PATCH] IPoIB: Fix build now that destructor is in neigh_params

2006-03-07 Thread Roland Dreier
David> Why not just put this into your -ipoib patch set in -mm? David> The change was for IPOIB's sake anyways... OK, good idea. I'll put this in my for-2.6.17 and for-mm queues. - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] IPoIB: Fix build now that destructor is in neigh_params

2006-03-07 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 07 Mar 2006 11:21:08 -0800 > Dave, here's an incremental patch that fixes the IPoIB build (which is > broken in net-2.6.17 because of my screw-up, which left out the chunk > below). I'll also send a full patch that can replace the "Move > destruc

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread David S. Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 7 Mar 2006 23:47:11 +0100 > In particular I liked the concept of using arrays of pointers as > queues instead of double linked lists to be more cache friendly. Why doesn't someone work on a generic data-structure framework in some generic header fil

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread Andi Kleen
On Tuesday 07 March 2006 22:19, Benjamin LaHaise wrote: > At this point I'd just like to stir up some discussion, so please comment > away with any ideas and concerns. I think the first step for better spreading of work would be better MSI-X support. In particular we need ways for drivers to eas

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-07 Thread Evgeniy Polyakov
On Mon, Mar 06, 2006 at 02:01:11PM -0800, Benjamin LaHaise ([EMAIL PROTECTED]) wrote: > Hello again, > > This patch introduces the use of rcu for the ipv4 established connections > hashtable, as well as the timewait table since they are closely intertwined. > This removes 4 atomic operations p

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread Michael S. Tsirkin
Quoting r. Stephen Hemminger <[EMAIL PROTECTED]>: > Is IB using NAPI or just doing netif_rx()? No, IPoIB doesn't use NAPI. -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

[PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-07 Thread Rick Jones
Provide a sysctl called "tcp_tape_broken_windows" to disable limiting the advertised TCP window to 32767 bytes when the remote has not sent us a window scale option. Long long ago and far away, there were it seems some broken TCP stacks which mistakenly treated the 16 bit TCP window field as a sig

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread Stephen Hemminger
On Tue, 07 Mar 2006 13:44:51 -0800 Matt Leininger <[EMAIL PROTECTED]> wrote: > On Mon, 2006-03-06 at 19:13 -0800, Shirley Ma wrote: > > > > > More likely you are getting hit by the fact that TSO prevents the > > congestion > > window from increasing properly. This was fixed in 2.6.15 (around mid

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread Matt Leininger
On Mon, 2006-03-06 at 19:13 -0800, Shirley Ma wrote: > > > More likely you are getting hit by the fact that TSO prevents the > congestion > window from increasing properly. This was fixed in 2.6.15 (around mid > of Nov 2005). > > Yep, I noticed the same problem. After updating to the new kernel,

[EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread Benjamin LaHaise
Hi folks, I'd like to start some discussions on SMP optimizations for the networking stack. The patch below is one such example which changes the loopback device in a way that helps out on workloads like netperf by trying to share more work with the other CPU on an HT system. Basically, if th

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread Herbert Xu
Ingo Oeser <[EMAIL PROTECTED]> wrote: > > Would you mind queueing a patch nearly citing your first comment like this? There is no point in singling this out. We assume this all over the place. We even cast dst entries directly to IPv4/IPv6 route entries. Cheers, -- Visit Openswan at http://www

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-07 Thread Andrew Morton
"Eric Molitor" <[EMAIL PROTECTED]> wrote: > > Attached is a TCP Dump, SYS output was... > > tcpdump -i lo > debug.dump > tcpdump: verbose output suppressed, use -v or -vv for full protocol decode > listening on lo, link-type EN10MB (Ethernet), capture size 96 bytes > 31066 packets captured > 9365

[PATCH] [NET]: Move destructor from neigh->ops to neigh_params

2006-03-07 Thread Roland Dreier
Here's the fixed version of the original patch. --- From: Michael S. Tsirkin <[EMAIL PROTECTED]> struct neigh_ops currently has a destructor field, which no in-kernel drivers outside of infiniband use. The infiniband/ulp/ipoib in-tree driver stashes some info in the neighbour structure (the res

[PATCH] IPoIB: Fix build now that destructor is in neigh_params

2006-03-07 Thread Roland Dreier
Dave, here's an incremental patch that fixes the IPoIB build (which is broken in net-2.6.17 because of my screw-up, which left out the chunk below). I'll also send a full patch that can replace the "Move destructor from neigh->ops to neigh_params" patch if you'd rather replace it in your tree. Th

[PATCH 3/3] sky2: truncate oversize packets

2006-03-07 Thread Stephen Hemminger
Turn on truncation to prevent getting choked by frames larger than expected. Without this fix, driver hangs after receiving an oversize packet. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- jeff-2.6.orig/drivers/net/sky2.c2006-03-07 10:40:34.0 -0800 +++ jeff-2.6/drivers/ne

[PATCH 1/3] sky2: not random enough

2006-03-07 Thread Stephen Hemminger
Don't use sky2 to seed random pool beacause the network packet arrival time will not be truly random due to NAPI and interrupt mitigation. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c2006-03-06 09:59:02.0 -0800 +++ sky2-1.0/drivers/net/sky

[PATCH 2/3] sky2: force early transmit interrupts

2006-03-07 Thread Stephen Hemminger
Avoid premature transmit ring full conditions. Force a transmit status interrupt if transmit ring gets nearly full and after a TSO send. Allow more entries in transmit ring to be used if dma_addr is 32 bits Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- jeff-2.6.orig/drivers/net/sky2.c

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-07 Thread Stephen Hemminger
On Mon, 06 Mar 2006 16:57:11 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Mon, 6 Mar 2006 22:30:59 +0100 > > Francois Romieu <[EMAIL PROTECTED]> wrote: > > > > > >>(s/osld.org/osdl.org/g) > >> > >>Stephen Hemminger <[EMAIL PROTECTED]> : > >> > >>>Redo the interu

Re: 2.6.16-rc5-mm2: IPW_QOS: two remarks

2006-03-07 Thread Adrian Bunk
On Sun, Mar 05, 2006 at 01:46:26AM +0100, Andreas Happe wrote: > On Friday 03 March 2006 16:26, Adrian Bunk wrote: >... > > - please add a help text > > i could add some stuff about WMM to its help text, but I think someone more > involved with the ipw2200-project should do that. Even a short he

Re: de2104x: interrupts before interrupt handler is registered

2006-03-07 Thread Martin Michlmayr
* Martin Michlmayr <[EMAIL PROTECTED]> [2006-03-06 19:17]: > There's another interrupt related bug in the driver, though. I There's yet another bug (or two). I just got another kernel panic: http://www.cyrius.com/tmp/de2104x_panic2.jpg (which I haven't been able to reproduce so far; this was wit

Re: de2104x: interrupts before interrupt handler is registered

2006-03-07 Thread Martin Michlmayr
* Martin Michlmayr <[EMAIL PROTECTED]> [2006-03-07 05:11]: > * Francois Romieu <[EMAIL PROTECTED]> [2006-03-06 22:17]: > > Not sure about this one, but... > > It seems to help. It's hard to say for sure because I don't have a > foolproof way to reproduce this panic. It _usually_ occurs after > c

Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-07 Thread jamal
On Mon, 2006-06-03 at 12:00 -0500, Shailabh Nagar wrote: > My design was to have the listener get both responses (what I call > replies in the code) as well as events (data sent on exit of pid) > I think i may not be doing justice explaining this, so let me be more elaborate so we can be in syn

Re: [PATCH] avoid atomic op on page free

2006-03-07 Thread Andi Kleen
On Tuesday 07 March 2006 02:52, Benjamin LaHaise wrote: > Those 1-2 cycles are free if you look at how things get scheduled with the > execution of the surrounding code. I bet $20 that you can't find a modern > CPU where the cost is measurable (meaning something like a P4, Athlon). > If this l

Re: [PATCH] [NETFILTER] ip_queue: Fix wrong skb->len == nlmsg_len assumption

2006-03-07 Thread Patrick McHardy
Thomas Graf wrote: > The size of the skb carrying the netlink message is not > equivalent to the length of the actual netlink message > due to padding. ip_queue matches the length of the payload > against the original packet size to determine if packet > mangling is desired, due to the above wrong

Re: GigE on PowerMac G5

2006-03-07 Thread Andreas Schwab
Benjamin Herrenschmidt <[EMAIL PROTECTED]> writes: > At this point, all I can say is... does it work in OS X ? Strange, OS X can't do it either. Looks like I have a hardware problem. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürn

[PATCH] [NETFILTER] ip_queue: Fix wrong skb->len == nlmsg_len assumption

2006-03-07 Thread Thomas Graf
The size of the skb carrying the netlink message is not equivalent to the length of the actual netlink message due to padding. ip_queue matches the length of the payload against the original packet size to determine if packet mangling is desired, due to the above wrong assumption arbitary packets m

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread Ingo Oeser
YOSHIFUJI Hideaki wrote: > In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo > Oeser <[EMAIL PROTECTED]> says: > > > What about sth. like this simple defensive patch instead > > (against Linux 2.6.16-rc4)? > > I disagree again. Sorry. Fine with me. If somebody changes

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 07 Mar 2006 19:45:42 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo > Oeser <[EMAIL PROTECTED]> says: > > > What about sth. like this simple defensive patch instead > > (against Linux 2.6.16-rc4)? >

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > What about sth. like this simple defensive patch instead > (against Linux 2.6.16-rc4)? I disagree again. Sorry. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netd

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread Ingo Oeser
Hi, YOSHIFUJI Hideaki wrote: > In article <[EMAIL PROTECTED]> (at Mon, 06 Mar 2006 21:50:33 +0100), > Jean-Mickael Guerin <[EMAIL PROTECTED]> says: > > This patch fixes potential null pointer dereference (I never experiment > > such crash). > > The patch is made for net-2.6.17. > > I disagree.

Re: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-07 Thread Evgeniy Polyakov
On Tue, Mar 07, 2006 at 10:43:59AM +0100, Ingo Oeser ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > > On Mon, Mar 06, 2006 at 06:44:07PM +0100, Ingo Oeser ([EMAIL PROTECTED]) > > wrote: > > > Hmm, so I should resurrect my user page table walker abstraction? > > > > > > There I would hand

Re: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-07 Thread Ingo Oeser
Evgeniy Polyakov wrote: > On Mon, Mar 06, 2006 at 06:44:07PM +0100, Ingo Oeser ([EMAIL PROTECTED]) > wrote: > > Hmm, so I should resurrect my user page table walker abstraction? > > > > There I would hand each page to a "recording" function, which > > can drop the page from the collection or coal

Re: [PATCH, RESEND] Add MWI workaround for Tulip DC21143

2006-03-07 Thread Geert Uytterhoeven
On Tue, 7 Mar 2006, Ralf Baechle wrote: > On Tue, Mar 07, 2006 at 12:15:30AM +0100, Francois Romieu wrote: > > > [...] > > > Does anyone have comments regarding this patch? I received > > > confirmation from a number of Debian users that this patch > > > significantly improves the lockup situatio