[PATCH 5/6]x25:Allow ITU-T DTE facilities for x25

2006-02-16 Thread Shaun Pereira
From: [EMAIL PROTECTED] Allows use of the optional user facility to insert ITU-T (http://www.itu.int/ITU-T/) specified DTE facilities in call set-up x25 packets. This feature is optional; no facilities will be added if the ioctl is not used, and call setup packet remains the same as before. If th

[PATCH 6/6]x25:dte facilities 32 64 ioctl conversion

2006-02-16 Thread Shaun Pereira
From: [EMAIL PROTECTED] Allows dte facility patch to use 32 64 bit ioctl conversion mechanism Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]> --- diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net/x25/af_x25.c linux-2.6.16-rc3/net/x25/af_x25.c --- linux-2.6.16-rc3-vanilla/net/x25/af_x25.c 200

[PATCH 3/6]x25:ioctl conversion 32 bit user to 64 bit kernel

2006-02-16 Thread Shaun Pereira
From: [EMAIL PROTECTED] To allow 32 bit x25 module structures to be passed to a 64 bit kernel via ioctl using the new compat_sock_ioctl registration mechanism instead of the obsolete 'register_ioctl32_conversion into hash table' mechanism Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]> Acked-by:

[PATCH 4/6]x25:Fix kernel error message 64 bit kernel

2006-02-16 Thread Shaun Pereira
From: [EMAIL PROTECTED] Fixes the following error from kernel T2 kernel: schedule_timeout: wrong timeout value from 88164796 Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> --- diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net

[PATCH 1/6]net:Allow 32 bit socket ioctl in 64 bit kernel

2006-02-16 Thread Shaun Pereira
From: [EMAIL PROTECTED] Since the register_ioctl32_conversion() patch in the kernel is now obsolete, provide another method to allow 32 bit user space ioctls to reach the kernel. Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> --- diff -uprN -X dontdiff

[PATCH 2/6]net:socket timestamp 32 bit handler for 64 bit kernel

2006-02-16 Thread Shaun Pereira
From: [EMAIL PROTECTED] Get socket timestamp handler function that does not use the ioctl32_hash_table. Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> --- diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/include/net/compat.h linux-2.6.16-rc3/include/ne

[PATCH 2.6.16] Wavelan_cs bitfield fixes

2006-02-16 Thread Jean Tourrilhes
Hi Jeff, Some bitfields were incorrectly initialised in wavelan_cs, causing some compiler warning. Also killed a error message that should not be there... Tested in 2.6.16-rc3... Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> Have fun... Jean diff -u

Re: [RFT] sky2 0.16

2006-02-16 Thread Ian Kumlien
> It adds a debugging interface /proc/net/sky2/{pci-id} that will show > the pending status and transmit ring. It would be useful to see what > that contains after a hang. This version also has some other changes, > so the hang might already be fixed. Thank you kindly, =), it's now up and runn

Re: [PATCH] mtu probing: move tcp-specific data out of inet_connection_sock

2006-02-16 Thread Ian McDonald
> No Ian. John was the one that moved those fields out of tcp.h and into > inet_connection_sock.h: > > http://master.kernel.org/git/?p=linux/kernel/git/acme/net-2.6.17.git;a=commit;h=55bb045aa49d5e5234c6213d1ed0bfef0c636971 > > When we get to fix the DCCP PMTU code we can revisit if this move is >

Re: [PATCH] mtu probing: move tcp-specific data out of inet_connection_sock

2006-02-16 Thread John Heffner
Ian McDonald wrote: On 2/17/06, John Heffner <[EMAIL PROTECTED]> wrote: This moves some TCP-specific MTU probing state out of inet_connection_sock back to tcp_sock. Signed-off-by: John Heffner <[EMAIL PROTECTED]> Why do you want to do this? What benefit does it give? I would like to see PMT

[RFT] sky2 0.16

2006-02-16 Thread Stephen Hemminger
Could everyone who has problems with hangs try the following patch (against current 2.6.16-rc3 version) If it gets mangled (it's also at http://developer.osdl.org/shemminger/prototypes/sky2-0.15-0.16.diff). It adds a debugging interface /proc/net/sky2/{pci-id} that will show the pending status

Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-16 Thread Shaun Pereira
Thank for reviewing the patch Ingo. There was a mistake the first time round, lucky for me Arnaldo's comment about the magic number helped me spot it. When ITU-T DTE facilities are added to the X.25 header packet the length field has to contain n + 1 bytes where n is the number of bytes needed to h

Re: [PATCH] mtu probing: move tcp-specific data out of inet_connection_sock

2006-02-16 Thread Arnaldo Carvalho de Melo
On 2/16/06, Ian McDonald <[EMAIL PROTECTED]> wrote: > On 2/17/06, John Heffner <[EMAIL PROTECTED]> wrote: > > This moves some TCP-specific MTU probing state out of > > inet_connection_sock back to tcp_sock. > > > > Signed-off-by: John Heffner <[EMAIL PROTECTED]> > > > > Why do you want to do this?

Re: [PATCH] mtu probing: move tcp-specific data out of inet_connection_sock

2006-02-16 Thread Ian McDonald
On 2/17/06, John Heffner <[EMAIL PROTECTED]> wrote: > This moves some TCP-specific MTU probing state out of > inet_connection_sock back to tcp_sock. > > Signed-off-by: John Heffner <[EMAIL PROTECTED]> > Why do you want to do this? What benefit does it give? I would like to see PMTU done in DCCP a

Re: Please pull 'upstream' branch of wireless-2.6

2006-02-16 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit fe45f58a19768c5fd182c90030ab73a0a343e3b4: Dan Williams: wireless/airo: fix setting TX key index plus key in ENCODEEXT are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.gi

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-02-16 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit fdfd0c941715ef8c23a3cbeb7dc44978b5020d13: John W. Linville: Merge git://git.kernel.org/.../torvalds/linux-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstr

Please pull 'upstream' branch of wireless-2.6

2006-02-16 Thread John W. Linville
The following changes since commit fe45f58a19768c5fd182c90030ab73a0a343e3b4: Dan Williams: wireless/airo: fix setting TX key index plus key in ENCODEEXT are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Andreas Happe

Re: KERNEL: assertion (!sk->sk_forward_alloc) failed

2006-02-16 Thread Jan-Frode Myklebust
On 2006-02-09, Boris B. Zhmurov <[EMAIL PROTECTED]> wrote: > >> Is it possible for you to download 2.6.16-rc2 or similar and see if it >> goes away? > > It'll be better, if I get only patch fixs that problem, not all 2.6.16-rc2. I just got this same warning on a system running 2.6.14.5. It's been

Re: Please pull 'upstream' branch of wireless-2.6

2006-02-16 Thread John W. Linville
On Mon, Feb 13, 2006 at 10:19:18PM -0500, John W. Linville wrote: > The following changes since commit fe45f58a19768c5fd182c90030ab73a0a343e3b4: > Dan Williams: > wireless/airo: fix setting TX key index plus key in ENCODEEXT > > are found in the git repository at: > > git://git.kernel

Re: [PATCH] pktgen: fix races between control/worker threads

2006-02-16 Thread Arthur Kepner
On Thu, 16 Feb 2006, Jesse Brandeburg wrote: > > should i test this patch to see if it fixes the pktgen panic when > removing a network driver module (or renegotiating link, i don't > remember where i saw the failure) in the middle of a pktgen run? > Yes, please. Removing the network dri

Re: [PATCH] pktgen: fix races between control/worker threads

2006-02-16 Thread Jesse Brandeburg
On 2/15/06, Arthur Kepner <[EMAIL PROTECTED]> wrote: > > Let's try this again. How does this look, Robert? > > There's a race in pktgen which can lead to a double > free of a pktgen_dev's skb. If a worker thread is in > the midst of doing fill_packet(), and the controlling > thread gets a "stop" me

[PATCH] mtu probing: move tcp-specific data out of inet_connection_sock

2006-02-16 Thread John Heffner
This moves some TCP-specific MTU probing state out of inet_connection_sock back to tcp_sock. Signed-off-by: John Heffner <[EMAIL PROTECTED]> diff --git a/include/linux/tcp.h b/include/linux/tcp.h index f2bb239..542d395 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -343,6 +343,1

Re: [PATCH] pktgen: fix races between control/worker threads

2006-02-16 Thread Arthur Kepner
On Thu, 16 Feb 2006, Robert Olsson wrote: > . > >if(remove) { > > > + t->control |= T_REMDEV; > > + pkt_dev->removal_mark = 1; > > >} > > Guess you should mark b

Re: [NETLINK]: Add netlink_has_listeners for avoiding unneccessary event message generation

2006-02-16 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 16 Feb 2006 08:08:10 -0500 > BTW, Dave when you get the time, after you apply this patch, please look > at applying the ones i submitted for ipsec for 2.6.17. They are > dependent on this patch from Patrick. Ok. - To unsubscribe from this list: send the

Re: [PKT_SCHED 00/05]: net/sched patches for 2.6.17

2006-02-16 Thread Patrick McHardy
jamal wrote: > On Wed, 2006-15-02 at 09:54 +0100, Patrick McHardy wrote: > > [..] > >> [PKT_SCHED]: Convert sch_red to a classful qdisc > > > This is the only one i have issues with (i.e ACK all the other ones)[1]. > > I can understand for a RED algorithm to have a set of parameters for >

Re: [PKT_SCHED]: Change default clock source to gettimeofday

2006-02-16 Thread Patrick McHardy
Andy Furniss wrote: > Patrick McHardy wrote: > >> Sorry for the repost Dave, I accidentally used the @oss.sgi.com address >> in my previous posting. >> >> - >> >> It seems to be a common mistake to use jiffies as clocksource, >> which gives very bad results in most cases. This patch change

Re: [PATCH] [IPV4] PMTU issues due to TOS field manipulation

2006-02-16 Thread Ilia Sotnikov
On 2/15/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Feb 15, 2006 at 03:21:50PM +0200, Ilia Sotnikov wrote: > > > > Totally agree but perhaps we should ask the confirmation from someone? > > That's what this list is for :) Send a patch and if there are no objections > it should be go in. He

[PATCH 5/6] scsi tgt: scsi target netlink interface

2006-02-16 Thread Mike Christie
This patch implments a netlink interface for the scsi tgt framework. I was not sure if code using the netlink interface had to get reviewed by the netdev guys. I am ccing them on this patch and providing a basic review of why/how we want to use netlink. I did not think the netdev people wanted to

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Ian Kumlien
On Thu, 2006-02-16 at 11:25 +0100, Andi Kleen wrote: > On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > > (Sorry, resent due to wrong message in CC, sending again to keep > > consistency) > > > > I have been having problems for some while with sky2 on my machine even > > with sky2 0.15 (as

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Ian Kumlien
On Thu, 2006-02-16 at 11:25 +0100, Andi Kleen wrote: > On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > > (Sorry, resent due to wrong message in CC, sending again to keep > > consistency) > > > > I have been having problems for some while with sky2 on my machine even > > with sky2 0.15 (as

[PATCH] pktgen: fix races between control/worker threads

2006-02-16 Thread Robert Olsson
Arthur Kepner writes: > > Let's try this again. How does this look, Robert? Yeep better > if(remove) { > +t->control |= T_REMDEV; > +pkt_dev->removal_mark = 1; >

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-02-16 Thread Joy Latten
On Thu, 2006-02-16 at 01:30 -0500, Catherine Zhang wrote: > Joy, > > Thanks for your comment and sorry for the delay. Did you mean a > separate error code for 'null' context? The current code catches the > case when the sid is SECSID_NULL, and returns ENOPROTOOPT. The > question is whether we w

Re: [PATCH 5/6] x25: Allow 32 bit socket ioctl in 64 bit kernel

2006-02-16 Thread Ingo Oeser
Shaun Pereira wrote: > removed magic number 33 as suggested by Arnaldo But are you sure, you use the right substitute for it? > struct x25_calluserdata { > diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/include/net/x25.h > linux-2.6.16-rc3/include/net/x25.h > --- linux-2.6.16-rc3-vanilla/inc

Re: [NETLINK]: Add netlink_has_listeners for avoiding unneccessary event message generation

2006-02-16 Thread jamal
On Thu, 2006-16-02 at 08:08 -0500, jamal wrote: > BTW, Dave when you get the time, after you apply this patch, please look > at applying the ones i submitted for ipsec for 2.6.17. They are > dependent on this patch from Patrick. > Sorry, I should have been more specific: Subject: [Patch 0/7] IP

Re: [NETLINK]: Add netlink_has_listeners for avoiding unneccessary event message generation

2006-02-16 Thread jamal
On Thu, 2006-16-02 at 02:43 +0100, Patrick McHardy wrote: > This version should be fine for > net-2.6.17, my upcoming netfilter patches will add the first > two users. > ACKed-by: Jamal Hadi Salim<[EMAIL PROTECTED]> And hey, I was the first user ;-> I didnt have the misfortune of bumping into th

Re: [PKT_SCHED 00/05]: net/sched patches for 2.6.17

2006-02-16 Thread jamal
On Wed, 2006-15-02 at 09:54 +0100, Patrick McHardy wrote: [..] > [PKT_SCHED]: Convert sch_red to a classful qdisc This is the only one i have issues with (i.e ACK all the other ones)[1]. I can understand for a RED algorithm to have a set of parameters for a physical queue (even in the case

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Ian Kumlien
--- > On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > > (Sorry, resent due to wrong message in CC, sending again to keep > > consistency) > > > > I have been having problems for some while with sky2 on my machine even > > with sky2 0.15 (as in 2.6.16-rc3-git4) > > The appe

Re: [PKT_SCHED]: Change default clock source to gettimeofday

2006-02-16 Thread Andy Furniss
Patrick McHardy wrote: Sorry for the repost Dave, I accidentally used the @oss.sgi.com address in my previous posting. - It seems to be a common mistake to use jiffies as clocksource, which gives very bad results in most cases. This patch changes the default to gettimeofday. What do y

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Andi Kleen
On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > (Sorry, resent due to wrong message in CC, sending again to keep > consistency) > > I have been having problems for some while with sky2 on my machine even > with sky2 0.15 (as in 2.6.16-rc3-git4) The appended patch should fix the problem to

Re: [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module

2006-02-16 Thread Michael Buesch
On Thursday 16 February 2006 10:35, you wrote: > On Wed, 15 Feb 2006 22:34:35 +0100, Michael Buesch wrote: > > On Wednesday 15 February 2006 20:21, you wrote: > > > This patch fixes an oops when bcm43xx-d80211 module is unloaded. > > This is already fixed in my tree. > > Is the tree available some

Re: [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module

2006-02-16 Thread Jiri Benc
On Wed, 15 Feb 2006 22:34:35 +0100, Michael Buesch wrote: > On Wednesday 15 February 2006 20:21, you wrote: > > This patch fixes an oops when bcm43xx-d80211 module is unloaded. > This is already fixed in my tree. Is the tree available somewhere? I'm testing some patches for the d80211 stack and it

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-02-16 Thread netdev-owner
On Mon, Feb 06, 2006 at 12:12:31PM -0500, Catherine Zhang wrote: > > Updated as per James' comment. I don't quite understand how one actually uses this but it looks correct technically :) > diff -puN security/dummy.c~lsm-secpeer security/dummy.c > --- linux-2.6.16-rc1/security/dummy.c~lsm-secpee

Re: ipw2200 firmware bug?

2006-02-16 Thread Zhu Yi
On Wed, 2006-02-15 at 23:21 +0100, Michael Buesch wrote: > but it seems like it is still missing packets. > I do not receive a beacon every second (interval is one sec, here) > and the 80211 sequence number is interrupted. The mode monitor is usually in frequency hopping. You can try to set the ch