Re: [PATCH]eepro100: remove devices supported by e100

2005-11-08 Thread Jeff Garzik
Scott Feldman wrote: I was going to say that eepro100's speedo_rx_link() does the same DMA abuse as e100, but then I noticed one little detail: eepro100 sets both EL (end of list) and S (suspend) bits in the RFD as it chains it to the RFD list. e100 was only setting the EL bit. Hmmm, that'

Re: sendfile system call and UDP sockets

2005-11-08 Thread John Que
Hello, Thanks. I use 2.6.11-1 kernel ,Fedora Core 4. Here is the program I use and the error I get after I send one UDP packet to this machine on the port it listens on ,9000. (Note : input.txt is a nonempty small input file.) #include #include #include #include #include #include #in

[git patches] 2.6.x net driver updates

2005-11-08 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to receive the following updates, including a big ipw wireless update: include/linux/eeprom.h| 136 Documentation/networking/README.ipw2100 | 119 Documentati

Re: [PATCH] cris v10 eth: use ethtool_ops

2005-11-08 Thread Jeff Garzik
applied all three ethtool-related patches - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethtool: Format register dump for tg3

2005-11-08 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] b44: replace B44_FLAG_INIT_COMPLETE with netif_running()

2005-11-08 Thread Jeff Garzik
applied 1-3 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] cleanup ieee80211_crypto.c

2005-11-08 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/58] ipw2x00: Catch ipw2100 and ipw2200 up to the out-of-tree versions

2005-11-08 Thread Jeff Garzik
Two post-application notes: * I applied the attached patch to kill some warnings * Please fix the first line of each commit's description, so that it shows up properly when piped through git-shortlog (see attached shortlog.txt). Example: Fixed parameter reordering in firmware log rou

Re: [PATCH 0/58] ipw2x00: Catch ipw2100 and ipw2200 up to the out-of-tree versions

2005-11-08 Thread Jeff Garzik
James Ketrenos wrote: You can also pull this series from rsync://bughost.org/repos/ipw-delta/.git/ (the GIT overlay is against the ieee80211 overlay at rsync://bughost.org/repos/ieee80211-delta/.git/ vs. netdev-2.6#upstream) Ignore my last email. I just pulled the quoted URL into netdev. Tha

Re: [PATCH 0/58] ipw2x00: Catch ipw2100 and ipw2200 up to the out-of-tree versions

2005-11-08 Thread Jeff Garzik
James Ketrenos wrote: This series brings the ipw2100 and ipw2200 drivers up to be in sync w/ the current out of tree drivers (ipw2100 v1.1.3 and ipw2200 v1.0.8) This series looks OK to me. However I appear to be missing patches #5 and #6, which causes the obvious cascade effect. Can you tos

Re: [PATCH 0/3] ieee80211: Lindent, WEP group key bug, update version to 1.1.7

2005-11-08 Thread Jeff Garzik
James Ketrenos wrote: This series does the following: [1/3] scripts/Lindent on ieee80211 subsystem. [2/3] Fix problem with WEP unicast key > index 0 [3/3] Stamp as 1.1.7 You can pull this series from: rsync://bughost.org/repos/ieee80211-delta/.git/ Pulled, thanks. Jeff -

Re: [PATCH 1/7] skge: clear PCI PHY COMA mode on boot

2005-11-08 Thread Jeff Garzik
applied 1-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 13:01:52 -0800 > Endianness often makes my head spin, so please be kind - are the > addresses being converted to little endian before the hash (ntohl as > it were) or is it just happening as a consequence? If the former, > why the conver

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread Herbert Xu
Rick Jones <[EMAIL PROTECTED]> wrote: > > Endianness often makes my head spin, so please be kind - are the addresses > being > converted to little endian before the hash (ntohl as it were) or is it just > happening as a consequence? If the former, why the conversion? When you load a 32-bit in

Re: [PATCH 10/15] [NETFILTER] nfnetlink: only load subsystems if CAP_NET_ADMIN is set

2005-11-08 Thread Pablo Neira
Harald Welte wrote: > [NETFILTER] nfnetlink: only load subsystems if CAP_NET_ADMIN is set > > Without this patch, any user can cause nfnetlink subsystems to be > autoloaded. Those subsystems however could add significant processing > overhead to packet processing, and would refuse any configurati

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-08 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2005-11-08 15:11 > Yes, fixing it correctly looks very hard. Just changing the routes > doesn't seem right to me, someone might have added it with exactly > this prefsrc and doesn't want it to change, its also not clear how > to notify on this. Right, OTOH thi

Re: [PATCH 8/15] [NETFILTER] ctnetlink: get_conntrack can use GFP_KERNEL

2005-11-08 Thread Pablo Neira
Please drop this patch. Harald Welte wrote: > @@ -788,6 +788,12 @@ ctnetlink_get_conntrack(struct sock *ctn > > err = ctnetlink_fill_info(skb2, NETLINK_CB(skb).pid, nlh->nlmsg_seq, > IPCTNL_MSG_CT_NEW, 1, ct); > + > +#ifdef CONFIG_IP_NF_CT_ACCT > + if (

[PATCH 16/15] [NETFILTER] ctnetlink: ICMP_ID is u_int16_t not u_int8_t.

2005-11-08 Thread Harald Welte
(seems like i can't even count, thus 16/15) [NETFILTER] ctnetlink: ICMP_ID is u_int16_t not u_int8_t. Signed-off-by: Krzysztof Piotr Oledzki <[EMAIL PROTECTED]> Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 824a31f4feb58ea25c4c838

[PATCH 15/15] [NETFILTER] ctnetlink: Fix oops when no ICMP ID info in message

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: Fix oops when no ICMP ID info in message This patch fixes an userspace triggered oops. If there is no ICMP_ID info the reference to attr will be NULL. Signed-off-by: Krzysztof Piotr Oledzki <[EMAIL PROTECTED]> Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-

[PATCH 10/15] [NETFILTER] nfnetlink: only load subsystems if CAP_NET_ADMIN is set

2005-11-08 Thread Harald Welte
[NETFILTER] nfnetlink: only load subsystems if CAP_NET_ADMIN is set Without this patch, any user can cause nfnetlink subsystems to be autoloaded. Those subsystems however could add significant processing overhead to packet processing, and would refuse any configuration messages from non-CAP_NET_A

[PATCH 6/15] [NETFILTER] ctnetlink: add module alias to fix autoloading

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: add module alias to fix autoloading Add missing module alias. This is a must to load ctnetlink on demand. For example, the conntrack tool will fail if the module isn't loaded. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED

[PATCH 11/15] [NETFILTER] stop tracking ICMP error at early point

2005-11-08 Thread Harald Welte
[NETFILTER] stop tracking ICMP error at early point Currently connection tracking handles ICMP error like normal packets if it failed to get related connection. But it fails that after all. This makes connection tracking stop tracking ICMP error at early point. Signed-off-by: Yasuyuki Kozakai <[

[PATCH 9/15] [NETFILTER] PPTP helper: fix PNS-PAC expectation call id

2005-11-08 Thread Harald Welte
[NETFILTER] PPTP helper: fix PNS-PAC expectation call id The reply tuple of the PNS->PAC expectation was using the wrong call id. So we had the following situation: - PNS behind NAT firewall - PNS call id requires NATing - PNS->PAC gre packet arrives first then the PNS->PAC expectation is matche

[PATCH 13/15] [NETFILTER] ctnetlink: propagate error instaed of returning -EPERM

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: propagate error instaed of returning -EPERM Propagate the error to userspace instead of returning -EPERM if the get conntrack operation fails. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 9cdec7d1acde0d0a9e

[PATCH 7/15] [NETFILTER] ctnetlink: kill unused includes

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: kill unused includes Kill some useless headers included in ctnetlink. They aren't used in any way. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 1f83ca8dd34407e20c17d0f172b8d9e59a326ba1 tree e49612c72536ac13

[PATCH 12/15] [NETFILTER] ctnetlink: return -EINVAL if size is wrong

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: return -EINVAL if size is wrong Return -EINVAL if the size isn't OK instead of -EPERM. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 6ec2ee65ba91c23a2d36d11a9d92a435b30e56db tree c6331d67f7d253384bf13aa29d83

[PATCH 8/15] [NETFILTER] ctnetlink: get_conntrack can use GFP_KERNEL

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: get_conntrack can use GFP_KERNEL ctnetlink_get_conntrack is always called from user context, so GFP_KERNEL is enough. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 7b13da49573e77b6e122d9f9253728dac04d6658 tr

[PATCH] Fix fallout from CONFIG_IPV6_PRIVACY

2005-11-08 Thread Peter Chubb
Trying to build today's 2.6.14+git snapshot gives undefined references to use_tempaddr Looks like an ifdef got left out. Signed-off-by: Peter Chubb <[EMAIL PROTECTED]> net/ipv6/addrconf.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6-import/net/ipv6/addrconf.c ==

Re: Patch: RFC2863 #1 (incomplete)

2005-11-08 Thread Thomas Graf
* Hasso Tepper <[EMAIL PROTECTED]> 2005-11-08 17:14 > OSPF doesn't care if there is connected route or not if !IFF_RUNNING. And > it doesn't matter if it's demand circuit or usual one. If kernel reports > link down (!IFF_RUNNING), no any packets are sent over this link - > hellos, LS updates etc. H

[PATCH 14/15] [NETFILTER] ctnetlink: Add support to identify expectations by ID's

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: Add support to identify expectations by ID's Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit b98f5d02ab4cecbe4c3b038287e064973be27dcb tree 135f77d58d8b18a19dc91c83e6f01c094f810be1 parent 9cdec7d1acde0d0a9e15ba3

[PATCH 3/15] [NETFILTER] nfnetlink: nfattr_parse() can never fail, make it void

2005-11-08 Thread Harald Welte
[NETFILTER] nfnetlink: nfattr_parse() can never fail, make it void nfattr_parse (and thus nfattr_parse_nested) always returns success. So we can make them 'void' and remove all the checking at the caller side. Based on original patch by Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald

[PATCH 4/15] [NETFILTER] ctnetlink: check if protoinfo is present

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: check if protoinfo is present This fixes an oops triggered from userspace. If we don't pass information about the private protocol info, the reference to attr will be NULL. This is likely to happen in update messages. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Sig

[RFC] new driver - Asix AX88796

2005-11-08 Thread Ben Dooks
Attached is a platform driver for the Asix AX88796 10/100 Ethernet controller. This controller has an NE2000 compatible core, with extensions for MII Phy control, and an simple bi-directional parallel port (seperate part to linux-parport) Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> --- linux-2.6.

[PATCH 2/15] [NETFILTER] refcount leak of proto when ctnetlink dumping tuple

2005-11-08 Thread Harald Welte
[NETFILTER] refcount leak of proto when ctnetlink dumping tuple Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit dce6b47e7a1f4b7f34e0f696f15b9c8361a8f64e tree 40798ea28cceb7174104c7ad22161b75e7f130af parent 4f97be1da822b520d2a27b8766cf

[PATCH 1/15] NETFILTER: packet counter of conntrack is 32bits

2005-11-08 Thread Harald Welte
[NETFILTER] packet counter of conntrack is 32bits The packet counter variable of conntrack was changed to 32bits from 64bits. This follows that change. Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> diff --git a/net

[PATCH 5/15] [NETFILTER] ctnetlink: add marking support from userspace

2005-11-08 Thread Harald Welte
[NETFILTER] ctnetlink: add marking support from userspace This patch adds support for conntrack marking from user space. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 6fb708af6bead3d02683185649398bbdc74bb4a5 tree 4488bf1fb9805d3af

Re: [stable] [NET] Fix zero-size datagram reception

2005-11-08 Thread Daniel Phillips
On Tuesday 08 November 2005 10:13, Greg KH wrote: > On Thu, Nov 03, 2005 at 07:55:38AM +1100, Herbert Xu wrote: > > The recent rewrite of skb_copy_datagram_iovec broke the reception of > > zero-size datagrams. This patch fixes it. > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > > > Pleas

[PATCH 2/3] b44: race on device closing

2005-11-08 Thread Francois Romieu
Usual fix: - b44_interrupt() does not schedule NAPI polling when the device is going down; - b44_close() waits for any scheduled NAPI polling before it starts to release the private structures of the device. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- 63e9595140aec93c6f8bbc4455d86

[PATCH 3/3] b44: increase version number

2005-11-08 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- 74c2bceb5ef0b044b9c3206966494536f2c28fcf diff --git a/drivers/net/b44.c b/drivers/net/b44.c --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -29,8 +29,8 @@ #define DRV_MODULE_NAME"b44" #define PFX DRV_MODULE_NAME": "

[PATCH 1/3] b44: replace B44_FLAG_INIT_COMPLETE with netif_running()

2005-11-08 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- 964030a0efb18f203ff356a737c23f158bb7ec5a diff --git a/drivers/net/b44.c b/drivers/net/b44.c --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -1392,7 +1392,6 @@ static int b44_open(struct net_device *d b44_init_rings(bp); b

[PATCH] ethtool: Format register dump for tg3

2005-11-08 Thread Michael Chan
Format output of "ethtool -d" for tg3 devices to make it more readable. Each register is displayed as a 32-bit value and the undefined regions in the register space are skipped. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff -rup ethtool-3.a/ethtool.c ethtool-3.b/ethtool.c --- ethtool-3.a/

Re: [GIT PATCH] RFC3484 compliant source address selection

2005-11-08 Thread Brian Haley
Hi Yoshifuji, /* + * find the first different bit between two addresses + * length of address must be a multiple of 32bits + */ +static inline int __ipv6_addr_diff(const void *token1, const void *token2, int addrlen) +{ + const __u32 *a1 = token1, *a2 = token2; + int i; + + a

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread Rick Jones
David S. Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 12:12:19 -0800 Still seems to be doing as well - I'm assuming that when the "random" IPs are generated that they do not have to be put into network byte order, since they are randomly generated bits. When the I

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 12:12:19 -0800 > Still seems to be doing as well - I'm assuming that when the > "random" IPs are generated that they do not have to be put into > network byte order, since they are randomly generated bits. When > the IPs aren't random, t

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread Rick Jones
David S. Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 11:33:16 -0800 Is there a test case I may have missed - otherwise it looks like it was adding much randomness - particularly in the case of the IP's being "close" to one another - the xor tends to "knock-out" th

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 11:33:16 -0800 > Is there a test case I may have missed - otherwise it looks like it > was adding much randomness - particularly in the case of the IP's > being "close" to one another - the xor tends to "knock-out" the > upper bits of the

[RFT] pcnet32: support for boards with multiple phys

2005-11-08 Thread Don Fry
This patch contains code from Thomas Bogendoerfer which I have modified somewhat. It works fine for me in my testing, but I would like additional exposure to this code before submitting to mainline. It should fix bugzilla bug #4219 as well. The patch is based on 2.6.14-git11. The ethtool version

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread Rick Jones
David S. Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 11:11:17 -0800 What are the two lines xoring h with shifts of itself meant to be doing? So that all the upper bits get mixed into the hash somehow, regardless of the size of the hash table. Is there a test

Re: sendfile system call and UDP sockets

2005-11-08 Thread Ian McDonald
> But when I am trying to write a user space program > which tries using sendfile with > UDP sockets I encounter erros. (with TCP sockets > sendfile works OK). > If you want help you need to supply more information. Please supply a small sample program and also the error messages. You should also s

Re: what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 11:11:17 -0800 > What are the two lines xoring h with shifts of itself meant to be doing? So that all the upper bits get mixed into the hash somehow, regardless of the size of the hash table. - To unsubscribe from this list: send the lin

Re: [PATCH] Annotate h_proto in struct ethhdr

2005-11-08 Thread Pavel Roskin
The protocol field in ethernet headers is big-endian and should be annotated as such. This patch allows detection of missing ntohs() calls on the ethernet protocol field when sparse is run with __CHECK_ENDIAN__ defined. This is a revised version that includes so that the userspace programs are n

what is the nefarious porpoise of the "h shift" in inet_ehashfn?

2005-11-08 Thread Rick Jones
Out of pseudo-morbid curiousity I was looking at inet_ehashfn, which looks rather like this: static inline int inet_ehashfn_orig(const __u32 laddr, const __u16 lport, const __u32 faddr, const __u16 fport, const int ehash_size) { int h = (laddr

[PATCH 0/7] skge: version 1.2

2005-11-08 Thread Stephen Hemminger
Minor update to skge driver: * support MII tool interface. handy for debugging, and some tools use it. * fix some shutdown issues with some motherboards -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: s

[PATCH 7/7] skge: increase version number

2005-11-08 Thread Stephen Hemminger
Increase the driver version number and print version when probing. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -43,7 +43,7 @@ #include "skge.h" #define DRV_NAME "skge" -#define DRV_VERSION

[PATCH 1/7] skge: clear PCI PHY COMA mode on boot

2005-11-08 Thread Stephen Hemminger
When skge is booted up, the PHY may be stuck in power down state by the previous OS. So we may need to turn it on. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2893,6 +2893,7 @@ static const char *skge_board_name(con

[PATCH 3/7] skge: add mii ioctl support

2005-11-08 Thread Stephen Hemminger
Basic MII ioctl support for skge driver. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include "skge.h" @@ -88,8 +89,8 @@ MODULE_DEVICE_TABLE(p

[PATCH 2/7] skge: use kzalloc

2005-11-08 Thread Stephen Hemminger
Can use kzalloc in skge driver. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -3168,14 +3168,13 @@ static int __devinit skge_probe(struct p #endif err = -ENOMEM; - hw = kmalloc(sizeof(*hw), GFP_KERNEL)

[PATCH 6/7] skge: spelling fixes

2005-11-08 Thread Stephen Hemminger
Fix some of my bad spelling. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -130,7 +130,7 @@ static void skge_get_regs(struct net_dev regs->len - B3_RI_WTO_R1); } -/* Wake on Lan only supported

[PATCH 4/7] skge: goto low power mode on shutdown

2005-11-08 Thread Stephen Hemminger
Go into power down mode on shutdown. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -1804,6 +1804,25 @@ static void yukon_mac_init(struct skge_h skge_write16(hw, SK_REG(port, TX_GMF_CTRL_T), GMF_OPER_ON); }

[ANNOUNCE] iproute2 2.6.14-051107

2005-11-08 Thread Stephen Hemminger
Update to iproute2 is available. Most of the changes were to repair the things that broke with the introduction of the batch mode to the ip command. http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.14-051107.tar.gz For info on CVS ans other info see: http://linux-net.

Re: [stable] [NET] Fix zero-size datagram reception

2005-11-08 Thread Greg KH
On Thu, Nov 03, 2005 at 07:55:38AM +1100, Herbert Xu wrote: > Hi: > > The recent rewrite of skb_copy_datagram_iovec broke the reception of > zero-size datagrams. This patch fixes it. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Please apply it to both 2.6.15 and 2.6.14. queued to -sta

Re: [stable] [2.6 patch] airo.c/airo_cs.c: correct prototypes

2005-11-08 Thread Greg KH
On Sat, Nov 05, 2005 at 05:42:27PM +0100, Adrian Bunk wrote: > This patch creates a file airo.h containing prototypes of the global > functions in airo.c used by airo_cs.c . > > If you got strange problems with either airo_cs devices or in any other > completely unrelated part of the kernel shor

Re: [stable] [PATCH] tcp: BIC max increment too large

2005-11-08 Thread Greg KH
On Tue, Nov 01, 2005 at 03:26:45PM -0800, Stephen Hemminger wrote: > The max growth of BIC TCP is too large. Original code was based on > BIC 1.0 and the default there was 32. Later code (2.6.13) included > compensation for delayed acks, and should have reduced the default > value to 16; since norm

Re: Align DMA buffers to a cacheline

2005-11-08 Thread David S. Miller
From: Anton Blanchard <[EMAIL PROTECTED]> Date: Wed, 9 Nov 2005 03:12:20 +1100 > Do you mean we expect exactly 16 bytes, or at least 16 bytes. Im happy > to ammend it so we always require the minimum 16 bytes, and can expand > it on architectures where it makes sense. I meant "at least 16 bytes".

Re: Align DMA buffers to a cacheline

2005-11-08 Thread Anton Blanchard
Hi, > There is still a lot of code that depends upon there being > a scratch of ~15 bytes there at the beginning of the SKB data > area. > > This kind of change, at best, would require a thorough audit > of every single piece of the networking, particularly things > that tunnel other protocols

Re: [PATCH] Annotate h_proto in struct ethhdr

2005-11-08 Thread David S. Miller
From: Pavel Roskin <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 01:40:57 -0500 > The protocol field in ethernet headers is big-endian and should be > annotated as such. This patch allows detection of missing ntohs() calls > on the ethernet protocol field when sparse is run with __CHECK_ENDIAN__ > d

Re: Future of DONGLE_OLD drivers?

2005-11-08 Thread jt
On Tue, Nov 08, 2005 at 04:42:26AM +0100, Adrian Bunk wrote: > Looking at drivers/net/irda/Kconfig, it seems all DONGLE_OLD drivers > except EP7211_IR have more recent drivers. > > My questions are: > > Is there still any reason to keep the DONGLE_OLD drivers except > EP7211_IR? The ol

Re: Align DMA buffers to a cacheline

2005-11-08 Thread John W. Linville
On Tue, Nov 08, 2005 at 08:57:14AM -0800, David S. Miller wrote: > From: Anton Blanchard <[EMAIL PROTECTED]> > Date: Tue, 8 Nov 2005 17:56:47 +1100 > > > Any thoughts on this? The other option was to override dev_alloc_skb, > > but I would prefer not to if possible. > > There is still a lot of c

[PATCH] drivers/net/gt96100eth.c: don't concatenate __FUNCTION__ with strings

2005-11-08 Thread Alexey Dobriyan
From: Clemens Buchacher <[EMAIL PROTECTED]> It's deprecated. Use "%s", __FUNCTION__ instead. Signed-off-by: Clemens Buchacher <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>

Re: Align DMA buffers to a cacheline

2005-11-08 Thread David S. Miller
From: Anton Blanchard <[EMAIL PROTECTED]> Date: Tue, 8 Nov 2005 17:56:47 +1100 > Any thoughts on this? The other option was to override dev_alloc_skb, > but I would prefer not to if possible. There is still a lot of code that depends upon there being a scratch of ~15 bytes there at the beginning

Re: [RFC] TSO problems with congestion updates

2005-11-08 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 7 Nov 2005 16:25:32 -0800 > it could be limited to power of 2 and a shift? That might not be a bad idea. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RFC] TSO problems with congestion updates

2005-11-08 Thread Ingo Oeser
Hi, here an idea, how we might get rid of the nasty divide: Stephen Hemminger wrote: > +/* RFC2861 Check whether we are limited by application or congestion > window + * This is the inverse of tcp_tso_should_defer > + */ > +static inline int tcp_cwnd_full(const struct tcp_sock *tp, u32 in_flight,

Re: Patch: RFC2863 #1 (incomplete)

2005-11-08 Thread Hasso Tepper
Thomas Graf wrote: > Whatever is used, there is a link state detection implemented as a > heartbeat protocol. Even on DC the probing can be done periodically > while the link is up. My point is that there are such things and it's > basically the same as the kernel reporting !IFF_RUNNING. I cannot >

Re: Interrupts and NF_HOOKS

2005-11-08 Thread John Que
Hello, Sorry; I did not completed my message; here is the full one: Thanks a lot for your answer ! Following your answer I did some reading in LDD3 and "Undersatnding the linux kernel" and I want to verify if I may that I understood the interrupts mechanism right regarding my nethooks question:

Re: Interrupts and NF_HOOKS

2005-11-08 Thread John Que
Hello, Thanks a lot for your answer ! Following your answer I did some reading in LDD3 I want to verify that I understood the interrupts mechanism right: NF_IP_FORWARD On 10/30/05, Harald Welte <[EMAIL PROTECTED]> wrote: > On Sat, Oct 29, 2005 at 03:39:30PM +0200, John Que wrote: > > Hello, >

Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion

2005-11-08 Thread Patrick McHardy
Thomas Graf wrote: > * Thomas Graf <[EMAIL PROTECTED]> 2005-11-05 14:46 > >>Assuming this is a separate bug, I'm not sure if this is the right >>way to fix it. I think it would be better to rewrite the preferred >>source address of all related local routes and only perform a >>remove-and-add on th

sendfile system call and UDP sockets

2005-11-08 Thread John Que
Hello, Is it possible to use the sendfile system call with UDP sockets in linux kernel ? I saw in net/ipv4/udp.c a comment made by Hirokazu Takahashi, which says "sendfile() on UDP works now." (this is in the linux 2.6.* kernels). But when I am trying to write a user space program which tries u

Re: [NF+IPsec 4/6]: Make IPsec input processing symetrical to output

2005-11-08 Thread Patrick McHardy
Yasuyuki KOZAKAI wrote: > I try to comment based on discussion with Yoshifuji-san and Miyazawa-san. > > We think it's confusing for user to mix decrypted packets and pre-decrypted > ones to same hook. For example, if user want to accept packets encrypted by > transport mode ESP and drop others, he

Re: Patch: RFC2863 #1 (incomplete)

2005-11-08 Thread Thomas Graf
* Hasso Tepper <[EMAIL PROTECTED]> 2005-11-08 15:39 > The same is true for any OSPF link. Only periodical hellos are used for > that in standard case. Demand circuits are there to suppress periodical > hellos and link state update refreshes - ie. if there is no real > application traffic going over

Re: Patch: RFC2863 #1 (incomplete)

2005-11-08 Thread Hasso Tepper
Thomas Graf wrote: > Yes there is, it's called neighbour probing. Link state updates are > sent periodically and acked. It's there to handle crashed OSPF software > and oversubscription. Then after DCs were introcued in rfc1793 it got > unuseable and wasn't reintroduced until rfc3883, it's back the

Re: Patch: RFC2863 #1 (incomplete)

2005-11-08 Thread Thomas Graf
* Hasso Tepper <[EMAIL PROTECTED]> 2005-11-08 14:55 > Thomas Graf wrote: > > Then how are you going to implement OSPF which has its own link state > > detection? > > OSPF doesn't have any link state detection. If carrier is up, hello > packets are sent out to the interface, if carrier is down, no

Re: Patch: RFC2863 #1 (incomplete)

2005-11-08 Thread Hasso Tepper
Thomas Graf wrote: > Then how are you going to implement OSPF which has its own link state > detection? OSPF doesn't have any link state detection. If carrier is up, hello packets are sent out to the interface, if carrier is down, no hellos. With hellos adjacencies can be formed to exchange routin

Invitation to France, Spain, and Montreal, Canada; c/ba

2005-11-08 Thread IPSI Conferences
Dear potential Speaker: Based on your explicit interest expressed in the past and/or a recommendation from a colleague who read your past publication(s), on behalf of the organizing committee, we would like to extend a cordial invitat on for you to submit a paper to the IPSI Transactions journa

Align DMA buffers to a cacheline

2005-11-08 Thread Anton Blanchard
Hi, On ppc64 we want DMA writes (ie receive packets) to be aligned, hopefully on a cacheline boundary. The NET_IP_ALIGN patch got us part of the way, so that DMAs were 16 byte aligned. The following patch addresses the other source of misalignment. Every skb has 16 bytes of headroom reserved for