From: Rick Jones <[EMAIL PROTECTED]>
Date: Tue, 08 Nov 2005 11:33:16 -0800

> Is there a test case I may have missed - otherwise it looks like it
> was adding much randomness - particularly in the case of the IP's
> being "close" to one another - the xor tends to "knock-out" the
> upper bits of the IPs.  And even when the remote IPs were random,
> the two seemed to produce quite similar results.

You might wish to make sure you try your tests on both
big and little endian systems, trying sizes such as 8-bit
hash size masks up to something like 16-bit ones.

Somewhere deep in the history is the change where Alexey
Kuznetsov added those xor+shift statements, noting in the
changelog how without it the hash works well on big-endian
(which is where I wrote it) but fails spectacularly on
little-endian.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to