Re: [PATCH netdev-2.6] sky2: new experimental Marvell Yukon2 driver

2005-08-16 Thread Jeff Garzik
Stephen Hemminger wrote: New driver for the Marvell Yukon2 Gigabit Ethernet chipset. This driver is based on the skge driver, but using the logic from the SysKonnect version of the sk98lin driver. It should support all the Yukon2 chipsets that are available in many current Intel and AMD motherboa

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 16 Aug 2005 21:58:36 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > It also is a preferred change than your minimal version > because it makes the ip6 input path very similar to > the ipv4 variant, so it's easier to verify the two pieces > of c

Re: [PATCH] (2/3) FIB Trie using RCU

2005-08-16 Thread Stephen Hemminger
On Tue, 16 Aug 2005 20:37:25 -0700 (PDT) "David S. Miller" <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 16 Aug 2005 13:22:50 -0700 > > > Convert fib_trie to use Read Copy Update. Since all updates to > > FIB happen under RTNL mutex (semaphore), we don't n

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 16 Aug 2005 21:04:10 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Wed, 17 Aug 2005 05:52:06 +0200 > > > David S. Miller wrote: > > > Applied to both net-2.6 and net-2.6.14 > > > > BTW, the I

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 17 Aug 2005 05:52:06 +0200 > David S. Miller wrote: > > Applied to both net-2.6 and net-2.6.14 > > BTW, the IPv6 skb leak fix is only in your net-2.6.14 tree > so far, I think it should go in net-2.6 as well. Agreed, added to net-2.6 - To unsu

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread Patrick McHardy
David S. Miller wrote: Applied to both net-2.6 and net-2.6.14 BTW, the IPv6 skb leak fix is only in your net-2.6.14 tree so far, I think it should go in net-2.6 as well. [IPV6]: Fix SKB leak in ip6_input_finish() Changing it to how ip_input handles should fix it. Signed-off-by: Patrick McHar

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 17 Aug 2005 05:33:44 +0200 > [IPV6]: Fix raw socket hardware checksum failures > > When packets hit raw sockets the csum update isn't done yet, do it manually. > Packets can also reach rawv6_rcv on the output path through > ip6_call_ra_chain, i

Re: [PATCH] (2/3) FIB Trie using RCU

2005-08-16 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 16 Aug 2005 13:22:50 -0700 > Convert fib_trie to use Read Copy Update. Since all updates to > FIB happen under RTNL mutex (semaphore), we don't need fib_lock > for writing. Robert was independantly working on an RCU patch, which recently he

[IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread Patrick McHardy
This patch fixes "kernel: raw v6 hw csum failure." messages. It distracted me from the TCPMSS issue, I'll take care of that tomorrow. [IPV6]: Fix raw socket hardware checksum failures When packets hit raw sockets the csum update isn't done yet, do it manually. Packets can also reach rawv6_rcv on

Re: [ANNOUNCE] iproute2 util update

2005-08-16 Thread Eric Dumazet
Stephen Hemminger a écrit : http://developer.osdl.org/dev/iproute2/download/iproute2-050816.tar.gz Update to iproute2 to include: * Limit ip neigh flush to 10 rounds * tc ematch support (thomas) * build cleanups (thomas, et al) * Fix for options process with ipt (

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-08-16 Thread Arthur Kepner
On Tue, 16 Aug 2005, Herbert Xu wrote: > . > So my preference for this isn't really based on particularly strong > reasons. However, as I couldn't see any strong reason for it to be > more strict either I'd rather stay with the one since it's slightly > simpler to code. > Fair enough. --

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-08-16 Thread Herbert Xu
On Tue, Aug 16, 2005 at 09:21:24AM -0700, Arthur Kepner wrote: > > So, your patch would accept up to sysctl_ipfrag_max_dist "disorder" > between calls to ip_frag_too_far() (for a particluar fragment queue). > (I'm using "disorder" loosely, but I think it's clear enough what is > meant?) With my

Re: [PATCH 1/1][IP] Introduce ip_options_get_from_user

2005-08-16 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Tue, 16 Aug 2005 19:57:48 -0300 > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Looks good, pulled. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] M

[PATCH 1/1][IP] Introduce ip_options_get_from_user

2005-08-16 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree 97bdf91e0c95ee3136f781de86cf8bd64ee8f6a5 parent ded36fa488366d09958ba025354db8456b0131cc author Arnaldo Carvalho de Melo <

Representatives needed urgently

2005-08-16 Thread kim lee
Dear Sir/Madam, I am Mr.kim Lee ,we are a company that deal on importing and exporting raw materials into Canada,America and England. We are searching for representatives who can help us establish a medium of getting to our costumers in the Canada,America and England as well as making payments

Re: [PATCH 1/1][NETLINK] Fix sparse warnings

2005-08-16 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Tue, 16 Aug 2005 19:07:03 -0300 > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Pulled, thanks Arnaldo. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTE

[PATCH 1/1][NETLINK] Fix sparse warnings

2005-08-16 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree c6bac7343b60605e5fe6e8be56e0ff780631a749 parent 200afe1409e8f7305789a8a3f023d1b840a0a434 author Arnaldo Carvalho de Melo <

[ANNOUNCE] iproute2 util update

2005-08-16 Thread Stephen Hemminger
http://developer.osdl.org/dev/iproute2/download/iproute2-050816.tar.gz Update to iproute2 to include: * Limit ip neigh flush to 10 rounds * tc ematch support (thomas) * build cleanups (thomas, et al) * Fix for options process with ipt (jamal) * Fix array ove

Re: Hit BUG on ipv4/netfilter/ipt_TCPMSS.c:190

2005-08-16 Thread Patrick McHardy
Matthew J Galgoci wrote: Matthew, please post the rules you're using with the TCPMSS target The rule is as follows: -A INPUT -m tcp -p tcp --tcp-flags SYN,RST SYN -j TCPMSS --set-mss 1400 Thanks, I misread the check in checkentry. I'll look into fixing it now. - To unsubscribe from this list

Re: [PATCH netdev-2.6 1/4] skge: stop bogus sensor messages

2005-08-16 Thread Jeff Garzik
applied patches 1-4 to 'upstream' branch of netdev-2.6.git - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH netdev-2.6 4/4] skge: turn on link status LED

2005-08-16 Thread Stephen Hemminger
Turn on the link status LED when link comes up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/skge.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/skge.c b/drivers/net/skge.c --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -

[PATCH netdev-2.6 1/4] skge: stop bogus sensor messages

2005-08-16 Thread Stephen Hemminger
Some versions of the Marvell yukon generate bogus sensor warning interrupts. The driver would flood log with these messages. Handle this situation cleanly by masking away at boot time. Fixes: http://bugs.gentoo.org/show_bug.cgi?id=87182 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> driv

[PATCH netdev-2.6 3/4] skge: increase receive flush threshold default

2005-08-16 Thread Stephen Hemminger
The flush threshold in the MAC chip should be increased. Found while reviewing vendor version of sk98lin driver. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> diff --git a/drivers/net/skge.c b/drivers/net/skge.c --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -1780,7 +1780,12 @@ stati

[PATCH netdev-2.6 2/4] skge: fibre vs copper detection cleanup

2005-08-16 Thread Stephen Hemminger
Cleanup the code that handles fibre vs copper detection. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> drivers/net/skge.c | 26 -- drivers/net/skge.h | 11 ++- 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/net/skge.c b/drivers

[PATCH] (2/3) FIB Trie using RCU

2005-08-16 Thread Stephen Hemminger
Convert fib_trie to use Read Copy Update. Since all updates to FIB happen under RTNL mutex (semaphore), we don't need fib_lock for writing. This version is different from earlier RCU patches because: * only need hlist_add_before_rcu by recoding insert_leaf_info * only use RCU for

[PATCH] (1/3) FIB trie cleanup

2005-08-16 Thread Stephen Hemminger
This is a redo of earlier cleanup stuff: * replace DBG() macro with pr_debug() * get rid of duplicate extern's that are already in fib_lookup.h * use BUG_ON and WARN_ON * don't use BUG checks for null pointers where next statement would get a fault anyway

[PATCH] (3/3) FIB Trie proc iterator

2005-08-16 Thread Stephen Hemminger
Create one iterator for walking over FIB trie, and use it for all the /proc functions. Add a /proc/net/route output for backwards compatibility with old applications. Make initialization of fib_trie same as fib_hash so no #ifdef is needed in af_inet.c Signed-off-by: Stephen Hemminger <[EMAIL PROT

Re: Hit BUG on ipv4/netfilter/ipt_TCPMSS.c:190

2005-08-16 Thread Matthew J Galgoci
> > skge sets CHECKSUM_HW on received packets, sk98lin does not, > > instead it just marks the packet with CHECKSUM_NONE. > > > > Patrick, I can't see how ipt_TCPMSS.c's BUG() check can be > > correct in the presence of a driver which sets CHECKSUM_HW > > on received packets. > > TCPMSS can only

Re: Hit BUG on ipv4/netfilter/ipt_TCPMSS.c:190

2005-08-16 Thread Patrick McHardy
David S. Miller wrote: From: Matthew J Galgoci <[EMAIL PROTECTED]> Date: Tue, 16 Aug 2005 07:13:45 +0100 Is this a spurrious BUG() statement that is no longer applicable, or is there a subtle problem with the skge driver that involves hw checksumming syn packets? skge sets CHECKSUM_HW on re

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-08-16 Thread Arthur Kepner
On Tue, 16 Aug 2005, Herbert Xu wrote: > On Thu, Aug 04, 2005 at 05:48:17PM -0700, Arthur Kepner wrote: > > > > @@ -366,6 +376,9 @@ static struct ipq *ip_frag_create(unsign > > . > > + qp->peer = sysctl_ipfrag_max_dist ? inet_getpeer(iph->saddr, 1) : NULL; > > + if (qp->peer) > > +

Re: IP_RECVTTL

2005-08-16 Thread Andi Kleen
On Tue, Aug 16, 2005 at 12:50:51PM +0300, Hasso Tepper wrote: > According to man 7 ip: > > IP_RECVTTL > When this flag is set pass a IP_RECVTTL control message with the > time to live field of the received packet as a byte. Not > supported for SOCK_STREAM sockets. > > This is

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-08-16 Thread Herbert Xu
On Thu, Aug 04, 2005 at 05:48:17PM -0700, Arthur Kepner wrote: > > @@ -366,6 +376,9 @@ static struct ipq *ip_frag_create(unsign > qp->meat = 0; > qp->fragments = NULL; > qp->iif = 0; > + qp->peer = sysctl_ipfrag_max_dist ? inet_getpeer(iph->saddr, 1) : NULL; > + if (qp->pe

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-16 Thread Amin Azez
Work well done, so oughtn't div64_64 to go in include/asm-generic/div64.h one day, to be available kernel wide, as do_div64_64 I see that net/core/pktgen.c is full of 64 bit division and maybe could benefit from this, and perhaps a version that does remainders too. Amin Patrick McHardy wrote: >

Çë°ïæͶÎÒÅ®¶ùÒ» Ʊ°É

2005-08-16 Thread IDWXixeMaCX0r
Òæ´ï½à°×,Ц³ö²ÊÉ«ÈËÉú¸ãÒ»¸ö»î¶¯,ÎÒ°ÑÎÒÅ®¶ùµÄÕÕƬҲ´«ÉÏÈ¥ÁË, ÄúÈç¹ûÓпÕ,¾Í°ÝÍаïæͶÎÒÅ®¶ùһƱ,¶àлÁË! ÎÒÅ®¶ùµÄͼƬµØÖ·ÈçÏÂ: http://www.extrawhite.com.cn/detail.asp?id=590EA968-0E98-40F4-ABB9-C1EDDA65B4D9 ÎÒ×ÔÈÏΪÎÒÅ®¶ùµÄЦÈÝÊÇÕæÕý²ÓÀõÄ,ÊÇÈ«¼ÒµÄ¿ªÐĹû°¡!ÏàÐÅÄú¿´ÁËÒ²»áͬÒâÎҵĿ´·¨! ÄúÖ»ÐèÔÚ"ÎÒÒ

Re: Re: [patch] net/tulip: LAN driver for ULI M5261/M5263

2005-08-16 Thread Peer . Chen
Jeff: The attached file is the incremental patch to the original uli526x.c I send you first time, I modify the source according to your advice, thanks. Signed-off-by: Peer Chen <[EMAIL PROTECTED]> (See attached file: patch_uli526x_inc) Best Regards Peer |-+--->

IP_RECVTTL

2005-08-16 Thread Hasso Tepper
According to man 7 ip: IP_RECVTTL When this flag is set pass a IP_RECVTTL control message with the time to live field of the received packet as a byte. Not supported for SOCK_STREAM sockets. This is not what happens. Instead of control message with type IP_RECVTTL (12)

Re: Hit BUG on ipv4/netfilter/ipt_TCPMSS.c:190

2005-08-16 Thread David S. Miller
From: Matthew J Galgoci <[EMAIL PROTECTED]> Date: Tue, 16 Aug 2005 07:13:45 +0100 > Is this a spurrious BUG() statement that is no longer applicable, or > is there a subtle problem with the skge driver that involves hw > checksumming syn packets? skge sets CHECKSUM_HW on received packets, sk98lin