David S. Miller wrote:
From: Matthew J Galgoci <[EMAIL PROTECTED]>
Date: Tue, 16 Aug 2005 07:13:45 +0100
Is this a spurrious BUG() statement that is no longer applicable, or
is there a subtle problem with the skge driver that involves hw
checksumming syn packets?
skge sets CHECKSUM_HW on received packets, sk98lin does not,
instead it just marks the packet with CHECKSUM_NONE.
Patrick, I can't see how ipt_TCPMSS.c's BUG() check can be
correct in the presence of a driver which sets CHECKSUM_HW
on received packets.
TCPMSS can only be used in the output path, so I'm not sure how this
can happen. The BUG() and the comment (can never happen for SYN) was
added by yourself, so I assume it is correct. In ip_forward we reset
ip_summed to CHECKSUM_NONE before the FORWARD hook is called.
Matthew, please post the rules you're using with the TCPMSS target.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
