Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-11 Thread David S. Miller
From: Scott Bardone <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 23:16:14 -0700 > - static was removed from functions '__tcp_inherit_port' & '__tcp_v4_hash' > because these are called outside of tcp_ipv4.c from the TOM driver. There is no way you're going to be allowed to call such deep TCP intern

[PATCH] TCP Offload (TOE) - Chelsio

2005-08-11 Thread Scott Bardone
"OPEN TOE" submission from Chelsio Communications. The following items have been addressed: - cleaned up indentation. - cleaned up comments. - cleaned up c-styles. - using EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL - removed 2.4 compatibility. - created TCP_OFFLOAD config option. - moved #defines

Re: Doubt in kernel packet generation

2005-08-11 Thread Evgeniy Polyakov
On Fri, Aug 12, 2005 at 09:33:13AM +0530, varun ([EMAIL PROTECTED]) wrote: > Hi all, > > I have a major doubt regarding how to generate my own icmp > packet from the kernel space. That is iam aware of raw sockets and > packet sockets but thats from user space. I want one of my kernel mod

Re: argh... ;/

2005-08-11 Thread Chris Wedgwood
On Fri, Aug 05, 2005 at 01:20:59PM -0400, John W. Linville wrote: > Yes. Opening attachments makes them harder to review. Lots of people can't inline patches because they are inflicted with crappy MUAs --- I would much prefer patches as attachments in those cases versus mangled patches. Also, I

Re: [RFC] Net vm deadlock fix, version 6

2005-08-11 Thread Daniel Phillips
Ahem: + } adjust_memalloc_reserve(-netdev->memalloc_pages); - } Regards, Daniel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-11 Thread Patrick McHardy
Harald Welte wrote: +/* 64bit divisor, dividend and result. dynamic precision */ +static u_int64_t div64_64(u_int64_t divisor, u_int64_t dividend) +{ + u_int64_t result = divisor; + + if (dividend > 0x) { + int first_bit = find_first_bit((unsigned long *) ÷nd, s

Re: Super TSO performance drop

2005-08-11 Thread David S. Miller
From: Dmitry Yusupov <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 16:30:49 -0700 > But even with new TSO schema, this logic can not send more than > MAX_SKB_FRAGS which at best case ~60K. With old TSO schema. > I thought with SuperTSO we could send >> than 60K. And than it could be > very beneficial

Re: Super TSO performance drop

2005-08-11 Thread Dmitry Yusupov
On Thu, 2005-08-11 at 16:15 -0700, David S. Miller wrote: > From: "Leonid Grossman" <[EMAIL PROTECTED]> > Date: Thu, 11 Aug 2005 19:05:22 -0400 > > > Basically, it looks like with SuperTSO most of the traffic in our tests > > comes down to the driver with mss 0 (TSO is mostly "off"). > > With the

Re: Super TSO performance drop

2005-08-11 Thread David S. Miller
From: "Leonid Grossman" <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 19:05:22 -0400 > Basically, it looks like with SuperTSO most of the traffic in our tests > comes down to the driver with mss 0 (TSO is mostly "off"). > With the original TSO, is was always "on" (see below). > Could you describe how

RE: Super TSO performance drop

2005-08-11 Thread Leonid Grossman
> -Original Message- > From: David S. Miller [mailto:[EMAIL PROTECTED] > Sent: Friday, August 05, 2005 1:19 AM > To: Leonid Grossman > Cc: netdev@vger.kernel.org > Subject: Re: Super TSO performance drop > I'm not talking about the application, I'm talking about the > new kernel segme

Re: [PATCH] Make skb->protocol __be16

2005-08-11 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 19:49:48 +0400 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, but I may defer this to 2.6.14, we'll see. Also, please properly "-p1" root your patch next time. > --- linux.orig/linux-sparse/include/linux/skbuff.h

Re: [PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread Harald Welte
On Fri, Aug 12, 2005 at 07:46:55AM +1000, Herbert Xu wrote: > Ingo Oeser <[EMAIL PROTECTED]> wrote: > > > > What about using a brace more: > > > >>diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h > >>--- a/include/linux/netfilter.h > >>+++ b/include/linux/netfilter.h > >>@@ -29,

Re: [PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 12 Aug 2005 07:46:55 +1000 > Actually, these two versions are different. & is higher than | so > Harald's version is actually > > #define NF_QUEUE_NR(x) (((x << NF_VERDICT_QBITS) & NF_VERDICT_QMASK) | > NF_QUEUE) > > Which is it? It's the forme

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-11 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 22:03:49 +0200 > +struct ipt_connbytes_info > +{ > + struct { > + u_int64_t from; /* count to be matched */ > + u_int64_t to; /* count to be matched */ > + } count; > + u_int8_t what; /* ip

[RFC] Net vm deadlock fix, version 6

2005-08-11 Thread Daniel Phillips
Hi, This version corrects a couple of bugs previously noted and ties up some loose ends in the e1000 driver. Some versions of this driver support packet splitting into multiple pages, with just the protocol header in the skb itself. This is a very good thing because it avoids the high order page

Re: [PATCH 1/2] make nf_log compile with PROC_FS == n

2005-08-11 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 09:12:43 +0200 > [NETFILTER] Fix compilation when no PROC_FS enabled > > Signed-off-by: Harald Welte <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

Re: [PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 09:13:21 +0200 > [NETFILTER] Fix NF_QUEUE_NR() macro > > I obviously wanted to use bitwise-or, not logical or. > > Signed-off-by: Harald Welte <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH] Gianfar PHY Layer Update

2005-08-11 Thread Andy Fleming
Hmmm I just did an update, and tried applying first the PHY Layer patch, and then the Gianfar PHY Layer patch. It worked fine for me. Did you apply the the 7/28 patch: [PATCH] sysfs feature enablement for gianfar? Because that patch would screw up the PHY patch for gianfar (I sent a

Re: [PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread Herbert Xu
Ingo Oeser <[EMAIL PROTECTED]> wrote: > > What about using a brace more: > >>diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h >>--- a/include/linux/netfilter.h >>+++ b/include/linux/netfilter.h >>@@ -29,7 +29,7 @@ >> #define NF_VERDICT_QMASK 0x >> #define NF_VERDICT_QBIT

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-11 Thread Herbert Xu
Balazs Scheidler <[EMAIL PROTECTED]> wrote: > > Shall I panic in this case? Yes please. Just panic at the spot where the allocation fails rather than going up. BTW, you should CC davem if you'd like to see your patch included. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbe

Re: [resend][PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH to zero

2005-08-11 Thread Jeff Garzik
applied patches 1-9 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[resend][PATCH net-drivers-2.6 9/9] ixgb: Driver version, white space, comments

2005-08-11 Thread Malli Chilakala
Driver version, white space, comments & added Module_version Patch from linville Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c

[resend][PATCH net-drivers-2.6 8/9] ixgb: Redefined buffer_info-dma to be dma_addr_t instead of uint64

2005-08-11 Thread Malli Chilakala
Redefined buffer_info-dma to be dma_addr_t instead of uint64 Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb.h netdev-2.6.new/drivers/net/ix

[resend][PATCH net-drivers-2.6 7/9] ixgb: Remove unused functions

2005-08-11 Thread Malli Chilakala
Remove unused functions, render some variable static instead of global - based on patch from Adrian Bunk Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/

[resend][PATCH net-drivers-2.6 6/9] ixgb: Ethtool cleanup patch from Stephen Hemminger

2005-08-11 Thread Malli Chilakala
Ethtool cleanup patch from Stephen Hemminger * use ADVERTISED_xxx fields when setting advertised fields Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/

[resend][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by ethtool -d

2005-08-11 Thread Malli Chilakala
Fix data output by ethtool -d Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6.new/drivers/net/ixgb/ixgb_ethtool.c ---

[resend][PATCH net-drivers-2.6 3/9] ixgb: Use netdev_priv() instead of netdev->priv

2005-08-11 Thread Malli Chilakala
Use netdev_priv() instead of netdev->priv Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6.new/drivers/net/ixgb/ixgb_eth

[resend][PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH to zero

2005-08-11 Thread Malli Chilakala
Set RXDCTL:PTHRESH/HTHRESH to zero Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_main.c netdev-2.6.new/drivers/net/ixgb/ixgb_main.c --- n

[resend][PATCH net-drivers-2.6 0/9] ixgb: driver update

2005-08-11 Thread Malli Chilakala
ixgb: driver update Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> 1. Set RXDCTL:PTHRESH/HTHRESH to zero 2. Dmesg will now no longer fill up with "link up" messages without a corre

[resend][PATCH net-drivers-2.6 2/9] ixgb: Fix unnecessary link state messages

2005-08-11 Thread Malli Chilakala
Fix unnecessary link state messages Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6.new/drivers/net/ixgb/ixgb_ethtool.c

[resend][PATCH net-drivers-2.6 4/9] ixgb: Fix Broadcast/Multicast packets received statistics

2005-08-11 Thread Malli Chilakala
Fix Broadcast/Multicast packets received statistics Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_main.c netdev-2.6.new/drivers/net/ixgb/i

[PATCH] add new iptables ipt_connbytes match

2005-08-11 Thread Harald Welte
Hi Dave, please apply to your net-2.6.14 tree: -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ "Fragmentation is like classful addressing -- an interesting early architectural error that

Re: net-2.6.14 to be rebased

2005-08-11 Thread Harald Welte
On Thu, Aug 11, 2005 at 12:40:48PM -0700, David S. Miller wrote: > What I do is I extract all of the patches out of the net-2.6.14 > tree, then apply them one-by-one into a fresh copy of Linus's tree, > then replace the tree on kernel.org with the new one. ouch. > I even go one step further and

Re: [PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread Harald Welte
On Thu, Aug 11, 2005 at 04:31:24PM +0200, Ingo Oeser wrote: > Harald Welte wrote: > > Hi Dave, please apply! > > What about using a brace more: I wouldn't mind the extra brace, but I don't want to make this more difficult for Dave. So it's his call whether he would manually edit the line before

Re: [PATCH] sockaddr_ll change for IPoIB interface

2005-08-11 Thread David S. Miller
From: Hal Rosenstock <[EMAIL PROTECTED]> Date: 11 Aug 2005 14:48:37 -0400 > The patch below is to accomodate IPoIB link layer address in the > sockaddr_ll struct so that user space can send and receive IPoIB link > later packets. Unfortunately, IPoIB has 20 bytes LL addresses rather > than the 8 b

Re: net-2.6.14 to be rebased

2005-08-11 Thread David S. Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 13:22:58 -0400 > Personally, I -hope- it's a merge. It's not, I absolutely do not want those ugly branches in my tree history just because I felt like rebasing. I want a clean tree, and also it gives me the opportunity to combine bug f

Re: net-2.6.14 to be rebased

2005-08-11 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 18:44:30 +0200 > On Tue, Aug 09, 2005 at 06:23:33PM -0700, David S. Miller wrote: > > I want some net bug fixes in Linus's tree to propagate into the > > net-2.6.14 tree so I plan to rebase it this evening, so please be > > careful when

[PATCH 2/2] LSM-IPSec Networking Hooks -- Minor mods

2005-08-11 Thread jaegert
I have made some modifications to the SELinux part of this patch as well. These fall into three categories: (1) removed unnecessary <0 checks on unsigned ints (2) converted sec_ctx variables to uctx since the latter is used for variables of the xfrm_user_sec_ctx data type (3) check for the alg ra

[PATCH 1/2] LSM-IPSec Networking Hooks -- mods based on Herbert's comments

2005-08-11 Thread jaegert
This patch has been modified based on Herbert's comments. I also added explicit length checking code to xfrm_user.c based on Herbert's comments in the rest of the code. Most of the other modifications are deletions of unnecessary checks per Herbert's identification. Regards, Trent. ==

Re: 2.6.13-rc5 panic with tg3, e1000, vlan, tso

2005-08-11 Thread David S. Miller
From: "Vladimir B. Savkin" <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 15:48:36 +0400 > Today my gateway crashed. Known problem, please try Linus's current tree as we've made a bug fix since -rc5 that we think fixes this bug. - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [patch] net/tulip: LAN driver for ULI M5261/M5263

2005-08-11 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Jeff: I have removed the uli526x support from tulip core driver,check the patch file for detail,thanks. Patch applied, thanks! Alexey: Here the new patch,please check it, thanks. (See attached file: patchuli526x) Please submit a patch -incremental- to the original

[PATCH] sockaddr_ll change for IPoIB interface

2005-08-11 Thread Hal Rosenstock
Hi, This is a repost of a patch which was posted last week which appears to have been lost in the shuffle. The patch below is to accomodate IPoIB link layer address in the sockaddr_ll struct so that user space can send and receive IPoIB link later packets. Unfortunately, IPoIB has 20 bytes LL add

Re: net-2.6.14 to be rebased

2005-08-11 Thread Jeff Garzik
Harald Welte wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Dave! On Tue, Aug 09, 2005 at 06:23:33PM -0700, David S. Miller wrote: I want some net bug fixes in Linus's tree to propagate into the net-2.6.14 tree so I plan to rebase it this evening, so please be careful when sync'ing w

Re: net-2.6.14 to be rebased

2005-08-11 Thread Harald Welte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Dave! On Tue, Aug 09, 2005 at 06:23:33PM -0700, David S. Miller wrote: > I want some net bug fixes in Linus's tree to propagate into the > net-2.6.14 tree so I plan to rebase it this evening, so please be > careful when sync'ing with my tree over t

[PATCH] Make skb->protocol __be16

2005-08-11 Thread Alexey Dobriyan
There are many instances of skb->protocol = htons(ETH_P_*); skb->protocol = __constant_htons(ETH_P_*); and skb->protocol = *_type_trans(...); Most of *_type_trans() are already endian-annotated, so, let's shift attention on other warnings. Signed-off-by: Alexey Dobriyan <

Re: [PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread Ingo Oeser
Harald Welte wrote: > Hi Dave, please apply! What about using a brace more: >diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h >--- a/include/linux/netfilter.h >+++ b/include/linux/netfilter.h >@@ -29,7 +29,7 @@ > #define NF_VERDICT_QMASK 0x > #define NF_VERDICT_QBITS 16

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-11 Thread Balazs Scheidler
On Thu, 2005-08-11 at 14:44 +0200, Balazs Scheidler wrote: > On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote: > > Balazs Scheidler <[EMAIL PROTECTED]> wrote: > > > > > > I've attached a revised patch, this time with complete error checking, > > > and > > > propagating the error code to the ca

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-11 Thread Balazs Scheidler
On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote: > Balazs Scheidler <[EMAIL PROTECTED]> wrote: > > > > I've attached a revised patch, this time with complete error checking, and > > propagating the error code to the caller. Please apply. > > Sorry, but it seems that you've left out the bits t

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-11 Thread Herbert Xu
Balazs Scheidler <[EMAIL PROTECTED]> wrote: > > I've attached a revised patch, this time with complete error checking, and > propagating the error code to the caller. Please apply. Sorry, but it seems that you've left out the bits that check the return value from xfrm_init()? Thanks, -- Visit O

Re: 2.6.13-rc5 panic with tg3, e1000, vlan, tso

2005-08-11 Thread Herbert Xu
Vladimir B. Savkin <[EMAIL PROTECTED]> wrote: > > Today my gateway crashed. > I wrote down crash info on a paper. > It's not complete since only last 25 lines were shown, > but complete stackdump is here (I omitted hexadecimal values). > > Call Trace: >tcp_write_xmit+318 This should be fixe

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-11 Thread Balazs Scheidler
On Mon, 2005-08-08 at 16:27 +0200, Balazs Scheidler wrote: > Is this tiny patchlet worth the trouble of changing > xfrm_init/xfrm_state_init to return int, and do error checking from > ip_rt_init() ? I've attached a revised patch, this time with complete error checking, and propagating the error

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-11 Thread Philippe De Muyter
I wrote : > I just noticed something at the end of process_input_packet : > In the normal case, skb is given to the next stage and ap->rpkt is reset, > but in the error case, skb is kept, ap->rpkt is not reset, so we keep > the skb with skb->data aligned for one message and we put another one > int

[PATCH 1/2] make nf_log compile with PROC_FS == n

2005-08-11 Thread Harald Welte
Hi Dave, please apply! -- - Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/ "Privacy in residential applications is a desirable marketing option."

[PATCH 2/2] fix NF_QUEUE_NR() macro

2005-08-11 Thread Harald Welte
Hi Dave, please apply! -- - Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/ "Privacy in residential applications is a desirable marketing option."