Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 18:53 -0700, Matt Mackall wrote: > On Fri, Aug 05, 2005 at 08:23:55PM -0400, Steven Rostedt wrote: [...] > > If you need to really get the data out, then the design should be > > changed. Have some return value showing the failure, check for > > oops_in_progress or whatever,

Re: assertion (cnt <= tp->packets_out) failed

2005-08-05 Thread Herbert Xu
On Fri, Aug 05, 2005 at 09:32:08AM -0700, David S. Miller wrote: > > It therefore may be desirable to keep Herbert's fix in there, but > back out my changes until they can be reimplemented correctly. > > Herbert? Sure. Let's back it out until a better solution is found. -- Visit Openswan at ht

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 08:23:55PM -0400, Steven Rostedt wrote: > On Fri, 2005-08-05 at 14:28 -0700, Matt Mackall wrote: > > > > Netpoll generally must assume it won't get a second chance, as it's > > being called by things like oops() and panic() and used by things like > > kgdb. If netpoll fails

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Daniel Phillips
On Saturday 06 August 2005 11:22, Matt Mackall wrote: > On Sat, Aug 06, 2005 at 01:51:22AM +0200, Andi Kleen wrote: > > > But why are we in a hurry to dump the backlog on the floor? Why are we > > > worrying about the performance of netpoll without the cable plugged in > > > at all? We shouldn't be

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Sat, Aug 06, 2005 at 01:51:22AM +0200, Andi Kleen wrote: > > But why are we in a hurry to dump the backlog on the floor? Why are we > > worrying about the performance of netpoll without the cable plugged in > > at all? We shouldn't be optimizing the data loss case. > > Because a system shouldn'

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:51:18PM +0200, Andi Kleen wrote: > > > If that was the policy it would be a quite dumb one and make netpoll > > > totally unsuitable for production use. I hope it is not. > > > > Suggest you rip __GFP_NOFAIL out of JBD before complaining about this. > > So you're sugges

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 23:26 +0200, Andi Kleen wrote: > I suspect Steven's patch for the e1000 is needed in addition to > handle different cases too. > I haven't tested it. Someone with a e1000 must see if it works. I submitted the e100 fix that had the same problem, but I would feel better if th

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 14:28 -0700, Matt Mackall wrote: > > Netpoll generally must assume it won't get a second chance, as it's > being called by things like oops() and panic() and used by things like > kgdb. If netpoll fails, the box is dead anyway. > But it is also being called by every printk

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
> But why are we in a hurry to dump the backlog on the floor? Why are we > worrying about the performance of netpoll without the cable plugged in > at all? We shouldn't be optimizing the data loss case. Because a system shouldn't stall for minutes (or forever like right now) at boot just because

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:56:50PM +0200, Andi Kleen wrote: > > I still don't like this fix. Yes, you're right, it should eventually > > give up. But here it gives up way too easily - 5 could easily > > translate to 5 microseconds. This is analogous to giving up on serial > > transmit if CTS is dow

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Andi Kleen
> > If that was the policy it would be a quite dumb one and make netpoll > > totally unsuitable for production use. I hope it is not. > > Suggest you rip __GFP_NOFAIL out of JBD before complaining about this. So you're suggesting we should become as bad at handling networking errors as we are at

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:26:10PM +0200, Andi Kleen wrote: > On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote: > > The netpoll philosophy is to assume that its traffic is an absolute > > priority - it is better to potentially hang trying to deliver a panic > > message than to give up a

Re: ICMP broken in 2.6.13-rc5

2005-08-05 Thread Vladimir B. Savkin
On Fri, Aug 05, 2005 at 07:43:25PM +0200, Harald Welte wrote: > On Wed, Aug 03, 2005 at 03:50:15PM +0400, Vladimir B. Savkin wrote: > > Hello! > > > > When trying to upgrade a gateway from old 2.6.10-rc2 to > > new 2.6.13-rc5, I noticed a flood of messages like > > "172.16.12.1 sent an invalid IC

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
> I still don't like this fix. Yes, you're right, it should eventually > give up. But here it gives up way too easily - 5 could easily > translate to 5 microseconds. This is analogous to giving up on serial > transmit if CTS is down for 5 loops. > > I'd be much happier if there were some udelay or

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Andi Kleen
On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote: > The netpoll philosophy is to assume that its traffic is an absolute > priority - it is better to potentially hang trying to deliver a panic > message than to give up and crash silently. That would be ok if netpoll was only used to del

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 04:57:00PM -0400, Steven Rostedt wrote: > On Fri, 2005-08-05 at 13:01 -0700, Matt Mackall wrote: > > On Fri, Aug 05, 2005 at 10:36:31AM -0400, Steven Rostedt wrote: > > > Looking at the netpoll routines, I noticed that the find_skb could > > > lockup if the memory is low. Th

error about rp_filter

2005-08-05 Thread Sam Ravnborg
Hi Adrian. This is better suited for netdev, so I've forwarded your mail there. [It was originally sent to kbuild-devel] Sam On Fri, Aug 05, 2005 at 06:44:59PM +0300, Adrian Buciuman wrote: > Hello, > > rp-filter is default off (see ip-sysctl.txt and proc.txt or test it), > but comments

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 13:01 -0700, Matt Mackall wrote: > On Fri, Aug 05, 2005 at 10:36:31AM -0400, Steven Rostedt wrote: > > Looking at the netpoll routines, I noticed that the find_skb could > > lockup if the memory is low. This is because the allocations are > > called with GFP_ATOMIC (since this

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 01:45:55PM +0200, Andi Kleen wrote: > John B?ckstrand <[EMAIL PROTECTED]> writes: > > > I've been trying to hunt down a hard lockup issue with some hardware > > of mine, but I've possibly hit a kernel bug instead. When using > > netconsole on my e1000, if I unplug the cable

Re: [PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 10:36:31AM -0400, Steven Rostedt wrote: > Looking at the netpoll routines, I noticed that the find_skb could > lockup if the memory is low. This is because the allocations are > called with GFP_ATOMIC (since this is in interrupt context) and if > it fails, it will continue t

Re: latest netdev tree - (broadcom44 bug?) letting you know...

2005-08-05 Thread Mateusz Berezecki
On 8/5/05, Pekka Pietikainen <[EMAIL PROTECTED]> wrote: > I heard some rumors that someone recently broke ACPI (interrupt routing or > somesuch) and that broke b44 in some configs. Could be that. > Thanks a lot. Im going to try with ACPI turned off. all the best Mateusz - To unsubscribe from thi

Re: latest netdev tree - (broadcom44 bug?) letting you know...

2005-08-05 Thread Pekka Pietikainen
On Thu, Aug 04, 2005 at 11:51:02PM +0200, Mateusz Berezecki wrote: > Jeff Garzik wrote: > > > > >Nothing in that tree has changed the b44 driver... > > > > Ok, so I will try to find out what has changed as soon as I have some > more time > > also please ignore forwarded e-mail. I just upd

test

2005-08-05 Thread Daniel Phillips
On Saturday 06 August 2005 02:33, David S. Miller wrote: > You can't call into the networking packet input path from > hardware interrupt context, it simply is not allowed. > > And that's the context in which netif_rx() gets called. Duh. I assumed we already were in softirq context here (but with

Re: Bypass softnet

2005-08-05 Thread Daniel Phillips
On Saturday 06 August 2005 02:33, David S. Miller wrote: > You can't call into the networking packet input path from > hardware interrupt context, it simply is not allowed. > > And that's the context in which netif_rx() gets called. Duh. I assumed we already were in softirq context here (but with

[RESEND][PATCH net-drivers-2.6 2/9] ixgb: Fix unnecessary link state messages

2005-08-05 Thread Malli Chilakala
Fix unnecessary link state messages Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6/drivers/net/ixgb.new/ixgb_ethtool.c

[RESEND][PATCH net-drivers-2.6 0/9] ixgb: driver update

2005-08-05 Thread Malli Chilakala
ixgb: driver update Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> 1. Set RXDCTL:PTHRESH/HTHRESH to zero 2. Dmesg will now no longer fill up with "link up" messages without a corre

Re: argh... ;/

2005-08-05 Thread Daniel Phillips
On Saturday 06 August 2005 03:49, Dave Jones wrote: > On Fri, Aug 05, 2005 at 01:20:59PM -0400, John W. Linville wrote: > > On Sat, Aug 06, 2005 at 02:41:30AM +1000, Daniel Phillips wrote: > > > On Friday 05 August 2005 13:04, Mateusz Berezecki wrote: > > > > I accidentaly posted the patches as

Re: atheros driver - desc

2005-08-05 Thread Mateusz Berezecki
On 8/5/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > There is no document describing the API AFAIK. > > The best thing to do is read over the ipw2[12]00 drivers. > > Jeff Ok, thanks for pointing me there. best Mateusz - To unsubscribe from this list: send the line "unsubscribe netdev"

[RESEND][PATCH net-drivers-2.6 3/9] ixgb: Use netdev_priv() instead of netdev->priv

2005-08-05 Thread Malli Chilakala
Use netdev_priv() instead of netdev->priv Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6/drivers/net/ixgb.new/ixgb_eth

Re: atheros driver - desc

2005-08-05 Thread Jeff Garzik
Mateusz Berezecki wrote: And regarding that ieee80211 API, I would be very excited if anyone could explain the general overview of how new wireless API works. I read the source but sometimes a quick answer from experienced kernel coder would do more good. There is no document describing the A

[RESEND][PATCH net-drivers-2.6 8/9] ixgb: Redefined buffer_info-dma to be dma_addr_t instead of uint64

2005-08-05 Thread Malli Chilakala
Redefined buffer_info-dma to be dma_addr_t instead of uint64 Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb.h netdev-2.6/drivers/net/ixgb.n

Re: critical section violation in tg3.c?

2005-08-05 Thread Jeff Garzik
The call to pci_save_state(), and possibly the call to pci_set_drvdata(), should be moved above the register_netdev() call, to eliminate the race. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[RESEND][PATCH net-drivers-2.6 6/9] ixgb: Ethtool cleanup patch from Stephen Hemminger

2005-08-05 Thread Malli Chilakala
Ethtool cleanup patch from Stephen Hemminger * use ADVERTISED_xxx fields when setting advertised fields Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/

[RESEND][PATCH net-drivers-2.6 9/9] ixgb: Driver version, white space, comments

2005-08-05 Thread Malli Chilakala
Driver version, white space, comments & added Module_version Patch from linville Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c

[RESEND][PATCH net-drivers-2.6 7/9] ixgb: Remove unused functions

2005-08-05 Thread Malli Chilakala
Remove unused functions, render some variable static instead of global - based on patch from Adrian Bunk Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/

[RESEND][PATCH net-drivers-2.6 4/9] ixgb: Fix Broadcast/Multicast packets received statistics

2005-08-05 Thread Malli Chilakala
Fix Broadcast/Multicast packets received statistics Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_main.c netdev-2.6/drivers/net/ixgb.new/i

[RESEND][PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH to zero

2005-08-05 Thread Malli Chilakala
Set RXDCTL:PTHRESH/HTHRESH to zero Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_main.c netdev-2.6/drivers/net/ixgb.new/ixgb_main.c --- n

[RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by ethtool -d

2005-08-05 Thread Malli Chilakala
Fix data output by ethtool -d Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6/drivers/net/ixgb.new/ixgb_ethtool.c ---

RE: [PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH to zero

2005-08-05 Thread Chilakala, Mallikarjuna
I was able to find the problem, I'll resend the updated ones :) -Malli -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Sunday, June 26, 2005 9:37 PM To: Chilakala, Mallikarjuna Cc: Netdev List Subject: Re: [PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH

critical section violation in tg3.c?

2005-08-05 Thread Chris Elmquist
Folks, We have been battling a tough one here for a couple weeks. We think we have isolated it though and are seeking comments before we submit a patch. Here's the deal: tg3 driver v3.23 as packaged with SuSE SLES9 SP2 multiprocessor IA64 platform We were experiencing panic's during boot at a r

[PATCH] sockaddr_ll change for IPoIB interfaces

2005-08-05 Thread Hal Rosenstock
Hi, The patch below is to accomodate IPoIB link layer address in the sockaddr_ll struct so that user space can send and receive IPoIB link later packets. Unfortunately, IPoIB has 20 bytes LL addresses rather than the 8 byte MAC addresses (or under) used by other LLs. There is a similar change to

Re: atheros driver - desc

2005-08-05 Thread Mateusz Berezecki
On 09:46 Fri 05 Aug , Bryan O'Sullivan wrote: > On Fri, 2005-08-05 at 04:55 +0200, Mateusz Berezecki wrote: > > How far from working is it? I have a miniPCI Atheros card and would be > interested in helping out with bringing the driver up, but it would be > good to know what to expect first :

Re: ICMP broken in 2.6.13-rc5

2005-08-05 Thread Harald Welte
On Wed, Aug 03, 2005 at 03:50:15PM +0400, Vladimir B. Savkin wrote: > Hello! > > When trying to upgrade a gateway from old 2.6.10-rc2 to > new 2.6.13-rc5, I noticed a flood of messages like > "172.16.12.1 sent an invalid ICMP type 11, code 0 error to a broadcast: > 0.0.0.0" > Source IP is always

Re: argh... ;/

2005-08-05 Thread Dave Jones
On Fri, Aug 05, 2005 at 01:20:59PM -0400, John W. Linville wrote: > On Sat, Aug 06, 2005 at 02:41:30AM +1000, Daniel Phillips wrote: > > On Friday 05 August 2005 13:04, Mateusz Berezecki wrote: > > > I accidentaly posted the patches as MIME attachments... its 5:03 am here > > > Does anybody s

Re: atheros driver - desc

2005-08-05 Thread Jeff Garzik
Mateusz Berezecki wrote: Hi list members, I just post the code for review for anyone interested. I would be more than pleased to hear some feedback from you on the code. Im sending a series of 8 patches splitted and diffed as in SubmittingPatches documentation. The driver is not yet fully wo

Re: argh... ;/

2005-08-05 Thread Jeff Garzik
John W. Linville wrote: On Sat, Aug 06, 2005 at 02:41:30AM +1000, Daniel Phillips wrote: On Friday 05 August 2005 13:04, Mateusz Berezecki wrote: I accidentaly posted the patches as MIME attachments... its 5:03 am here Does anybody still care if patches are posted as attachments, particula

Re: argh... ;/

2005-08-05 Thread John W. Linville
On Sat, Aug 06, 2005 at 02:41:30AM +1000, Daniel Phillips wrote: > On Friday 05 August 2005 13:04, Mateusz Berezecki wrote: > > I accidentaly posted the patches as MIME attachments... its 5:03 am here > Does anybody still care if patches are posted as attachments, particularly > for > review as

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-05 Thread Harald Welte
On Fri, Aug 05, 2005 at 06:37:09PM +0200, Harald Welte wrote: > Ok, I'll extend nfnetlink_log.c to add TLV's for those two fields in > case CONFIG_BRIDGE_NF is set. I'll send a patch later tonight. What about the following (only compile-tested) patch ? [NETFILTER] add phys{in,out}dev support to

Re: atheros driver - desc

2005-08-05 Thread Bryan O'Sullivan
On Fri, 2005-08-05 at 04:55 +0200, Mateusz Berezecki wrote: > The driver is not yet fully working because I didn't finish kernel > integration yet. How far from working is it? I have a miniPCI Atheros card and would be interested in helping out with bringing the driver up, but it would be good

Re: skge: ignoring bogus sensor interrups

2005-08-05 Thread Daniel Drake
Stephen Hemminger wrote: On Sat, 30 Jul 2005 01:46:13 +0100 Daniel Drake <[EMAIL PROTECTED]> wrote: Hi, its your favourite bug reporter again ;) A Gentoo user (on CC) has reported many of these messages appearing: skge ignoring bogus sensor interrups They appear so frequently that 3

Re: argh... ;/

2005-08-05 Thread Daniel Phillips
On Friday 05 August 2005 13:04, Mateusz Berezecki wrote: > I accidentaly posted the patches as MIME attachments... its 5:03 am here > already. Sorry guys. > I can resubmit if you want. I just dont want do that now and not trash > your mailboxes Does anybody still care if patches are posted as atta

Re: [PATCH] ctnetlink: fix conntrack expect refcount leak

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:28:20 +0200 > [NETFILTER] fix conntrack refcount leak in unlink_expect() Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH] ctnetlink: fix typo in ctnl_exp_cb array

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:21:42 +0200 > [NETFILTER] Fix typo in ctnl_exp_cb array (no bug, just memory waste) Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH] ctnetlink: fix list traversal order

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:26:50 +0200 > [NETFILTER] fix list traversal order in ctnetlink Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] ctnetlink: make sure event order is correct

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:27:38 +0200 > [NETFILTER] ctnetlink: make sure event order is correct Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-05 Thread Harald Welte
On Fri, Aug 05, 2005 at 11:26:07AM +, Bart De Schuymer wrote: > I don't think your patch will satisfy the simple and rational demand of > people using userspace logging on a bridging firewall: they like to know > what bridge port the packet arrived at/will leave by. These are the > physindev a

Re: Bypass softnet

2005-08-05 Thread David S. Miller
You can't call into the networking packet input path from hardware interrupt context, it simply is not allowed. And that's the context in which netif_rx() gets called. That is why netif_rx() just queues, and schedules a software interrupt in which the netif_receive_skb() call gets made. - To uns

Re: assertion (cnt <= tp->packets_out) failed

2005-08-05 Thread David S. Miller
From: John Bäckstrand <[EMAIL PROTECTED]> Date: Fri, 05 Aug 2005 17:53:11 +0200 > KERNEL: assertion (cnt <= tp->packets_out) failed at > net/ipv4/tcp_input.c (1476) I suspect this is a side effect of some changes Herbert Xu and myself did to fix some other bugs. Herbert, I think there are serio

[PATCH] ctnetlink: make sure event order is correct

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] ctnetlink: make sure event order is correct The following sequence is displayed during events dumping of an ICMP connection: [NEW] [DESTROY] [UPDATE] This happens because the event IPCT_DESTROY is delivered in death_by_timeout(), that is called from the icmp pr

[PATCH] ctnetlink: fix typo in ctnl_exp_cb array

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] Fix typo in ctnl_exp_cb array (no bug, just memory waste) This fixes the size of the ctnl_exp_cb array that is IPCTNL_MSG_EXP_MAX instead of IPCTNL_MSG_MAX. Simple typo. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PR

[PATCH] ctnetlink: fix conntrack expect refcount leak

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] fix conntrack refcount leak in unlink_expect() In unlink_expect(), the expectation is removed from the list so the refcount must be dropped as well. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit

[PATCH] ctnetlink: fix list traversal order

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] fix list traversal order in ctnetlink Currently conntracks are inserted after the head. That means that conntracks are sorted from the biggest to the smallest id. This happens because we use list_prepend (list_add) instead list_add_tail. This can result in probl

Bypass softnet

2005-08-05 Thread Daniel Phillips
Hi, OK, I am still a network klutz. The attached patch changes netif_rx to call netif_receive_skb directly instead of going through softnet. It works with my e1000 here, but eventually oopses under moderate load. I see that a few drivers use netif_receive_skb directly, sometimes together wit

assertion (cnt <= tp->packets_out) failed

2005-08-05 Thread John Bäckstrand
I get KERNEL: assertion (cnt <= tp->packets_out) failed at net/ipv4/tcp_input.c (1476) with 2.6.13-rc5, also with a small netpoll patch that shouldnt affect these things. (Topic: "lockups with netconsole on e1000 on media insertion"). I have a decent amount of dropped/overruns: eth2

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 07:36 -0700, David S. Miller wrote: > From: Steven Rostedt <[EMAIL PROTECTED]> > Date: Fri, 05 Aug 2005 10:27:06 -0400 > > > Darn it, since this should really be reported. Yes, the core netpoll > > should bail out, but it is also a problem with the driver and should be > > f

[PATCH] netpoll can lock up on low memory.

2005-08-05 Thread Steven Rostedt
Looking at the netpoll routines, I noticed that the find_skb could lockup if the memory is low. This is because the allocations are called with GFP_ATOMIC (since this is in interrupt context) and if it fails, it will continue to fail. This is just by observing the code, I didn't have this actually

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread David S. Miller
From: Steven Rostedt <[EMAIL PROTECTED]> Date: Fri, 05 Aug 2005 10:27:06 -0400 > Darn it, since this should really be reported. Yes, the core netpoll > should bail out, but it is also a problem with the driver and should be > fixed. I don't get how you can even remotely claim this to be a proble

Re: [BUG?]memory leakage in fib_create_info()?

2005-08-05 Thread David S. Miller
From: Yan Zheng <[EMAIL PROTECTED]> Date: Fri, 05 Aug 2005 22:27:11 +0800 > Kernel: linux-2.6.12.3 > Keywords: IPv4 Forwarding Information Base > > Function fib_create_info(in net/ipv4/fib_semantics.c) do not free memory > used by old hash table after enlarge fib_info hash table. Is this a bug?

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 16:14 +0200, Andi Kleen wrote: > On Fri, Aug 05, 2005 at 10:10:13AM -0400, Steven Rostedt wrote: > > On Fri, 2005-08-05 at 15:55 +0200, Andi Kleen wrote: > > > > This is fixing the symptom and is not the cure. Unfortunately I don't > > > > have a e1000 card so I can't try a f

[BUG?]memory leakage in fib_create_info()?

2005-08-05 Thread Yan Zheng
Kernel: linux-2.6.12.3 Keywords: IPv4 Forwarding Information Base Function fib_create_info(in net/ipv4/fib_semantics.c) do not free memory used by old hash table after enlarge fib_info hash table. Is this a bug? give me a replay please!

[patch 4/8] atheros driver - eeprom routines

2005-08-05 Thread Mateusz Berezecki
resending patch 4/8 as it was reported missing diff -uprN -X 'netdev-2.6.git#ieee80211/Documentation/dontdiff' netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/eeprom.c netdev-atheros/drivers/net/wireless/atheros/atheros5212/eeprom.c --- netdev-2.6.git#ieee80211/drivers/net/wirel

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
On Fri, Aug 05, 2005 at 10:10:13AM -0400, Steven Rostedt wrote: > On Fri, 2005-08-05 at 15:55 +0200, Andi Kleen wrote: > > > This is fixing the symptom and is not the cure. Unfortunately I don't > > > have a e1000 card so I can't try a fix. But I did have a e100 card that > > > would lock up the s

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 15:55 +0200, Andi Kleen wrote: > > This is fixing the symptom and is not the cure. Unfortunately I don't > > have a e1000 card so I can't try a fix. But I did have a e100 card that > > would lock up the same way. The problem was that netpoll_poll calls the > > cards netpoll

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
> This is fixing the symptom and is not the cure. Unfortunately I don't > have a e1000 card so I can't try a fix. But I did have a e100 card that > would lock up the same way. The problem was that netpoll_poll calls the > cards netpoll routine (in e1000_main.c e1000_netpoll). In the e100 > case,

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 13:45 +0200, Andi Kleen wrote: > John Bäckstrand <[EMAIL PROTECTED]> writes: > > > I've been trying to hunt down a hard lockup issue with some hardware > > of mine, but I've possibly hit a kernel bug instead. When using > > netconsole on my e1000, if I unplug the cable and th

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread John Bäckstrand
Andi Kleen wrote: The patch was for 2.6.12, did a quick untested port to 2.6.13rc5. -Andi Only try a limited number to send packets in netpoll Thanks, worked nicely! --- John Bäckstrand - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
John Bäckstrand <[EMAIL PROTECTED]> writes: > I've been trying to hunt down a hard lockup issue with some hardware > of mine, but I've possibly hit a kernel bug instead. When using > netconsole on my e1000, if I unplug the cable and then re-plug it, the > machine locks up hard. It manages to print

Re: [PATCH] IPSec anti-replay sequence numbers

2005-08-05 Thread KOVACS Krisztian
Hi, On Friday 05 August 2005 12.50, Patrick McHardy wrote: > Is there already userspace code which uses this feature somewhere? AFAIK Ulrich has a patch for OpenSWAN, and we (Balabit) have a patch for racoon. Unfortunately this racoon version is available only as a commercial product. --

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-05 Thread Bart De Schuymer
Op zo, 31-07-2005 te 09:05 +0200, schreef Harald Welte: > On Sat, Jul 30, 2005 at 09:04:23PM -0700, David S. Miller wrote: > > > > attached is a patch that converts ebt_ulog to use the generic logging > > > mechanism (and thus be able to use the nfnetlink_log backend). > > > > > > This patch bre

Re: [PATCH] IPSec anti-replay sequence numbers

2005-08-05 Thread Patrick McHardy
Ulrich Weber wrote: > KOVACS Krisztian wrote: > > >>>Ulrich, I already have some code which supports per-state >>>difference settings, along with optional time limits. I don't know >>>whether or not the latter would be necessary or not, but putting >>>the per-state diff values would be trivial. I

Re: oops with 2.6.13-rc5 on webserver with raid

2005-08-05 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Subject: Fw: oops with 2.6.13-rc5 on webserver with raid Date: Fri, 5 Aug 2005 03:20:41 -0700 > Did we fix this today? Yeah, looks like the same exact oops trace. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Fw: oops with 2.6.13-rc5 on webserver with raid

2005-08-05 Thread Andrew Morton
Did we fix this today? Begin forwarded message: Date: Fri, 05 Aug 2005 11:52:15 +0200 From: Martin Braun <[EMAIL PROTECTED]> To: linux-kernel@vger.kernel.org Subject: oops with 2.6.13-rc5 on webserver with raid Hi, I've been trying to upgrade kernel to 2.6.13-rc5. The server boots normally w

Re: atheros driver - desc

2005-08-05 Thread Michael Renzmann
Hi. Mateusz Berezecki wrote: > Im sending a series of 8 patches splitted and diffed as in > SubmittingPatches documentation. Patch 4/8 is missing here. Bye, Mike -- Use PGP/GPG! My key: http://keys.indymedia.org/cgi-bin/lookup?op=get&search=62C29B94 Fingerprint: BC2E 79BF 0C8F 0282 864B 9CEC 83

Re: [PATCH 0/6] nfnetlink / ctnetlink fixes + updates

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Tue, 2 Aug 2005 12:54:27 +0200 > I know you're travelling, but I already have this pile of patches/fixes > for nfnetlink and ctnetlink. I'm sorry to keep patch-bombing you, but > I think it's better we find those issues right now (before it is in mainl

Re: [TCP]: Fix TSO cwnd caching bug

2005-08-05 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 10:57:41 +1000 > OK, here is the final version. It depends on the patch that David > posted earlier on in this thread. Please let me know if you need a > copy of that. > > [TCP]: Fix TSO cwnd caching bug Good catch Herbert :) - To unsu

Re: Super TSO performance drop

2005-08-05 Thread David S. Miller
From: "Leonid Grossman" <[EMAIL PROTECTED]> Date: Thu, 4 Aug 2005 16:10:30 -0400 > I'm not sure there is anything specific about ntttcp packet patterns, > it's a generic tcp benchmark... > We did not try iperf or netperf, but typically these programs perform > extremely close to ntttcp numbers. I