On Fri, 13 Jun 2025 07:55:17 GMT, Volkan Yazici wrote:
>> Removes following files added in
>> [JDK-8235459](https://bugs.openjdk.org/browse/JDK-8235459) and are forgotten
>> to be removed during the `SecurityManager`-removal
>> ([JDK-8344228](https://bugs.openjdk.org/browse/JDK-8344228)):
>>
green with tiers 1, 2, 3 and the test is stable.
p-nima has updated the pull request incrementally with one additional commit
since the last revision:
apply review feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25490/files
- new: https://git.openjdk.org/jdk/pull
On Fri, 30 May 2025 09:06:00 GMT, Volkan Yazici wrote:
>> p-nima has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> apply review feedback
>
> test/jdk/java/net/httpclient/HttpClientRetryLimi
green with tiers 1, 2, 3 and the test is stable.
p-nima has updated the pull request incrementally with one additional commit
since the last revision:
update summary
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25490/files
- new: https://git.openjdk.org/jdk/pull/25490/fil
On Wed, 28 May 2025 11:26:17 GMT, p-nima wrote:
> The AuthenticationFilter did not respect the default retry limit of 3 retries
> in case of invalid credentials supplied.
>
> This PR helps to resolve the bug and tests it with default and updated retry
>
The AuthenticationFilter did not respect the default retry limit of 3 retries
in case of invalid credentials supplied.
This PR helps to resolve the bug and tests it with default and updated retry
limit set via `jdk.httpclient.auth.retrylimit=1`.
The test is green with tiers 1, 2, 3 and the test
On Wed, 28 May 2025 12:05:20 GMT, Mikhail Yankelevich
wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.ht
On Wed, 28 May 2025 13:40:42 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 34:
>>
>>> 32: * @build jdk.httpclient.test.lib.http2.Http2TestServer
>>> 33: * @run junit HttpClientRetryLimitTest
>>> 34: * @run junit/othervm -Djdk.httpclient.auth.retry
On Wed, 28 May 2025 14:07:37 GMT, Darragh Clarke wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 52:
>>
>>> 50:
>>> 51: private static final int DEFAULT_RETRY_LIMIT = 3;
>>> 52: private final int retryLimit =
>>> Integer.getInteger("jdk.httpclient.auth.retryli
On Wed, 28 May 2025 12:16:02 GMT, Volkan Yazici wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.httpclien
On Fri, 30 May 2025 14:42:11 GMT, Volkan Yazici wrote:
>> p-nima has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> update summary
>
> test/jdk/java/net/httpclient/HttpClientRetryLi
On Fri, 30 May 2025 09:08:46 GMT, Volkan Yazici wrote:
>> p-nima has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> update summary
>
> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 73:
&g
On Fri, 30 May 2025 15:01:03 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 57:
>>
>>> 55:
>>> 56:
>>> 57: class HttpClientRetryLimitTest implements HttpServerAdapters {
>>
>> Shall we rename this to `HttpClientAuthRetryLimit`, since [there are sev
On Tue, 10 Jun 2025 15:10:36 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java line 136:
>>
>>> 134: } else {
>>> 135: assertEquals(0, totalRequestCount - 1);
>>> 136: }
>>
>> Ok - so now we're getting
On Mon, 9 Jun 2025 14:21:45 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java line 132:
>>
>>> 130: assertEquals("too many authentication attempts. Limit:
>>> " + RETRY_LIMIT, exception.getMessage());
>>> 131: assertEquals
green with tiers 1, 2, 3 and the test is stable.
p-nima has updated the pull request incrementally with one additional commit
since the last revision:
update copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25490/files
- new: https://git.openjdk.org/jdk/pull
On Thu, 12 Jun 2025 17:27:11 GMT, Daniel Fuchs wrote:
>> p-nima has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> apply review feedback and update java docs to clarify authentication retry
>> behaviour
>
green with tiers 1, 2, 3 and the test is stable.
p-nima has updated the pull request incrementally with one additional commit
since the last revision:
apply review feedback and improve readability
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25490/files
- new: https://git
On Wed, 4 Jun 2025 13:46:55 GMT, Daniel Fuchs wrote:
>> @p-nima, the handler still accepts all calls to `/`, you only salted the
>> request URI. Would you mind doing the same in
>> `httpTestServer.addHandler(...)` too, please? (You better create a `String
>> requestP
On Thu, 12 Jun 2025 14:48:58 GMT, Daniel Fuchs wrote:
>> After this discussion I think this isn't a bug, though the wording on the
>> property may need clarification
>
> Agreed. And it's very good to have a test now to verify the expected
> behavior. So I would change the test to test the behav
green with tiers 1, 2, 3 and the test is stable.
p-nima has updated the pull request incrementally with one additional commit
since the last revision:
apply review feedback and update java docs to clarify authentication retry
behaviour
-
Changes:
- all: https://git.openjdk.org
On Thu, 12 Jun 2025 14:56:28 GMT, p-nima wrote:
>> Agreed. And it's very good to have a test now to verify the expected
>> behavior. So I would change the test to test the behaviour we want. Then
>> double check that it fails with the current proposed changes, and pass
22 matches
Mail list logo
