On Thu, 12 Jun 2025 17:27:11 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> p-nima has updated the pull request incrementally with one additional commit >> since the last revision: >> >> apply review feedback and update java docs to clarify authentication retry >> behaviour > > src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights >> reserved. > > This change should be reverted too now since we dind't change anything in > this file... This has been updated in 8803830b39f03ef60e2e96a33773bf0fcd0e70e7 > test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java line 9: > >> 7: * published by the Free Software Foundation. Oracle designates this >> 8: * particular file as subject to the "Classpath" exception as provided >> 9: * by Oracle in the LICENSE file that accompanied this code. > > This is the wrong Copyright for a test file. Tests shouldn't have the > Classpath exception. Please copy the copyright from a nearby test. The copyright has been updated in 8803830b39f03ef60e2e96a33773bf0fcd0e70e7 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2143323964 PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2143323687
