Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v2]

2025-02-05 Thread Mikhail Yankelevich
On Wed, 5 Feb 2025 18:42:10 GMT, Daniel Fuchs wrote: > And implementing the suggested changes would be good... done, thanks - PR Comment: https://git.openjdk.org/jdk/pull/23469#issuecomment-2637743071

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-02-06 Thread Mikhail Yankelevich
> * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor com

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v2]

2025-02-05 Thread Mikhail Yankelevich
> * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Apply suggest

RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid

2025-02-05 Thread Mikhail Yankelevich
* fully automated the test * removed the race condition * client on a thread and server on a thread options are now run together automatically - Commit messages: - JDK-8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid Changes: https://git.o

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v2]

2025-02-06 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 15:16:30 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply suggestions from cr >> >> Co-authored-by: Daniel Fuchs <

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v2]

2025-02-06 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 15:18:40 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply suggestions from cr >> >> Co-authored-by: Daniel Fuchs <

Re: RFR: 8353453: URLDecoder should use HexFormat

2025-04-01 Thread Mikhail Yankelevich
On Sat, 29 Mar 2025 17:27:20 GMT, Patrick Strawderman wrote: > Use `HexFormat.fromHexDigits` in URLDecoder, instead of `Integer.parseInt`. Hi! This commit must refer to an issue. Could you please create one and provide some background for the change here. Thank you - PR Comment:

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number

2025-04-11 Thread Mikhail Yankelevich
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash wrote: > `scanByte` throws `NumberFormatException` for URIs that start with numbers, > e.g., https://.x.y/ > The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`. > `parseIPv4Address` uses `NumberFormatException` for control

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-05-06 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich wrote: >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > Mikhail Yankelevich has updated the pull

Re: RFR: 8355475: UNCTest should use an existing UNC path

2025-04-24 Thread Mikhail Yankelevich
On Thu, 24 Apr 2025 08:12:37 GMT, Eirik Bjørsnøs wrote: > Please review this test-only PR which updates `UNCTest.java` to use a UNC > path which is known to exist. > > The test currently uses the file URL > `file://jdk/LOCAL-JAVA/jdk1.4/win/README.txt`, but since this is unlikely to > resolve

Re: RFR: 8355475: UNCTest should use an existing UNC path [v4]

2025-04-25 Thread Mikhail Yankelevich
On Fri, 25 Apr 2025 06:19:30 GMT, Eirik Bjørsnøs wrote: >> Please review this test-only PR which updates `UNCTest.java` to use a UNC >> path which is known to exist. >> >> The test currently uses the file URL >> `file://jdk/LOCAL-JAVA/jdk1.4/win/README.txt`, but since this is unlikely to >> r

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-04-10 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich wrote: >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > Mikhail Yankelevich has updated the pull

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v4]

2025-05-08 Thread Mikhail Yankelevich
> * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: cleanup and u

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-05-08 Thread Mikhail Yankelevich
On Thu, 8 May 2025 05:54:58 GMT, Rajan Halade wrote: > I understand this is a old test and it is not in scope of this bug to update > existing code. But there are few issues in this test that should be > addressed, for instance, use of deprecated URL, old style threads, old code > styles, typo

Re: RFR: 8350546: Several java/net/InetAddress tests fails UnknownHostException

2025-03-03 Thread Mikhail Yankelevich
On Tue, 25 Feb 2025 08:57:00 GMT, SendaoYan wrote: > Hi all, > > Two java/net/InetAddress tests fails "java.net.UnknownHostException" on some > special machines. The machine cannot connect to the Internet directly and > needs to be connected to the Internet through a jump machine. The > java/

Re: RFR: 8350546: Several java/net/InetAddress tests fails UnknownHostException [v4]

2025-03-03 Thread Mikhail Yankelevich
On Mon, 3 Mar 2025 11:18:10 GMT, SendaoYan wrote: >> Hi all, >> >> Two java/net/InetAddress tests fails "java.net.UnknownHostException" on some >> special machines. The machine cannot connect to the Internet directly and >> needs to be connected to the Internet through a jump machine. The >>

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-03-06 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich wrote: >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > Mikhail Yankelevich has updated the pull

Re: RFR: 8350915: [JMH] test SocketChannelConnectionSetup failed for 2 threads config

2025-02-28 Thread Mikhail Yankelevich
On Fri, 28 Feb 2025 12:50:15 GMT, Volkan Yazici wrote: > Fixes deletion of non-existent (i.e., already-deleted) files in > `SocketChannelConnectionSetup`. Confirmed the fix using > > > make build-microbenchmark > build/linux-x64/jdk/bin/java \ > -jar build/linux-x64/images/test/micro/benchma

Re: RFR: 8325766: Review seclibs tests for cert expiry

2025-02-20 Thread Mikhail Yankelevich
On Wed, 19 Feb 2025 15:48:10 GMT, Matthew Donovan wrote: > This PR updates the CertificateBuilder with a new method that creates a new > instance with common fields (subject name, public key, serial number, > validity, and key uses) filled-in. One test, IPIdentities.java, is updated to > show

RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress

2025-05-20 Thread Mikhail Yankelevich
HttpServer::stop will terminate the server immidiately after all exhcnages are complete. If the exchanges take longer then the specified delay it will terminate straight after the delay, the same as the previous behaviour. Used to wait until the delay is complete at all times, regardless of the

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v5]

2025-05-27 Thread Mikhail Yankelevich
plete at all times, regardless of the > number of active exchanges. > > Tests based on @eirbjo work, so adding Eirik as a contributor. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: consolidated events ---

Integrated: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress

2025-05-28 Thread Mikhail Yankelevich
On Tue, 20 May 2025 15:51:50 GMT, Mikhail Yankelevich wrote: > HttpServer::stop will terminate the server immidiately after all exhcnages > are complete. > If the exchanges take longer then the specified delay it will terminate > straight after the delay, the same as the previo

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-28 Thread Mikhail Yankelevich
On Mon, 26 May 2025 16:28:52 GMT, Daniel Fuchs wrote: >> I wonder could the two Event types be consolidated inside Event.java? It >> seems overkill to have them in three separate source files now. > >> I wonder could the two Event types be consolidated inside Event.java? It >> seems overkill to

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v6]

2025-05-27 Thread Mikhail Yankelevich
plete at all times, regardless of the > number of active exchanges. > > Tests based on @eirbjo work, so adding Eirik as a contributor. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: discussion - Changes: - a

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-22 Thread Mikhail Yankelevich
plete at all times, regardless of the > number of active exchanges. > > Tests based on @eirbjo work, so adding Eirik as a contributor. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Suggestions from cr Co-authored-by

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mikhail Yankelevich
On Fri, 23 May 2025 08:50:11 GMT, Mark Sheppard wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Suggestions from cr >> >> Co-authored-by: Daniel Fuchs <67001856+

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v2]

2025-05-21 Thread Mikhail Yankelevich
On Tue, 20 May 2025 16:58:02 GMT, Daniel Fuchs wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressing comments > > src/jdk.httpserver/share/classes/sun/net/httpserver/Serve

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v2]

2025-05-21 Thread Mikhail Yankelevich
On Tue, 20 May 2025 17:17:21 GMT, Daniel Jeliński wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressing comments > > src/jdk.httpserver/share/classes/sun/net/https

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v2]

2025-05-21 Thread Mikhail Yankelevich
On Tue, 20 May 2025 17:20:26 GMT, Daniel Jeliński wrote: >> src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java line 252: >> >>> 250: selector.wakeup(); >>> 251: long latest = System.nanoTime() + delay * 10L; >>> 252: while (System.nanoTime() < lat

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v3]

2025-05-21 Thread Mikhail Yankelevich
On Tue, 20 May 2025 17:05:32 GMT, Daniel Fuchs wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cleanup > > test/jdk/com/sun/net/httpserver/ServerStopTerminationTest.jav

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v3]

2025-05-21 Thread Mikhail Yankelevich
plete at all times, regardless of the > number of active exchanges. > > Tests based on @eirbjo work, so adding Eirik as a contributor. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: cleanup - Changes: - a

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v2]

2025-05-21 Thread Mikhail Yankelevich
plete at all times, regardless of the > number of active exchanges. > > Tests based on @eirbjo work, so adding Eirik as a contributor. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: addressing comments ---

Re: RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries

2025-06-04 Thread Mikhail Yankelevich
On Wed, 28 May 2025 11:26:17 GMT, p-nima wrote: > The AuthenticationFilter did not respect the default retry limit of 3 retries > in case of invalid credentials supplied. > > This PR helps to resolve the bug and tests it with default and updated retry > limit set via `jdk.httpclient.auth.retry

Re: RFR: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java

2025-07-15 Thread Mikhail Yankelevich
On Fri, 11 Jul 2025 13:39:33 GMT, ayush wrote: > This is part of a series of diagnostic output updates to java.net tests to > assist in the analysis of failures in IPv6 only environments > for Linux there is not IPv4 configuration but the IPv4 stack remains enabled > For macOS, and windows the I

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v5]

2025-07-30 Thread Mikhail Yankelevich
On Wed, 30 Jul 2025 09:32:17 GMT, Volkan Yazici wrote: >> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` >> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` >> publisher to upload a certain region of a file. The new publisher does not >> mod