On Mon, 6 Jun 2022 09:43:50 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.java.net/browse/JDK-8276798?
>
> `sun.net.www.protocol.http.HttpURLConnection` has a (private) `writeRequests`
> method. This method is responsible for c
On Fri, 24 Jun 2022 08:49:06 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the broken link in the
> javadoc of `SimpleFileServer`? This fixes
> https://bugs.openjdk.org/browse/JDK-8288983 which has the necessary context
> on why/when this link broke.
>
> I u
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Wed, 29 Jun 2022 10:20:42 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.org/browse/JDK-8289291?
>
> As noted in that issue, right now, the Http(s)Server sets an incorrect value
> for the `max` parameter of the `Keep-Alive` header
On Wed, 29 Jun 2022 12:05:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which addresses
>> https://bugs.openjdk.org/browse/JDK-8289291?
>>
>> As noted in that issue, right now, the Http(s)Server sets an incorrect value
>> for the `max` parameter of the `Keep-Alive` h
Hi,
Could I get the following small change reviewed please?
It removes a test that calls Thread.stop() which is no longer required since it
was checking for
a bug in the old SocketImpl that has recently been replaced by the NIO
implementation.
Thanks,
Michael.
-
Commit messages:
On Mon, 4 Jul 2022 13:03:46 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small change reviewed please?
>
> It removes a test that calls Thread.stop() which is no longer required since
> it was checking for
> a bug in the old SocketImpl that has recently
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
Hi,
Could I get the following trivial code change reviewed please? Static analysis
shows one
static field declaration in java.net.URL that should be final.
Thanks,
Michael.
-
Commit messages:
- add final keyword
Changes: https://git.openjdk.org/jdk/pull/9586/files
Webrev: https
On Thu, 21 Jul 2022 09:46:27 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial code change reviewed please? Static
> analysis shows one
> static field declaration in java.net.URL that should be final.
>
> Thanks,
> Michael.
This pull request
On Thu, 21 Jul 2022 17:41:22 GMT, Daniel Jeliński wrote:
>> src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c line 207:
>>
>>> 205: }
>>> 206: }
>>> 207: return JNI_TRUE;
>>
>> Hello Daniel, if I'm reading this diff correctly, then we have inverted the
>> check on `fd`.
On Wed, 20 Jul 2022 17:19:50 GMT, Daniel Jeliński wrote:
> This patch partially fixes the issue where IPv6 sockets were fragmenting
> outgoing IPv4 datagrams even when IP_DONTFRAGMENT flag was set. Specifically,
> it fixes the issue on Linux and Windows. As far as I could tell, the issue is
>
On Wed, 3 Aug 2022 09:43:44 GMT, Daniel Jeliński wrote:
>> This patch partially fixes the issue where IPv6 sockets were fragmenting
>> outgoing IPv4 datagrams even when IP_DONTFRAGMENT flag was set.
>> Specifically, it fixes the issue on Linux and Windows. As far as I could
>> tell, the issue
Hi,
Some new keep alive tests are exposing some old bugs. In this case if the
server sends an invalid timeout (say -20 seconds) we accept it creating a
timeout in the past. So, the first time the keep alive thread wakes up it will
close the connection.
The correct behavior is to ignore the inva
On Fri, 5 Aug 2022 06:28:33 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Some new keep alive tests are exposing some old bugs. In this case if the
>> server sends an invalid timeout (say -20 seconds) we accept it creating a
>> timeout in the past. So, the first time the keep alive thread wakes up it
On Fri, 5 Aug 2022 06:29:42 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Some new keep alive tests are exposing some old bugs. In this case if the
>> server sends an invalid timeout (say -20 seconds) we accept it creating a
>> timeout in the past. So, the first time the keep alive thread wakes up it
orrect behavior is to ignore the invalid parameter and fallback to the
> default timeout or the timeout set by the relevant system property.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revi
On Fri, 5 Aug 2022 12:53:22 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update from Jai's review
>
> test/jdk/sun/net/www/http/KeepAliveCa
orrect behavior is to ignore the invalid parameter and fallback to the
> default timeout or the timeout set by the relevant system property.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
small te
On Thu, 4 Aug 2022 20:41:33 GMT, Michael McMahon wrote:
> Hi,
>
> Some new keep alive tests are exposing some old bugs. In this case if the
> server sends an invalid timeout (say -20 seconds) we accept it creating a
> timeout in the past. So, the first time the keep alive thr
On Tue, 9 Aug 2022 11:02:31 GMT, KIRIYAMA Takuya wrote:
>> Consider an authority component without trailing "/" as a base URI. When
>> resolving a relative path against this base URI, the resulting URI is a
>> concatenated URI without "/".
>> This behaviour should be fixed, which is rationalize
On Tue, 9 Aug 2022 11:02:31 GMT, KIRIYAMA Takuya wrote:
>> Consider an authority component without trailing "/" as a base URI. When
>> resolving a relative path against this base URI, the resulting URI is a
>> concatenated URI without "/".
>> This behaviour should be fixed, which is rationalize
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Thu, 18 Aug 2022 10:03:23 GMT, Matthias Baesken wrote:
> NTLMAuthSequence getCredentialsHandle has a number of cleanup paths doing
> various JNU_ReleaseStringPlatformChars calls; those could be placed at one
> place in the function.
Looks good. Minor suggestion that the check in line 144 be
On Thu, 18 Aug 2022 11:45:11 GMT, Matthias Baesken wrote:
>> NTLMAuthSequence getCredentialsHandle has a number of cleanup paths doing
>> various JNU_ReleaseStringPlatformChars calls; those could be placed at one
>> place in the function.
>
> Matthias Baesken has updated the pull request increm
On Mon, 29 Aug 2022 14:26:09 GMT, Ramesh Bhagavatam Gangadhar
wrote:
>> There are total 160 scenarios written with combination of client properties
>> (Client Scenarios) and Server Response (Server Scenarios).
>>
>> In tabular format, Client and Server scenarios along with expected output
>>
On Mon, 29 Aug 2022 14:26:09 GMT, Ramesh Bhagavatam Gangadhar
wrote:
>> There are total 160 scenarios written with combination of client properties
>> (Client Scenarios) and Server Response (Server Scenarios).
>>
>> In tabular format, Client and Server scenarios along with expected output
>>
On Tue, 6 Sep 2022 06:38:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internally) ignore the intermediate 1xx informati
On Fri, 9 Sep 2022 09:57:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internally) ignore the intermediate 1xx informati
On Mon, 12 Sep 2022 07:45:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ignore interim informational 1xx
On Mon, 12 Sep 2022 13:26:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ignore interim informational 1xx
On Mon, 19 Sep 2022 14:32:24 GMT, Darragh Clarke wrote:
> No tests were affected so this is purely a removal PR apart from updating
> copyright headers.
> I ran tests for Tier 1,2&3 and everything seems to be passing
Have the AIX changes been verified with an AIX build?
-
PR: http
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Wed, 28 Sep 2022 15:36:04 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes sure KeepAliveCache does not block all
>> threads while closing sockets.
>>
>> Changes:
>> - get operation no longer closes sockets; if there's no socket that is
>> recent enough, get returns null a
On Wed, 28 Sep 2022 17:31:46 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes sure KeepAliveCache does not block all
>> threads while closing sockets.
>>
>> Changes:
>> - get operation no longer closes sockets; if there's no socket that is
>> recent enough, get returns null a
On Wed, 28 Sep 2022 17:31:46 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes sure KeepAliveCache does not block all
>> threads while closing sockets.
>>
>> Changes:
>> - get operation no longer closes sockets; if there's no socket that is
>> recent enough, get returns null a
On Fri, 30 Sep 2022 12:38:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes sure KeepAliveCache does not block all
>> threads while closing sockets.
>>
>> Changes:
>> - get operation no longer closes sockets; if there's no socket that is
>> recent enough, get returns null a
On Thu, 6 Oct 2022 15:10:18 GMT, Daniel Fuchs wrote:
>> Many built-in URL Handlers perform additional syntax checking on the URL
>> when `URLStreamHandler::openConnection` / connect is called. In some cases,
>> some of these checks could be also performed earlier, when
>> `URLStreamHandler::pa
On Mon, 19 Sep 2022 14:09:04 GMT, Ramesh Bhagavatam Gangadhar
wrote:
>> There are total 160 scenarios written with combination of client properties
>> (Client Scenarios) and Server Response (Server Scenarios).
>>
>> In tabular format, Client and Server scenarios along with expected output
>>
Hi,
This is a copyright update to the PR just integrated to fix the incorrect
copyright notice in the new test
Thanks,
Michael
-
Commit messages:
- added comma
Changes: https://git.openjdk.org/jdk/pull/10674/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10674&range=00
On Wed, 12 Oct 2022 12:05:44 GMT, Michael McMahon wrote:
> Hi,
>
> This is a copyright update to the PR just integrated to fix the incorrect
> copyright notice in the new test
>
> Thanks,
> Michael
This pull request has now been integrated.
Changeset: cb62f1c5
Autho
Hi
Could I get the following change reviewed please? It fixes an issue identified
by the new KeepAliveTest test case where a server returned keep-alive
"timeout=0" should have closed the connection, but was reverting to the old
defaults.
Thanks,
Michael.
-
Commit messages:
- upd
> Hi
>
> Could I get the following change reviewed please? It fixes an issue
> identified by the new KeepAliveTest test case where a server returned
> keep-alive "timeout=0" should have closed the connection, but was reverting
> to the old defaults.
>
> Thank
On Wed, 12 Oct 2022 14:18:49 GMT, Michael McMahon wrote:
> Hi
>
> Could I get the following change reviewed please? It fixes an issue
> identified by the new KeepAliveTest test case where a server returned
> keep-alive "timeout=0" should have closed the connection, bu
On Mon, 17 Oct 2022 19:21:17 GMT, Daniel Fuchs wrote:
>> When [JDK-8277969](https://bugs.openjdk.org/browse/JDK-8277969) was
>> implemented, a list of outstanding response subscribers was added to
>> `HttpClientImpl`. A body subscriber is added to the list after being created
>> and is removed
On Tue, 18 Oct 2022 13:46:06 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
>> line 642:
>>
>>> 640: final long webSocketCount = pendingWebSocketCount.get();
>>> 641: if (count == 0 && facadeRef.refersTo(null)) {
>>> 642:
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as no
On Tue, 18 Oct 2022 13:37:42 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/SmallTimeout.java line 86:
>>
>>> 84: HttpClient client = HttpClient.newHttpClient();
>>> 85: ReferenceTracker.INSTANCE.track(client);
>>> 86: Reference reference = new WeakReference<>(c
On Tue, 18 Oct 2022 17:06:34 GMT, Michael McMahon wrote:
>> The reference is passed to another thread but should remain alive until that
>> other thread has terminated - which is ensured by waiting for the executor
>> to shutdown. What happens here is that the test failed
On Tue, 18 Oct 2022 14:27:06 GMT, Daniel Fuchs wrote:
>> When [JDK-8277969](https://bugs.openjdk.org/browse/JDK-8277969) was
>> implemented, a list of outstanding response subscribers was added to
>> `HttpClientImpl`. A body subscriber is added to the list after being created
>> and is removed
On Wed, 19 Oct 2022 13:57:52 GMT, Daniel Fuchs wrote:
>> During the review of JDK-8293590, it was noted that some methods in
>> `URLStreamHandler` were missing an `@throws IllegalArgumentException` clause
>> in their API documentation.
>>
>> This change adds the requested information, and als
Hi,
This change adds some documentation to the jdk.httpserver module-info listing
all of the system properties used by the implementation and which can be set by
users.
CSR at https://bugs.openjdk.org/browse/JDK-8295667
Thanks,
Michael.
-
Commit messages:
- update TCP_NODELAY li
On Wed, 19 Oct 2022 15:03:21 GMT, Aleksei Efimov wrote:
>> src/jdk.httpserver/share/classes/module-info.java line 92:
>>
>>> 90: *
>>> 91: * {@systemProperty sun.net.httpserver.nodelay} (default:
>>> false)
>>> 92: * Boolean value, which if true, sets the TCP_NODELAY socket option on
>>> a
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
On Thu, 20 Oct 2022 10:38:47 GMT, Jaikiran Pai wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> blank line removed
>
> src/jdk.httpserver/share/classes/module-info.java line 4
On Thu, 20 Oct 2022 10:53:33 GMT, Jaikiran Pai wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> blank line removed
>
> src/jdk.httpserver/share/classes/module-info.java line 90:
On Thu, 20 Oct 2022 11:43:25 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/module-info.java line 86:
>>
>>> 84: *
>>> 85: * {@systemProperty sun.net.httpserver.debug} (default:
>>> false)
>>> 86: * Boolean value, which if true, generates debug information on the
>>> console.
On Thu, 20 Oct 2022 11:49:25 GMT, Daniel Fuchs wrote:
>> Maybe, I should include the property that is used to locate the impl as
>> first in the list and say the remaining properties apply to the default impl
>> in the JDK?
>
> No. That property should probably be deprecated since there is a mo
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
On Thu, 20 Oct 2022 15:03:11 GMT, Jaikiran Pai wrote:
>> src/jdk.httpserver/share/classes/module-info.java line 58:
>>
>>> 56: * The maximum number of idle connections at a time.
>>> 57: *
>>> 58: * {@systemProperty sun.net.httpserver.drainAmount}
>>> (default: 64K)
>>
>> Hello Michael, so
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
On Thu, 20 Oct 2022 15:07:48 GMT, Jaikiran Pai wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> after review
>
> src/jdk.httpserver/share/classes/module-info.java line 73:
>
On Thu, 20 Oct 2022 15:29:20 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds some documentation to the jdk.httpserver module-info
>> listing all of the system properties used by the implementation and which
>> can be set by users.
>>
>>
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>
> Thanks,
> Michael.
M
On Wed, 19 Oct 2022 14:22:19 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds some documentation to the jdk.httpserver module-info listing
> all of the system properties used by the implementation and which can be set
> by users.
>
> CSR at https://bugs.openjdk.o
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in
On Thu, 27 Oct 2022 05:14:19 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/net/JarURLConnection.java line 177:
>>
>>> 175: @SuppressWarnings("deprecation")
>>> 176: var tmp = jarFileURL = new URL(spec.substring(0, separator++));
>>> 177:
>>
>> I realise that @Suppres
Hi,
Can I get the following trivial change reviewed please? It removes an
unreferenced class
that was left over from a previous cleanup.
Thanks,
Michael
-
Commit messages:
- deleted InetAddressContainer
Changes: https://git.openjdk.org/jdk/pull/10886/files
Webrev: https://webrev
On Thu, 27 Oct 2022 15:54:58 GMT, Michael McMahon wrote:
> Hi,
>
> Can I get the following trivial change reviewed please? It removes an
> unreferenced class
> that was left over from a previous cleanup.
>
> Thanks,
> Michael
This pull request has now been integrat
On Thu, 3 Nov 2022 10:56:28 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism define
On Thu, 3 Nov 2022 11:20:03 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism define
On Thu, 3 Nov 2022 16:28:08 GMT, Conor Cleary wrote:
>> **Issue**
>> When using HTTP/2 with the HttpClient, it can often be necessary to close an
>> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
>> server or cloud based tool could close a TCP connection silently whe
On Tue, 8 Nov 2022 22:28:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update in jdk.net reviewed?
>
> While build on MacOX, I run into the following issues:
Seems strange that the definition has been removed in a newer Xcode version.
Have you checked if it has been moved to a d
On Tue, 8 Nov 2022 22:28:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update in jdk.net reviewed?
>
> While build on MacOX, I run into the following issues:
Marked as reviewed by michaelm (Reviewer).
Thanks. I think your suggested change in the webrev is best.
-
P
On Tue, 15 Nov 2022 12:10:00 GMT, Conor Cleary wrote:
>> **Issue**
>> When using HTTP/2 with the HttpClient, it can often be necessary to close an
>> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
>> server or cloud based tool could close a TCP connection silently wh
Hi,
Could I get the following doc change reviewed please? It documents the
system/networking properties used by the java.net.http HTTP client in its
module-info. (CSR to follow)
Thanks,
Michael
-
Commit messages:
- first draft
Changes: https://git.openjdk.org/jdk/pull/11241/file
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request increment
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new tar
On Mon, 21 Nov 2022 13:36:29 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Tue, 22 Nov 2022 12:22:57 GMT, Daniel Fuchs wrote:
>> Please find here a test fix for the
>> sun/net/www/http/HttpClient/MultiThreadTest.
>>
>> This test makes concurrent connections to a server using multiple threads,
>> and due to keep-alive, expects that there should not be more connecti
On Mon, 21 Nov 2022 13:41:06 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request increment
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request increment
On Mon, 21 Nov 2022 13:41:42 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Mon, 21 Nov 2022 13:42:33 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request increment
On Wed, 23 Nov 2022 14:25:37 GMT, Daniel Fuchs wrote:
>> Please find here a test fix for the
>> sun/net/www/http/HttpClient/MultiThreadTest.
>>
>> This test makes concurrent connections to a server using multiple threads,
>> and due to keep-alive, expects that there should not be more connecti
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request increment
On Thu, 24 Nov 2022 11:53:11 GMT, Daniel Fuchs wrote:
>> Please find here a test fix for the
>> sun/net/www/http/HttpClient/MultiThreadTest.
>>
>> This test makes concurrent connections to a server using multiple threads,
>> and due to keep-alive, expects that there should not be more connecti
On Tue, 22 Nov 2022 11:10:14 GMT, Conor Cleary wrote:
> Proposed changes to reduce the default Keep Alive Timeout value in
> `jdk/internal/net/http/HttpClientImpl.java` from 1200 seconds to 30 seconds.
> The current default value of 1200s is needlessly high and in remote
> connections that all
On Fri, 25 Nov 2022 07:20:26 GMT, Jaikiran Pai wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update to be compatible with JDK-8297030
>
> src/java.net.http/share/classes/modu
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request increment
On Thu, 24 Nov 2022 11:18:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following doc change reviewed please? It documents the
>> system/networking properties used by the java.net.http HTTP client in its
>> module-info. (CSR to follow)
>>
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new tar
On Fri, 25 Nov 2022 13:37:36 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following doc change reviewed please? It documents the
>> system/networking properties used by the java.net.http HTTP client in its
>> module-info. (CSR to follow)
>>
1 - 100 of 432 matches
Mail list logo
