On Mon, 21 Nov 2022 13:36:29 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into http.properties
>> - update after Daniel's review
>> - first draft
>
> src/java.net.http/share/classes/module-info.java line 113:
>
>> 111: * <li><p><b>{@systemProperty jdk.httpclient.maxstreams}</b> (default:
>> 100)<br>
>> 112: * The maximum number of HTTP/2 streams per connection.
>> 113: * </li>
>
> It might be useful to be a bit more precise here: this is the maximum number
> of concurrent push streams that a server is allowed to initiate on an HTTP/2
> connection
Right, good point. It's the client telling the server how many streams it is
allowed to open. So, that implies push streams only
> src/java.net.http/share/classes/module-info.java line 133:
>
>> 131: * This allows the thread to terminate when no longer needed. The value
>> provided is limited
>> 132: * to the range from 1 to 1200(???) seconds.
>> 133: * </li>
>
> Do we need to document this property? If yes then what is the meaning of the
> `(???)` question marks?
The question mark was a place holder to query the value range. 1200 seemed
extremely high. But, I think we don't need to document it at all.
-------------
PR: https://git.openjdk.org/jdk/pull/11241
