* Refactored SSLContextTemplate and SSLSocketTemplate to put common code in one
base class (SSLContextTemplate)
* Updated TLS/SSL tests to extend SSLSocketTemplate where possible.
* Updated SSLEngineTemplate to accommodate changes in SSLContextTemplate. To
keep this changeset to a reasonable size
On Thu, 16 Feb 2023 18:31:30 GMT, Rajan Halade wrote:
>> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in
>> one base class (SSLContextTemplate)
>> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible.
>> * Updated SSLEngineTemplate to accommodate changes
On Thu, 16 Feb 2023 18:40:56 GMT, Rajan Halade wrote:
>> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in
>> one base class (SSLContextTemplate)
>> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible.
>> * Updated SSLEngineTemplate to accommodate changes
On Thu, 16 Feb 2023 18:59:15 GMT, Rajan Halade wrote:
>> test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java line
>> 2:
>>
>>> 1: /*
>>> 2: * Copyright (C) 2021, 2023 THL A29 Limited, a Tencent company. All
>>> rights reserved.
>>
>> Missing comma and this is not Oracle c
changeset to a reasonable size, updates to SSLEngine tests will be
> made under JDK-8301194.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request conta
changeset to a reasonable size, updates to SSLEngine tests will be
> made under JDK-8301194.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull requ
On Tue, 14 Mar 2023 17:18:46 GMT, Rajan Halade wrote:
>> removed
>
> Don't see this file deleted in PR.
It was still being used by an "engine" test in that directory; I removed that
last use and deleted the key manager class.
(there is another bug to refactor the SSLEngine tests.)
---
changeset to a reasonable size, updates to SSLEngine tests will be
> made under JDK-8301194.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
removed last use of MyX509ExtendedKeyManager in ALPN directory
-
Chang
On Tue, 14 Mar 2023 17:56:07 GMT, Rajan Halade wrote:
> Updated review looks good to me except few minor code cleanup comments.
I went through all the changed files and added @Override where necessary and
cleaned up imports. I think I got them all.
-
PR: https://git.openjdk.org/jd
changeset to a reasonable size, updates to SSLEngine tests will be
> made under JDK-8301194.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
cleaned up code
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12555/fi
On Tue, 14 Feb 2023 12:17:39 GMT, Matthew Donovan wrote:
> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in
> one base class (SSLContextTemplate)
> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible.
> * Updated SSLEngineTemplate to accommo
For this PR, I identified TLS tests that can fail due to hard-code certificates
expiring. I updated those tests to use certificates that are generated
programmatically. This includes adding some helper methods to the
CertificateBuilder class to create builder objects with common default values.
tests that use
> it. These tests require significant refactoring to incorporate
> programmatically generated certificates and should be a separate task.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unr
On Tue, 21 May 2024 20:11:03 GMT, Sean Mullan wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
tests that use
> it. These tests require significant refactoring to incorporate
> programmatically generated certificates and should be a separate task.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unr
On Thu, 23 May 2024 18:23:28 GMT, Sean Mullan wrote:
>> I renamed the method.
>>
>> I don't want to over-generalize the code when I don't know what we'll
>> need/want in the future. The tests in this PR just create CA and end-entity
>> certs and with a couple exceptions, the tests in this PR
On Wed, 5 Feb 2025 18:50:25 GMT, Mikhail Yankelevich wrote:
>> * fully automated the test
>> * removed the race condition
>> * client on a thread and server on a thread options are now run together
>> automatically
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> ad
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains seven commits:
- rev
On Fri, 21 Feb 2025 13:47:59 GMT, Matthew Donovan wrote:
> The similarity between the certificate pairs is impressive! Just curious -
> why the change in issuer and owner names?
After looking into this some more, I found that `X500Name(String dname)` is
expecting the string to be in th
On Fri, 18 Apr 2025 15:38:02 GMT, Artur Barashev wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 10 commits:
>>
>> - expanded wildcard imports
>> - Merge branch 'm
On Thu, 3 Apr 2025 20:30:33 GMT, Artur Barashev wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - reversed order of DN strings when making certificates.
&g
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 10 commits:
- expa
This PR updates the CertificateBuilder with a new method that creates a new
instance with common fields (subject name, public key, serial number, validity,
and key uses) filled-in. One test, IPIdentities.java, is updated to show how
the method can be used to create various certificates. I attach
On Thu, 20 Feb 2025 20:27:27 GMT, Weijun Wang wrote:
> The similarity between the certificate pairs is impressive! Just curious -
> why the change in issuer and owner names?
Looks like it's something between `keytool` and `openssl x509`. When i print
the certificates with openssl, the issuer a
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
changed boolean array initiali
On Thu, 20 Feb 2025 11:22:41 GMT, Mikhail Yankelevich wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed boolean array initialization
>
> test/jdk/sun/net/www/pro
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 12 commits:
- fixed
On Fri, 30 May 2025 19:28:27 GMT, Sean Mullan wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 10 commits:
>>
>> - expanded wildcard imports
>> - Merge branch 'm
On Tue, 3 Jun 2025 15:31:37 GMT, Sean Mullan wrote:
>> I think the way it currently is follows the builder pattern better. All of
>> the 'set' methods return `this` which means if I change this method to a
>> constructor, I'd have to duplicate the "set" code from all those methods.
>>
>> I lik
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 15 commits:
- changed
30 matches
Mail list logo
