On Wed, 5 Feb 2025 18:50:25 GMT, Mikhail Yankelevich <d...@openjdk.org> wrote:
>> * fully automated the test
>> * removed the race condition
>> * client on a thread and server on a thread options are now run together
>> automatically
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Apply suggestions from cr
>
> Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com>
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 50:
> 48: public static final String CLOSE_THE_SSL_CONNECTION_PASSIVE = "close
> the SSL connection (passive)";
> 49:
> 50: static Map cookies;
These two fields, Map and ServerSocket, don't look like they're used anywhere.
They could be deleted.
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 225:
> 223: System.setProperty("javax.net.ssl.trustStorePassword", passwd);
> 224:
> 225: System.setProperty("javax.net.debug", "all");
Is this printing a lot of stuff to the logs? Why did you remove the `if
(debug)`?
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 241:
> 239: // this will allow the error stream to be printed in case of
> an exception inside for debugging purposes
> 240: System.setErr(originalErr);
> 241: if (debug) {
This field is hard-coded to false which requires rebuilding to turn it on. I
have been changing that to:
`static boolean debug = Boolean.getBoolean("test.debug");`
So it can be turned on with a system property.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1944913967
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1944909916
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1944908477
