Replacing deprecated constructors of primitive wrapper classes. Used valueOf()
method as replacement.
Alternatively, auto boxing could have been used here as well. It would be
beneficial to set a precedent for the other related doc bugs.
-
Commit messages:
- Replace constructors w
On Thu, 5 Jan 2023 19:09:29 GMT, Justin Lu wrote:
> Replacing deprecated constructors of primitive wrapper classes. Used
> valueOf() method as replacement.
>
> Alternatively, auto boxing could have been used here as well. It would be
> beneficial to set a precedent for the ot
> Replacing deprecated constructors of primitive wrapper classes. Used
> valueOf() method as replacement.
>
> Alternatively, auto boxing could have been used here as well. It would be
> beneficial to set a precedent for the other related doc bugs.
Justin Lu has updated t
On Fri, 6 Jan 2023 00:18:38 GMT, Naoto Sato wrote:
> Seems that you modified a different file?
Yes I did, 🙃. Thanks for catching that, fixed it.
-
PR: https://git.openjdk.org/jdk/pull/11866
On Thu, 5 Jan 2023 19:09:29 GMT, Justin Lu wrote:
> Replacing deprecated constructors of primitive wrapper classes. Used
> valueOf() method as replacement.
>
> Alternatively, auto boxing could have been used here as well. It would be
> beneficial to set a precedent for the ot
This pull request contains a backport of commit
[63cf4aa0](https://github.com/openjdk/jdk/commit/63cf4aa0c897406fc9370a8e05cb035caafc5d69)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Justin Lu on 7 Jan 2023 and was
reviewed by
On Fri, 13 Jan 2023 22:08:20 GMT, Justin Lu wrote:
> This pull request contains a backport of commit
> [63cf4aa0](https://github.com/openjdk/jdk/commit/63cf4aa0c897406fc9370a8e05cb035caafc5d69)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit b
This PR converts Unicode sequences to UTF-8 native in .properties file.
(Excluding the Unicode space and tab sequence). The conversion was done using
native2ascii.
In addition, the build logic is adjusted to support reading in the .properties
files as UTF-8 during the conversion from .propertie
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support readin
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with four additional
commits since the last revision:
- Bug6204853 should not be converted
- Copyright year for CompileProperties
- Redo translation for CS.prope
On Thu, 16 Mar 2023 18:19:29 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
On Wed, 15 Mar 2023 20:19:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompileProperties
>>
On Wed, 15 Mar 2023 16:18:44 GMT, Archie L. Cobbs wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompilePropert
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- Reconvert CS.properties to UTF-8
- Revert all changes to CurrencySymbols.properties
-
Ch
On Thu, 16 Mar 2023 18:31:23 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust CF test to read in with UTF-8 to fix failing test
-
Changes:
- all: https://git.openj
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Close streams when finished loading into props
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
On Tue, 4 Apr 2023 17:02:08 GMT, Darragh Clarke wrote:
> Currently it is possible for `HttpURLConnection` with the `Expect:
> 100-Continue` header to timeout awaiting for a server response. According to
> [RFC-7231](https://www.rfc-editor.org/rfc/rfc7231#section-5.1.1) a client
> `SHOULD NOT w
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 16 commits:
- Convert the merged master changes to UTF-8
- Merge master and fix conflicts
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode escape
or .properties files need
> to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1
> unless manually changed).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Replace InputStreamReader with BufferedReader
---
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK .
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files chang
Please review this PR which fixes incorrect usage of `jthrowable
ExceptionOccurred(JNIEnv *env)` within _java.base_.
This corrects instances where the return value is being treated as a boolean.
Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`.
-
Commit mes
On Thu, 19 Sep 2024 22:25:25 GMT, Justin Lu wrote:
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please
On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in thi
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote:
> Please review this PR which fixes incorrect usage of `jthrowable
> ExceptionOccurred(JNIEnv *env)` within _java.base_.
>
> This corrects instances where the return value is being treated as a boolean.
> Such occurrences ar
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote:
> Please review this PR which fixes incorrect usage of `jthrowable
> ExceptionOccurred(JNIEnv *env)` within _java.base_.
>
> This corrects instances where the return value is being treated as a boolean.
> Such occurrences ar
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Wed, 30 Oct 2024 17:37:25 GMT, Naoto Sato wrote:
>> The warning received is that got is set but not used - I had a look at
>> getLocaleInfoWrapper and it seems like it has no side effects, its only
>> purpose is to return a value, which is the variable got in this case. I'm
>> pretty certai
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 18 Sep 2024 06:53:27 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review comments
>
> src/java.base/share/classes/java/nio/charset/spi/CharsetP
On Wed, 18 Sep 2024 06:52:17 GMT, Alan Bateman wrote:
>> `repaint()` could be substituted with another arbitrary method name to
>> highlight some work this thread has to perform.
>>
>> given the thread name `blink`, perhaps we could just use `blink()` in this
>> example.
>
> Don't waste too mu
PI.
>
>
> in _src/java.base/share/classes/java/lang/ThreadGroup.java_.
> Please see the JBS issue comments for further reasoning on why other
> occurrences were not removed.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
why they were not included.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
restore DefaultTimeZoneTest.java as a manual test using PassFailJFrame
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21096/fi
On Wed, 25 Sep 2024 21:36:54 GMT, Naoto Sato wrote:
> Removing `test/jdk/java/util/TimeZone/DefaultTimeZoneTest.*` looks good to
> me. It's a manual test that involves underlying OS settings manipulation
> which cannot be automated.
As we previously spoke offline, I did not think there was muc
Tea applet
> - test/jdk/java/net/Socket/SocketImplTest.java
> - An old Applet test missing Jtreg tags.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
review: update wording of instructions
-
Changes:
- all: https://git.op
why they were not included.
>
> The following files were removed,
>
> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html
> - Test runner is no longer an Applet, so not needed
> - test/jdk/java/net/Socket/SocketImplTest.java
> - An old Applet test missing Jtreg tags.
On Thu, 26 Sep 2024 17:06:38 GMT, Daniel Fuchs wrote:
> `test/jdk/sun/net/www/ParseUtil_6380332.java`: shouldn't we actually keep
> this test? I see that the code in ParseUtil which is tested here is still
> there, and I don't think we'd want to touch ParseUtil given potential
> compatibility
why they were not included.
>
> The following files were removed,
>
> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html
> - Test runner is no longer an Applet, so not needed
> - test/jdk/java/net/Socket/SocketImplTest.java
> - An old Applet test missing Jtreg tags.
Please review this PR which removes usages of Applet within the corelibs tests.
This includes both code usage as well as occurrences of the word.
There were more files found than the ones included in this PR, please see the
comment on the JBS issue for the reason why they were not included. In g
Please review this PR which removes occurrences of 'applet' within the corelibs
specification. Applet has been deprecated since JDK9, and may be a confusing
term for new Java developers, so it should be removed from the documentation.
Primarily, usages where 'applet' is used interchangeably with
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so i
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote:
> Please review this PR which removes occurrences of 'applet' within the
> corelibs specification. Applet has been deprecated since JDK9, and may be a
> confusing term for new Java developers, so it should be removed from t
y they were not included. In
> general, I removed the file if the entirety was focused on Applet, otherwise
> I removed the portions applicable.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes bro
why they were not included.
>
> The following files were removed,
>
> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html
> - Test runner is no longer an Applet, so not needed
> - test/jdk/java/net/Socket/SocketImplTest.java
> - An old Applet test missing Jtreg tags.
On Wed, 20 Nov 2024 07:20:32 GMT, Laurent Bourgès wrote:
> I will check today if any 'bad' pattern is remaining in the openjdk master
> source folder... to be sure.
>
> Maybe improving jni documentation would be great in another issue...
Thanks for checking @bourgesl. The JNI docs did in fact
Please review this PR which removes the leftover ocurrences of incorrect JNI
`ExceptionOccurred(env)` usage within _java.base_.
This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
these occurrences are fine and were intentionally not removed during the first
pass, it
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these
On Wed, 9 Apr 2025 15:06:32 GMT, Magnus Ihse Bursie wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 16 commits:
>>
>> - Convert the merged master changes to UTF-8
>> -
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace InputStreamReader with BufferedReader
>
> FWIW, I checked out the revision
56 matches
Mail list logo
