On Fri, 13 Jun 2025 15:01:46 GMT, Daniel Fuchs wrote:
> Hi,
>
> I would like to backport this test-only stabilization fix to the JDK 25.
> This will remove some noise from the CI when running on macOS.
>
> This is a clean backport.
Marked as reviewed by alanb (Reviewer).
-
PR Rev
Hi,
I would like to backport this test-only stabilization fix to the JDK 25.
This will remove some noise from the CI when running on macOS.
This is a clean backport.
-
Commit messages:
- Backport 57cabc6d741c14a8029aec324ba96e8ced4afcbd
Changes: https://git.openjdk.org/jdk/pull/25
On Fri, 13 Jun 2025 13:49:55 GMT, Jaikiran Pai wrote:
>The timeout values noted in that text are mere examples to convey the detail
>that application developers need to >be aware that the timeout they pass to
>the connect() method may not influence connection establishment failure >due
>to tim
On Fri, 13 Jun 2025 14:36:21 GMT, Alan Bateman wrote:
>> "The timeout values noted in that text are mere examples to convey the
>> detail that application developers need to be aware that the timeout they
>> pass to the connect() method may not influence connection establishment
>> failure due
On Fri, 6 Jun 2025 21:11:16 GMT, Artur Barashev wrote:
>> src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java line
>> 401:
>>
>>> 399: continue;
>>> 400: }
>>> 401:
>>
>> I think we should also call `CertType.check` here, like in
>> `X509KeyMan
On Fri, 13 Jun 2025 14:14:25 GMT, Mark Sheppard wrote:
> This is all that needs to be said. There is no need to state any typical
> values, but if you do then those values need to be factually correct, and for
> the currently supported platforms 60 seconds is not typical, it's 21, 75, and
> 12
On Fri, 13 Jun 2025 16:08:43 GMT, Daniel Fuchs wrote:
>> why are you insisting on specifying 60 seconds? It does not exist on any
>> supported OS platform. There is no need to specify any value in the apiNote,
>> all it does is add misinformation
>
> Maybe we could say:
>
>
> The typical oper
> When the deafult SunX509KeyManagerImpl is being used we are in violation of
> TLSv1.3 RFC spec because we ignore peer supported certificate signatures sent
> to us in "signature_algorithms"/"signature_algorithms_cert" extensions:
> https://datatracker.ietf.org/doc/html/rfc8446#section-4.4.2.2
>
> Hi,
>
> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
> targeting it to 26.
> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
> Expires attributes
> are present in a cookie, the Max-Age should take precedence.
>
> Thanks
> Michael
Michael
On Fri, 13 Jun 2025 15:20:47 GMT, Mark Sheppard wrote:
>>> This is all that needs to be said. There is no need to state any typical
>>> values, but if you do then those values need to be factually correct, and
>>> for the currently supported platforms 60 seconds is not typical, it's 21,
>>> 75
On Fri, 13 Jun 2025 15:01:46 GMT, Daniel Fuchs wrote:
> Hi,
>
> I would like to backport this test-only stabilization fix to the JDK 25.
> This will remove some noise from the CI when running on macOS.
>
> This is a clean backport.
This pull request has now been integrated.
Changeset: 4111730
On Thu, 12 Jun 2025 18:52:12 GMT, Daniel Fuchs wrote:
>> Like
>> [java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java](https://git.openjdk.org/jdk/pull/25692),
>> the test java/net/URL/EarlyOrDelayedParsing doesn't expect proxies, and may
>> fail if a proxy is selected.
>>
>>
On Thu, 12 Jun 2025 18:52:12 GMT, Daniel Fuchs wrote:
>> Like
>> [java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java](https://git.openjdk.org/jdk/pull/25692),
>> the test java/net/URL/EarlyOrDelayedParsing doesn't expect proxies, and may
>> fail if a proxy is selected.
>>
>>
On Thu, 12 Jun 2025 16:02:51 GMT, Daniel Fuchs wrote:
> Like
> [java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java](https://git.openjdk.org/jdk/pull/25692),
> the test java/net/URL/EarlyOrDelayedParsing doesn't expect proxies, and may
> fail if a proxy is selected.
>
> The te
On Fri, 13 Jun 2025 09:16:39 GMT, Mark Sheppard wrote:
> Also first sentence need minor refinement changing connection timeout to
> connect timeout
>
> connection timeout is when the connection is established
I haven't previously seen connection timeout term being used to mean a timeout
(for t
On Thu, 12 Jun 2025 18:20:58 GMT, Volkan Yazici wrote:
> @Michael-Mc-Mahon, instead of making an exception for `max-age` and
> `expires`, and removing them from `assignors`, can't we convert the type of
> `assignors` from `Map` to `List` and add `max-age` & `expires` entries at the
> end?
Jus
On Fri, 13 Jun 2025 07:12:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add a
>> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
>> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in
On Thu, 12 Jun 2025 17:52:51 GMT, p-nima wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.httpclient.auth.
On Fri, 13 Jun 2025 06:36:19 GMT, SendaoYan wrote:
> Hi all,
>
> Test com/sun/nio/sctp/SctpChannel/CloseDescriptors.java should throw
> jtreg.SkippedException when there is no lsof command or there is no SCTP in
> test machine.
> Before this PR, this test report Execution successful when there
On Thu, 12 Jun 2025 10:19:21 GMT, Mark Sheppard wrote:
>> Looking at this on the 3 main OS platforms (Windows, OL and macOS) and
>> running a simple test to trigger a connect timeout then finding are
>>
>> macOS the connect timeout is 75 seconds as this is derived from 4.3 BSD
>>
>> If OL linu
> Can I please get a review of this doc-only change which proposes to add a
> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>
> As noted in that issue, users can find it surprising that when the
> `S
> Removes following files added in
> [JDK-8235459](https://bugs.openjdk.org/browse/JDK-8235459) and are forgotten
> to be removed during the `SecurityManager`-removal
> ([JDK-8344228](https://bugs.openjdk.org/browse/JDK-8344228)):
>
>
> test/jdk/java/net/httpclient/FilePublisher/FilePublisherP
On Fri, 13 Jun 2025 07:08:58 GMT, Jaikiran Pai wrote:
>> FWIW an possible alternative wording
>>
>> Establishing a TCP/IP connection is subject to a connect timeout, determined
>> by configuration settings
>> of the operating system, for example the number of connect retries together
>> with a
On Wed, 28 May 2025 11:26:17 GMT, p-nima wrote:
> The AuthenticationFilter did not respect the default retry limit of 3 retries
> in case of invalid credentials supplied.
>
> This PR helps to resolve the bug and tests it with default and updated retry
> limit set via `jdk.httpclient.auth.retry
java.net.URLConnection has
public Object getContent();
It uses the desktop module to find handlers for image and audio data
Briefly, the desktop module
"provides java.net.ContentHandlerFactory with
sun.awt.www.content.MultimediaContentHandlers;"
That knows about several audio and im
25 matches
Mail list logo
