On Thu, 12 Jun 2025 18:52:12 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Like >> [java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java](https://git.openjdk.org/jdk/pull/25692), >> the test java/net/URL/EarlyOrDelayedParsing doesn't expect proxies, and may >> fail if a proxy is selected. >> >> The test sets system properties and runs in otrhervm. The fix is to set up a >> default ProxySelector that will always return NO_PROXY. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Copyright update This looks fine to me. Although there's a test `@run` which is not `othervm`, setting this default ProxySelector (and not resetting it back) should be fine since `jdk.net.url.delayParsing` by default is `false` and we don't set the ProxySelector in those cases. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25783#pullrequestreview-2924775768
