Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with two additional commits since the last revision:

RFR: 7046003: Default value of Authenticator.getRequestingURL() is not specified

2025-05-07 Thread kieran-farrell
Clarificatiion of spec to outline that Authenticator.getRequestingURL() returns null in the event that the corresponding request does not specify a URL. - Commit messages: - authenticator getRequestingURL spec update - update inetaddress javadoc Changes: https://git.openjdk.org/jd

Re: RFR: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value [v2]

2025-05-07 Thread Daniel Fuchs
On Fri, 2 May 2025 09:15:24 GMT, Volkan Yazici wrote: >> Replaces `os.name` checks in tests with `@requires`. This prevents these >> tests from being run, and superficial results being generated, on >> unnecessary platforms. >> >> Note that `os.name` checks are replaced with `os.family` instea

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-07 Thread Daniel Fuchs
On Wed, 7 May 2025 10:37:47 GMT, Jaikiran Pai wrote: >> Okay with me but for SocketImpl then I think it has to be an apiNote as the >> create method is not deprecated. >> >> BTW: "Use DatagramSocket instead for UDP transport" switches the >> terminology. The first sentence uses "datagram socke

Re: RFR: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value [v2]

2025-05-07 Thread Daniel Fuchs
On Fri, 2 May 2025 09:15:24 GMT, Volkan Yazici wrote: >> Replaces `os.name` checks in tests with `@requires`. This prevents these >> tests from being run, and superficial results being generated, on >> unnecessary platforms. >> >> Note that `os.name` checks are replaced with `os.family` instea

RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method

2025-05-07 Thread kieran-farrell
Spec currently suggests that only IPv6 addresses can return null for InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 address such as the loopback address do not support broadcasting and can therefore also return null. - Commit messages: - update inetadd

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v9]

2025-05-07 Thread Jaikiran Pai
On Wed, 7 May 2025 11:34:08 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to respecify the 2 >> `java.net.Socket` constructors that allow construction of UDP sockets? This >> addresses https://bugs.openjdk.org/browse/JDK-8356154. >> >> As noted in that JBS

Integrated: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException

2025-05-07 Thread Jaikiran Pai
On Mon, 5 May 2025 10:12:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to respecify the 2 > `java.net.Socket` constructors that allow construction of UDP sockets? This > addresses https://bugs.openjdk.org/browse/JDK-8356154. > > As noted in that JBS issu

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-05-07 Thread Rajan Halade
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich wrote: >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > Mikhail Yankelevich has updated the pull request incrementally with one > a

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-07 Thread Bradford Wetmore
On Wed, 7 May 2025 16:28:27 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578 >> for compilation) > > src/java.base/share

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v5]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Per Minborg
On Wed, 7 May 2025 11:54:09 GMT, David Beaumont wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Reformat >> - Revert changes in public classes > > test/jdk/java/lang/StableValue/StableFieldUpdaterExampleTest.java

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v9]

2025-05-07 Thread Daniel Fuchs
On Wed, 7 May 2025 11:34:08 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to respecify the 2 >> `java.net.Socket` constructors that allow construction of UDP sockets? This >> addresses https://bugs.openjdk.org/browse/JDK-8356154. >> >> As noted in that JBS

Re: RFR: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value [v2]

2025-05-07 Thread duke
On Fri, 2 May 2025 09:15:24 GMT, Volkan Yazici wrote: >> Replaces `os.name` checks in tests with `@requires`. This prevents these >> tests from being run, and superficial results being generated, on >> unnecessary platforms. >> >> Note that `os.name` checks are replaced with `os.family` instea

Integrated: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value

2025-05-07 Thread Volkan Yazici
On Fri, 2 May 2025 08:26:48 GMT, Volkan Yazici wrote: > Replaces `os.name` checks in tests with `@requires`. This prevents these > tests from being run, and superficial results being generated, on unnecessary > platforms. > > Note that `os.name` checks are replaced with `os.family` instead. T

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v2]

2025-05-07 Thread Per Minborg
On Tue, 6 May 2025 15:34:11 GMT, Daniel Fuchs wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix raw long updater under 32-bit mode > > src/java.base/share/classes/java/net/URI.java line 558: > >> 556: >> 557:

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Per Minborg
On Tue, 6 May 2025 12:23:44 GMT, Chen Liang wrote: >> This would require another implementation to be written. Maybe we can add >> that later? > > I feel like declaring a function is declaring redundant classes when we can > just reuse a DirectMethodHandle pointing to an actual method. Also the

Re: RFR: 7046003: Default value of Authenticator.getRequestingURL() is not specified [v2]

2025-05-07 Thread kieran-farrell
On Wed, 7 May 2025 15:58:29 GMT, Chen Liang wrote: > CCC is a legacy internal process only present for archival purposes. I think > we should withdraw that CCC and remove the "csr of" link so we can create a > new CSR. @liach - Old CSR withdrawn and new CSR created - JDK-8356410, thank you --

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-07 Thread Weijun Wang
On Wed, 7 May 2025 05:47:30 GMT, Bradford Wetmore wrote: >> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE >> respectively. >> >> CSR is underway. >> >> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK >> API (jck:api/java_security jck:a

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-07 Thread Weijun Wang
On Wed, 7 May 2025 05:47:30 GMT, Bradford Wetmore wrote: >> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE >> respectively. >> >> CSR is underway. >> >> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK >> API (jck:api/java_security jck:a

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v9]

2025-05-07 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to respecify the 2 > `java.net.Socket` constructors that allow construction of UDP sockets? This > addresses https://bugs.openjdk.org/browse/JDK-8356154. > > As noted in that JBS issue, in Java 23 we deprecated for removal the 2 > `Socke

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Chen Liang
On Wed, 7 May 2025 09:23:45 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v6]

2025-05-07 Thread ExE Boss
On Wed, 7 May 2025 14:58:33 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen

Re: RFR: 7046003: Default value of Authenticator.getRequestingURL() is not specified [v2]

2025-05-07 Thread Chen Liang
On Wed, 7 May 2025 14:39:35 GMT, kieran-farrell wrote: >> Clarificatiion of spec to outline that Authenticator.getRequestingURL() >> returns null in the event that the corresponding request does not specify a >> URL. > > kieran-farrell has updated the pull request incrementally with one additio

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v7]

2025-05-07 Thread ExE Boss
On Wed, 7 May 2025 15:03:57 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-07 Thread Jaikiran Pai
On Tue, 6 May 2025 15:22:02 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Michael's review suggestions > > src/java.base/share/classes/java/net/Socket.java line 390: > >> 388: * The {@code

Re: RFR: 8353440: Disable FTP fallback for non-local file URLs by default [v14]

2025-05-07 Thread Eirik Bjørsnøs
On Fri, 2 May 2025 20:32:27 GMT, Eirik Bjørsnøs wrote: >> Please help review this PR which disables the unspecified but long-standing >> feature where an `FtpURLConnection` is opened as a fallback for non-local >> file URLs. >> >> Before this change, if a file URL has a non-local host componen

Re: RFR: 7046003: Default value of Authenticator.getRequestingURL() is not specified [v2]

2025-05-07 Thread kieran-farrell
On Wed, 7 May 2025 14:39:35 GMT, kieran-farrell wrote: >> Clarificatiion of spec to outline that Authenticator.getRequestingURL() >> returns null in the event that the corresponding request does not specify a >> URL. > > kieran-farrell has updated the pull request incrementally with one additio

Re: RFR: 7046003: Default value of Authenticator.getRequestingURL() is not specified [v2]

2025-05-07 Thread Chen Liang
On Wed, 7 May 2025 14:39:35 GMT, kieran-farrell wrote: >> Clarificatiion of spec to outline that Authenticator.getRequestingURL() >> returns null in the event that the corresponding request does not specify a >> URL. > > kieran-farrell has updated the pull request incrementally with one additio

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 10:29:44 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/net/Socket.java line 390: >> >>> 388: * The {@code stream} parameter provided a way in early JDK >>> releases >>> 389: * to create a {@code Socket} that used a datagram socket. This >>> feature >

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-07 Thread Jaikiran Pai
On Wed, 7 May 2025 10:34:07 GMT, Alan Bateman wrote: > Okay with me but for SocketImpl then I think it has to be an apiNote as the > create method is not deprecated. Makes sense. > BTW: "Use DatagramSocket instead for UDP transport" switches the terminology. > The first sentence uses "datagr

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-07 Thread Jaikiran Pai
On Wed, 7 May 2025 11:16:48 GMT, Daniel Fuchs wrote: >>> Okay with me but for SocketImpl then I think it has to be an apiNote as the >>> create method is not deprecated. >> >> Makes sense. >> >>> BTW: "Use DatagramSocket instead for UDP transport" switches the >>> terminology. The first sent

Re: RFR: 7046003: Default value of Authenticator.getRequestingURL() is not specified [v2]

2025-05-07 Thread kieran-farrell
> Clarificatiion of spec to outline that Authenticator.getRequestingURL() > returns null in the event that the corresponding request does not specify a > URL. kieran-farrell has updated the pull request incrementally with one additional commit since the last revision: revert changes ---

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method

2025-05-07 Thread Daniel Fuchs
On Wed, 7 May 2025 14:02:52 GMT, kieran-farrell wrote: > Spec currently suggests that only IPv6 addresses can return null for > InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 > address such as the loopback address do not support broadcasting and can > therefore als

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v6]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v7]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 11:29:11 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Document `@requires` rationale with `@comment` >> >> Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.gi

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread David Beaumont
On Wed, 7 May 2025 09:23:45 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v8]

2025-05-07 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v3]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v3]

2025-05-07 Thread Shaojin Wen
On Wed, 7 May 2025 07:46:45 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen