On Wed, 7 May 2025 10:37:47 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Okay with me but for SocketImpl then I think it has to be an apiNote as the >> create method is not deprecated. >> >> BTW: "Use DatagramSocket instead for UDP transport" switches the >> terminology. The first sentence uses "datagram socket" so I best to use that >> in the second sentence to avoid "UDP" and "transport". > >> Okay with me but for SocketImpl then I think it has to be an apiNote as the >> create method is not deprecated. > > Makes sense. > >> BTW: "Use DatagramSocket instead for UDP transport" switches the >> terminology. The first sentence uses "datagram socket" so I best to use that >> in the second sentence to avoid "UDP" and "transport". > > I agree, I'll use "datagram socket". Thanks Jaikiran. Yes - it feels weird to add an `@apiNote` to a method or constructor that has long been deprecated: if it's deprecated you're not supposed to use it. I couldn't help feeling that using an `@apiNote` there conveyed the wrong message. I am completely OK with the `@apiNote` on the `create` method though - since that one isn't deprecated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25031#discussion_r2077398768
