On Thu, 10 Apr 2025 07:31:37 GMT, Magnus Ihse Bursie wrote:
>> Right, that `å` looks to have been incorrectly converted during the
>> ISO-8859-1 to UTF-8 conversion. (I can't find the script used for conversion
>> as this change is from some time ago.)
>>
>> Since the change occurs in a commen
On Thu, 10 Apr 2025 12:48:32 GMT, Volkan Yazici wrote:
>> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
>> don't fully implement the described requirements.
>>
>> This PR adds the following validation:
>> - pseudo-headers defined for requests are rejected in respo
On Thu, 10 Apr 2025 11:37:23 GMT, Daniel Jeliński wrote:
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
> don't fully implement the described requirements.
>
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in response
On Thu, 10 Apr 2025 11:37:23 GMT, Daniel Jeliński wrote:
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
> don't fully implement the described requirements.
>
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in response
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Thu, 10 Apr 2025 12:59:25 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/common/ValidatingHeadersConsumer.java
>> line 46:
>>
>>> 44: REQUEST,
>>> 45: RESPONSE,
>>> 46: TRAILER
>>
>> Do we need `TRAILER`, given we don't use it, AFAI
On Thu, 10 Apr 2025 12:41:51 GMT, Volkan Yazici wrote:
>> Daniel Jeliński has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove trailers
>> - Add bug id
>
> test/jdk/java/net/httpclient/http2/BadHeadersTest.java line 30:
>
>> 28: *
On Mon, 7 Apr 2025 18:40:35 GMT, Roger Riggs wrote:
>> Now that the Security Manager is permanently disabled, the following
>> permission classes in the core libraries area can be deprecated for removal
>> as they are no longer useful: FilePermission, LinkPermission,
>> LoggingPermission, Prop
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
> don't fully implement the described requirements.
>
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in responses and push
> streams
> - pseudo-headers defined for respon
On Thu, 10 Apr 2025 13:31:40 GMT, Daniel Jeliński wrote:
>> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
>> don't fully implement the described requirements.
>>
>> This PR adds the following validation:
>> - pseudo-headers defined for requests are rejected in res
On Thu, 10 Apr 2025 12:45:40 GMT, Volkan Yazici wrote:
>> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
>> don't fully implement the described requirements.
>>
>> This PR adds the following validation:
>> - pseudo-headers defined for requests are rejected in respo
On Tue, 8 Apr 2025 19:27:17 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates:
Any endpoint receiving any certificate which it would need to
validate using any signature algorithm using an MD5 hash MUST abort
the handshake with a "bad_certificate" alert.
The bug manifests itself when older versions of
On Thu, 10 Apr 2025 13:52:52 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add `@implNote` to state that the built-in is always non-empty
>
> test/jdk/java/net/httpclient/HttpResponseConnection
On Tue, 8 Apr 2025 19:27:17 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
On Thu, 10 Apr 2025 05:47:09 GMT, Volkan Yazici wrote:
> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
Marked as reviewed by dfuchs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24561#pullrequestreview-2756129194
On Thu, 10 Apr 2025 05:52:07 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yaz
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote:
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
This pull request ha
On Thu, 10 Apr 2025 05:47:09 GMT, Volkan Yazici wrote:
> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
LGTM.
Don't use `noreg-self` for this. That label is used for fixing test issues.
`noreg-perf` or `noreg-cleanup` would be more appropriate here.
-
Marked as revi
`ServerUdsChannelHolder` is introduced to manage the life cycle of a
`ServerSocketChannel` created using Unix domain sockets (UDS) in a thread-safe
manner.
### Testing
Changes can be tested as follows:
make build-microbenchmark
build/linux-x64/jdk/bin/java \
-jar build/linux-x64/images/test
On Thu, 10 Apr 2025 10:49:04 GMT, Daniel Jeliński wrote:
>> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
>
> LGTM.
>
> Don't use `noreg-self` for this. That label is used for fixing test issues.
> `noreg-perf` or `noreg-cleanup` would be more appropriate here.
@djelinski, thank
On Thu, 10 Apr 2025 05:47:09 GMT, Volkan Yazici wrote:
> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
Marked as reviewed by michaelm (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24561#pullrequestreview-2756348007
On Thu, 10 Apr 2025 05:47:09 GMT, Volkan Yazici wrote:
> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
@vy
Your change (at version 4385b04466227cacdc9d58e9f6cd1f55968b0e27) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/
RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
don't fully implement the described requirements.
This PR adds the following validation:
- pseudo-headers defined for requests are rejected in responses and push streams
- pseudo-headers defined for responses are rejecte
On Thu, 10 Apr 2025 11:23:57 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This is a minor doc change to clarify that java.net.http.HttpClient only
>> supports HTTP Basic authentication.
>>
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one
> additional c
On Thu, 10 Apr 2025 05:52:07 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yaz
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote:
>> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right
>> now, where I will include a fix for this as well.
>
> If anything, I might be a bit worried that there are more incorrect
> conversions stemming from this
On Thu, 10 Apr 2025 08:08:02 GMT, Eirik Bjørsnøs wrote:
>> If anything, I might be a bit worried that there are more incorrect
>> conversions stemming from this PR, that my automated tools and manual
>> scanning has not revealed.
>
> Some observations:
>
> 1: This PR seems to have been abondo
On Thu, 10 Apr 2025 11:23:57 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This is a minor doc change to clarify that java.net.http.HttpClient only
>> supports HTTP Basic authentication.
>>
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one
> additional c
On Wed, 9 Apr 2025 14:35:30 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yazi
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
> don't fully implement the described requirements.
>
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in responses and push
> streams
> - pseudo-headers defined for respon
On Mon, 7 Apr 2025 13:22:56 GMT, Eirik Bjørsnøs wrote:
>> Please help review this cleanup PR which consolidates 'local file' URL
>> checks across the 'file:' and 'jar:' URL scheme implementations and defines
>> this check in terms of RFC 8089, Section 2.
>>
>> This PR:
>>
>> * Moves `URLJarFi
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
> don't fully implement the described requirements.
>
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in responses and push
> streams
> - pseudo-headers defined for respon
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Wed, 9 Apr 2025 11:35:29 GMT, Jaikiran Pai wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review suggestions
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 74:
>
>> 72: @MethodSource("
On Thu, 10 Apr 2025 11:37:23 GMT, Daniel Jeliński wrote:
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient
> don't fully implement the described requirements.
>
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in response
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace InputStreamReader with BufferedReader
>
> FWIW, I checked out the revision of the commit previous to this change
On Fri, 4 Apr 2025 12:37:32 GMT, Roger Riggs wrote:
> Now that the Security Manager is permanently disabled, the following
> permission classes in the core libraries area can be deprecated for removal
> as they are no longer useful: FilePermission, LinkPermission,
> LoggingPermission, Property
On Wed, 9 Apr 2025 14:08:06 GMT, Michael McMahon wrote:
> Hi,
>
> This is a minor doc change to clarify that java.net.http.HttpClient only
> supports HTTP Basic authentication.
>
> Thanks,
> Michael
This pull request has now been integrated.
Changeset: e35f67b9
Author:Michael McMahon
UR
> Now that the Security Manager is permanently disabled, the following
> permission classes in the core libraries area can be deprecated for removal
> as they are no longer useful: FilePermission, LinkPermission,
> LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission,
> a
Overhauls `EmptyAuthenticate` to
- Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
- Test both clear-text and SSL
- Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related problems
-
Commit messages:
- Overhaul `EmptyAuthenticate`
Changes: https://git.ope
On Tue, 8 Apr 2025 12:33:52 GMT, serhiysachkov wrote:
> Remove extra args to System.out.printf in open/test/jsk/java/net/httpclient
> tests
This pull request has now been integrated.
Changeset: f94a4f7a
Author:Serhiy Sachkov
Committer: Mahendra Chhipa
URL:
https://git.openjdk.org/
On Thu, 10 Apr 2025 21:26:21 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich
wrote:
>> * fully automated the test
>> * removed the race condition
>> * client on a thread and server on a thread options are now run together
>> automatically
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> a
On Wed, 9 Apr 2025 21:26:15 GMT, Justin Lu wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties
>> line 22:
>>
>>> 20: # Peter Smolik
>>> 21: Cp1250 WINDOWS-1250 0x00FF
>>> 22: # Patch attributed to hava...@underdusken.no (H�vard Wigtil)
>>
>> Th
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
> Hi,
>
> This is a minor doc change to clarify that java.net.http.HttpClient only
> supports HTTP Basic authentication.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
copyright update
-
Chan
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
49 matches
Mail list logo
