On Wed, 9 Apr 2025 11:35:29 GMT, Jaikiran Pai <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review suggestions
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 74:
>
>> 72: @MethodSource("args")
>> 73: void test(Version version, boolean secure) throws Exception {
>> 74: HttpTestServer server =
>> createStartedServerRespondingWithEmptyWwwAuthHeader(version, secure);
>
> Nit - in general, I think it should be OK to have simpler names for these
> methods. So `startServer()` should be fine. Similarly the
> `ServerHandlerRespondingWithEmptyWwwAuthHeader` handler class could be named
> just `Handler`. If the method or the class in these tests does something very
> involved (unlike in this case), I think, the names can still stay simple and
> a brief code comment on the method/class would be fine.
>
> However, if you prefer it to use the current form, that's fine with me.
Shortened in 7b5c849002c2302a3b4d4cdec3fd427fc9a1c4f7.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24542#discussion_r2035387247
