Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v4]

2024-09-26 Thread Naoto Sato
On Wed, 25 Sep 2024 23:32:08 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >>

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v5]

2024-09-26 Thread Daniel Fuchs
On Thu, 26 Sep 2024 17:00:18 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >>

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v6]

2024-09-26 Thread Justin Lu
> Please review this PR which removes usages of Applet within the corelibs > tests. > > Most changes are removed comments/updated var names. The JBS issue lists more > files than the ones included in this pull request, please see the comment on > the JBS issue for the reason why they were not i

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v5]

2024-09-26 Thread Justin Lu
On Thu, 26 Sep 2024 17:06:38 GMT, Daniel Fuchs wrote: > `test/jdk/sun/net/www/ParseUtil_6380332.java`: shouldn't we actually keep > this test? I see that the code in ParseUtil which is tested here is still > there, and I don't think we'd want to touch ParseUtil given potential > compatibility

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v6]

2024-09-26 Thread Daniel Fuchs
On Thu, 26 Sep 2024 17:24:18 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >>

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v4]

2024-09-26 Thread Naoto Sato
On Thu, 26 Sep 2024 21:03:20 GMT, Phil Race wrote: >> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80: >> >>> 78: 6. Turn on "Adjust for daylight saving time automatically" >>> 79: >>> 80: If the local time in the control panel and test window are >>> alw

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v4]

2024-09-26 Thread Phil Race
On Thu, 26 Sep 2024 16:25:21 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review: update wording of instructions > > test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80: > >> 78: