Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]

2024-09-25 Thread Naoto Sato
On Wed, 25 Sep 2024 18:28:02 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >>

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v3]

2024-09-25 Thread Naoto Sato
On Wed, 25 Sep 2024 22:06:55 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >>

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v3]

2024-09-25 Thread Justin Lu
> Please review this PR which removes usages of Applet within the corelibs > tests. > > Most changes are removed comments/updated var names. The JBS issue lists more > files than the ones included in this pull request, please see the comment on > the JBS issue for the reason why they were not i

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]

2024-09-25 Thread Justin Lu
On Wed, 25 Sep 2024 21:36:54 GMT, Naoto Sato wrote: > Removing `test/jdk/java/util/TimeZone/DefaultTimeZoneTest.*` looks good to > me. It's a manual test that involves underlying OS settings manipulation > which cannot be automated. As we previously spoke offline, I did not think there was muc

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]

2024-09-25 Thread Phil Race
On Wed, 25 Sep 2024 22:03:59 GMT, Justin Lu wrote: > Not sure if it will be ran by anyone as it is manual, I don't know about other vendors, but for Oracle, manual tests are run at least once on every release some time after RDP1 and before RDP2. - PR Comment: https://git.openjd

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v4]

2024-09-25 Thread Justin Lu
> Please review this PR which removes usages of Applet within the corelibs > tests. > > Most changes are removed comments/updated var names. The JBS issue lists more > files than the ones included in this pull request, please see the comment on > the JBS issue for the reason why they were not i

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]

2024-09-25 Thread Justin Lu
> Please review this PR which removes usages of Applet within the corelibs > tests. This includes both code usage as well as occurrences of the word. > > There were more files found than the ones included in this PR, please see the > comment on the JBS issue for the reason why they were not incl