Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v3]

2024-09-03 Thread Daniel Jeliński
On Mon, 2 Sep 2024 17:44:31 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes [v2]

2024-09-03 Thread Daniel Fuchs
> The `java/net/httpclient/HttpsTunnelAuthTest.java` has been observed failing > intermittently with `java.io.IOException: HTTP/1.1 header parser received no > bytes`, ... `Caused by: java.net.SocketException: Connection reset `. > > My suspicion is that the ProxyServer used by this test is the

Re: RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes [v2]

2024-09-03 Thread Daniel Fuchs
On Tue, 3 Sep 2024 06:48:38 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review feedback > > test/jdk/java/net/httpclient/ProxyServer.java line 199: > >> 197: >> 198: volatile bool

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v4]

2024-09-03 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision: - Update src/java.base/share/classes/java/

Re: RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes [v2]

2024-09-03 Thread Daniel Jeliński
On Tue, 3 Sep 2024 11:08:48 GMT, Daniel Fuchs wrote: >> The `java/net/httpclient/HttpsTunnelAuthTest.java` has been observed failing >> intermittently with `java.io.IOException: HTTP/1.1 header parser received no >> bytes`, ... `Caused by: java.net.SocketException: Connection reset `. >> >> My

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v5]

2024-09-03 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with six additional commits since the last revision: - Update src/java.base/share/classes/java/

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v4]

2024-09-03 Thread Daniel Fuchs
On Tue, 3 Sep 2024 11:15:52 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with two additional > commits since t

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v6]

2024-09-03 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Fix typo - Changes: - all:

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v7]

2024-09-03 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Integrated more feedback - C

Re: RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes [v2]

2024-09-03 Thread Jaikiran Pai
On Tue, 3 Sep 2024 11:08:48 GMT, Daniel Fuchs wrote: >> The `java/net/httpclient/HttpsTunnelAuthTest.java` has been observed failing >> intermittently with `java.io.IOException: HTTP/1.1 header parser received no >> bytes`, ... `Caused by: java.net.SocketException: Connection reset `. >> >> My

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v7]

2024-09-03 Thread Daniel Fuchs
On Tue, 3 Sep 2024 13:05:33 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since th

Integrated: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes

2024-09-03 Thread Daniel Fuchs
On Thu, 22 Aug 2024 11:04:52 GMT, Daniel Fuchs wrote: > The `java/net/httpclient/HttpsTunnelAuthTest.java` has been observed failing > intermittently with `java.io.IOException: HTTP/1.1 header parser received no > bytes`, ... `Caused by: java.net.SocketException: Connection reset `. > > My sus

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v8]

2024-09-03 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brough

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v8]

2024-09-03 Thread Mark Sheppard
On Tue, 3 Sep 2024 13:54:44 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v9]

2024-09-03 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Review feedback - Changes: