On Tue, 3 Sep 2024 13:54:44 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 14 additional > commits since the last revision: > > - Merge branch 'master' into NetworkInterface-8283779 > - Integrated more feedback > - Fix typo > - Update src/java.base/share/classes/java/net/NetworkInterface.java > - Update src/java.base/share/classes/java/net/NetworkInterface.java > - Update src/java.base/share/classes/java/net/NetworkInterface.java > - Update src/java.base/share/classes/java/net/NetworkInterface.java > - Update src/java.base/share/classes/java/net/NetworkInterface.java > - Update src/java.base/share/classes/java/net/NetworkInterface.java > - Update src/java.base/share/classes/java/net/NetworkInterface.java > > Co-authored-by: Daniel Jelinski <djelins...@gmail.com> > - ... and 4 more: https://git.openjdk.org/jdk/compare/2f860c3f...7e335f83 These are good additions and help fortify the current apiNote on the equals method and help bring into focus the transient and dynamic nature of NetworkInterface configurations in contemporary network environments. src/java.base/share/classes/java/net/NetworkInterface.java line 121: > 119: * > 120: * @implNote > 121: * The returned enumeration contains all or a subset of the > InetAddresses that were perhaps additional comma for emphasis The returned enumeration contains all, or a subset, of the InetAddresses . . . src/java.base/share/classes/java/net/NetworkInterface.java line 145: > 143: * > 144: * @implNote > 145: * The stream contains all or a subset of the InetAddresses that were perhaps additional comma for emphasis The stream contains all, or a subset, of the InetAddresses . . . ------------- PR Review: https://git.openjdk.org/jdk/pull/20822#pullrequestreview-2278116444 PR Review Comment: https://git.openjdk.org/jdk/pull/20822#discussion_r1742460905 PR Review Comment: https://git.openjdk.org/jdk/pull/20822#discussion_r1742462603
