Integrated: 8339169: Remove NaiveHuffman coder

2024-09-02 Thread Aleksei Efimov
On Thu, 29 Aug 2024 10:21:45 GMT, Aleksei Efimov wrote: > `jdk.internal.net.http.hpack.NaiveHuffman` is an internal class and not used > in `java.net.http` module or any test. > It is proposed to remove this class. > `HttpClient` will continue to use the > `jdk.internal.net.http.hpack.Quick

Re: RFR: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)

2024-09-02 Thread Jaikiran Pai
On Fri, 30 Aug 2024 13:26:57 GMT, Daniel Fuchs wrote: > The fired assert appears to be too strong and can be safely removed. The test > uses a "Staller" to stall the delivery of bytes to the body handlers. > However, the stalling happens for the push promise response bodies, and > there's no g

RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes

2024-09-02 Thread Daniel Fuchs
Please find here a change that adds a few `@apiNote` and `@implNote` to `NetworkInterface` to clarify user expectation and implementation. - Commit messages: - 8283779 Changes: https://git.openjdk.org/jdk/pull/20822/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20822&ran

Integrated: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)

2024-09-02 Thread Daniel Fuchs
On Fri, 30 Aug 2024 13:26:57 GMT, Daniel Fuchs wrote: > The fired assert appears to be too strong and can be safely removed. The test > uses a "Staller" to stall the delivery of bytes to the body handlers. > However, the stalling happens for the push promise response bodies, and > there's no g

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes

2024-09-02 Thread Mark Sheppard
On Mon, 2 Sep 2024 13:48:55 GMT, Daniel Fuchs wrote: > Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Also, I think it would be useful and helpful to allude to the "snapshot" characteristics of a Netw

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v2]

2024-09-02 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Improve class-level API documentation ---

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v3]

2024-09-02 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Improve class level description again ---

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v3]

2024-09-02 Thread Alan Bateman
On Mon, 2 Sep 2024 17:44:31 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v3]

2024-09-02 Thread Alan Bateman
On Mon, 2 Sep 2024 17:44:31 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes

2024-09-02 Thread Daniel Jeliński
On Thu, 22 Aug 2024 11:04:52 GMT, Daniel Fuchs wrote: > The `java/net/httpclient/HttpsTunnelAuthTest.java` has been observed failing > intermittently with `java.io.IOException: HTTP/1.1 header parser received no > bytes`, ... `Caused by: java.net.SocketException: Connection reset `. > > My sus