On Fri, 30 Aug 2024 13:26:57 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> The fired assert appears to be too strong and can be safely removed. The test > uses a "Staller" to stall the delivery of bytes to the body handlers. > However, the stalling happens for the push promise response bodies, and > there's no guarantee the main response body can't be fully completed before > the push promise bodies start being delivered. > > I have replaced the assert with a comment, and also updated the test to make > it easier to parse logs and diagnose future issues. This test-only change looks OK to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20795#pullrequestreview-2275373360
