Re: RFR: 8336817: DatagramSocket.connect does not specify behavior when already connected

2024-08-13 Thread Alan Bateman
On Mon, 12 Aug 2024 08:18:17 GMT, Jaikiran Pai wrote: > Can I please get a review of this doc-only change which updates the javadoc > on several methods of the `java.net.DatagramSocket` class to match its > current implementation? > > This addresses https://bugs.openjdk.org/browse/JDK-8336817.

Re: RFR: 8324209: Check implementation of Expect: 100-continue in the java.net.http.HttpClient [v3]

2024-08-13 Thread Daniel Fuchs
On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke wrote: >> Currently `HttpClient` will timeout if a server doesn't respond to a request >> which includes `Expect: 100-Continue` >> >> Section 10.1.1 of [rfc >> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that >> >> a

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v6]

2024-08-13 Thread Jaikiran Pai
> Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. > The HTTP3 RFC https://www.rfc-

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v5]

2024-08-13 Thread Jaikiran Pai
On Mon, 12 Aug 2024 14:33:29 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> simplify request approver test construct - no need to expect request path > > src/java.net.http/share/classes/jdk/inter

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v6]

2024-08-13 Thread Jaikiran Pai
On Tue, 13 Aug 2024 13:19:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes the issue noted in >> https://bugs.openjdk.org/browse/JDK-8335181? >> >> As noted in that issue, the current implementation in the >> `java.net.http.HttpClient` doesn't correctly handl

Withdrawn: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

2024-08-13 Thread Jaikiran Pai
On Fri, 2 Aug 2024 11:13:42 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an i

RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

2024-08-13 Thread Jaikiran Pai
This is a fresh version of the PR that I had opened here https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up causing unexpected issues with that old PR. The commits in this PR are the ones which were already reviewed and a new one which was done to implement Daniel's sugge

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-13 Thread Jaikiran Pai
> This is a fresh version of the PR that I had opened here > https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up > causing unexpected issues with that old PR. > > The commits in this PR are the ones which were already reviewed and a new one > which was done to implement Da

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-13 Thread Daniel Fuchs
On Tue, 13 Aug 2024 15:08:24 GMT, Jaikiran Pai wrote: >> This is a fresh version of the PR that I had opened here >> https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up >> causing unexpected issues with that old PR. >> >> The commits in this PR are the ones which were alr

RFR: 8336655: java/net/httpclient/DigestEchoClient.java IOException: HTTP/1.1 header parser received no bytes

2024-08-13 Thread Daniel Fuchs
Please find here a fix for [8336655: java/net/httpclient/DigestEchoClient.java IOException: HTTP/1.1 header parser received no bytes](https://bugs.openjdk.org/browse/JDK-8336655). This fix has been seen failing intermittently on the mainline. When an HTTP/1.1 is returned to the HTTP/1.1 pool, a

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-13 Thread Jaikiran Pai
On Tue, 13 Aug 2024 15:08:24 GMT, Jaikiran Pai wrote: >> This is a fresh version of the PR that I had opened here >> https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up >> causing unexpected issues with that old PR. >> >> The commits in this PR are the ones which were alr

Integrated: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

2024-08-13 Thread Jaikiran Pai
On Tue, 13 Aug 2024 13:32:19 GMT, Jaikiran Pai wrote: > This is a fresh version of the PR that I had opened here > https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up > causing unexpected issues with that old PR. > > The commits in this PR are the ones which were already