Re: RFR: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed [v5]

2024-07-24 Thread Jaikiran Pai
> Can I please get a review of this change which updates the specification of a > few methods in `java.net.Socket` and `java.net.ServerSocket` classes to > specify the `IOException` that the implementation currently already throws? > > This is merely a doc update and doesn't change the implement

Re: RFR: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed [v4]

2024-07-24 Thread Jaikiran Pai
On Sat, 20 Jul 2024 16:49:09 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which updates the specification of >> a few methods in `java.net.Socket` and `java.net.ServerSocket` classes to >> specify the `IOException` that the implementation currently already throws? >> >>

Re: RFR: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed [v5]

2024-07-24 Thread Alan Bateman
On Wed, 24 Jul 2024 11:03:50 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which updates the specification of >> a few methods in `java.net.Socket` and `java.net.ServerSocket` classes to >> specify the `IOException` that the implementation currently already throws? >> >>

Re: RFR: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed [v6]

2024-07-24 Thread Jaikiran Pai
> Can I please get a review of this change which updates the specification of a > few methods in `java.net.Socket` and `java.net.ServerSocket` classes to > specify the `IOException` that the implementation currently already throws? > > This is merely a doc update and doesn't change the implement

Re: RFR: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed [v5]

2024-07-24 Thread Jaikiran Pai
On Wed, 24 Jul 2024 11:10:10 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add Joe's suggestion to the close() methods > > src/java.base/share/classes/java/net/Socket.java line 1737: > >> 1735:

Re: RFR: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed [v6]

2024-07-24 Thread Alan Bateman
On Wed, 24 Jul 2024 11:37:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which updates the specification of >> a few methods in `java.net.Socket` and `java.net.ServerSocket` classes to >> specify the `IOException` that the implementation currently already throws? >> >>

Integrated: 8336815: Several methods in java.net.Socket and ServerSocket do not specify behavior when already bound, connected or closed

2024-07-24 Thread Jaikiran Pai
On Sat, 20 Jul 2024 07:51:59 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which updates the specification of a > few methods in `java.net.Socket` and `java.net.ServerSocket` classes to > specify the `IOException` that the implementation currently already throws? > > This

RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2024-07-24 Thread Brian Burkhalter
This proposed change would move the native objects required for NIO file interaction from the libnio native library to the libjava native library on Linux, macOS, and Windows. - Commit messages: - 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava Cha

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2024-07-24 Thread Brian Burkhalter
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote: > This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. This change passes CI tiers 1-5 jobs on all platforms.

Fwd: Very long response headers and java.net.http.HttpClient?

2024-07-24 Thread Andy Boothe
Hello, I'm moving this thread from jdk-dev to this list on the sage advice of Pavel Rappo. As a brief recap, it looks like HttpClient and HttpURLConnection do not currently support a way to set the maximum acceptable response header length. As a result, sending HTTP requests with these classes th