Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v7]

2024-05-06 Thread Jaikiran Pai
On Wed, 17 Apr 2024 22:23:41 GMT, Sergey Chernyshev wrote: >> There are two distinct approaches to parsing IPv4 literal addresses. One is >> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another >> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v7]

2024-05-06 Thread Sergey Chernyshev
On Mon, 6 May 2024 10:35:35 GMT, Jaikiran Pai wrote: > Hello Sergey, do you plan to update the PR with the class level doc change > suggested by Michael? Hi @jaikiran ! Yes I plan to update the PR. Apologies for the delay. - PR Comment: https://git.openjdk.org/jdk/pull/18493#issue

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v7]

2024-05-06 Thread Sergey Chernyshev
On Thu, 18 Apr 2024 13:29:21 GMT, Michael McMahon wrote: >>> which lists the methods that parse as decimal only, and the new method >>> which parses using the "loose" syntax. >> >> That might not be practical: the only method that supports non decimal form >> is the new `ofBSDLiteral`. But any

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v8]

2024-05-06 Thread Sergey Chernyshev
> There are two distinct approaches to parsing IPv4 literal addresses. One is > the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another > one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr` > allowing octal and hexadecimal forms [2]). The goal of this

RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-06 Thread Christian Stein
Please pre-review this draft pull request adding a default for response for the `/favicon.ico` path to the Simple Web Server introduced by [JEP 408](https://openjdk.org/jeps/408). The image in this PR is a copy of https://inside.java/images/favicon.ico Before this change, an initial request fro

Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-06 Thread Christian Stein
On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein wrote: > Please pre-review this draft pull request adding a default for response for > the `/favicon.ico` path to the Simple Web Server introduced by [JEP > 408](https://openjdk.org/jeps/408). The image in this PR is a copy of > https://inside.

Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-06 Thread Christian Stein
On Mon, 6 May 2024 14:55:31 GMT, Christian Stein wrote: >> Please pre-review this draft pull request adding a default for response for >> the `/favicon.ico` path to the Simple Web Server introduced by [JEP >> 408](https://openjdk.org/jeps/408). The image in this PR is a copy of >> https://insi