Re: RFR: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length [v27]

2024-05-03 Thread Michael McMahon
On Thu, 25 Apr 2024 17:01:52 GMT, robert engels wrote: >> fix bug JDK-B6968351 by avoiding flush after response headers > > robert engels has updated the pull request incrementally with one additional > commit since the last revision: > > update copyright date Looks fine. Thanks for the cont

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-05-03 Thread Ethan McCue
On Wed, 1 May 2024 21:12:05 GMT, robert engels wrote: >> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge remot

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-05-03 Thread robert engels
On Fri, 3 May 2024 13:17:43 GMT, Ethan McCue wrote: >> robert engels has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'robaho/HttpExchange-api-change' into >> HttpExchange-api-change >> >># Conflict

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-05-03 Thread Ethan McCue
On Wed, 1 May 2024 21:12:05 GMT, robert engels wrote: >> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge remot

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-05-03 Thread robert engels
On Fri, 3 May 2024 13:23:59 GMT, robert engels wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java >> line 82: >> >>> 80: * @see #sendResponseHeaders(int, long) >>> 81: * */ >>> 82: public static final long CHUNKED_CONTENT = 0L; >> >> I feel a lit

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-05-03 Thread Ethan McCue
On Fri, 3 May 2024 13:38:10 GMT, robert engels wrote: > and people have made do I think there is cause for this level of analysis. Specifically * This API, while part of the JDK, is not in widespread professional use * The intended use-case of the API is now "reducing the "getting startup" eff

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-05-03 Thread robert engels
On Fri, 3 May 2024 13:53:39 GMT, Ethan McCue wrote: >> I think the solution is to document that the length must be greater than 0 >> or BBC an IllegalArgumentException is thrown. >> >> As I mention in the other comment - there is only really a single use for >> this - streaming a file of know