On Fri, 2 May 2025 20:32:27 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host componen
On Fri, 2 May 2025 20:32:27 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host componen
On Fri, 2 May 2025 20:32:27 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host componen
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Fri, 25 Apr 2025 18:56:36 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Mon, 28 Apr 2025 09:21:54 GMT, Michael McMahon wrote:
> > > I have added a Release Note as a subtask in the JBS issue, this also
> > > needs a review.
> >
> >
> > Hi Eirik, I have updated the wording of the release note at
> > https://bugs.openjdk.org/browse/JDK-8354658 ; @AlanBateman or
On Fri, 25 Apr 2025 17:08:09 GMT, Daniel Fuchs wrote:
> > I have added a Release Note as a subtask in the JBS issue, this also needs
> > a review.
>
> Hi Eirik, I have updated the wording of the release note at
> https://bugs.openjdk.org/browse/JDK-8354658 ; @AlanBateman or
> @Michael-Mc-Maho
On Fri, 25 Apr 2025 18:41:19 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Fri, 25 Apr 2025 18:48:48 GMT, Daniel Fuchs wrote:
> MalformedURLException could be thrown while constructing the URL...
Good catch, fixed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24657#discussion_r2060739140
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Fri, 25 Apr 2025 17:30:41 GMT, Daniel Fuchs wrote:
> Sorry - rewording the release note got me thinking again...
Documentation Driven Development For The Win! 👍
> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
> line 55:
>
>> 53: System.getProperty
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Wed, 23 Apr 2025 17:04:30 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 174:
>>
>>> 172:
>>> 173: File URL stream protocol handler properties
>>> 174: The following properties are used to configure the handler for URLs
>>> with the {@c
On Fri, 25 Apr 2025 11:24:11 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Fri, 25 Apr 2025 11:24:11 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Fri, 25 Apr 2025 17:08:09 GMT, Daniel Fuchs wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits
On Fri, 25 Apr 2025 12:25:53 GMT, Daniel Fuchs wrote:
> Will do.
Great!
> The CSR could also be moved to "Proposed".
It was earlier today.
-
PR Comment: https://git.openjdk.org/jdk/pull/24657#issuecomment-2830292381
On Fri, 25 Apr 2025 09:44:34 GMT, Daniel Fuchs wrote:
>> You will still need to update `java/net/URL/OpenStream.java` to make it pass
>> with the new changes. Possibly have two `@run`, one with
>> `-Djdk.net.file.ftpfallback=true` and one without and adapt the test
>> expectation based on the
On Wed, 23 Apr 2025 18:28:48 GMT, Daniel Fuchs wrote:
> Two tests under `java/net/` are now failing on windows with the message:
> "Unsupported non-local file URL"
>
> java/net/URL/OpenStream.java
> java/net/URLConnection/UNCTest.java
With the updates to `OpenStream` in this PR and the updates
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Fri, 25 Apr 2025 09:44:34 GMT, Daniel Fuchs wrote:
> I wonder if we need to add a comment in OpenStream that "bad" UNC paths are
> tested in NonLocalFtpFallback.
We could. But there is technincally no such thing as a "bad" UNC path though.
If File::exists fails, then it isn't considered a U
On Thu, 24 Apr 2025 10:08:10 GMT, Daniel Fuchs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix repeated "should should"
>
> You will still need to update `java/net/URL/OpenStream.java` to make it pass
> with
On Fri, 25 Apr 2025 09:55:52 GMT, Eirik Bjørsnøs wrote:
> I wonder if we need to add a comment in OpenStream that "bad" UNC paths are
> tested in NonLocalFtpFallback.
Could we say something like: _For testing of non-local file URLs with the
legacy FTP fallback feature enabled, see NonLocalFtp
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Wed, 23 Apr 2025 17:34:33 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Thu, 24 Apr 2025 10:08:10 GMT, Daniel Fuchs wrote:
> You will still need to update `java/net/URL/OpenStream.java` to make it pass
> with the new changes. Possibly have two `@run`, one with
> `-Djdk.net.file.ftpfallback=true` and one without and adapt the test
> expectation based on the pres
On Wed, 23 Apr 2025 17:34:33 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Wed, 23 Apr 2025 17:34:33 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Wed, 23 Apr 2025 19:24:33 GMT, Eirik Bjørsnøs wrote:
> This should probably be mentioned in the compatibility risk section of the
> CSR, and in the release note too.
I have updated both to mention code affected by relying on behavior of a
failing `FtpURLConnection`, such as catching `Unknow
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Wed, 23 Apr 2025 18:28:48 GMT, Daniel Fuchs wrote:
> java/net/URLConnection/UNCTest.java
It's not completely clear to me whether this test was originally written under
the assumption that a FileURLConnection for an UNC path would be returned by
this test.
If so, the CI instance running the
On Wed, 23 Apr 2025 18:39:05 GMT, Daniel Fuchs wrote:
> The `java/net/URL/OpenStream.java` test however shows a potential
> compatibility issue: it was expecting `UnknownHostException` and gets
> `MalformedURLException` instead.
>
> This should probably be mentioned in the compatibility risk s
On Wed, 23 Apr 2025 17:34:33 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Wed, 23 Apr 2025 12:29:03 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Wed, 23 Apr 2025 17:34:33 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Wed, 23 Apr 2025 17:07:05 GMT, Eirik Bjørsnøs wrote:
>>> We have not really discussed a future removal of this feature in the
>>> context of this PR. This PR simply disables the feature by default.
>>
>> Yes - sorry my bad. The disabling of this feature (and hopefully its removal
>> in some
On Wed, 23 Apr 2025 17:24:24 GMT, Eirik Bjørsnøs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move file URL properties out of the Proxy section, replace URI with URL
>
> src/java.base/share/classes/sun/net/www
On Wed, 23 Apr 2025 12:32:51 GMT, Eirik Bjørsnøs wrote:
> The Proxy section curiusly seems to use **URI** everywhere, but I've changed
> to using **URL** for this new section. It's a bit weird now that RFC 8089
> uses URI, but maybe it's too hard to be consistent **and** correct in this
> case
On Wed, 23 Apr 2025 17:07:05 GMT, Eirik Bjørsnøs wrote:
> I'm curious what the feelback channel would be here? Do vendors collect
> metrics for use of system properties, directly or indirectly through support
> channels such that usage of a property like this may be gauged somehow?
Nothing of
On Wed, 23 Apr 2025 15:46:23 GMT, Daniel Fuchs wrote:
> Good question. I believe disabling is a good first step, which will hopefully
> tell us whether anyone is actually using it.
I'm curious what the feelback channel would be here? Do vendors collect metrics
for use of system properties, dir
On Wed, 23 Apr 2025 15:57:00 GMT, Daniel Fuchs wrote:
> I wonder if it should say the `{@code file:}` scheme instead.
This seems like an improvement to me. Not really a deliberate choice to include
the slashes on my part, probably more for consistency with other schemes under
Proxy. Files wit
On Wed, 23 Apr 2025 12:29:03 GMT, Eirik Bjørsnøs wrote:
>> Please help review this PR which disables the unspecified but long-standing
>> feature where an `FtpURLConnection` is opened as a fallback for non-local
>> file URLs.
>>
>> Before this change, if a file URL has a non-local host compone
On Wed, 23 Apr 2025 12:37:20 GMT, Eirik Bjørsnøs wrote:
> We have not really discussed a future removal of this feature in the context
> of this PR. This PR simply disables the feature by default.
Yes - sorry my bad. The disabling of this feature (and hopefully its removal in
some future versi
On Wed, 23 Apr 2025 11:01:48 GMT, Daniel Fuchs wrote:
> Sorry for being late to the party. I too would welcome the removal of this
> old legacy feature.
We have not really discussed a future removal of this feature in the context of
this PR. This PR simply disables the feature by default.
If
On Wed, 23 Apr 2025 11:01:48 GMT, Daniel Fuchs wrote:
> There are no handlers for URIs - only for URLs - so I would replace URI with
> URL in the property description to avoid any confusion.
I just realized I had initially put this under the Proxies section. That does
not make much sense, so I
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Wed, 23 Apr 2025 09:28:41 GMT, Eirik Bjørsnøs wrote:
> I have made a first attempt of a text documenting the new property. Since I
> don't want the documentation of this feature to encourage wider use, I added
> some verbiage recommending that explicit `ftp://` URIs should be used instead.
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Tue, 22 Apr 2025 08:53:54 GMT, Michael McMahon wrote:
> No objection here to this change either.
Thanks for your help in making progress here!
> The property will need to be documented in
> src/java.base/share/classes/java/net/doc-files/net-properties.html also.
I have made a first attemp
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the imple
On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs wrote:
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, s
On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs wrote:
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, s
On Mon, 21 Apr 2025 07:05:05 GMT, Alan Bateman wrote:
> No objection to disabling this legacy feature by default but I think it will
> require writing a release note, and thus will document the system property
Indeed. A provisional release note can be found here:
https://bugs.openjdk.org/brow
On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs wrote:
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, s
On Tue, 15 Apr 2025 20:09:39 GMT, Eirik Bjørsnøs wrote:
> The current behavior for _existing_ UNC paths would be unaffected by this
> change.
For the sake of completeness:
If `Files::exists` failed for a UNC path before this change, then the code
would continue to the FTP fallback and the re
On Tue, 15 Apr 2025 19:08:00 GMT, Bernd wrote:
> Is there a Risk that This breaks Applications which parses Potential UNC path
> as URL (or even worse want to open them?. I am not sure if this actually ever
> worked, but) I know people are reguläres confused about file:/// (when is it
> needed
On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs wrote:
> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, s
61 matches
Mail list logo
