> Please help review this PR which disables the unspecified but long-standing
> feature where an `FtpURLConnection` is opened as a fallback for non-local
> file URLs.
>
> Before this change, if a file URL has a non-local host component, say
> `file://remotehost/folder/data.txt`, then the implementation would attempt
> opening an FTP connection to `remotehost`. After this change, such URLs will
> be rejected with a `MalformedURLException`, unless the FTP fallback feature
> is explicitly re-enabled via a system property.
>
> This change was initially discussed here:
> https://mail.openjdk.org/pipermail/net-dev/2025-March/025988.html
>
> See the above discussion and CSR draft JDK-8354678 for the motivation for
> this change. I plan to update the CSR pending an initial round of review of
> this PR.
>
> This PR:
>
> * Changes file URL `Handler::openConnection` implementation for unix/windows
> to throw `MalformedURLException`, unless the FTP fallback feature is
> explicitly enabled by configuration.
> * Introduces a new system property `jdk.net.file.ftpenabled` which when set
> to `true` re-enables the feature.
> * Updates the existing test `NonLocalFtpFallback` to enable the feature via
> said system property.
> * Adds a new test `NonLocalFtpFallbackDisabled` verifying that a
> `MalformedURLException` is thrown by default for a non-local URL host
> component.
>
> I have added a Release Note as a subtask in the JBS issue, this also needs a
> review.
Eirik Bjørsnøs has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 12 additional commits
since the last revision:
- Merge branch 'master' into disable-non-local-file-urls
- Add @comment referencing testing of non-local file URLs in
NonLocalFtpFallback
- verifyNonLocalFileURLRejected is a better name for this test which expects
the FTP fallback to be disabled
- Move testing of exceptional behavior of a non-local, FTP-fallback enabled
file URL from OpenStream to NonLocalFtpFallback
- Add a test verifying that local file URLs such as
'file://localhost/folder/data.xml' are not affected by the FTP fallback feature
being enabled
- Merge branch 'master' into disable-non-local-file-urls
- Fix repeated "should should"
- Move file URL properties out of the Proxy section, replace URI with URL
- Be explicit about explicit {@code ftp://} URIs
- Document jdk.net.file.ftpfallback as a Networking Property
- ... and 2 more: https://git.openjdk.org/jdk/compare/58f93f9f...af73727f
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24657/files
- new: https://git.openjdk.org/jdk/pull/24657/files/4ad1ab8e..af73727f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24657&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24657&range=08-09
Stats: 3176 lines in 134 files changed: 1959 ins; 828 del; 389 mod
Patch: https://git.openjdk.org/jdk/pull/24657.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24657/head:pull/24657
PR: https://git.openjdk.org/jdk/pull/24657
