On Wed, 9 Apr 2025 11:35:29 GMT, Jaikiran Pai wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review suggestions
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 74:
>
>> 72: @MethodSource("
On Wed, 9 Apr 2025 14:35:30 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yazi
On Thu, 10 Apr 2025 05:52:07 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yaz
On Thu, 10 Apr 2025 05:52:07 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yaz
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
Volkan Yazici has updated the pull request incrementally with one additional
On Wed, 9 Apr 2025 11:32:38 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review suggestions
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 103:
>
>> 101: :
On Wed, 9 Apr 2025 12:06:23 GMT, Daniel Fuchs wrote:
>> I'm guessing that this test passes for you locally. If so, then we might
>> need some additional investigation here as to why it passes (given the exact
>> opposite assertion of what the test was previously asserting).
>>
>> I see that th
On Wed, 9 Apr 2025 13:36:23 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yazi
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
Volkan Yazici has updated the pull request incrementally with one additional
On Wed, 9 Apr 2025 14:21:57 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 75:
>>
>>> 73: void test(Version version, boolean secure) throws Exception {
>>> 74: String uriPath =
>>> "/%s/%s/%s".formatted(EmptyAuthenticate.class.getSimpleName(), v
On Wed, 9 Apr 2025 14:18:20 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review suggestions
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 75:
>
>> 73: void test(Versi
On Wed, 9 Apr 2025 13:36:23 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yazi
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
Volkan Yazici has updated the pull request incrementally with one additional
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote:
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
test/jdk/java/net/ht
On Wed, 9 Apr 2025 11:43:25 GMT, Jaikiran Pai wrote:
>> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 83:
>>
>>> 81:
>>> responseHeaders.firstValue(WWW_AUTH_HEADER_NAME).orElse(null),
>>> 82: () -> "was expecting empty `%s` header in:
>>> %s".
On Wed, 9 Apr 2025 11:30:58 GMT, Jaikiran Pai wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> test/jdk/jav
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote:
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
test/jdk/java/net/ht
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote:
> Overhauls `EmptyAuthenticate` to
>
> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
> - Test both clear-text and SSL
> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
> problems
test/jdk/java/net/ht
18 matches
Mail list logo