On Mon, 20 May 2024 09:25:31 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Mon, 20 May 2024 09:25:31 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Sun, 19 May 2024 14:29:49 GMT, Alan Bateman wrote:
> I think you may have mis-read my comment. I think we need to add `@see
> InetAddress4#ofPosixLiteral(String)` to InetAddress.ofLiteral, not
> Inet4Address.ofLiteral. The reason is that methods defined by Inet4Address
> are not very discov
On Fri, 17 May 2024 10:42:44 GMT, Alan Bateman wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>> Co-authored-by: Daniel Fuchs <67001856+df
On Fri, 17 May 2024 11:23:34 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Fri, 17 May 2024 11:23:34 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Fri, 17 May 2024 10:42:44 GMT, Alan Bateman wrote:
> The new method is not easily discovered, which is okay as it's very much a
> method for experts, I see wonder if we should put a `@see` in
> InetAddress.ofLiteral.
Thanks @AlanBateman for your note. There's a link to `ofPosixLiteral` from
On Fri, 17 May 2024 11:23:34 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Fri, 17 May 2024 10:31:02 GMT, Michael McMahon wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>> Co-authored-by: Daniel Fuchs <67001856
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Tue, 7 May 2024 10:08:12 GMT, Aleksei Efimov wrote:
>> The parsing code and the test changes look good to me with a couple of minor
>> suggestions.
>
>> @AlekseiEfimov @jaikiran @Michael-Mc-Mahon Could you please take a look and
>> review the [CSR ](https://bugs.openjdk.org/browse/JDK-832987
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Tue, 7 May 2024 10:08:12 GMT, Aleksei Efimov wrote:
>> The parsing code and the test changes look good to me with a couple of minor
>> suggestions.
>
>> @AlekseiEfimov @jaikiran @Michael-Mc-Mahon Could you please take a look and
>> review the [CSR ](https://bugs.openjdk.org/browse/JDK-832987
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Wed, 15 May 2024 17:34:21 GMT, Daniel Fuchs wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed class level docs
>
> src/java.base/share/classes/java/net/Inet4Address.java line 102:
>
>> 100: * Please
On Mon, 6 May 2024 18:36:24 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
On Mon, 13 May 2024 14:01:34 GMT, Sergey Chernyshev
wrote:
> missing the fact that the _only_ form supported
I'd also note that, when mentioned in the docs that this is the _only_ method
capable of parsing this type of strings, it can be limiting to the future APIs
that could introduce other
On Mon, 6 May 2024 18:36:24 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
On Thu, 18 Apr 2024 13:29:21 GMT, Michael McMahon wrote:
>>> which lists the methods that parse as decimal only, and the new method
>>> which parses using the "loose" syntax.
>>
>> That might not be practical: the only method that supports non decimal form
>> is the new `ofBSDLiteral`. But any
On Tue, 16 Apr 2024 22:38:57 GMT, Aleksei Efimov wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>>Co-authored-by: Daniel Fuchs <67001
On Tue, 16 Apr 2024 22:38:57 GMT, Aleksei Efimov wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>>Co-authored-by: Daniel Fuchs <67001
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Thu, 18 Apr 2024 13:29:21 GMT, Michael McMahon wrote:
>>> which lists the methods that parse as decimal only, and the new method
>>> which parses using the "loose" syntax.
>>
>> That might not be practical: the only method that supports non decimal form
>> is the new `ofBSDLiteral`. But any
On Mon, 6 May 2024 10:35:35 GMT, Jaikiran Pai wrote:
> Hello Sergey, do you plan to update the PR with the class level doc change
> suggested by Michael?
Hi @jaikiran ! Yes I plan to update the PR. Apologies for the delay.
-
PR Comment: https://git.openjdk.org/jdk/pull/18493#issue
On Wed, 17 Apr 2024 22:23:41 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 18 Apr 2024 13:29:21 GMT, Michael McMahon wrote:
> I think we only need to talk about the methods in InetAddress. Though it
> could be phrased as `ofPosixLiteral` supports decimal, hex and octal. All
> other parsing is decimal only.
Yes. that latter formulation might be better.
--
On Thu, 18 Apr 2024 11:35:21 GMT, Daniel Fuchs wrote:
> > which lists the methods that parse as decimal only, and the new method
> > which parses using the "loose" syntax.
>
> That might not be practical: the only method that supports non decimal form
> is the new `ofBSDLiteral`. But any other
On Thu, 18 Apr 2024 10:24:30 GMT, Michael McMahon wrote:
> which lists the methods that parse as decimal only, and the new method which
> parses using the "loose" syntax.
That might not be practical: the only method that supports non decimal form is
the new `ofBSDLiteral`. But any other method
On Wed, 17 Apr 2024 22:23:41 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Wed, 17 Apr 2024 14:26:35 GMT, Jaikiran Pai wrote:
> Should we be setting any expectations by specifying what
> `InetAddress.getHostAddress()` will return for an `Inet4Address` constructed
> using this new `Inet4Address.ofPosixLiteral()` method? In its current form I
> believe it will conti
On Wed, 17 Apr 2024 14:48:37 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/net/Inet4Address.java line 104:
>>
>>> 102: * Purposes.
>>> 103: * For methods that return a textual representation as output
>>> 104: * value, the first form, i.e. a dotted-quad string, is used.
>>
>>
On Tue, 16 Apr 2024 22:17:21 GMT, Aleksei Efimov wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>>Co-authored-by: Daniel Fuchs <67001
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Wed, 17 Apr 2024 14:37:56 GMT, Daniel Fuchs wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>>Co-authored-by: Daniel Fuchs <6700185
On Thu, 11 Apr 2024 15:27:55 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Wed, 17 Apr 2024 14:26:35 GMT, Jaikiran Pai wrote:
> The changes proposed in this PR introduce a new paragraph in the class level
> documentation just before the line which states the dotted-quad string. So I
> think it may not be clear enough whether dotted-quad string implies decimal
> va
On Wed, 17 Apr 2024 14:16:30 GMT, Daniel Fuchs wrote:
> > Should we be setting any expectations by specifying what
> > InetAddress.getHostAddress() will return for an Inet4Address constructed
> > using this new Inet4Address.ofPosixLiteral() method? In its current form I
> > believe it will con
On Wed, 17 Apr 2024 14:02:05 GMT, Jaikiran Pai wrote:
> Should we be setting any expectations by specifying what
> InetAddress.getHostAddress() will return for an Inet4Address constructed
> using this new Inet4Address.ofPosixLiteral() method? In its current form I
> believe it will continue to
On Thu, 11 Apr 2024 15:27:55 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 11 Apr 2024 15:27:55 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Thu, 11 Apr 2024 12:58:07 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 11 Apr 2024 09:21:36 GMT, Daniel Fuchs wrote:
>> I updated the docs to link to the class specification, also added an anchor
>> in the spec.
>
> I would rather move the description of the loose syntax fully here, since the
> only method that accepts it is `Inet4Address.ofPosixLiteral`.
On Thu, 11 Apr 2024 09:56:56 GMT, Florent Guillaume wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments in Javadoc
>
> test/jdk/java/net/InetAddress/OfLiteralTest.java line 232:
>
>> 230
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Thu, 11 Apr 2024 09:15:54 GMT, Daniel Fuchs wrote:
>> This removes the reference of loose syntax that was opposed to strict
>> syntax. Would you think to also remove the word "strict"?
>
> @sercher the word "loose" is still there - it's not removed?
Right. Apologies, i didn't notice it.
---
On Wed, 10 Apr 2024 15:34:22 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Wed, 10 Apr 2024 15:30:52 GMT, Sergey Chernyshev
wrote:
>> src/java.base/share/classes/java/net/Inet4Address.java line 103:
>>
>>> 101: * octal and hexadecimal address segments. Please refer to
>>> 102: * https://www.ietf.org/rfc/rfc6943.html#section-3.1.1";>
>>> RFC
>>> 103: * 6943: Is
On Wed, 10 Apr 2024 15:34:22 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Tue, 9 Apr 2024 13:35:00 GMT, Daniel Fuchs wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments in Javadoc
>
> src/java.base/share/classes/java/net/Inet4Address.java line 103:
>
>> 101
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Tue, 26 Mar 2024 17:25:54 GMT, Sergey Chernyshev
wrote:
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
On Tue, 26 Mar 2024 17:25:54 GMT, Sergey Chernyshev
wrote:
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
There are two distinct approaches to parsing IPv4 literal addresses. One is the
Java baseline "strict" syntax (all-decimal d.d.d.d form family), another one is
the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr` allowing
octal and hexadecimal forms [2]). The goal of this PR is to
60 matches
Mail list logo
