On Thu, 18 Apr 2024 13:29:21 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>>> which lists the methods that parse as decimal only, and the new method >>> which parses using the "loose" syntax. >> >> That might not be practical: the only method that supports non decimal form >> is the new `ofBSDLiteral`. But any other method only support decimal >> notation. These include URL/URI, permissions, InetSocketAdderess, >> InetAddress, Socket/DatagramSocket constructors, etc... Building a >> comprehensive list would be both unpractical and difficult. > >> > which lists the methods that parse as decimal only, and the new method >> > which parses using the "loose" syntax. >> >> That might not be practical: the only method that supports non decimal form >> is the new `ofBSDLiteral`. But any other method only support decimal >> notation. These include URL/URI, permissions, InetSocketAdderess, >> InetAddress, Socket/DatagramSocket constructors, etc... Building a >> comprehensive list would be both unpractical and difficult. > > I think we only need to talk about the methods in InetAddress. Though it > could be phrased as `ofPosixLiteral` supports decimal, hex and octal. All > other parsing is decimal only. > Thanks @Michael-Mc-Mahon, @jaikiran. I updated the class level doc so that > the sentence "These forms support parts in decimal format only" is completely > removed (it wasn't looking good to me any more because it was repeated by the > next sentence "For example..."). I didn't add the sub-section "Parsing of > literal addresses" because it already belongs to "Textual representation of > IPv4 addresses" which is more or less the same. Please see the updated class > level doc. Ok - so now we seem to be missing the fact that the *only* form supported by the existing methods is the decimal form. Can we find a wording that makes this clear? ------------- PR Comment: https://git.openjdk.org/jdk/pull/18493#issuecomment-2102290671
