Thank you for proposition, we certainly will take a look a all that.
That being said, the FTP Client API project is in a unusual state.
You see, as a pointed numerous times, we do have an API already, even if
it's a rather incomplete and not flexible one. Which leads to 2 issues:
1) Any new FTP A
Here is my proposed fix for CR 6660405.
The issue is that after a redirect, and if there is a cache hit (i.e.
the URL is found in the cache) HttpURLConnection will return the wrong
InputStream. Details are in the evaluation section of the CR.
My proposed fix is to set inputStream back to null in
This is a straightforward fix in mailtoURLConnection to remove a left
over debug statement in the connect() method.
Also took the opportunity to remove unneeded imports and add appropriate
@Override tags.
No regression test as this is a trivial change.
Patch attached.
--- old/src/share/classes/
Approved.
Christopher Hegarty - Sun Microsystems Ireland wrote:
CR 6667108: "typo in javadoc for
java.net.Socket.getRemoteSocketAddress()"
Trivial cleanup of a typo in getRemoteSocketAddress specification.
diff -r fa6948bdc4b0 src/share/classes/java/net/Socket.java
--- a/src/share/classes/ja
Approved.
Christopher Hegarty - Sun Microsystems Ireland wrote:
Another trivial documentation change.
CR 6591358:
"documentation error in URLConnection.setRequestProperty("accept", ...)"
-Chris.
I filed CR 6644726 (Cookie management issues) after discovering a few
inconsistencies between the way J2SE handles cookies and the 'real
world'. I also have been working on a fix for that.
I thought all these issues were bugs, but one turned out to be a more
complicated.
It's actually the firs
Roman Kennke wrote:
I am confused how this method is supposed to work. It has a boolean
parameter that is documented to be used to distinguish between datagram
and stream sockets. However, it is only used by Socket and ServerSocket,
so I guess it must always be a stream socket? But it gets worse.
Here are my proposed changes to fix 6644726
It does fix all 7 issues listed in the CR (see
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details)
and adds a proper regression test.
The short list is:
- support for more 'expires' date format
- enforce 'secure' cookies
- enforc
Approved.
Christopher Hegarty - Sun Microsystem wrote:
Hi Michael, Jessie,
Can I please get a code review for CR 6659779. This trivially adds
logger invocations to log tunnel requests, ie. HTTP CONNECT.
-Chris.
Changeset: d44e3bf49ffb
Author:jccollet
Date: 2008-04-17 11:05 +0200
URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d44e3bf49ffb
6644726: Cookie management issues
Summary: Many changes to accomodate RFC 2965 and old Netscape specs
Reviewed-by: chegar
! src/share/classes/java/net/
I need a code review for the simple fix to 6558853.
It's a simple case of a flag not set in the native code when creating a
Inet6Address.
Patch attached below.
Thanks
--- /home/jccollet/tmp/webrev/raw_files/old/src/share/native/java/net/net_util.c 2008-04-18 13:59:44.0 +0200
+++ /home/
Changeset: a71ab67d3ece
Author:jccollet
Date: 2008-04-18 15:23 +0200
URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a71ab67d3ece
6558853: getHostAddress() on connections using IPv6 link-local addrs should
have zone id
Summary: Set the scope_id_set flag when necessary
Reviewed-by:
Hello,
I have posted an entry in my blog about the current status of the FTP
client API.
It contains a quick description of the project as well as a link to the
current draft of the API. So if you're interested in that topic go take
a look at http://blogs.sun.com/jcc/
As mentioned in the pos
Alan Bateman wrote:
Jean-Christophe Collet wrote:
Hello,
I have posted an entry in my blog about the current status of the FTP
client API.
It contains a quick description of the project as well as a link to
the current draft of the API. So if you're interested in that topic
go take a
owever, it is possible to get the 'raw'
listing using FtpClient.list(String path) instead. It returns an
InputStream to the unparsed listing.
Thanks
Max
On May 23, 2008, at 11:20 PM, Jean-Christophe Collet wrote:
Hello,
I have posted an entry in my blog about the current status of
David M. Lloyd wrote:
On 05/23/2008 10:20 AM, Jean-Christophe Collet wrote:
Hello,
I have posted an entry in my blog about the current status of the FTP
client API.
It contains a quick description of the project as well as a link to
the current draft of the API. So if you're interest
I've updated the API draft to cover most of the points raised here.
See http://blogs.sun.com/jcc/ for the details.
Thanks for the feedback, past and future :-)
This is a serialization issue in Inet6Address. When de-serializing an
address with an interface name as the scope, the test for its existence
should be done sooner rather than later to avoid a NullPointerException.
I took the opportunity to clean up the code in Inet6Address to act on
some NetBea
Changeset: f4289d75cd29
Author:jccollet
Date: 2008-08-25 14:38 +0200
URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/f4289d75cd29
6717876: Make java.net.NetworkInterface.getIndex() public
Summary: Make getIndex() and getByIndex() public. Required a name change in
native code
Revie
Andrew John Hughes wrote:
On 27/08/2008, Mark Wielaard <[EMAIL PROTECTED]> wrote:
Hi,
On Mon, Aug 25, 2008 at 12:43:59PM +, [EMAIL PROTECTED] wrote:
> URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/f4289d75cd29
>
> 6717876: Make java.net.NetworkInterface.getIndex() public
>
Changeset: eb342082e2b6
Author:jccollet
Date: 2008-09-04 15:26 +0200
URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/eb342082e2b6
6692802: HttpCookie needs to support HttpOnly attribute
Summary: Added HttpOnly tag support to HttpCookie class.
Reviewed-by: chegar, michaelm
! src/sh
Only Members of the Networking Group are eligible to vote on this
decision. The current Members are:
Alan Bateman
Christopher Hegarty
Michael McMahon
Jean-Christophe Collet
Thanks,
Michael
[1]
http://mail.openjdk.java.net/pipermail/net-dev/2008-October/000427.html
Changeset: 53d9259661c3
Author:jccollet
Date: 2009-01-27 11:36 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/53d9259661c3
6790677: java.net.HttpCookie.parse(String) should ignore unrecognized
attributes, RFC2965
Summary: Changed code not to throw an exception on unknown att
Changeset: 6c5d04d1eff4
Author:jccollet
Date: 2009-02-02 16:50 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c5d04d1eff4
6791927: Wrong Locale in HttpCookie::expiryDate2DeltaSeconds
Summary: Force Locale.US when parsing the cookie expiration date.
Reviewed-by: chegar
! src
Changeset: 61ee91f965ac
Author:jccollet
Date: 2009-02-04 14:15 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/61ee91f965ac
6585546: Please update API doc for java.net.CookieManager
Summary: Trivial doc updates
Reviewed-by: chegar
! src/share/classes/java/net/CookieManager.ja
--- Begin Message ---
Looks good to me.
I assume it will have a noreg-hard tag?
Christopher Hegarty - Sun Microsystems Ireland wrote:
Even though the code reviews are going external now, I still expect
that we are the only ones going to review them. Any takers?
-Chris.
Original Mes
Christopher Hegarty - Sun Microsystems Ireland wrote:
Hi Michael, Jessie,
Please take a few moments to review this trivial change:
6737323: Typo in javadoc for SocketPermission
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6737323
http://cr.openjdk.java.net/~chegar/6737323/webrev.
Alan Bateman wrote:
Mandy Chung wrote:
6817246: Redundant call to set InetAddressCachePolicy to FOREVER if
not set during initialization
Webrev at:
http://cr.openjdk.java.net/~mchung/6817246/webrev.00/
System.setSecurityManager0 calls
InetAddressCachePolicy.setIfNotSet(InetAddressCachePol
I've put out a webrev for the proposed fix to 6726695 (the Expect:
100-Continue problem)
There is an explanation of the issue and an example of code usage on my
blog at http://blogs.sun.com/jcc/
http://cr.openjdk.java.net/~jccollet/6726695/webrev.00/
The changes look good to me.
Mandy Chung wrote:
6819122: DefaultProxySelector should lazily initialize the Pattern
object and the NonProxyInfo objects
Webrev at:
http://cr.openjdk.java.net/~mchung/6819122/webrev.00/
Details:
1. The Pattern object is only used for checking a IPv6 loopback
ad
Misha Bykov wrote:
Apple engineers have some questions about proxy settings in JDK (not
deploy or applets).
1) Does the JDK support Automatic proxy configuration (WPAD) ? They know
that applets and Webstart do, but they are interested in standalone
java applications.
No.
2) Does the JD
Roman Kennke wrote:
Hi,
2) Does the JDK support PAC files ? (Again, they know that applets and
webstart does, through the browser settings).
No this requires a javascript interpreter which we don't have in
standalone JDK.
No? Isn't javax.script an API for scripting, and
This is a very simple fix: Domain of a cookie should default to the host
name if not specified.
Webrev available at:
http://cr.openjdk.java.net/~jccollet/6349566/webrev.00/
Thanks,
I have been working on adding better logging and debugging tools to the
HTTP implementation.
A significant chunk of the bugs that we have to investigate are HTTP
related and being able to monitor the traffic has always been a problem.
Using a packet sniffer is cumbersome and not always possible.
The \. in sun\.com looks a little cumbersome. I know .hgignore
supports several different pattern matching mechanisms, probably worth
a look?
The idea is to use regular expressions to allow for maximum flexibility
AND simpler implementation.
Thanks
Max
On Apr 23, 2009, at 10:02 PM, Jean-
Paulo Levi wrote:
Anyone read the first message at all? The problem is that other proxy
requests are effectively ignored after a DIRECT connection even if it
fails.
What i am trying right now is implementing ProxySelector so that a
"manual" proxy configuration is added at the end of the
publi
Paulo Levi wrote:
But it's completely unintuitive! I can't know if i need to bother the
user about proxy configuration before trying with no proxy, but trying
to use that disallows the use of any other.
Trying to wrap Proxy.NO_PROXY to circumvent that, even if technically
possible, just makes
I approve these changes.
Christopher Hegarty - Sun Microsystems Ireland wrote:
Hi Jessie, Michael, Alan,
I would like to try and get this simple change into b59 through the
build integration slot, and therefore make M3. The change is simply to
the docs Makefile so that the SCTP API docs are g
Changeset: 206d73d299d4
Author:jccollet
Date: 2009-05-25 22:27 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/206d73d299d4
6349566: java.net.CookieManager doesn't set default domain
Summary: Enforce default domain in CookieManager
Reviewed-by: michaelm
! src/share/classes/ja
Changeset: 045aeb76b0ff
Author:jccollet
Date: 2009-05-26 16:03 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/045aeb76b0ff
6726695: HttpURLConnection shoul support 'Expect: 100-contimue' headers for PUT
Summary: Added code triggered when 'Expect: 100-continue' header has been
Changeset: ed38f9e6ad9a
Author:jccollet
Date: 2009-06-19 14:12 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed38f9e6ad9a
6852108: Remove Preferences dependance from SocksSocketImpl
Summary: Removed Preferences API use and fixed a few findbugs gotchas
Reviewed-by: alanb
! s
Here is proposal to add more debugging tool for the HTTP protocol handler.
This adds more logging, a formatter for the logs and a traffic capture tool.
These changes have no implications on normal operation, they just add
features that can be turned on when investigating bugs.
A webrev is avail
Changeset: 70c0a927e21a
Author:jccollet
Date: 2009-06-25 18:56 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/70c0a927e21a
6811297: Add more logging to HTTP protocol handler
Summary: Added extra logging to HttpURLConnection and HttpClient. Added a
capture tool.
Reviewed-by:
Changeset: 0b6571d4b4b5
Author:jccollet
Date: 2009-06-26 16:50 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b6571d4b4b5
6855297: Windows build breaks after 6811297
Summary: re-introduced the mistakenly taken out authObj member
Reviewed-by: chegar
! src/share/classes/sun/n
Yes, it would be nice and there are actually already 2 RFEs covering this:
4640805: Protocol and content handlers SPI
6249864: make it easier to write custom url handlers
However this is no small task, specially considering the compatibility
and security constraints.
So far resources (or lack o
Changeset: fa488e4ff685
Author:jccollet
Date: 2009-07-06 15:13 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa488e4ff685
6856856: NPE in HTTP protocol handler logging
Summary: Fixed the NPE and Moved the java.util.logging dependency to a single
class and used reflection to
Here are the changes for 6737819.
This allows for the previously hard-coded, always in, values for
http.nonProxyHosts and ftp.nonProxyHosts to be overridden when necessary.
I.E. before it was never possible to reach localhost (and its
variations) via a proxy (hard coded exemption). These changes
Changeset: ee68feef41d2
Author:jccollet
Date: 2009-09-18 10:51 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee68feef41d2
6737819: sun.misc.net.DefaultProxySelector doesn't use proxy setting to
localhost
Summary: Move default nonProxyHosts from hardcoded to property default
Here are my proposed changes to fix 6873543 (httpOnly cookies).
Also took the opportunity to clarify the javadoc of a few methods.
http://cr.openjdk.java.net/~jccollet/6873543/webrev.00/
Christopher Hegarty - Sun Microsystems Ireland wrote:
6882384: Update http protocol handler to use PlatformLogger
Webrev:
http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/
Change http logging to use the PlatformLogger. We can simply remove
the reflective calls to the logging API f
These changes provide 2 things:
- a minor bug fix for 6519647 (FTP PUT operation through HTTP proxy)
- an overhaul of the FTP code and laying the bases of a future public
FTP Client API.
That's why the code is separated between sun.net.ftp and sun.net.ftp.iml
Ultimately, what is in sun.net.ftp
Changeset: 5ab37d9d9260
Author:jccollet
Date: 2009-10-21 13:42 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ab37d9d9260
6873543: CookieManager doesn't enforce httpOnly
Summary: Adds check for httpOnly tag and clarifies javadoc
Reviewed-by: chegar
! src/share/classes/java/
Changeset: 75c453fa1aa1
Author:jccollet
Date: 2009-10-21 16:28 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75c453fa1aa1
6893702: Overhaul of Ftp Client internal code
Summary: Major reorg of internal FTP client code
Reviewed-by: chegar
! make/sun/net/FILES_java.gmk
! src/s
Christopher Hegarty - Sun Microsystems Ireland wrote:
The changes look fine.
Same here. Looks fine.
-Chris.
On 23/10/2009 14:57, Alan Bateman wrote:
I need a reviewer for a small fix to sun.net.NetHooks. On Solaris,
the code incorrectly assumes that the sdp provider is always present.
T
This is a simple fix for a cookie parsing issue.
http://cr.openjdk.java.net/~jccollet/6901170/webrev.0/
Thanks,
<>
Changeset: ca026eb5cf3c
Author:jccollet
Date: 2009-11-20 14:50 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ca026eb5cf3c
6901170: HttpCookie parsing of version and max-age mis-handled
Summary: Accept single quotes in cookies and better exception handling in
CookieManager
R
Paulo Levi wrote:
Just realized you might be confused about the saving of the original
proxyselector in the test code. To be clear:
What is called and throws the StackOverflowError is the
UserProxySelector class. I just expected calling
url.openConnection(Proxy.NO_PROXY); not to call the userpr
I approve this change.
On 12/10/09 16:35, Christopher Hegarty -Sun Microsystems Ireland wrote:
CR 6909089: Memory leak occurs by lack of free for read buffer in
SocketInputStream#read()
Webrev:
http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/
Bug description says it all.
-Chr
Changeset: f544825d0976
Author:jccollet
Date: 2010-01-26 11:39 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f544825d0976
6919185: test/closed/sun/net/ftp/FtpTests fails to compile
Summary: Fixed a couple of regressions in FtpClient and updated the test.
Reviewed-by: chegar
59 matches
Mail list logo
