--- Begin Message ---
Looks good to me.
I assume it will have a noreg-hard tag?
Christopher Hegarty - Sun Microsystems Ireland wrote:
Even though the code reviews are going external now, I still expect
that we are the only ones going to review them. Any takers?
-Chris.
-------- Original Message --------
Subject: CR 6800805 - code review
Date: Fri, 13 Feb 2009 16:19:46 +0000
From: Christopher Hegarty - Sun Microsystems Ireland
<christopher.hega...@sun.com>
Reply-To: christopher.hega...@sun.com
To: OpenJDK Network Dev list <net-dev@openjdk.java.net>
I need to get a code review for
6800805: java.net.NetworkInterface.getNetworkInterfaces() does not
list IPv6 network interfaces correctly.
http://cr.openjdk.java.net/~chegar/6800805/webrev.00/
There is a change in behaviour between JDK5 and JDK6 in how virtual
interfaces addresses are reported. This is as a result of the change for
CR 6386190. This change uses an ioctl to determine if the parent
interface is accessible from the current context. The problem is that on
Solaris if the interface being queried has only IPv6 addresses assigned
to it then the ioctl needs to be called with an IPv6 socket. This is
currently not the case.
To fix this bug we need to try with an IPv6 socket before determining
that the parent is not accessible, similar to what we done for CR
6628569.
Thanks,
-Chris.
--- End Message ---
begin:vcard
fn:Jean-Christophe Collet
n:Collet;Jean-Christophe
org:Sun Microsystems
adr:;;2 rue de Jargonnant;Geneva;;1207;Switzerland
email;internet:jean-christophe.col...@sun.com
title:Staff Engineer
x-mozilla-html:FALSE
version:2.1
end:vcard
